- 01 Nov, 2019 40 commits
-
-
nancy authored
BUG=1011235 Change-Id: Id3db4f6c2415009b33b6b1023270fde8a493c0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893595 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711625}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb5c6687. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I0da62a896e691d3028d0c3519cf84a9fd1d8c76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894812Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711624}
-
Meredith Lane authored
Simple follow up CL to add a comment and link to bug that was mistakenly omitted during sheriffing. See: https://chromium-review.googlesource.com/c/chromium/src/+/1880408 TBR=tobyhuang@chromium.org Change-Id: I4d63454c6e9f960907bfa45a05cdc92fe54f5f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891812Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#711623}
-
Dmitry Gozman authored
Regressed by crrev.com/83d5d416. DidObserveLoadingBehavior should come after DispatchDidCommitLoad, and the order got reversed while moving DispatchDidCommitLoad call a bit later in the navigation commit process. Bug: 1020082 Change-Id: I0c636f8d64b917a49902e560a38b1f0cb3c7bfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893688Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711622}
-
Justin Cohen authored
This reverts commit 856b8913. Reason for revert: This breaks iOS downstream. Original change's description: > Limit GN visibility of libxml for security audit control. > > This splits the libxml_utils helper classes into xml_reader and > xml_writer targets. The xml_writer can be safely used from any target. > The xml_reader has strictly limited visibility to locations that are > audited by the Security Team. Direct access to the libxml target is now > also limited. > > Bug: 699306 > Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711536} TBR=rohitrao@chromium.org,dcheng@chromium.org,davidben@chromium.org,thakis@chromium.org,reillyg@chromium.org,zmin@chromium.org,rsesek@chromium.org Change-Id: Iaeae81ddebcf43482fbd3c26b806147a8147d0fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 699306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893967Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711621}
-
Kevin Qin authored
There are 3 more OpenXR events that require actions: 1. XrEventDataInstanceLossPending: Destroy instance and exit presentation 2. XrEventDataInteractionProfileChanged: change WebXR input profiles 3. XrEventDataReferenceSpaceChangePending: Update Local to Stage Space transform Fixed: 1020354 Change-Id: I03ac3ef5fe4fcd70d4f1943c389456ca72ef1a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842615 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#711620}
-
Nick Diego Yamane authored
Since non-Ozone X11 PlatformEvent implementation is meant to be migrated soon to use ui::Event, as ozone path currently does, it makes sense to move it to a separate class. This is what this CL does, and in a follow-up change, tests will be modified to re-use this new class so that we can ensure ui::EVent's construction is equivalent to the one used in current Aura/X11 code. Also, this prepares X11EventSource delegate implementations to be refactored to use the same interfaces to comunicate about X11 events (e.g: event translation, XEventDispatcher, etc). Such change will be sent soon in separate CL. Bug: 965991, 1008755 Change-Id: I6153ad7ff1e3c2f5baf4b94df6a13af4ca7fe71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866752Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#711619}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ia5a262a69e0e2000ff371afd8a6ea9dd4cdf341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893966Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/283ec65f632a..7f680a638e96 git log 283ec65f632a..7f680a638e96 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7f680a638e96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: I8691c653ccdfdbbcae1c207abdd4bb66a6faf8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711617}
-
Peter Kotwicz authored
This CL makes WebappActivity use CustomTabActivityNavigationController This requires: - Introducing a webapp specific implementation of CustomTabActivityTabController (WebappActivityTabController) - Adding a parameter to SingleTabModel so that SingleTabModel#closeTab() uses CustomTabActivityNavigationController's fancy logic for finishing the activity BUG=1016650 Binary-Size: Methods added/removed measured by binary size trybot are due to function inlining Change-Id: Ibb60d28298e20c51bebbdd73d10f77106acf7f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877600 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711616}
-
Anand K. Mistry authored
This option is either ignored by cros-disks, or ineffective. cros-disks now takes an opinionated, mount-specific approach to unmounting. Bug: 1019975 Change-Id: Ib85d2cf450fd943fd28b063254f5f7628ed5fe03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866092Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#711615}
-
Mingjing Zhang authored
This CL provides a basic level of debug info for a DCHECK failures in frame sequence tracker. The debug info is helpful to determine the tracker type when DCHECK failure occurs. Related to Bug: 1017291 Change-Id: I65e90697d283e0540d7d11dfbece278d25e0be6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893523 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a936069d60ce..385f3caebd48 git log a936069d60ce..385f3caebd48 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 oysteine@google.com Merge "Do not add samples/callstack which reference invalid data" Created with: gclient setdep -r src/third_party/perfetto@385f3caebd48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1661f9591b60d941de29671a245ab005f4bfb56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894855Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cdc22769d474..fb03935bedd7 git log cdc22769d474..fb03935bedd7 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 enga@chromium.org Add a GetInstanceProcAddr helper for the native Vulkan backend. 2019-11-01 enga@chromium.org Revert "Implement readonly storage buffer - validation at API side" 2019-10-31 yunchao.he@intel.com Implement readonly storage buffer - validation at API side Created with: gclient setdep -r src/third_party/dawn@fb03935bedd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I40b0bb56af6efeade53e3f8366dd6acc080bf652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894854Reviewed-by:
-
Jay Harris authored
This was caused because PendingAppManager's shortcut_manager_ was not being initialized in SetSubsystems. It was not caught by existing tests because we disable shortcut creation in tests, as it's hard to clean up afterwards. In a followup CL I'm going to try and push shortcuts being disabled further down the stack. Bug: 1019319 Change-Id: I91d8b22eb5cdba67a23481db778e0c4f9724e632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890394Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#711611}
-
Regan Hsu authored
Currently, if you tap on some sections (see Before screenshot), the focus highlight is chopped, because only those pixels can trigger the link. This CL extends the link to fill the space that was previously missing, which also extends the focus highlight to fill the missing space. Before screenshot: https://screenshot.googleplex.com/8d5h2kok95m After screenshot: https://drive.google.com/drive/folders/1fKpbwx3C0_REo1McC3JyYX68ng3b-sTA?usp=sharing Bug: 1008361 Change-Id: Ibc89b79294e7ee7c9b9285ab8f80ce3b3768689e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879445Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711610}
-
John Lee authored
- Track thumbnails only if they are currently in view or are just a standard finger swipe away. - Do not track thumbnails for pinned tabs. - Do not track thumbnails when the tab strip is closed. Note that this CL does not implement actually untracking thumbnails. It merely calls the method in the C++ side that will eventually do it. Bug: 1015132 Change-Id: I16cce4a71ad3e6e887555be27e1525cdef9beb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894245Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711609}
-
Abigail Klein authored
Use the accessibility event recorder to capture events fired on a page, and display the log on chrome:accessibility. This log isn't particularly meaningful for now, but follow-up CLs will make this be more useful. Bug: 785493 Change-Id: I5bf88bc070ac7df322cb41847a86642cbf038483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823617 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711608}
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of IDBCursor, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: Ic35389c4b1e0e8d38aff73186bd5db10ed1a1e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890521 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711607}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b131630e7c74..48233ad3d45b git log b131630e7c74..48233ad3d45b --date=short --no-merges --format='%ad %ae %s' 2019-11-01 johnkslang@users.noreply.github.com Merge pull request #1949 from corporateshark/master Created with: gclient setdep -r src/third_party/glslang/src@48233ad3d45b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: If57a7070233d6152a0f9d93a99f7e4ae349e5335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893686Reviewed-by:
-
Xinghui Lu authored
Launch bug: crbug.com/1000331 Bug: 995926 Change-Id: If68dd89ce3bbcddaa0ce2c6553eedf9f6d263216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894297 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711605}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ba65c156cf76..e96039218e9d git log ba65c156cf76..e96039218e9d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 jmadill@chromium.org Capture/Replay: Correct a few GLenum replay issues. Created with: gclient setdep -r src/third_party/angle@e96039218e9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Icfc2f7c19eaf3570f2b25644ab2e7ea017656011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893685Reviewed-by:
-
Rakina Zata Amni authored
Unload events never fire for documents that are put into the BackForwardCache, so these tests won't work with bfcache turned on. Change-Id: I5db67e2d014f993e27764bae841323207191a72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883352Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#711603}
-
Julie Jeongeun Kim authored
This CL converts ProxyResolvingSocketFactoryPtr to new Mojo types using PendingRemote and Remote. Bug: 955171 Change-Id: Ib92e2fd3f2103568e70c50699a5d2b573056594c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889271Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711602}
-
Gyuyoung Kim authored
This CL converts old Mojo types of CdmService interface to new Mojo types. Major changes are as below, - Convert connector()->BindInterface to connector()->Connect - Convert FooPtr to mojo::Remote Bug: 955171 Change-Id: Ic754b8747258f941afc249d5c628906d3ef43675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890453Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#711601}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4835364353e6493df87ce6fc273a70b6a6e12ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894504Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa2b7d8d16c4..95bb5f86b1c0 Created with: gclient setdep -r src-internal@95bb5f86b1c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1019931,chromium:None Change-Id: I03a522098472a6002ccdc64f9a66c8a0699a625b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894063Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711599}
-
Nate Fischer authored
No change to production logic. This adds tests for already-implemented UMA proto fields (specifically, the hardware.* fields). This intentionally skips fields which don't apply to Android OS (ex. hardware.form_factor, hardare.max_dpi_*). This also skips fields where we're not logging a meaningful value (ex. gpu.vendor_id), since such fields are effectively empty anyway. Bug: 1011991, 1008534 Test: run_webview_instrumentation_test_apk -f AwMetricsMetadataTest.* Change-Id: I871d81b1b669ddef4169744715fe9f043f7573be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888399Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711598}
-
Alice Boxhall authored
The :focus-visible pseudo-selector emulates the existing behaviour of native elements like buttons by only showing a focus ring when focus is moved using the keyboard. This change modifies that behaviour to always match :focus-visible on the focused element, regardless of how focus was moved (effectively making :focus-visible equivalent to :focus) if the user has enabled the "Highlight the object with keyboard focus when it changes" setting on Chrome OS. This plumbs through the ash::prefs::kAccessibilityFocusHighlightEnabled preference on Chrome OS to a new web setting on Blink, and checks that setting when computing whether :focus-visible matches on the focused element. Bug: 817199 Change-Id: I072e24eba525e5f62507fb5ab7a369d618067c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886075 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Justin Cohen authored
For some reason this button constantly gets a long press when it should be a tap. Consolidate this hack. Change-Id: Ia6f0f36d9e2aea79673ac0c74fc0d95289d0b043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892220Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711596}
-
Peter Kasting authored
Calling logically-const methods like GetHeightForWidth() would change the layout. This resulted in graphical bugs unless Layout() got called after each such case, which in theory shouldn't be necessary (and was not happening after crrev.com/699335 ). Bug: 1015717 Change-Id: I06bd35f273a9192b29fbaabfae9b5cc1aba66532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884455 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711595}
-
Hector Carmona authored
This is a followup to https://crrev.com/c/1874816 that brings the same a11y fix to browser settings. Bug: 987406 Change-Id: I6a22bd509ffcf75312c2897af4374ce5bf418718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888315 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#711594}
-
Austin Eng authored
FlexibleArrayBufferView allows small ArrayBufferViews to be passed as a temporary on the stack. This saves creating global handles and weak roots in V8. Bug: 852089 Change-Id: Ic0e8ee941c5175ac5232d5b6a2c1f3f1a315bf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894409Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#711593}
-
Jacques Newman authored
Bug: 1019947 Change-Id: Ie19d410e0fc5e07b1ebc1fcdf3d94a94dfce9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888188Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711592}
-
Alexey Baskakov authored
This is a reland of 5a0adcbe Looks like some platforms don't support sophisticated fonts to render fancy unicode characters. Let's use simple "+" ASCII character. Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Bug: 1019102 Change-Id: I25f09ff941b8256d7fae9a7121aa439dc2ef2b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893596Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#711591}
-
Xiaohan Wang authored
The new test case verifies that pipeline initialization of encrypted playback waits for a CDM to be set, and a CDM that doesn't support a Decryptor or a valid CDM ID will cause initialization error. Bug: 1018854 Test: New test cases Change-Id: I67fe51fb5012059533a5113ac929b89f47fdfe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885022Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711590}
-
Daniel Hosseinian authored
Rename shadowed variables in PDFiumPage::GetLinkTarget() Bug: 993548 Change-Id: I88e660b6df99c4f3e2140014e1bb5e6626d56ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893504 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711589}
-
Matt Mueller authored
Bug: 635205 Change-Id: Ia35549688605986b88eb06b373f9d63c3bd3a26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882761 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711588}
-
Dominic Farolino authored
R=gab@chromium.org Bug: N/A Change-Id: Ie4779514a78a37f5fdf55d17e713eea46138a8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892551Reviewed-by:
-
Justin Cohen authored
Adds tests for opening and restoring various sites. Also tests that only the activate webState is restored. Currently there is no support for background/restore in EG2, so those portions of the test suite are #ifdefed out. Change-Id: I5a8e4e3d019ba1598ec806175e369b7dae3cba84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874447 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
