- 01 Oct, 2020 40 commits
-
-
Esmael El-Moslimany authored
Bug: 1132424 Change-Id: I1b56fdec5c37d81a4939e986b3282af4585772ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440970 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812569}
-
Nate Fischer authored
The kOutOfBlinkCors base::Feature was removed in https://crrev.com/c/2415752. This removes the corresponding Dev UI switch since it's obsolete. Fixed: 1132134 Test: N/A Change-Id: I314358545fd89ccdcf68a340da671242e4be99c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441933 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#812568}
-
Omid Tourzan authored
Bug: 491043 Change-Id: Ib87a5acf508ad25cbd5a84e584c75cb5df0d5c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422102Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812567}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8265a309314..fae3f2841bd0 2020-10-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8e84efc7aefde658de5d075fbeebb8297e4a2e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812566}
-
Shakti Sahu authored
This CL adds metrics for the video player, which includes user clicks on various buttons, video latency, and various video playback states. Some more metrics will be added in the next CL. Bug: 1117155 Change-Id: I6ef8a515dfff43c66ca2197cf8db087b058db236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434096Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812565}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8e0aa441a550..8c337a36b2e8 2020-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ad421a248adb to da5828c06b4c (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I1e3b628e6109eece6444228801062ae16da8f956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442412Reviewed-by:
-
Alex Newcomer authored
For clipboard history, record the format of the item pasted or deleted in two separate metrics. Bug: 1099338 Change-Id: I903f83a6b0e22f7d55cc9e478584146aa52af4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424680 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812563}
-
Xiaohan Wang authored
A binder for interface media.mojom.CdmInfobarService for the frame scope was only registered at the chrome/ layer, but not in the content layer. So when running content_browsertests, the render process was terminated for bad Mojo message. This CL fixes the issue by using an EmptyBinderForFrame for the service at content layer. Bug: 1128445 Change-Id: I5ce49b2af3a17035bad71b165bc8c24a0bd1b9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441292 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812562}
-
chrome://flagsAustin Tankiang authored
Bug: 1067346 Change-Id: I6a4425e6398ad95b693b1a7a5d089d1da6f580b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440324Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#812561}
-
Alexandre Courbot authored
The V4L2 IP only supports MMAP and DMABUF as storage types for output buffers. Make sure to fail building the IP if the client requests output storage to be user memory, so we can fall back to another IP in this case. Bug: None Test: image_processor_test on Kukui and Hana falls back to libyuvIP instead of failing to queue the USERPTR output buffer. Change-Id: I3c66d6eb8aecaf4240b4ceac516d3c43b4d6e141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123498Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#812560}
-
Mei Liang authored
Using PopupWindow as a container has shown some disadvantages, and it is listed in https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing. In addition, crrev.com/c/2399314 has also shown the difficulties of supporting accessibility with the focusable PopupWindow. This CL removes the PopupWindow usage in TabSelectionEditor by allowing TabSelectionEditorLayout attaches itself to the parent view when TabSelectionEditorController#show is called, and removes itself from the parent view when TabSelectionEditorController#hide is called. Bug: 1133014, 1124919 Change-Id: Ic53efddd9de1c22d02753c3f40df2769a5603495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438769Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812559}
-
Charlie Hu authored
This CL uses unique image URLs for image policy tests, so that the policy violation console messages do not get deduplicated. This is the prework to land violation report deduplication for document policy violation(https://chromium-review.googlesource.com/c/chromium/src/+/2405646). Bug: 924684, 926199 Change-Id: Ib736799fb7370b639e8102361c0b0d4627f0ccb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416849 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#812558}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/de0105d0bb7a..5e947adaf26e 2020-10-01 capn@google.com Fix clamping cube face coordinates to [0.0, 1.0) range If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I448a204ca60d8f0493f9ea786d637156ab3d9fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442061 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Chih-Yu Huang authored
The V4L2 stateful API requires the caller pass the same buffers to the output queue slot. This CL change V4L2Queue::GetFreeBuffer() signature that allows the caller get a specific output queue slot. BUG=b:159688625 TEST=video.DecodeAccel.h264 passes on Kukui. Change-Id: I5245998b236dbb698df3d1ca11b6f269dd5de374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413943 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
-
Ben Goldberger authored
-Resolve issue with text overlapping close button on multiline chips -Add top and bottom padding for multiline chips (12dp) -Increase start and end chip padding (16dp) and padding close button padding (16dp) -Switch to lens icon with color -Increase size of close icon to 24dp to match lens icon -Align text to viewStart Screenshot light: https://drive.google.com/file/d/1kpiDc_Wr14hPvrPqF5T9ExZhhl-nW7MQ/view Screenshot dark: https://drive.google.com/file/d/1LPfy4zJ9wYZRR9E71A6fvvgwFpPh2-b0/view Bug: 1099982 Change-Id: I41307dd2168bd3a7e0ecb3fb8c01b0df1ee64764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436516 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#812555}
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2438385 Bug: chromium:1133675 Change-Id: I54cc0e61a260f13944520002632109e30dbb1881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440599 Auto-Submit: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#812554}
-
Takashi Sakamoto authored
This reverts commit 84d8dbe7. Reason for revert: Suspect causing blink_web_tests failures on WebKi_Linux_ASAN because of heap-use-after-free. First detected build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/18333 blink_web_tests failure: https://test-results.appspot.com/data/layout_results/WebKit_Linux_ASAN/18333/blink_web_tests/layout-test-results/results.html --- STDERR: ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d0000065e8 at pc 0x562d5af2328d bp 0x7ffd61c33860 sp 0x7ffd61c33858 STDERR: READ of size 8 at 0x60d0000065e8 thread T0 (content_shell) STDERR: error: unknown argument '--demangle=True' STDERR: #0 0x562d5af2328c in content::AgentSchedulingGroup::RemoveRoute(int) ./../../content/renderer/agent_scheduling_group.cc:133 STDERR: #1 0x562d5af2328c in ?? ??:0 STDERR: #2 0x562d5af61740 in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:248 STDERR: #3 0x562d5af61740 in ?? ??:0 STDERR: #4 0x562d5af61b7d in content::RenderFrameProxy::~RenderFrameProxy() ./../../content/renderer/render_frame_proxy.cc:246 STDERR: #5 0x562d5af61b7d in ?? ??:0 STDERR: #6 0x562d5af6712d in content::RenderFrameProxy::FrameDetached(blink::WebRemoteFrameClient::DetachType) ./../../content/renderer/render_frame_proxy.cc:620 STDERR: #7 0x562d5af6712d in ?? ??:0 --- Original change's description: > [MBI]: Use |render_thread_| instead of RenderThread::Get in AgentSchedulingGroup > > R=haraken@chromium.org, kouhei@chromium.org, talp@chromium.org > > Bug: 1111231 > Change-Id: Ia7151587a3459c5262edd5721c63dfec60870cc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438709 > Commit-Queue: Dominic Farolino <dom@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Tal Pressman <talp@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812463} TBR=haraken@chromium.org,kouhei@chromium.org,dom@chromium.org,talp@chromium.org Change-Id: I1cda1459c45d129c669fa2736a4ea4322533515c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442211Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#812553}
-
Shakti Sahu authored
This CL adds : 1 - Sending Country code, and accept language to the server. 2 - Provides dependencies for video tutorial service creation. TBR=dtrainor@chromium.org Bug: 1133657 Change-Id: I04ed5cfecb481810e8e24102aff2d4468b44f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438780Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
Dana Fried authored
Changes two behaviors around hover cards: - overlong domains are now middle-elided, reducing the chance that bad data at either the beginning or end (depending on scheme) will mislead the user - blob: URLs now display as "temporary data" and no effort is made to display the "domain" of these URLs as it is not interesting at all to the user and only a source of potential exploitation Bug: 1133183 Change-Id: I4779fa477a05e0017acffb2d9b98290939887f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437154Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#812551}
-
Melissa Zhang authored
Add ActivityName to AccessibleName for screenreaders. Bug: 1131296 Change-Id: I5f01a14f8113cd00cfb3bda526da5975f7ceeb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440226Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812550}
-
Jiewei Qian authored
This reverts commit 29736b94. Reason for revert: Tests are failing consistently in linux-chromeos-rel Sample failing jobs: [1] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41574 [2] https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41572 Tried to reproduce locally, HasMaskLayerWithLongText fails 9 out of 10 times. Error message: ../../ash/ambient/ui/media_string_view_unittest.cc:285: Failure Value of: GetMediaStringViewTextContainer()->layer()->layer_mask_layer() Actual: false Expected: true Original change's description: > ambient: handle suspend case better > > Previously ambient mode will trigger lockscreen on screen dimm and then > rely on lock screen idle to show screen saver. This works in some cases, > but in suspend case the time between screen dim and cpu suspend is too > short. Screen saver was not able to enguage. The reason we have the set > up is because the screen saver was sharing the same window constainer as > the lock screen, it cannot show before lock screen is ready. > > Now screen saver has its own window container, we changed the flow to > show ambient mode immediately when idle. This will prevent cpu suspend > because screen saver will take a wake lock if charging. Screen saver > will still lock the screen in the back if user reference indicated > lockscreen after wake. > > Bug: b:169442907 > Test: unitests and manual tests > Change-Id: I1a5df2c58c976bba492c709e0a61dd5a6314d084 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435334 > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812397} TBR=xiaohuic@chromium.org,wutao@chromium.org,cowmoo@chromium.org Change-Id: I307c11aed04801e6705be083dcaabfa2c5099802 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:169442907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440326Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812549}
-
Eric Willigers authored
We now use CreateShareIntentFromFiles to create the ChromeOS intent. Bug: 1110119 Change-Id: Ic748392818e775f7466ea7c0937f8195025b8052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437679 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812548}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca3683da3ad6..b8265a309314 2020-10-01 asraine@google.com [Lighthouse] Roll Lighthouse 6.4.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb46289cb9f222620f4767ba42ca8d611d0a6647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442063Reviewed-by:
-
Bailey Berro authored
- Adds helper methods to convert between fields in the PowerSupplyProperties proto and new mojom enums. Bug: 1128204 Change-Id: I1ceeb4e9987b5975189a725d8f346c39b45186b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431477Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812546}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47270d12. With Chromium commits locally applied on WPT: 0c934f62 "[tables] Tables should respect the min content-size." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: If857635edef8d390f942695bb53571b0397eba80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441301Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812545}
-
Moe Ahmadi authored
Screenshot: https://screenshot.googleplex.com/BQKYn6sHSEq4fKs Fixed: 1130860 Change-Id: I0a63f7f93d662276a2407fe2533ba79ca0b55476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436699Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812544}
-
David Schinazi authored
As requested by Finch tool on Finch config CLs. Change-Id: I9717078a7a8ecc3bd49af49204637ce983f56c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441317 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#812543}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3859a3cba60..11d94d866e23 2020-10-01 jmadill@chromium.org Integrate Skia Gold with restricted trace tests. 2020-10-01 jmadill@chromium.org Drop isolated perf output arg in test runner. 2020-10-01 timvp@google.com Vulkan: Always reset during createPipelineLayout() 2020-10-01 ianelliott@google.com Vulkan:Add debug labels for OpenGL calls 2020-09-30 courtneygo@google.com Move LayoutCaches to ShareGroup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: Manually verify Cut the Rope doesn't crash Change-Id: If92931ea2cfc0c23a92481469e73fec80eca4525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442055Reviewed-by:
-
Tibor Goldschwendt authored
This is a reland of 4f97ffeb Original change's description: > [ntp][modules] Add info dialog to shopping module > > Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM > > Fixed: 1130862 > Change-Id: Ied56500f9384fc9bedc15eef4cb8ffcde4830b5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437473 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812227} TBR=mahmadi@chromium.org Change-Id: Id03d98a3e82e771f2f979985c9d3394adc772a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441298 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL adds Layout NG classes corresponding to blink::LayoutTextControlInnerEditor, blink::LayoutTextControlMultiLine, and blink::LayoutTextControlSingleLine. - LayoutNGTextControlInnerEditor doesn't need IsOfType(). - LayoutNGTextControl*Line should create new formatting context. This CL has no behavior changes. The new classes are not used yet. Bug: 1040826 Change-Id: If7d30d07ab7cf66bfa4e207b8ce99a4ba4cc3662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440228 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#812540}
-
Roman Arora authored
Adds support for cr-icon-button with no ripple animations required for certain UX scenarios. Bug: 1128599 Change-Id: Icd3f6749fd268b4548ea6f9639ec8340ed2da8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441041Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#812539}
-
Meilin Wang authored
This CL removes buttons on initial connecting UI and reconnecting UI to reflect the spec change. Screenshots: https://screenshot.googleplex.com/A6TprYL3kKm2q29.png https://screenshot.googleplex.com/AdmCtFgv4RqfMow.png BUG=1106937,1126208 Change-Id: Iff74b3168d6af80f17debf7be39af394e52da161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438983 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#812538}
-
Dirk Pranke authored
This allows callers to pass through --root and --dotfile args to GN as needed. Bug: 1133857 Change-Id: Id92c614c0c09f3cf94e43b4a50f2f9354b0392e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440477Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#812537}
-
John Palmer authored
This reverts commit c39af256. Reason for revert: This will be managed by finch instead. Original change's description: > Enable assistive autocorrect by default > > Bug: 1111135 > Change-Id: I740d8247b9770392cebc48ba434de775bbc9199a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412113 > Commit-Queue: John Palmer <jopalmer@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Auto-Submit: John Palmer <jopalmer@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807285} TBR=shend@chromium.org,jopalmer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111135 Change-Id: Ie3af175cdb992c1a03447681bf60c0035ca4462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440084 Commit-Queue: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#812536}
-
David Black authored
This is a reland of 9a224d53 Original change's description: > Miscellaneous holding space fixes. > > Fix pin toggle bounds in HoldingSpaceItemScreenshotView: > The bounds of the pin toggle button were being stretched to match the > full height of its parent container. > > Fix context menu bounds: > Context menu should be below the associated view (when space allows). > > Fix long press gesture: > When long pressing, the pressed view should become the selection just > prior to showing the context menu. > > Fix crash in HoldingSpaceTrayBubble: > If closing bubble due to ESC, bubble widget should only be closed if it > exists and hasn't already been marked closed. > > Fix drag behavior: > The holding space bubble should be closed during drag events. > > Bug: 1131262, 1131267, 1129981 > Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671 > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#812064} Bug: 1131262 Bug: 1131267 Bug: 1129981 Change-Id: I2e7438ac8b46c2bedf0896393e11a52cbf9f26ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441251 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812535}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ife74062292802a61f28605708b4abf323b41e382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441534Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812534}
-
Tibor Goldschwendt authored
Fixed: 1133411 Change-Id: Ib6ad0c6becd6d54ad9be1e1d1fb4a11828e7c214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436655 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812533}
-
Lan Wei authored
I have added wheel input source to testdriver action API, now I am using it to generate wheel scroll action in the wheel scroll WPT tests. Bug: 1040611 Change-Id: Ie359068ae0347591944d80033403205f4437ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316405Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#812532}
-
Ken Rockot authored
This is a reland of 18096716 No interesting changes, just updated to resolve a compile-breaking collision with another CL that landed earlier today. (see PS3) Original change's description: > Delete service_manager/embedder/switches.h > > Each switch is either deleted because it's no longer used, or migrated > to a more appropriate layer (generally Content). > > Bug: 977637 > Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 > Tbr: caseq@chromium.org > Tbr: dschuff@chromium.org > Tbr: finnur@chromium.org > Tbr: halliwell@chromium.org > Tbr: wez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812318} Bug: 977637 Change-Id: Ia33b2999f531e7504456b4b71d3b5e571af3a354 Tbr: caseq@chromium.org Tbr: dschuff@chromium.org Tbr: finnur@chromium.org Tbr: halliwell@chromium.org Tbr: rsesek@chromium.org Tbr: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440974 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812531}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f38f54f2f1a3..68377adad5ae 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibd03f0f3e26cf9e947f85d9ffe5a6a561e38c96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440991Reviewed-by:
-
