- 06 Jun, 2018 40 commits
-
-
Yoichi Osato authored
This patch rebases image failures that NG paints 1px taller than old. This is by-product but got lgtm at the previous patch: crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.) Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I26ab17747655017be2750355ab5c23708398fa40 Reviewed-on: https://chromium-review.googlesource.com/1086671 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564824}
-
Yuki Shiino authored
As a preparation to move DOMException's exception code into platform/, this patch decouples the definition of exception code from the implementation of DOMException class (especially data table). Also makes the value of exception code match the legacy error code of DOMException defined in Web IDL. Bug: 849607 Change-Id: I3044c1ebac8ddb344b3c1d380a08482c57225b30 Reviewed-on: https://chromium-review.googlesource.com/1086955Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#564823}
-
Yoichi Osato authored
This patch make the layout test contenteditable to reduce NG failure. Bug: 679977, 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iafc1d315fe9b3b88b66bf68a46939c98bda25409 Reviewed-on: https://chromium-review.googlesource.com/1086891Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#564822}
-
Christian Dullweber authored
When site data is removed, persistent quota gets resetted to zero. Instead of keeping the origin in the database, we should just delete it to remove traces of browsing_data. Bug: 849677 Change-Id: Ice2282274012fe8d2cb65bbac0b328523e8ce666 Reviewed-on: https://chromium-review.googlesource.com/1087057Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#564821}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2d16b804. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" bf5d61ae "Make fetch-event.https.html faster." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19108 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-scoping TBR=foolip No-Export: true Change-Id: Ice0d22c5e9582452b7017142246036f31d511fc0 Reviewed-on: https://chromium-review.googlesource.com/1088190 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#564820}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9861a71..ba9d017 git log 9861a71..ba9d017 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 nednguyen@google.com Add deprecation message for grouping_keys Created with: gclient setdep -r src/third_party/catapult@ba9d017 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: I5f393ee53d460a1081b727dc6bfc276643f2a553 Reviewed-on: https://chromium-review.googlesource.com/1088252Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564819}
-
Dominic Mazzoni authored
Refactor the messages used to communicate accessibility events from (1) the renderer to the browser, (2) from in content to outside of content, and (3) from the browser to the automation extension API. All three message structs are distinct, but previously each accessibility message consisted of one or more structs consisting of one AXTreeUpdate and one accessibility event (a few fields like type and id). Refactor all of these to a single struct consisting of (1) zero or more AXTreeUpdates, followed by (2) zero or more AXEvents, where AXEvent is a new struct that bundles together the common information needed about an event like its type and its target ID. See the design doc linked from the bug for additional motivation behind this refactoring. Bug: 848043 Change-Id: I6f5c743bcb79f8fe69453a7d1f9d24e515bbf123 Reviewed-on: https://chromium-review.googlesource.com/1080992Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#564818}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/844791e..ff6ae37 git log 844791e..ff6ae37 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 yunlian@google.com filter -Wl,-plugin-opt,-import-instr-limit= for simple chrome. Created with: gclient setdep -r src/third_party/chromite@ff6ae37 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I3a8d944f734395a6ebfe678b9dac72775f04d821 Reviewed-on: https://chromium-review.googlesource.com/1088251Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564817}
-
Yutaka Hirano authored
Bug: 721400 Change-Id: I033be720b2b1deb69ddb70cdd25a76087935423f Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1084809Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#564816}
-
Christian Biesinger authored
This is sort of a followup to https://chromium-review.googlesource.com/c/chromium/src/+/1084989, which added this call to a different location. R=mstensho@chromium.org Bug: 847807 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7e59f26b1d20615ae8ae4c8099991164533a6c21 Reviewed-on: https://chromium-review.googlesource.com/1087586 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564815}
-
Peter Qiu authored
Currently, when ui::mojo::Gpu interface is exposed by the Browser process (kMash feature is not enabled), only the binding requests from the Renderer processes are being handled. For certain devices and applications, it is desirable to access the ui::mojo::Gpu interface from a non-Renderer process, in order for that process to access video encode/decode accelerators hosted in the GPU process. This CL will allow other processes to bind to ui::mojom::Gpu interface hosted by the Browser process (assuming allowed by the manifest), by also handling ui::mojom::Gpu interface binding requests in CommonBrowserInterface. The handling for ui::mojom::Gpu interface binding requests from Renderer processes will stay the same. Bug: 836874 Test: run content_browsertests Change-Id: Ib1e3751d8c593a3c8d29096e7dc9cc609f6a1fa4 Reviewed-on: https://chromium-review.googlesource.com/1028556Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564814}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d43296..79725d3 git log 7d43296..79725d3 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 fmalita@chromium.org [skottie] Add a tool for dumping encoded animation frames Created with: gclient setdep -r src/third_party/skia@79725d3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Ib989a9e93c188395fc69eb0185fc4137dc35b24a Reviewed-on: https://chromium-review.googlesource.com/1088248Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564813}
-
Ramin Halavati authored
ExtensionFunction::include_incognito() is renamed to ExtensionFunction::include_incognito_information() to provide more clarity on the use cases. Bug: 845845 Change-Id: I0ba7bf58faf763a2ca8a50bf15f4c82e75ea82a0 Reviewed-on: https://chromium-review.googlesource.com/1078810 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#564812}
-
Hiroki Nakagawa authored
Referrer handling spans multiple algorithms in multiple specs, so I leave only the entry points of them. For top-level module script loading and static imports, referrer is determined based on the "outside settings": "Fetch a module worker script graph given url, outside settings, destination, the value of the credentials member of options, and inside settings." https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model For dynamic imports, referrer is determined based on the "referencing script's settings object". In this case, it's "inside settings": Step 2.4: "Fetch a module script graph given url, referencing script's settings object, "script", and options. Wait until the algorithm asynchronously completes with result." https://html.spec.whatwg.org/multipage/webappapis.html#hostimportmoduledynamically(referencingscriptormodule,-specifier,-promisecapability) These tests are still failing. Subsequent CLs will fix them. Bug: 842553 Change-Id: I3855b91c7e6ba93f5c99fb63b24b6274e6b43211 Reviewed-on: https://chromium-review.googlesource.com/1088339 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564811}
-
Hajime Hoshi authored
When the ExecutionContext is destroyed in an event queue, the event queue should no longer be available. Then it must delete all the queued events and close itself. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I2de831956238bc2e783e9c8c2eadc56f75f3faaf Reviewed-on: https://chromium-review.googlesource.com/1088341Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564810}
-
Koji Ishii authored
From a manual review of build 6212. * Images match, and text dumps match after known normalizations: compositing/self-painting-layers.html fast/forms/control-clip-overflow.html ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm virtual/video-surface-layer/media/video-display-toggle.html virtual/video-surface-layer/media/video-transformed.html * No images but text dumps match after known normalizations: printing/single-line-must-not-be-split-into-two-pages.html * Images match. Has additional anonymous LayoutBlockFlow: compositing/overflow/scroll-ancestor-update.html * Images match. NG does not create a text run for a space-only run in some cases due to different way to collapse whitespaces. css3/filters/effect-brightness-clamping.html css3/filters/effect-brightness.html fast/css/resize-corner-tracking.html images/feature-policy-max-downscaling-image-resize.html images/feature-policy-max-downscaling-image-styles.html images/feature-policy-max-downscaling-image.html * Console message differ. plugins/iframe-plugin-bgcolor.html * The height of culled inline box differ. transforms/3d/general/perspective-non-layer.html * Space differences in non text-dumps: images/color-profile-munsell-adobe-to-srgb.html http/tests/devtools/device-orientation-success.js TBR=atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I72b3e82c3a7713fb330ef44e015d9113b24f86e4 Reviewed-on: https://chromium-review.googlesource.com/1088340Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564809}
-
Allen Vicencio authored
This adds the metrics for the errors received during a failure in Remount in Native SMB File Share Bug: 757625 Change-Id: Ibb63eda818b0de190526b26e79a87288a13b67db Reviewed-on: https://chromium-review.googlesource.com/1080209 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#564808}
-
François Beaufort authored
This makes sure clicking the native Picture-in-Picture button (after entering Picture-in-Picture) exits Picture-in-Picture and that video controls are reflected when entering and exiting Picture-in-Picture. Screenshot: https://i.imgur.com/081Xbmb.png Bug: 840516, 806249 Change-Id: I410a4a06cc4eea62dae8e1d368e4d05394f13c86 Reviewed-on: https://chromium-review.googlesource.com/1084833 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#564807}
-
Joel Hockey authored
Currently async tests end up timing out when they call assert but don't catch the resulting exception and call done(true). It seems more natural that when an async test has an assertion failure, that the harness should catch the exception and take care of continuing tests. The alternative that async tests should catch there own errors has the drawback that specific errors are not ever reported. E.g. code below is bad. testAsync(done) { try { assertEquals('foo', 'bar', 'foo should match bar'); done(); } catch (err) { done(true) } } Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idbc88f94f6055eec37ab0d90b4b8d423fba6eb3f Reviewed-on: https://chromium-review.googlesource.com/1088327Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#564806}
-
Hiroki Nakagawa authored
See the issue for details. Bug: 849975 Change-Id: If597bdb282a3f50b7f9f36d1e9970ae7eae27271 Notry: true TBR: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1088347 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#564805}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/36d4a47..9861a71 git log 36d4a47..9861a71 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 sadrul@chromium.org tabs: Switch back to async trace events. Created with: gclient setdep -r src/third_party/catapult@9861a71 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849182 TBR=sullivan@chromium.org Change-Id: Id29f0c07a689efcbb900a4d9f0b54d2267602f51 Reviewed-on: https://chromium-review.googlesource.com/1088247Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564804}
-
Caleb Rouleau authored
Bug: chromedriver:2446 Change-Id: I63cfdc367af8cdbfc7f116fb51a3e3148ee0a950 Reviewed-on: https://chromium-review.googlesource.com/1087803 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#564803}
-
Xiaohan Wang authored
Also allow API to be used via Origin Trial. BUG=709348 Change-Id: I73e0c316a921ac3f9aac5cf259ef88ed37b38f9f Reviewed-on: https://chromium-review.googlesource.com/862965Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564802}
-
Christopher Lam authored
This CL fixes animations in the toolbar selection overlay. The elements would originally instantly appear rather than smoothly animate in due to the way dom-if worked. This has been fixed by applying an opacity animation rather than a show/hide. Bug: 842007 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75598d9048c3b4533a2dd52d003ff5a5d37e615d Reviewed-on: https://chromium-review.googlesource.com/1084391Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#564801}
-
Naoki Fukino authored
The volume label for Android files should be "Android Files", so this CL renames the label to the appropriate one and internationalize the label. This CL changes the icon for the "Play Files" volume, too. Bug: 846589 Test: Manually tested. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5ad9194094c14985d20a1055c153bab6c4d6b95 Reviewed-on: https://chromium-review.googlesource.com/1086899Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#564800}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d197803..0211346 git log d197803..0211346 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 jyan@ca.ibm.com PPC/s390: Fix GN error on PPC and s390 Created with: gclient setdep -r src/third_party/angle@0211346 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idc98620a8db960a78810386991a7fa82dc28dec2 Reviewed-on: https://chromium-review.googlesource.com/1088249Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564799}
-
Koji Ishii authored
CL:1063891 added some expectation files that have testharness failures. This patch remove them and add as [ Failure ] to track LayoutNG-only failures. TBR=yosin@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8424b1b40a659df694266416166861da24fb4672 Reviewed-on: https://chromium-review.googlesource.com/1088337 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#564798}
-
Allen Vicencio authored
This adds the metrics for the number of mounts a user has in Native SMB File Share Bug: 757625 Change-Id: Iec6e33523c56dbfb094f15758241ec7f2fabe8f7 Reviewed-on: https://chromium-review.googlesource.com/1080089 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#564797}
-
Tatsuhisa Yamaguchi authored
This is a reland of 181414e9 The original change was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1085067 > ==20322==ERROR: LeakSanitizer: detected memory leaks > Direct leak of 496 byte(s) in 1 object(s) allocated from: > #0 0x69b3d2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 > #1 0x65a6dca in ash::TopShortcutsView::TopShortcutsView(ash::UnifiedSystemTrayController*) ash/system/unified/top_shortcuts_view.cc:130:43 Original change's description: > Resize sign out button when it's too long. > > Limits the size of the sign-out / sign-out-all button to keep other > buttons and minimum spacing in the parent view. This is needed because > the translated text resource can be very long. Also adding description > for such text resources to keep them shorter in the next revision. > > Bug: 847100 > Change-Id: I8fc79b0b0d3eb661553323a2d9f094f02320fa0a > Reviewed-on: https://chromium-review.googlesource.com/1080364 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564016} Bug: 847100 Change-Id: Ic2641bf8d61d837c56072988033f68f31f3d5da8 Reviewed-on: https://chromium-review.googlesource.com/1085327Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564796}
-
Yutaka Hirano authored
This CL makes OnAuthRequired work with WebSocket when the network service is enabled. Design Doc: https://docs.google.com/document/d/1L85aXX-m5NaV-g223lH7kKB2HPg6kMi1cjrDVeEptE8/edit Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7587ea7937f3e283096a10a70d5d18b1a67d2650 Reviewed-on: https://chromium-review.googlesource.com/1009266Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#564795}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/87da90a..844791e git log 87da90a..844791e --date=short --no-merges --format='%ad %ae %s' 2018-06-06 pwang@chromium.org chromeos_config: remove arc-gts from infoVMTest Created with: gclient setdep -r src/third_party/chromite@844791e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I21d113592e0f28a427901a3c1c1df379865270aa Reviewed-on: https://chromium-review.googlesource.com/1088250Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564794}
-
Xianzhu Wang authored
This reverts commit 85b96ea9. Reason for revert: crbug.com/849968 Original change's description: > [PE] Ensure update of LayoutSVGShape::NoScalingStrokeTransform > > In Pre-SPv175 we forced subtree paint invalidation on non-composited > transform change. SPv175 no longer does that, causing > NonScalingStrokeTransform not updated on ancestor transform change. > > We also had a non-obvious bug that LayoutSVGShape::StrokeBoundingBox > didn't get updated on ancestor transform change. > > Now always explicitly update non-scaling-stroke data during layout. > > Bug: 849080 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ia61eb94f43e53a71a80e1102e4d605e4331f44b1 > Reviewed-on: https://chromium-review.googlesource.com/1086715 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#564584} TBR=wangxianzhu@chromium.org,fs@opera.com Change-Id: Ifbdd23b74dc45b5c8bc66c3d64bff580d5306f78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849080, 849968 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1087332Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564793}
-
François Beaufort authored
This makes sure Picture-in-Picture window controls are hidden when window is shown. Bug: 726619 Change-Id: I195df27741440c2f00ae0e50bdcd8abe59367f42 Reviewed-on: https://chromium-review.googlesource.com/1084094Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#564792}
-
Sidney San Martín authored
This fixes the window button position for MD refresh. Bug: 841348 Change-Id: Ib313a773a6a220cb8e3e39c944325e4a105ec7ad Reviewed-on: https://chromium-review.googlesource.com/1081053 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#564791}
-
Sasha Morrissey authored
Make setupAndWaitUntilReady take optional arguments for default entries to set up in the file manager. This is required for tests that need a different set of entries to the default. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c505ff3be8c8b85167bfbfe300714f728dba19a Reviewed-on: https://chromium-review.googlesource.com/1088330 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#564790}
-
Nigel Tao authored
This neither adds nor deletes declarations. It reorders them to lessen the diff on a subsequent commit (which automatically generates file_manager_private.js by running tools/json_schema_compiler/compiler.py on file_manager_private.idl). Two declarations (EntryAction, installWebstoreItem) don't have any corresponding entry in the file_manager_private.idl file. Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6dcc4a8f4f51182f7e33509decebe72b221f3ea6 Reviewed-on: https://chromium-review.googlesource.com/1082185Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#564789}
-
Sam McNally authored
Currently, FileManagerBrowserTestBase::SetUpCommandLine(), after setting command line args for guest mode, calls its base class, eventually calling ExtensionBrowsertest::SetUpCommandLine(), which overwrites kLoginUser with its test user. This results in guest mode running with an underlying profile with an associated email address, causing DriveIntegrationService to be enabled for the underlying profile. Change FileManagerBrowserTestBase::SetUpCommandLine() to disable the base class's setting of user account flags so the guest mode tests more accurately replicate the production environment. Fix the chrome.fileManagerPrivate.startCopy() implementation to check free disk on a blocking sequence instead of the IO thread. Without an enabled DriveIntegrationService for guest mode, this code path is now covered by tests. Fix createNewFolder tests to not expect a google drive entry in guest mode now that it isn't mounted in guest mode. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I953290b120a2a6b4f24214a12516efded442b75c Reviewed-on: https://chromium-review.googlesource.com/1086888 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564788}
-
rbpotter authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I09abc82ecd2ab71850a70c65a9a2decfcc011fe3 Bug: 849476 Reviewed-on: https://chromium-review.googlesource.com/1086236Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#564787}
-
Luciano Pacheco authored
An |Error| instance already has the |stack| attribute so the exception doesn't need to be raised, which makes the code cleaner and faster. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I148bb213f58b1c7ea352d862b9c666da35ba2b48 Reviewed-on: https://chromium-review.googlesource.com/1086562 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564786}
-
Nicholas Verne authored
Eliminates Termina, Concierge in all user-facing strings. These are internal code names. BUG=849900 Change-Id: I47d627c01aafefde001ce4e76cd405caa66ff1cf Reviewed-on: https://chromium-review.googlesource.com/1084423Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#564785}
-