- 12 Jan, 2021 40 commits
-
-
Ewann authored
This is a reland of 60e867a2 Original change's description: > [iOS] Updates system colours to use google material colours > > This CL replaces the existing system colours by Google material colours. > > Bug: 1155472 > Change-Id: Ia9c9e8f31d65fe1db70fd29ad94ca370d0aede07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595050 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Javier Flores <javierrobles@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840999} Bug: 1155472 Change-Id: I4ce77a7ffbe2cb75fe3c3434e54f1ff34fdae7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620804Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#842432}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610408110-1b25c741a858a17df9d643531610232aedd2e5da.profdata to chrome-linux-master-1610431066-b046cf295bac84ed9eefc440cb75a6df945c21fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54747662dcc6290e178ced85691a6bf5188766bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842431}
-
Matt Falkenhagen authored
This is a reland of f4b58578 The fix is to add an early return of null `handle_` in MaybeCreateSubresourceLoaderParams() which is a weak ptr. The comment for `handle_` explains that for workers it can be destroyed before the interceptor, because {Dedicated,Shared}WorkerHost can be destroyed during loading. Also change WorkerScriptLoader to early return when the host is already destroyed, to avoid unexpected behavior like going to network instead of the service worker when it should. Original change's description: > service worker: Simplify main resource "handler" & "interceptor" (3/3) > > Bug: 1138155 > Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307 > Reviewed-by: Asami Doi <asamidoi@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842305} Bug: 1138155 Change-Id: I0b76d1cc9f0365d4bb0f063e1b42e5cb96d6d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623609Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842430}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. This CL is a reland. The original CL was reverted as the introduced tests were flaky. I have since debugged the source of the flake; the fix is contained in the diff between PS1 and PS2. It turned out to be a pre-existing problem in //weblayer's subresource_filter_browsertest.cc that the new tests simply tickled: I was holding the TestRulesetCreator in a local variable and sending the temporary files that it creates to renderer processes, but it destroys those temporary files when it is destroyed. D'oh! Bug: 1116095 Change-Id: I25f5dca647761f652c9d5a2dfc41db1a4d7712b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622215 Auto-Submit: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842429}
-
rajendrant authored
This reverts commit 9bdf89ef. Reason for revert: Landing the failing tests separately Original change's description: > Revert "ImageCompression: Disable on logged-in pages" > > This reverts commit d672f7b5. > > Reason for revert: SubresourceRedirectLoginRobotsBrowserTest.TestCancelBeforeImageLoad is flaky. > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/96887 > > Original change's description: > > ImageCompression: Disable on logged-in pages > > > > This CL adds a mojo to disable image compression on likely loggged-in > > pages. > > > > Bug: 1160424 > > Change-Id: I42dda576947aa04e51d3cb3a5fac712945ac9651 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598858 > > Commit-Queue: rajendrant <rajendrant@chromium.org> > > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840523} > > TBR=kinuko@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I150cc38bc4c2fb7113e6bdcb68c9dad0f6a2fffa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1160424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613025 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840578} TBR=kinuko@chromium.org,rajendrant@chromium.org,mstensho@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: 1160424 Change-Id: Iaf5ff91bad4246c23941b1ae2974d4d4c0d56c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617213Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#842428}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610398040-59038019b78fe7d9277311f636fda97275a69be4.profdata to chrome-win32-master-1610420273-f729673981a14d4f8cc70d6513013e1d16474c41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic969507c13ac42ab14ff3b122489bdfbc864b88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623796Reviewed-by:
-
Mustafa Emre Acer authored
This CL adds a switch to chrome://flags to turn the omnibox experiment on with 3 and 10 second fallback timeouts. Bug: 1141691 Change-Id: I812e06b29f14829d9cf40ac45e5b82935a0a292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620462 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842426}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/ui/: - drag_selector.js - file_manager_dialog_base.js - file_manager_dialog_base_unittest.m.js - files_confirm_dialog.js - files_menu.js - suggest_apps_dialog.js In //ui/file_manager/file_manager/foreground/js: - launch_param.js - providers_model.js - providers_model_unittest.m.js - web_store_utils.js Bug: 1133186 Change-Id: I5bdd717c5643f5a0d0ae8fe3d23ab06623c9b62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620744 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842425}
-
Marc Treib authored
Before this CL, the "field trial name" specified for the "PasswordChangeInSettings" feature was different between about_flags.cc and the corresponding entry in fieldtrial_testing_config.json. This caused a crash if the about:flags entry was enabled in a developer build. This CL changes about_flags.cc to match the fieldtrial testing config. Bug: 1108692 Change-Id: I21112af815aa8e6bca361c1e9cafd17aceeae5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599805 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842424}
-
Wei Lee authored
Since the maximize button under tablet mode does not work. Bug: b/175322338 Test: Manually Change-Id: I9e8f21c81b33d5e964f95e2fc259e88eea8bcdef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622365 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842423}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f7379c80b03..1b97affa04ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com Change-Id: I8f937d8ea76a0ce1c156a1eb0268ec8823a4f4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842422}
-
Asami Doi authored
This is a reland of 475e9c81 The original change is reverted due to the difference between the default value of the CheckOfflineCapability feature. In fieldtrial_testing_config.json, the CheckOfflineCapability feature is set to be enabled and its check_mode is "enforce". However, some environment seems to use "warn_only" check_mode. So use parameterized tests for the CheckNotOfflineCapableStartUrl test. Original change's description: > Add installability test for when start_url has no offline response > > The following case should not pass the offline capability check: > - manifest's scope: /banners/ > - manifest's start_url: /banners/manifest_test_page.html?ignore > - service worker's scope: /banners/ > > Bug: 1157242, 965802 > Change-Id: I2832fbc102fd931aecc9d42394f5429e4c66e6aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596902 > Commit-Queue: Asami Doi <asamidoi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840905} Bug: 1163791, 965802 Change-Id: I5b7fc2697708027db5543f47800dd69fdfa005d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616645 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842421}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2af8b31616a5571473feb5965a933c66790cc44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623797Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of 967a3ef4e72a61dec5f1c7475711f03737f16cf7 Original change's description > This CL fixes the build error caused by exceeding the max token limit > using the function overloading in text_link_colors.h. This CL makes the > file include forward.h files instead of shared.h using below change. > FooColor(ColorScheme color_scheme = ColorScheme::kLight) const; > => > FooColor() const; > FooColor(ColorScheme color_scheme) const; > Original change's description: > > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > > > This CL replaces the existing uses of native ColorScheme > > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > > in order to remove unnecessary type conversion. > > > > Bug: 919392 > > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#817773} Bug: 919392, 1162834 Change-Id: I3f506bafe1929fb48b7097f686818bf4793865d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |FirstLetterTextLayoutObject()| in |FirstLetterPseudoElement| not to find first-letter text out side first- letter parent as follow-up of [1], which makes finding first-letter text outside parent. In below example, before this patch changing "contenteditable" attribute of <div> causing rebuilding layout tree for <p>, then we have unexpected <::first-letter> element for <p> with first-letter text "abc". Then we have invalid layout tree with invalid |NGOffsetMapping| to crash painting selection. <style>p::first-letter { ... }</style> <div contenteditable><p><b></b></p>abc</div> [1] http://crrev.com/c/2560522 [CSS] Skip empty span when finding the first-letter text Bug: 1159762 Change-Id: I41f5d9e75080633f34c68b328945e1c92721e60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622362 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842418}
-
David Black authored
Previously holding space commands were not enabled for recents sections of the Files app. Now, holding space commands are enabled provided that the selection of entries contains entries from supported volumes. Per UX recommendation, entries from unsupported volumes are ignored with respect to command execution. Bug: 1160933 Change-Id: Iaccb0a756c4ec07c301f335fc3f5468f9a6d7a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623175 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Kenichi Ishibashi authored
We collected enough information about the execution time of GetAllOriginsInfo() so we don't need this UMA any more. Bug: 1165261 Change-Id: If6ef0ad8e49ead0fdd2d34d8bd25e7fd10c2fc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622355Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842416}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ea26a8ce553f..2bd95f1cf454 2021-01-12 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c3c70f848a71 to 987376cd21a8 (7 revisions) 2021-01-12 hao.x.li@intel.com Query API: Non-precise occlusion query on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I023defb110a2846b67d79a6fc263874563e6bafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623793Reviewed-by:
-
Alexey Baskakov authored
Background: We update default web apps icons only if user opens the web app url (DidFinishNavigation, throttled at daily basis). This new force_reinstall_for_milestone parameter in the external .json config allows to trigger force reinstall on a particular milestone. Bug: 1150687 Change-Id: I86956537e933d34ba6746ea3d7fa44dfe5ff1a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620921 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#842414}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610387594-34ec7be13acbaa9470ba5363f8af27b0c42697d0.profdata to chrome-win64-master-1610420273-ecb28c29a45742c5cbc86dad1c6df0817cb1d9b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e574c960d502c896cc68ebd25cb300af339b16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623791Reviewed-by:
-
Yunke Zhou authored
Bug: 1163474 Change-Id: I931fa71f052b40e11d3f0316717344a0895b36c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612946Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#842412}
-
Josh Simmons authored
Expiry set to M92 for features such as Gallery and the Chrome Web Store dialog which will be deprecated or changed in the near future. Expiry set to M98 (slightly more than 1 year) for core metrics that are unlikely to be removed any time in the future. Bug: 1153738 Change-Id: I969265828bdeb0190a61d0e3cdd9ec4a689a67e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612871Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82b992a1656d..59b0ce20d3e5 2021-01-12 yyanagisawa@chromium.org Roll out new goma client binary VERSION=210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8f7339232f66c05fbc49ca6e381cdd28a9ccc6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623795Reviewed-by:
-
Yang Guo authored
Fixed: 1153862 Change-Id: If3dd79e6861164eb8d062cac4367cbffe2622c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605760Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Regan Hsu authored
After the user successfully completes the PhoneHub Notifications setup flow in OS Settings, the feature will now be enabled automatically. Fixed: 1164973 Bug: 1106937 Change-Id: I7b59b5b8a19aabffe034763367c801288a43898d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622737Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842408}
-
Matt Falkenhagen authored
ServiceWorkerSubresourceLoader::FollowRedirect() seems to be be getting called when there is no redirect_info_. Add crash keys to see whether a redirect was already followed, or was never received, or if something has gone wrong in the loader's state transitions. Bug: 1162035 Change-Id: I23ff73ca932d8ada60fe8156c9c33a132db42575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617527Reviewed-by:
-
Rainhard Findling authored
A small code health refactoring that: * Removes the redundant |SAFETY_CHECK| prefix as well as the additional |MANAGE_THROUGH| and |REVIEW_THROUGH| from some of the safety check metrics histogram variable names in metrics browser proxy. * Extends the |REVIEW_COMPROMISED_PASSWORDS| metric variable name for better clearity. Bug: 1015841 Change-Id: I032cc5c043acb961cb31d8feb69e4b9781618eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600738Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#842406}
-
Rainhard Findling authored
Add separate metrics for clicks on the safety check password check child in case weak but no compromised password have been found, so that compromised, weak only, and other cases can be distinguished. Bug: 1015841 Change-Id: I81904ac412088584cfbc9cff128e1de09e2ff81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599865Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6586aaa57716fe7f0a4ccfb2175bf29716952ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622714Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I0aeccbb16345b860c646c763ed2ba6be187bc17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623716Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842403}
-
Regan Hsu authored
* Remove gap between rows in "Connect to Network" page. * eSIM cellular network list will have 8px padding top and bottom. * Add fake esim pending profile to fake hermes manager client. Screenshots (Note that the background colors are not part of the CL and are only there for visualization of different network row types): https://drive.google.com/drive/folders/1iMszYFuCE_HDxIVWUcbgi8QnNjzLwqHn?usp=sharing Fixed: 1162054 Change-Id: I904cb9d94fdef9e07968953807d209be3c5a77d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612521 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id5a9e1766d5284f3b1b69b88a5230512b86db630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622715Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9c5f284a6e1d10f526449574ce96df9f5a1b2225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623788Reviewed-by:
-
Minoru Chikamune authored
This CL renames compositor_task_runner to compositor_task_queue when the type says it's queue. Bug: 1105403 Change-Id: I713784d2b42bc80aa3aa7d3fe6afabb98fa077e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617685Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#842399}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1d9935cf37fd..987376cd21a8 2021-01-12 dsinclair@chromium.org Revert the namer changes. 2021-01-12 dsinclair@chromium.org Add a Unsafe SPIR-V generate call. 2021-01-11 dsinclair@chromium.org Update new entry points to use correct namer. 2021-01-11 bclayton@google.com Add std::hash<tint::Symbol> specialization 2021-01-11 bclayton@google.com TypeDeterminer: Fix type map iterations 2021-01-11 bclayton@google.com Add diag::Formatter::Style::print_newline_at_end 2021-01-11 bclayton@google.com Implement textureDimensions() 2021-01-11 dsinclair@chromium.org Fix const-ness of inspector constructor. 2021-01-11 dneto@google.com Fix doxygen comment 2021-01-11 dneto@google.com spirv-reader: convert arity of textureLoad on depth texture 2021-01-11 dj2@everburning.com Switch default to the MangleNamer. 2021-01-11 dj2@everburning.com Allow setting the namer into the inspector. 2021-01-11 dj2@everburning.com Change generators to take a pointer instead of move. 2021-01-11 dj2@everburning.com Use TestNamer in the SPIR-V backend. 2021-01-11 dj2@everburning.com Use TestNamer in HLSL tests. 2021-01-11 dj2@everburning.com Use a test namer in the MSL generator. 2021-01-11 dj2@everburning.com Remove name fields 2021-01-11 dj2@everburning.com Remove IdentifierExpression::name(). 2021-01-11 dj2@everburning.com Remove Function::name(). 2021-01-11 dj2@everburning.com Remove StructMember::name(). 2021-01-11 dj2@everburning.com Remove StructType::name() 2021-01-11 dj2@everburning.com Remove the AliasType::name() getter. 2021-01-11 dj2@everburning.com Remove Variable::name(). 2021-01-11 dj2@everburning.com Use the top level namer in the SPIR-V backend. 2021-01-11 dj2@everburning.com Use namer in the Inspector. 2021-01-11 dj2@everburning.com Convert HLSL to higher level namer. 2021-01-11 dj2@everburning.com Convert MSL generator to unsafe namer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I27e45b9e32620e7933bec51ef29d24b26a160ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623789Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43ed322b..4281a3f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d34c0ea287367f7896ccaa0a1b78c4aa88b9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623715Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842397}
-
Tibor Goldschwendt authored
Tests ModuleDescriptor.initialize, which is the only function of that class with non-trivial logic. Adding tests is a precursor to making changes to that class in subsequent CLs. Change-Id: Ib023f014f21e547bcbf38776781a95b6d83b3e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623653 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
So far, a RepeatingTimer is used to abort the ClipboardOzone's requests and it's not being properly stopped when it's triggered (timeout). This switches to a OneShotTimer as well as resets pending_request_ after the internal run loop quits, so covering both the successful and abortion cases. R=dcheng@chromium.org Bug: 1165466 Change-Id: I5e7108b93999aa4632a2834b1667cf75aa7d1cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622285Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#842395}
-
cfredric authored
This brings the implementation into alignment with the final paragraph of https://github.com/cfredric/sameparty#sameparty-vs-samesite-enforcement-modes, which states that if a site is not a member of a First-Party Set, its cookies will be subject to SameSite rules, rather than SameParty rules. Bug: 1143756 Change-Id: Ie4c9066c874d9e7a42a6d8504f33d4b6e669ff7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613194Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#842394}
-
Yunke Zhou authored
Bug: 1130502 Change-Id: I7ac24f02a9ef1b41a7c3a25641069c38d85bee78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620260Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#842393}
-
