- 26 Jul, 2018 40 commits
-
-
Peter Wen authored
- Rename `repository` to `libs` in order to stop git complaining about previously ignored *.info files being overwitten (since we are now including them in the repo) when cherry picking - Nice side benefit of resetting to -cr0 for packages - Add gms libraries, previously defined in `build/secondary/third_party/android_tools/BUILD.gn` - Add `third_party/android_deps/Android_SDK_License-December_9_2016.txt` - This is used for all gms dependencies which require this license - Taken from `https://developer.android.com/studio/terms` - Pass in output file directly to `aar.py` - Add .info files to the repository and remove from `.gitignore` - Increment crX suffix for CIPD packages in order to avoid duplicate tags - Add OWNERS in each package's subdirectory under `libs` so that future version upgrades will not require full review, but new packages will still go through full third_party review. Bug: 865020, 865065, 863547 Change-Id: I91cc400d02ce83e0195d8aab3f76939d6ddcb120 Reviewed-on: https://chromium-review.googlesource.com/1142189Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578434}
-
kaiwang@chromium.org authored
BUG=724399,b:70905156 Review URL: https://chromiumcodereview.appspot.com/10535049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141295 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 49e4b033) Signed-off-by:
Gabriel Marin <gmx@chromium.org> Change-Id: I5a22ef15a79748fb123609c793c96acbdbe903e1 Reviewed-on: https://chromium-review.googlesource.com/1130778 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#578433}
-
Vaclav Brozek authored
...and also the related *password_value_is_default fields in PasswordForm. These are only set and never read. Bug: 845426 Change-Id: I87e686d2cfb588cb94a50e8a6395a7b19b7b82d5 Reviewed-on: https://chromium-review.googlesource.com/1149878Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578432}
-
sebsg authored
Was called AutofillProfileEnabled Is now called AutofillAddressEnabled Bug: 860526 Change-Id: Ic2b31c4a108a01049c59b1e6ccad62a7760c2cd9 Reviewed-on: https://chromium-review.googlesource.com/1150699Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578431}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/721613b08607..933672b6cfa1 git log 721613b08607..933672b6cfa1 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 bsheedy@chromium.org Reland "Handle stale directories when pushing files" 2018-07-26 benjhayden@chromium.org Fix a few typos in Descriptor. 2018-07-26 dtu@chromium.org [pinpoint] Add "Win 10 Perf" to list of Pinpoint bots. 2018-07-26 simonhatch@chromium.org Telemetry - Start xvfb when running snapit tests. 2018-07-26 wangge@google.com Modified Script to Parse Time from Arguments 2018-07-26 dtu@chromium.org [pinpoint] Add Job name field. Created with: gclient setdep -r src/third_party/catapult@933672b6cfa1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862845,chromium:863995,chromium:825434,chromium:863390,chromium:867722 TBR=sullivan@chromium.org Change-Id: I3f2cf3e0fdfe04a7f75b86519204fda3988625e6 Reviewed-on: https://chromium-review.googlesource.com/1151905Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578430}
-
akaba authored
Referencing SurfaceManager::GetLatestInFlightSurface in surface activation instead of fallback surface. Use SurfaceManager::LatestInFlightSurface in Surface::ActivateFrame to use the latest in-flight surface as the active reference instead of fallback. This allows for better garbage collection of surfaces and optimize the notion of fallback surface. Bug: 857575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4f597e431866b3a9886c04b982101199fd4011d7 Reviewed-on: https://chromium-review.googlesource.com/1149092 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#578429}
-
Michael Giuffrida authored
Moves some utility functions for URL filtering from chrome/browser/supervised_users into components/policy. These will continue to be used by supervised users, but can now also be used for policy (namely the upcoming safe sites filter implementation). Largely a refactoring. The only tangible difference is that the re2 regex objects used to be per-profile but are now global (static): They used to be members of SupervisedUserURLFilter (which was owned by the per-profile SupervisedUserService) but are now part of the singleton EmbeddedURLExtractor helper. Alternatively, we could create a new //components/url_filter component with per-profile EmbeddedURLExtractor services, but that seemed like overkill for a couple utility functions. Bug: 819405 Change-Id: I4f8313f46778447e123f0021dc3a32cb4598f58c Reviewed-on: https://chromium-review.googlesource.com/1117884Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578428}
-
Vaclav Brozek authored
This is a reland of ad191cb7 The fix is changing the build deps of the proto target from "override_lite_runtime_plugin" to the new "override_lite_runtime". This only makes sense after https://crrev.com/c/1128249 lands. Original change's description: > Add fuzzer for FormStructure::ProcessQueryResponse > > Also adds: > -fuzzing support for protos at components/autofill/core/browser/proto > -ProcessQueryResponse method to FormStructure class. > > Bug: 834707 > Change-Id: I831e012c0a5569f663d6bd435c7c24d7a6f6a524 > Reviewed-on: https://chromium-review.googlesource.com/1125847 > Commit-Queue: Uladzimir Miniailau <miniailau@google.com> > Reviewed-by: Vaclav Brozek <vabr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572609} Bug: 834707, 860750 Change-Id: Iab758495777a3d41ce58d0454c36877a3888440e Reviewed-on: https://chromium-review.googlesource.com/1129019Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578427}
-
Peter Boström authored
Gives 4dp of whitespace back to the user (in Refresh) by using TOOLBAR_ELEMENT_PADDING. This unifies the bookmark item spacing with toolbar items. Bug: chromium:848631 Change-Id: I20c2ea5735f93a4db2d7c7e6c218ed4bd528c458 Reviewed-on: https://chromium-review.googlesource.com/1152029 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#578426}
-
Olli Etuaho authored
This adds working WEBGL_multiview extension integration to the passthrough command buffer. It's not implemented in the validating command buffer. The implementation is built completely on top of ANGLE_multiview, and doesn't support native OVR_multiview as a backend. This doesn't yet include support for opaque framebuffers either. That is intended to be done as a follow-up. The extension is set as a draft extension so it is not enabled by default. It can be enabled with the --enable-webgl-draft-extensions flag. BUG=864524 TEST=WebGL conformance tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3153bfa3e5fcb6a9e044c8b0762a8a400b728c7a Reviewed-on: https://chromium-review.googlesource.com/1140299 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578425}
-
James Cook authored
Recently some positive regular expressions were added to the filter. When combined with the existing negative filters this resulted in no tests running. Keep the file a pure blacklist. TBR=estade@chromium.org Bug: 867965 Test: mash_browser_tests on bot Change-Id: I20b0bc01935fef188c3e21f877a8ad2754dc2250 Reviewed-on: https://chromium-review.googlesource.com/1151765 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#578424}
-
Dominic Farolino authored
This CL adds support for the referrerpolicy attribute on <script> elements, remove WPT expectation files for now-passing tests, and add TODOs for setting the referrer and referrer policy members separately in module script fetching code. I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/jfd4knvCiio/qcf5uaspBQAJ R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 841673 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0fca6a11806fe3c4dc994e5610270edd21467034 Reviewed-on: https://chromium-review.googlesource.com/1146065 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578423}
-
kaiwang@chromium.org authored
Write to NULL will trigger a Clang compile warning and the compiler may optimize and turn it into a non-op. int* -> volatile int* to fix this. Original BUG=127724 BUG=724399,b:70905156 Review URL: https://chromiumcodereview.appspot.com/10392109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137251 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 59ba0417) Signed-off-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c55015f7..4a0d5f35 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32d60266c17a1601258d5d9fabdec38d9372d186 Reviewed-on: https://chromium-review.googlesource.com/1151807Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578421}
-
Gabriel Charette authored
Somehow r562248 caused a regression whereby it should have been strictly more performant, the only difference is the potential static initializer (which if incorrectly initialized could result in it being non-zero? and somehow cause the timer to be fast?). Let's try to suppress it. R=fdoray@chromium.org Bug: 848255 Change-Id: I21111ddd4c069b9171badc58fc4a1914bb068641 Reviewed-on: https://chromium-review.googlesource.com/1090794Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578420}
-
Bruce Dawson authored
ChildProcessData was holding a raw ProcessHandle which meant that there was no guarantee that the handle would be valid when it was used. This change switches to a ScopedHandle on Windows, with the associated duplication of the handle, so that it is guaranteed to be valid. This fixes a frequently encountered use of an invalid handle that was detected by Application Verifier. This change also adds a CHECK to base::GetProcId to check for use of invalid handles even when not using Application Verifier. ChildProcessData::handle is now a private member so all references to it were updated to use accessors. When ChildProcessData::SetHandle is called the handle is duplicated. When a ChildProcessData object needs to be copied an explicit Duplicate function is called. An IsHandleValid helper function was added. An invalid test was removed because it was triggering the CHECK in base::GetProcId. Bug: 417532,821453,865805 Change-Id: I7e38140335c0140536919341f011f144f150c88f Reviewed-on: https://chromium-review.googlesource.com/1145767 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578419}
-
kaiwang@chromium.org authored
This is because on some platform (e.g. Windows), the way to implement abort() is different so chrome's crash service can not detect the crash but treat as normal exit. See http://code.google.com/p/chromium/issues/detail?id=118665 for some detail. In this implementation, a segment fault will be triggered and this will be treated as crash on all platforms. Original BUG=127724 BUG=724399,b:70905156 Review URL: https://chromiumcodereview.appspot.com/10384117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137013 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit b6da6b18) Signed-off-by:
-
James Cook authored
It's more IME code than general views code. Bug: none Test: none Change-Id: I572dc2c7be0d428760781f44a6678ea684b5f41c Reviewed-on: https://chromium-review.googlesource.com/1151964Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578417}
-
Justin Novosad authored
BUG=867025 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4d6abf4ecfb611a23214d96cd2bfe410c0529476 Reviewed-on: https://chromium-review.googlesource.com/1149003Reviewed-by:
-
Gabriel Charette authored
This is: s/base::TaskPriority::BACKGROUND/base::TaskPriority::BEST_EFFORT/g git cl format applied to //src. This CL only touches cases explicitly prefixed with base:: to avoid namespace conflicts should there be any. Will handle non-prefixed in a follow-up CL. TBR=robliao@chromium.org Bug: 863341 Change-Id: Idad34a7ecca01644af155ab779eedb3a87544fc0 Reviewed-on: https://chromium-review.googlesource.com/1148546Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578415}
-
Moe Ahmadi authored
The reason for the crash was that BeforeTranslateInfoBarController calls TranslateInfoBarDelegate::ShowNeverTranslateInfobar() in order to show the "never translate infobar which expects the existing translate infobar to be owned by an instance of InfoBarManager. However InfoBarManagerImpl's lifetime is tied to the WebState and it may be destroyed due to navigation. Bug: 867097 Change-Id: Ibf4f6ad15971897a2ac844fa602f961748ec848e Reviewed-on: https://chromium-review.googlesource.com/1151618Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578414}
-
jonross authored
It appears that all failures of telemetry_perf_unittests and telemetry_unittests when running VizDisplayCompositor have either been fixed, or since disabled as the tests where more general failures. This updates the isolated script for running these with Viz to no longer have any skipped tests. This only affect the Linux Viz FYI bot TEST=telemetry_unittests_viz, telemetry_perf_unittests_viz Bug: 799594 Change-Id: I7fafbe3c5ccb7b41fefb08f630c531c26dbba47c Reviewed-on: https://chromium-review.googlesource.com/1151720Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578413}
-
Weidong Guo authored
1. Enlarge folder icon to reveal partially hidden inner items when a dragged item is hovering the icon. To do this, we create two icon: unclipped and clipped icon. unclipped icon is only used inside AppListItemView to show the animation while clipped icon is provided by AppListItemView::GetIconImage(). 2. Enlarge preview circle when a dragged item is hovering non-folder icon. 3. Add mask layer to folder's background view so that it clips the top icons in folder opening and closing animation. Specs: https://screenshot.googleplex.com/ORnHSj8JYd1 Demo: https://drive.google.com/open?id=1pFna0cXFzMJ2Hqliq-T2EFbra2bkRaNw (With animation duration 10X) Bug: 860824 Change-Id: I174629a373bd398de418f8f66f2ad5b902d72c60 Reviewed-on: https://chromium-review.googlesource.com/1138641Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578412}
-
Elly Fong-Jones authored
That is, accelerators should read ",", not "Comma". Bug: 867732 Change-Id: I7dec0af8475b420cbc4e793fecc823378b04f3ad Reviewed-on: https://chromium-review.googlesource.com/1151649Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578411}
-
Sahel Sharify authored
This cl also removes TouchscreenFlingInProgress function that is no longer needed. Bug: 249063 Change-Id: Icc939d654cdfe0cf38c843933f2fd469f843b74c Reviewed-on: https://chromium-review.googlesource.com/1145784Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578410}
-
Sophie Chang authored
Only show Data Saver main menu item if it's already allowed by the current conditions AND the user has saved 100KB. Change-Id: I94363f7810d7529bf6975d9e50e1d5d142807a3e Bug: 867197 Reviewed-on: https://chromium-review.googlesource.com/1149271Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578409}
-
Daniel Cheng authored
This method is never accessible cross-origin, so by definition, it can only be invoked on a local frame. Change-Id: I9fd8c436a8169dcad8e1c1c7bfd213c7696337b1 Reviewed-on: https://chromium-review.googlesource.com/1151064Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578408}
-
Stephen McGruer authored
This test appears to be timeout-flaky on both Linux (dbg) and Mac (dbg). TBR=clamy@chromium.org Bug: 846747 Change-Id: Ic2fb023374915a8c5516127e5172402d8a4af27d Reviewed-on: https://chromium-review.googlesource.com/1151788Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578407}
-
Chris Mumford authored
base::DeleteFile ignores database locks, leveldb_chrome::DeleteDB does not and is safer. Bug: 802298 Change-Id: I6b30fb6826216c9e54a16569a133e1fbddfad98f Reviewed-on: https://chromium-review.googlesource.com/1151543 Commit-Queue: Chris Mumford <cmumford@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#578406}
-
Majid Valipour authored
- Move two tests for AnimationHost/WorkletAnimation interactions to animation_host_unittests - Remove unnecessary complexity related to creating and testing an impl instance. These tests don't need to distinguish between main/impl instances at all. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I928e664ddf4fab8496fbbe3a09fcdcd120c875fb Reviewed-on: https://chromium-review.googlesource.com/1133770Reviewed-by:
-
kristipark authored
Added functionality for adding/removing links and restoring the Most Visited tiles. If the URL is not valid, the link will not be added. The blacklist button now opens the edit dialog (editing links is currently not functional and will be added in a later CL). Also added hover/pressed/focus styling to the input fields and the buttons. Design Doc: go/chrome-ntp-custom-links Video: https://screencast.googleplex.com/cast/NTQyNDU2OTc1ODI1MzA1NnwwMjFkODAwYi1kMg Bug: 851293 Change-Id: Ic92e46ba93a4abcb375467a1d047cbb573f231ba Reviewed-on: https://chromium-review.googlesource.com/1149458 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578404}
-
Scott Haseley authored
This restores several obsolete affected-histogram names that are still were removed by commit c492381b (crrev.com/c/1106384) and are still being recorded. These are still useful in versions where the new metrics don't exist. Change-Id: Iee9a1fd852f19b9cbf7fb0c54ea9999441098ed8 Reviewed-on: https://chromium-review.googlesource.com/1145827Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#578403}
-
Daniel Bratell authored
Switching from Khronos headers to more approprite headers primarily to avoid jumbo compilation problems but also because it was wrong. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9a7c33acfcc72133638c47ae370020331c445ac9 Reviewed-on: https://chromium-review.googlesource.com/1151630Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#578402}
-
Dale Curtis authored
This implements the MediaCodec.Callback API as a layer within MediaCodecBridge so that we may easily support both the async and sync API on older versions of Android. Essentially it registers a callback listener that just stuffs the input and output buffers into queues as if we were using the normal synchronous API. When new inputs or outputs are available a callback is delivered to the bridge so that decoders may pump whatever work they need. For < 60fps content, this is reduction in the total number of timer interrupts used to drive the codec. E.g., with MCVD for 30fps we go from 3720 wakeups over 30s to 2706. For 60fps content we increase from 3926 wakeups with the old path to 4502 wakeups in the new path. There are a couple ways we could reduce the PumpCodec calls further (coalescing, smarter usage during Decode()), but we should see if it matters first. Testing shows this also reduces the total time spent waiting for frames by ~63% as measured by VideoRendererImpl. I.e. for a 1080p60 30s clip, we go from a total of ~17249ms spent waiting for a frame from the decoder to ~10867ms. Bug: 517673 Test: passes bots Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I35fa015dc8b1d6a2f396d7a143279c48d6471dfb Reviewed-on: https://chromium-review.googlesource.com/1132569 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#578401}
-
Joshua Bell authored
The 'secure' and 'sameSite' options were included for delete() calls for symmetry with set(). Although they are used internally as inputs into the cookie deletion process (which is a set with an expiry time in the past) they do not have an observable effect as they are not part of the "key" for cookies in the jar. Remove 'em from the script-facing API, and just pass defaults through. If passed, the options will be ignored, so this will have no affect on code using the API unless the code is trying to specifically probe option parsing. GitHub issue: https://github.com/WICG/cookie-store/issues/77 GitHub PR: https://github.com/WICG/cookie-store/pull/81 Bug: 729800 Change-Id: I847293f5274abcb6335140f7f1bf4e2f6f2f8bcf Reviewed-on: https://chromium-review.googlesource.com/1151723Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#578400}
-
gogerald authored
Bug: 845904 Change-Id: I1ee70df70b808e4611608006a019324c11ec87a9 Reviewed-on: https://chromium-review.googlesource.com/1151554 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578399}
-
Ria Jiang authored
RootConsumesScrollDuringOverscrollGesture, InputEventRouterTouchpadGestureTargetTest and TouchpadPinchOverOOPIF were flaky tests with Viz hit-testing config. However, looking at the log, they only happened infrequently on Android and Windows. I couldn't repro these locally and there have been some changes with how we wait for hit-test data and setting initial window bounds, so tentatively re-enable these three tests to see whether they are still flaky or not. Bug: 853761, 835058, 838835 Change-Id: I66ae6162ab9065e4a940c5779adb92254a6bf54c Reviewed-on: https://chromium-review.googlesource.com/1151899Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5093bc9ede3..897f256413c1 git log b5093bc9ede3..897f256413c1 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 ziadb@google.com SkAR Java: smooth finger painting, planes draw with outlines 2018-07-26 senorblanco@chromium.org GrTessellator: fix for collinear edge merging. Created with: gclient setdep -r src/third_party/skia@897f256413c1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866319 TBR=benjaminwagner@chromium.org Change-Id: I8cd6673f999a9f27ebcb29c5c7e3e6161008f153 Reviewed-on: https://chromium-review.googlesource.com/1151550Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578397}
-
Simeon Anfinrud authored
It's actually more concise to type "x ->" than "() ->", and this simplifies the model to make it more amenable to further refactors. Namely, the goal is to rename "ScopeFactory" to the less arcane "Observer" and "watch()" to the more conventional "subscribe()". Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I2763a987b1a2c424996cb404a9e59e211344372d Reviewed-on: https://chromium-review.googlesource.com/1119067Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578396}
-
Ian Vollick authored
This structure used to have 3 repetitive groups of booleans. With this change each of those similar groupings is a separate struct. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idef02f62650d5a3b73486a206e0f8077992fa2cd Reviewed-on: https://chromium-review.googlesource.com/1151711Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578395}
-
