GitLab

Adds a missing synchronization step to the end of some multiprocess
tests to ensure that client process termination does not race with IPC
events.

Bug: 883624
Change-Id: I91f4dd0d8b28469ff8da60714367d423e1e308fb
Reviewed-on: https://chromium-review.googlesource.com/1225604Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591169}

Bug: 881430
Change-Id: Ib8488e23e388d15c006b66d38e9084cfc93c6c70
Reviewed-on: https://chromium-review.googlesource.com/1222198Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591168}

https://chromium.googlesource.com/angle/angle.git/+log/f4d429c1cbc1..f0d258c32b04


git log f4d429c1cbc1..f0d258c32b04 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 courtneygo@google.com Vulkan: Emulate eglSwapBuffersWithDamage with full swap


Created with:
  gclient setdep -r src/third_party/angle@f0d258c32b04

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ic1a98d06ac7ff8e50427e65b04a9000c9bd05ee6
Reviewed-on: https://chromium-review.googlesource.com/1225315Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591167}

Using wpt-import in Chromium f7011e27.
With Chromium commits locally applied on WPT:
d8d86dd3 "Implement Feature-Policy: lazyload"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24660

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I50755f0dd49a1f8b228427c13eeda7a894b3a7f6
Reviewed-on: https://chromium-review.googlesource.com/1225272
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591166}

This patch has 4 changes:
1) Layer tree json now includes property tree indices.
2) Indentation has been fixed in LayerTreeHost::DoUpdateLayers so it's clear
the logging is for both layer-tree and layer-list codepaths.
3) LayerTreeHost::FinishCommitOnImplThread now dumps property trees and layer
list if --vmodule=layer_tree_host=3 is passed.
4) LayerTreeHostImpl::ActivateSyncTree now dumps property trees and layer
list if --vmodule=layer_tree_host_impl=3 is passed.

If you desire the ultimate logging experience, use: --vmodule=layer_tree_host*=3

Bug: 854200

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5ce6bf235eba1bc6dbcbcedf4781bf742d6004fa
Reviewed-on: https://chromium-review.googlesource.com/1217842Reviewed-by: enne <enne@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591165}

Change-Id: Ie38470885ce654b094eec14ee93bbf90d101c07e
Reviewed-on: https://chromium-review.googlesource.com/1225695
Commit-Queue: Manuel Rego <rego@igalia.com>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591164}

This CL makes it so that WebMediaPlayerMSCompositor can make proper calls
to a VideoFrameSubmitter to use cc::Surfaces for video instead of the
video layer. With this CL, cc::Surface for Video now works end to end
with WebMediaPlayerMS.

Bug: 746182
Change-Id: I90e100ba06dc7570d6ab10d6dc3862681fe80552
Reviewed-on: https://chromium-review.googlesource.com/1090031
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591163}

As of
https://chromium-review.googlesource.com/c/chromium/src/+/1211106

automation will fire focus and blur events at the beginning of an event "bundle".

Focus will always come first from automation_custom_bindings.js, which tracks the currently focused object and whether it has changed.

In ChromeVox, we can now more predictably use this fact to sync ChromeVox range after the panel is closed. In particular, the next focus event will be either fired upon the content being acted upon by a menu command, or as a target of an incremental search or jump command.

In all cases, first clear the focus by setting focus on the root. This is crucial for clearing the initial focus, which may be at the last position the user navigated. This is not necessarily where we want to be (e.g. when syncing to a heading for the next heading command).


Bug: 881495
Test: exercise manually: incremental search, control lists (e.g. headings list), and command list.
Change-Id: I63460f3bf7673299f4fa0310859f22d2f60b535b
Reviewed-on: https://chromium-review.googlesource.com/1222348
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591162}

Makes AshTestHelper supply a test GpuInterfaceProvider. The test version queues
up the requests and never binds them. This way, any code requesting an interface
doesn't get a closed pipe and do something weird.

This also makes TearDown() reset the context factory and context factory
private on Env. This is important as aura::Env is often created in the test
suite and long lived, where as AshTestHelper creates the factories.

BUG=883947
TEST=none

Change-Id: Ie2746e21562235e9ec9142a7a5dc7d856029ba57
Reviewed-on: https://chromium-review.googlesource.com/1225595
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591161}

This changes the logic for when we proxy for web request a bit. Instead
of waiting for the first listener/rule to be set, we listen for an
extension to be loaded that has web request permissions. This allows us
to proxy earlier in startup, and prevents resetting URLLoaderFactories
during the first navigation.

Bug: 879883
Change-Id: I1f68a987b76043d9bf956c1d9c114cd6459574eb
Reviewed-on: https://chromium-review.googlesource.com/1224641Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591160}

Now that all CrOS VDAs are supported by VdaVideoDecoder, this CL allows
--enable-features=MojoVideoDecoder to switch from GpuVideoDecoder to
MojoVideoDecoder on CrOS.

Bug: 522298
Change-Id: Ib4dd7adcd2d451837a35e84b2876079dc3429106
Reviewed-on: https://chromium-review.googlesource.com/1225275Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591159}

All crash reports can be put in two category:
1.  The InputEventAckState can be NON_BLOCKING at
InputRouterImpl::OnTouchEventAck, in this case, we should just set
the allowed touch action to Auto.
2. TouchActionFilter can start filtering gesture event
without an ack for a touch sequence start.

In both cases, we set the allowed touch action to Auto.

Bug: 851644
Change-Id: I630a5d7e8804078c6f39a9102476bb484127ae61
Reviewed-on: https://chromium-review.googlesource.com/1223247Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591158}

Should have enough bots to handle the load (barring any natural
disasters.)

Bug: 646404
Change-Id: I53f49cfa4d7c9c67626578d7ef36b40cb2d82a53
Reviewed-on: https://chromium-review.googlesource.com/1225850Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591157}

Bug: 883462,883045
Change-Id: I486a0924846a3ace08ae4064d99d5a4fb9b1ed03
Reviewed-on: https://chromium-review.googlesource.com/1222700Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591156}

Instead of getting it in DidStartProvisionalLoad and then
using in DidCommitProvisionalLoad, we can just ask
DocumentLoader whether it had a user gesture.

This is a step towards removing DidStartProvisionalLoad.

Bug: 855189
Change-Id: I9e1f47f532e7d2b0e0def7f988dff51569fd0f4b
Reviewed-on: https://chromium-review.googlesource.com/1220671Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591155}

https://aomedia.googlesource.com/aom.git/+log/7d447f5b0021..67645b8f529c

$ git log 7d447f5b0..67645b8f5 --date=short --no-merges --format='%ad %ae %s'
2018-09-12 lupo996 save all registers in avx quantize
2018-09-12 lupo996 shuffle code to work around gcc 8.2.0 issue
2018-09-12 weitinglin Update the target frame size boost for VBR mode
2018-09-12 wtc Do not cast worker->hook function pointers.
2018-07-06 chengchen Bitmask patch 0: Store info for bitmask at decoder
2018-09-12 debargha Fix memset call for selfguided sse4 code
2018-09-11 johann.koenig arm64: zero vectors for gcc 6.3
2018-09-11 weitinglin Disable GF length reduction other then AOM_Q mode
2018-09-12 johann.koenig fix av1_round_shift_rect_array_32_sse4_1 breakage
2018-09-11 deepa.kg AVX2 implementation of 4-tap filter for widths 8, 4
2018-09-11 sanampudi.venkatarao Handle early exit for skip case
2018-09-10 grant.hsu Refine prune_comp_search_by_single_result
2018-09-12 remya.prakasan Optimize highbd 8x16 and 16x8 inv_txfm
2018-09-12 sanampudi.venkatarao Optimize highbd 8x16, 16x8 fwd_txfm
2018-09-10 binpengsmail Move intra modes to the end of inter mode map
2018-09-06 huisu Special handling of IntraBC interpolation
2018-09-07 urvang handle_inter_mode: Reduce stack usage.
2018-09-07 sarahparker Avoid manipulating gf group lengths at end of sequence
2018-09-11 johann.koenig silence c++ abi warning
2018-09-11 debargha Error fix from incorrect aom_clear_system_state()
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com

Bug: 883004
Change-Id: If406b521f7e03e6cd49223b56becc41ef059c605
Reviewed-on: https://chromium-review.googlesource.com/1225273Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#591154}

This CL implements the FlingingControllerAdapter backed by
RemoteMediaClient in RemoteSessionController. The adapter is used to
bridge calls between blink/content layer and the SDK.

Bug: 711860
Change-Id: I0ffda9f67e8f64a42f6e9dae9fabc08e62a6d71e
Reviewed-on: https://chromium-review.googlesource.com/1220675
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591153}

Bug: None
Change-Id: I650d5b1a84ea63565a86c2f0ffa1f3d5ad2de356
Reviewed-on: https://chromium-review.googlesource.com/1225270
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591152}

Test: unittests, manual
Change-Id: Ieff3a4b4955162b01df0179d8423a7b6b206f007
Reviewed-on: https://chromium-review.googlesource.com/1225691
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591151}

Currently ViewHostMsg_RequestSetBounds is sent to both the widget and
the view. Moving this behavior into the OwnerDelegate allows routing
to go only to the RenderWidgetHost.

Bug: 545684
Change-Id: Iac8eeb04b73eefaf99d46343714c3a63d58b9460
Reviewed-on: https://chromium-review.googlesource.com/1220393Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591150}

The default value is already 'false', so there is no need to specify it unless
'true' is desired.

Bug: None
Change-Id: Id1d4b8bdae45b1d98b7f025059dd48927a07556e
Reviewed-on: https://chromium-review.googlesource.com/1225292Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591149}

This is a small patch that adds DCHECK validation checking that
ClipPathClip and ClipPathEffect are mutually exclusive (as stated in
the description of the fields)

R=pdr@chromium.org, trchen@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I98582c3fab476b1cd743c0398f9e9ebf1aec0da7
Reviewed-on: https://chromium-review.googlesource.com/1225107Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591148}

Node uses file paths for some scripts and urls for some modules.
We need to unify them as soon as possible.

R=dgozman@chromium.org

Bug: none
Change-Id: Ia229e1fac8a5cad92edacb9e545b2343f657f651
Reviewed-on: https://chromium-review.googlesource.com/1224799
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591147}

Tbr: msw@chromium.org
No-Try: true
Bug: 883884
Change-Id: I68abbd0b6d22e5a99c1494ad8f50d09bd0d1d738
Reviewed-on: https://chromium-review.googlesource.com/1225810Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591146}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86a4158a03f9..bc66a2cba899


Created with:
  gclient setdep -r src-internal@bc66a2cba899

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id90e0817097a50e85390393b5e606d20d904b0b0
Reviewed-on: https://chromium-review.googlesource.com/1225313Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591145}

Padding the audio with silence was breaking the fade-in logic.

Bug: b/114208977
Test: On device

Change-Id: I7a57837b370eda58feef9a60c6e92a6f3fc70cd0
Reviewed-on: https://chromium-review.googlesource.com/1220710
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591144}

Change-Id: Ia86e5baf72ef6a76f00482e4b2ad7952232c3e58
Reviewed-on: https://chromium-review.googlesource.com/1225293Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591143}

Create a browser-side doppelganger NSWindow in
BridgedNativeWidgetHostImpl. This is because we use gfx::NativeWindow
(aka NSWindow pointer) as an identifier for the NativeWidgetMac all
over in the browser process, and when the "true NSWindow" is in the
app shim process, so we need some identifying structure on the
browser side.

Reshuffle some of the initialization of BridgedNativeWidgetHostImpl
in preparation for creating remote bridges. In particular, defer
creating the bridge object until CreateLocalBridge is called, and
touch up the places (tests, mostly) where the bridge is assumed to
always exist.

Bug: 859152
Change-Id: I85f3de97239763c9c9edb1313796be03c2043d8b
Reviewed-on: https://chromium-review.googlesource.com/1220401Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591142}

If Sync-the-feature is disabled because of a "Reset Sync" action on
the dashboard, then the Sync entry in chrome://settings shows an error
message, and clicking on it should re-enable Sync.
The UI logic checks for this state via SyncService::IsEngineInitialized.
However, if Sync-the-transport is running, then the engine can be
initialized even though Sync-the-feature is still disabled. In this
situation, the user has no way to turn Sync back on.

This CL fixes this by adding a check for DISABLE_REASON_USER_CHOICE
which on desktop corresponds to a dashboard clear. It also adds tests.

Bug: 881934
Change-Id: I6216564ac6fbb9efff988a2ebd09d532c82985cd
Reviewed-on: https://chromium-review.googlesource.com/1224379Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591141}

This CL adds a new LaunchSourceType enum to CustomTabIntentDataProvider
that matches the WebappActivity.ActivityType enum but adds a new value
for apps launched from MediaLauncherActivity. This is used to
distinguish intents from the MLA from other MEDIA_VIEWER sources (e.g.
the Downloads Home UI). This will allow us to add Media-Intent-Handler-
specific metrics.

Bug: 861954
Change-Id: I01b20fec65e6207de3d24d42b9b08787a582adcb
Reviewed-on: https://chromium-review.googlesource.com/1185633Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591140}

This is implemented as an additional template parameter for readability.

We currently store all ngrams as lowercase. By making ngram extraction
automatically extract lower-cased ngrams, callers no longer have to
lower-case their input (usually causing an additional allocation / copy).


Bug: 767605
Change-Id: I466011a5143785520d2007700b01585363736153
Reviewed-on: https://chromium-review.googlesource.com/1223206Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591139}

https://chromium.googlesource.com/catapult.git/+log/5f6da8a57db1..572c25286dc6


git log 5f6da8a57db1..572c25286dc6 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner


Created with:
  gclient setdep -r src/third_party/catapult@572c25286dc6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882291
TBR=sullivan@chromium.org

Change-Id: I21b7895c23abe6fa3f370e025c322640825c5ce4
Reviewed-on: https://chromium-review.googlesource.com/1225310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591138}

https://pdfium.googlesource.com/pdfium.git/+log/5700d9e2eea5..29e180342e18


git log 5700d9e2eea5..29e180342e18 --date=short --no-merges --format='%ad %ae %s'
2018-09-13 tsepez@chromium.org Revert "Introduce FX_Number class as a replacement for FX_atonum()."


Created with:
  gclient setdep -r src/third_party/pdfium@29e180342e18

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic40444e60855238baaf01c218f63ea9e4dd6f2da
Reviewed-on: https://chromium-review.googlesource.com/1225302Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591137}

The current crash report tells mostly browser side info.

Bug: 850954
Change-Id: I2d479e6b7664d38939d498b34a86543521e6fc42
Reviewed-on: https://chromium-review.googlesource.com/1222251Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591136}

We have reports from some sites that data loaded from cache_storage via
a service worker is slower than when loaded from http cache.  One possible
explanation is that the mojo::DataPipes used for reading the BlobDataHandle
from cache_storage are not tuned like the DataPipes used by the network
loading path.  In the network loading path they use 512KB pipes and read in
32KB chunks.

This CL attempts to tune the various DataPipes used to read BlobDataHandle
objects.  It also includes some DataPipes in the service worker code that
are read in a similar way; for loading scripts, ReadableStreams, etc.

This CL uses 512KB pipes and 64KB read chunks as the default as those were
the best values in local testing.  It also adds features to control these
values in a future finch trial.  We can compare different values against
heartbeat metrics and site-specific metrics.

R=kinuko@chromium.org, mek@chromium.org, rkaplow@chromium.org

Bug: 881141
Change-Id: If8d956ad195c6cf85547f1c7172f4a35972513e4
Reviewed-on: https://chromium-review.googlesource.com/1211739Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591135}

A regression from earlier this year affected visual state updates when
they are being propagated to OOPIFs, such that they don't immediately
also propagate to nested OOPIFs underneath a direct child frame. This
was causing temporary mispositioning of things like popup menus.

This CL corrects the flaw.

It also fixes a bug in a test helper class, ShowWidgetMessageFilter,
which incorrectly discards information from messages that were called
before Wait() was called.

Bug: 878703, 873337
Change-Id: I61f42eba4f6b7ab41d96a1db479bceb64ef00954
Reviewed-on: https://chromium-review.googlesource.com/1225090Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591134}

On Android Q, queryIntentActivities(.. , MATCH_ALL) doesn't return
Chrome even if Chrome is installed. Passing MATCH_DEFAULT_ONLY
instead will fix this issue.

Bug: 851725
Change-Id: Id851ec9fcbea47df5a522a23355ad2b67401544f
Reviewed-on: https://chromium-review.googlesource.com/1222675
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591133}

Change-Id: Ic77f1075eda7299e5cce686dd11740081c3436ac
Reviewed-on: https://chromium-review.googlesource.com/1223026
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591132}

Currently, the extension action, media router action and the toolbar action bar,
all call into their delegates to close the overflow menu. Consolidate this code
so that the extension action and media router action use
ToolbarActionBar::CloseOverflowMenuIfOpen.

BUG=None

Change-Id: I4c6933901a3e3e2ba52ad0c4b0cb48efb6cd5172
Reviewed-on: https://chromium-review.googlesource.com/1222685Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591131}

This reverts commit e41ffb6c.

Reason for revert: WebAudio can still do recursive acquisition due to finalizing objects during an allocation in which the lock is held. See crbug.com/882314

Original change's description:
> WTF: CHECK if a mutex is recursively acquired.
> 
> This is a final attempt to flush out any recursive acquisition
> before support is totally removed for WTF::RecursiveMutex.
> 
> For pthreads, this requires maintaining the recursion_count_
> variable even in non-DCHECK builds. This is still quite cheap,
> and is temporary in any case.
> 
> Bug: 856641
> Change-Id: I2b550fd58e8c4cf6293ad7628dd49aa366b41ae9
> Reviewed-on: https://chromium-review.googlesource.com/1212453
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Jeremy Roman <jbroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589504}

TBR=jbroman@chromium.org,yutak@chromium.org,haraken@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 856641,882314
Change-Id: I1e2732ee0c810d5fed73ba29874088abaeed2d59
Reviewed-on: https://chromium-review.googlesource.com/1225297Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591130}