- 17 Dec, 2020 40 commits
-
-
Morten Stenshorne authored
Fixed for LayoutNG here: https://chromium-review.googlesource.com/c/chromium/src/+/2460849 TBR=myid.shin@igalia.com Bug: 576815 Change-Id: Icedf156de44fad5c61e8ce519246221c414b7782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596260Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838026}
-
Tanmoy Mollik authored
This cl creates the event change class that will be used to send primary account change notifications to the observers. This cl also adds unit tests for PrimaryAccountChangeEvent. Design Doc: go/consent-aware-api-dd Bug: 1046746 Change-Id: I7c82dd3ba8c3296ec457fbe94893550f27386a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592999Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#838025}
-
Morten Stenshorne authored
See https://chromium-review.googlesource.com/c/chromium/src/+/2585144 TBR=vmpstr@chromium.org Bug: 1147510 Change-Id: I75056b02fceb810139665ba791f4ab8580eaa05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595305Reviewed-by:
-
Morten Stenshorne authored
CL:2575206 marked it as passing, but it only passes if LayoutNG is enabled. TBR=smcgruer@chromium.org Bug: 997202,1076121 Change-Id: I7bb4adc043daf417655cb22ce024c90138d709b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597338Reviewed-by:
-
Morten Stenshorne authored
See https://chromium-review.googlesource.com/c/chromium/src/+/2585929 But test expectations for disable-layout-ng were not updated (why didn't any script complain about missing files?) TBR=dgrogan@chromium.org Change-Id: If43039915fdceb774e20081d7f936ddfc98126c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595434Reviewed-by:
-
Morten Stenshorne authored
Missing part of CL:2563861 TBR=aleventhal@chromium.org Bug: 427756,1152973 Change-Id: I06af34816899c06b31872082dc9f1f528d89a229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597299Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/448c4502..faaf95ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I47e6f920447d13c154da580854c65441e309f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838020}
-
Elizabeth Popova authored
Prior to this change, on help icon press in Autofill profiles/payments settings the general help article was opened. With this change the "Fill out forms automatically" page is shown instead. Bug: 1157449 Change-Id: If1ac8016713ed58d35f5e777ba07b29cc9eeb847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592796Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#838019}
-
Morten Stenshorne authored
This test has started to fail more than before in disable-layout-ng. New sub-test failures: |NextOnLine| and |PreviousOnLine| on paragraphs with anonymous blocks |NextOnLine| and |PreviousOnLine| on multiline inline elements TBR=aleventhal@chromium.org Bug: 1159730 Change-Id: Ieff6b71265a2407c2834ce831ba23b37f9df4e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595417Reviewed-by:
-
Clemens Arbesser authored
Bug: b/175776310 Change-Id: Ifff4467bb674c61fc2ca5b1cb4bd715585cbe601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595536 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Michele Mancina <micantox@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Michele Mancina <micantox@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#838017}
-
Saurabh Nijhara authored
This CL adds error code for update download canceled due to DeviceAutoUpdateTimeRestrictions policy to the enum so that it can be reflected in the histogram. This error code is already added in update engine code in the following CL - https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 Bug: chromium:1117450 Change-Id: I2c67b1799d9f121fbda8e84491723d41116d5fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593383Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#838016}
-
Benoit Lize authored
The thread cache uses batched allocation from the central allocator. Rather than using the cache hit rate to assess contention on the main lock, the number of batch fill requests is the one to track. This CL records this metric, and reports it in memory dumps and in UMA. Bug: 998048 Change-Id: Ie6a833c7a0ece66d3c138757c8fb3f49a1690c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593630Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838015}
-
Tanmoy Mollik authored
This cl adds two histograms for the AccountPickerBottomSheet Signin.AccountConsistencyPromoAction.Shown.Count - logged every time the bottom sheet is shown to the user. Records number of times bottom sheet was shown previously. Signin.AccountConsistencyPromoAction.SignedIn.Count - logged when the user signs in using the bottom sheet. Records number of times bottom sheet was shown previously. A new shared preference is also introduced to keep track of how many times the bottom sheet is shown. Bug: 1153093 Change-Id: I6a0bcc37dddfc107cbc89516ad5d6161c781faba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574849Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#838014}
-
Benoit Lize authored
PartitionAlloc may use more virtual address space than other allocators, since the normal bucket superpages are never released to the operating system, by design. This is likely causing some issues on Windows 32 bit, where the virtual address space is typically only 2GiB per process. Bug: 998048 Change-Id: I77f1e142b5092121db7ab30aafb74e8daca72088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584027Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#838013}
-
Chris Lu authored
Bug: 1159649 Change-Id: I3405050e9a8e15bb2ee0b3fb1abdd682d6d3f435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596024Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#838012}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib554c3313d1de704d908f845a17bc930ab2e1708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595639Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838011}
-
Colin Blundell authored
This CL moves the API and implementation via which devtools enables forced activation of the subresource filter from //chrome to //components. This move will enable easy reuse of this logic by WebLayer in a followup CL. In this CL there is no behavioral change. The relevant unittests are also ported from //chrome to //components. It was not possible to port a test of the interaction with content settings, as that interaction is //chrome-level. However, that check (that content settings is updated when the component declares to the client that the page is activated) is covered by other tests in //chrome's subresource_filter_unittest.cc. Bug: 1116095 Change-Id: Ia9126e445738d22b4e666515475d5da57dbd6eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587057 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#838010}
-
Rune Lillesveen authored
After we started doing style recalc in flat tree order, disabling fast rejection for ::slotted should not be necessary. Bug: 1159206 Change-Id: I746eefa85aaaa2d53ec80de5c837a55fa0e108e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596296 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#838009}
-
Tanmoy Mollik authored
If MOBILE_IDENTITY_CONSISTENCY is enabled, users are able to sign out from ManageSyncSettings page. But unicorn account (child accounts) should not be able to sign out from there. This cl checks for child accounts before showing the sign out button in ManageSyncSettings page. Also for child accounts sync should always be on. This cl also makes sure that sync is not toggled off when all data types are toggled off in ManageSyncSettings page. Bug: 1159410 Change-Id: Iee7b79af72dc3313ebbccc4ea9850d9e937c625b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595409Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#838008}
-
Wei Lee authored
Originally we thought the window states: {minimized, maximized, fullscreen, regular} are mutually exclusive. However, when under tablet mode, there are only two states: {minimized, maximized/fullscreen/regular}. Therefore, since the assumption is not valid under tablet mode, we should change the logic in CameraAppWindowStateController to make it works under tablet mode as well. Bug: b/172780736 Test: tast run [DUT] camera.CCAUI*.swa Change-Id: I2bcf472e78af3065f9c754024141e2275b7bc710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583670Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#838007}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9eeb00431109..316b70a0e9bb 2020-12-17 sigurds@chromium.org Update protocol 2020-12-17 wolfi@chromium.org Remove "blackbox" - refactor DebuggerPlugin If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic6b0ee2ef70b6f221f93306c8f8e440735240352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595216Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838006}
-
Clemens Arbesser authored
Some trigger sites will not directly navigate to the desired target domain, but will instead use a redirect to eventually arrive at the target domain. This resulted in an early error for trigger scripts. This CL removes the initial domain check. This should be a safe change because we own and trust the trigger sites. The result is that the initial redirect (if any) is ignored. All subsequent navigations are handled as before. Bug: b/175132318 Change-Id: Ie52271eb0bf70b8372d3290c9e6c174f3404a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593102 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ee7c8ce1be5..d89a80298292 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: Id2c4c556ad5ec950685946b0d3e6ec5c695bed59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Rahul Goyal authored
The goal is to add a second implementation further downstream. This CL is a refactoring only and should not have user-facing changes. Bug: b/174445633 Change-Id: I9d0fc65daf53c968557a79dd6db0bdfc7c03bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573138Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Markus Handell authored
Bug: 1157617 Change-Id: Idc38ef3c6fe98a59a839c1fd5b9c4711302be032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593117 Auto-Submit: Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#838002}
-
Matt Menke authored
These tests were setting a NetworkIsolationKey for a simulated received alternative service header, but not on the request that it was intended to affect. Bug: 969893 Change-Id: Id7eaa270e48db4303aca58b0536f7463398cc507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595827Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#838001}
-
Mario Sanchez Prada authored
Since there might be more than one mojo Remote for this mojo interface in the browser process at a given time (e.g. one for the regular media session and another one for a PiP session), it would be good to make sure we don't unnecessarily end up with unbound receivers in the set owned by HTMLMediaElement when only one of those remotes are removed. Thus, this CL adds the extra plumbing required in HeapMojoReceiverSet to allow setting disconnect_handlers on the wrapped mojo::ReceiverSet and uses it to make sure that unbound remotes on the browser process for the media::mojom::MediaPlayer interface result in the associated mojo receiver being removed in the renderer process. Bug: 1039252 Change-Id: I7140345658d1b5c30b5aee437285b55251452390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595047Reviewed-by:
-
Camillo Bruni authored
Pass the base URL for modules as member ModuleScriptCreationParams to JSModuleScript::Create. Bug: 1154943 Change-Id: I7c5fb214a638c4808d5412199ad093797e4cb451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572097 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#837999}
-
Ernest Galbrun authored
Read the bundle path and version from the latest GetScriptsForUrl call, and store it in the service's state. Forward them in the Initial request's ScriptStoreConfig. Change-Id: I80aef768ea893146af42f6671a03379356bdcf67 Bug: b/174227808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582118 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
-
Luciano Pacheco authored
JS modules for: - //ui/file_manager/file_manager/background/js/ - duplicate_finder.js - duplicate_finder_unitetst.js - //u/file_manager/externs/background/duplicate_finder.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. Bug: 1133186 Change-Id: I10240cb6d3083daf4bbc53773c391feb9d66c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596473 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837997}
-
Richard Stotz authored
After https://crrev.com/c/2588910 introduced a NativeIOManager in content/browser, this CL renames Blink's NativeIOManager to NativeIOFileManager to avoid future confusion. No functional changes are introduced. Bug: 1137788 Change-Id: I190ec89ac33864ce347374a33a0d6e57cb21f434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593374Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837996}
-
dpapad authored
Bug: 1132403 Change-Id: Ice9c1a005017378b0e215c19cec44aa8e2868630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595516Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837995}
-
Ryan Keane authored
Change-Id: If0b1a475873d886f36d3ed1a6231f881ec73d30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596112Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Auto-Submit: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#837994}
-
Mohamed Amir Yosef authored
to be aligned with the latest mocks. Basically we will show a static string and the user email. This is reverting most of the code in https://crrev.com/c/2550821 and doing minor modifications Screenshot: https://screenshot.googleplex.com/9zuD5cB5UhSiCDc Bug: 1139263 Change-Id: Ib6adbf8d49e80b07dcb74e98d4fd27b0a97237a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595531Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#837993}
-
Wojciech Dzierżanowski authored
MediaSessionPictureInPictureWindowControllerBrowserTest.PreviousTrackButtonVisibility (and a few similar tests too) didn't test the exact scenario it was meant to test. If it had, it would have _always_ failed when trying to verify the button bounds at the end: the button size is set to 0x0 upon hiding, so bounds comparison of a hidden and visible button should always fail. The reason it didn't fail most of the time is because the button size was, unintentionally, 0x0 throughout the test. The size was kept at 0x0 because never throughout the test was OverlayWindowViews::OnUpdateControlsBounds() called with `show_previous_track_button_` true. The test didn't execute the intended paths because RunUntilIdle() is misleading here. Seeing it used after setMediaSessionActionHandler('previoustrack') and video.play(), we were inclined to think the previous track button was now visible and the layout had been updated. What really happened was we would become idle even though the delayed OnUpdateControlsBounds() task had been posted. As the mouse was hovered over the window the button became visible, but the layout was still pending. And so a plausible explanation for the flaky failures is: when executing under heavy load sometimes the 1-second delayed layout did happen early enough to store the 20x20 size in `previous_track_bounds`. In this CL, we rework the test to wait for the desired events explicitly instead of calling RunUntilIdle(). Other tests checking control visibility are mirated as well. The tests that add/remove buttons with the controls hidden are moved to the unit test because it's hard for a browser test to know when it's the right time to make assertions about layout if all the controls are hidden. Once fixed, the test uncovered two issues with the implementation which were subsequently fixed: - When creating the window, UpdateControlsVisibility(false) was called too early. The operations in OnRootViewReady() would override its effect. - Control visibility must be updated along with their layout. Otherwise, a change in control visibility has no effect on the views::View visibility if it happens while the controls are shown (during hover). With that done, we can enable MediaSessionPictureInPictureWindowControllerBrowserTest.PreviousTrackButtonVisibility again. Bug: 985303 Change-Id: I411cdd2d0a55489ec5b7eb82bab95e05d84d323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587053Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#837992}
-
Luciano Pacheco authored
JS modules for: - //ui/file_manager/file_manager/background/js/ - media_scanner.js - mock_media_scanner.js - media_scanner_unittest.m.js - //u/file_manager/externs/background/media_scanner.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. Bug: 1133186 Change-Id: I55b14aaa58a140e1e754ceaf15c51219df19578a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596281Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608152110-c6b8168a74d771ecb9159dac1f934f7c3a6ae962.profdata to chrome-win64-master-1608163120-d054357d6971f45c660f6ad6c7bb434a3b74b3d5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifcbc8313e43fb0edcf535deb6b85fb46458a6124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597017Reviewed-by:
-
Alice Wang authored
This CL improves Android Studio support for javatests after modularization. Since with the new clank structure, we are going to have javatests and java files in one folder, we can list both of them in one gradle target as well. Bug: 620034 Change-Id: I48f6a376c87cb368ded662f868c1c1767755267e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594770 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837989}
-
Side Yilmaz authored
After enabling Incognito CCT, offline pages starts to use it because of passing EXTRA_OPEN_NEW_INCOGNITO_TAB true for incognito mode. Although this is an intended behavior, Incognito CCT fetches downloaded page from web, instead of fetching it from the disk. This CL disables Incognito CCT use for offline page and makes offline page behavior for incognito same with prior Incognito CCT is introduced. After there will be support for fetching downloaded pages from disk for incognito, this CL will be reverted. Bug: 1148275 Change-Id: I30cdc6486fb1725bec5c4f6bb6edb1c97be78782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588911Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837988}
-
Frédéric Wang authored
Per [1], mmultiscripts can only have one in-flow <mprescripts/> child so this CL fixes IsValidMultiscript() to align with the specification. It also makes similar adjustment for the corresponding fatal checks in NGMathScriptsLayoutAlgorithm::GatherChildren (rather than just checking the index of a previous <mprescripts> is nonzero, which does not work if there is no post-scripts). This fixes an assertion about node not being laid out due to the fact that the mmultiscripts algorithm only performs layout of at most one <mprescript>. [1] https://mathml-refresh.github.io/mathml-core/#prescripts-and-tensor-indices-mmultiscripts Bug: 1158375, 6606 Change-Id: I26964b2ef287585392db7f1854251b4b21075aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593643 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
-
