- 09 Oct, 2019 40 commits
-
-
Emil A Eklund authored
Bug: 1011885 Tbr: cbiesinger@chromium.org Change-Id: Id4186d64cef5eac6e4c0868dbe2a30fe3c129ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846568Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704232}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8e7d9d6c2326..ef4c25e71c32 git log 8e7d9d6c2326..ef4c25e71c32 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 geofflang@chromium.org GL: Skip buffer validation for transform feedback buffers. Created with: gclient setdep -r src/third_party/angle@ef4c25e71c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ia4d7515f2a0d21d53007a83f76c7585588f0ab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704231}
-
Toni Barzic authored
Enabling hotseat exposes some rounding errors when calculating expected app list layout half way during drag between peeking/half to full-screen/closed state. To fix this, calculate the expected search box padding using currently reported app list transition progress (which is already checked that is reasonably close to half state values), and gfx::Tween::IntValueBetween, which is also the method used to determine the padding value for the current progress app list progress. BUG=1011920 Change-Id: I9792442aba0953f880308606d2291a98e6aac9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848155 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#704230}
-
Sean Kau authored
We do not need the PrintJobHistoryService on the lock screen to support extensions. If we create the PrintJobHistoryService on the lock screen, it creates a CupsPrintJobManager which results in multiple notifications for each print job. Bug: chromium:1011532 Change-Id: I16399186031a334d3b98ceda5ec9ab22f23a7e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842557Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#704229}
-
Justin Cohen authored
Workaround for a WKWebView bug where WKNavigations can leak, leaving a permanent pending URL, thus breaking the omnibox. While it is possible for navigations to finish out-of-order, it's an edge case that should be handled gracefully, as last committed will appear in the omnibox instead of the pending URL. Added behind a feature flag as well as histogram to track usage. Bug: 1010765 Change-Id: I6cf2ed4c9ea6302a351f6775ef03d91f093c91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843232Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#704228}
-
Justin Cohen authored
This reverts commit f62ebc4f. Reason for revert: Failing on downstream iPhone bot: https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/4972 Original change's description: > Reland "[iOS][MF] Fix search in all passwords" > > This is a reland of b400d6c7 > > The reason for the revert was that the test failing on the slimnav bot. This > is a legacy bot and runs with the feature off. > > After investigating, it turns out it is a bug in Earl Grey where it is waiting > for a view controller to dismiss. > > Since slim-navigation is not related to the failure, this CL disables the > test when slim-navigation is off, and relands the fix. > > Original change's description: > > [iOS][MF] Fix search in all passwords > > > > If the password view controller was presenting something, it will stay > > around. This is fixed and a test is added. > > > > Bug: 1008421 > > Change-Id: I8248cbbf28be94bc4b84c65ccda42129a192db0b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826895 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702358} > > Bug: 1008421 > Change-Id: If336b1cc5b4d6427125921d01b636b0726b860f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844979 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704143} TBR=olivierrobin@chromium.org,javierrobles@chromium.org Change-Id: I94f7b760783984e19eece46c975b3ab3f1219add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849119Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704227}
-
Rohit Rao authored
BUG=934252 Change-Id: Ib7f68a0c9997ad4638cdb884e5099fcca8402a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849995Reviewed-by:
-
Christian Dullweber authored
Show a confirmation step when cookie blocking was enabled for a specific site. Bug: 967668 Change-Id: I09f2ebf71c196d6a7085a18405da9d59f581a183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849853Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704225}
-
John Delaney authored
Adds a use counter for the heavy ad intervention and adds the use counter to the UKM whitelist. This will be used to look at % page loads affected and also whether certain origins are more affected than others. Bug: 985890 Change-Id: I09f0f6b8fd2703b4801b9958d55fcac165658c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846174 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704224}
-
siyua authored
chip is visible. Uploaded screenshot in bug comment 30 Bug: 932818 Change-Id: I7e69019e18e7a217c3757a787bbb7be3810922ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848579Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#704223}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a529449a. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iffc1b84cfe83514bb4e835ae471d88976094ca9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849951Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704222}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/54548626a977..e27a503a0a21 git log 54548626a977..e27a503a0a21 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 kjlubick@google.com [canvaskit] Clean up embedded fonts Created with: gclient setdep -r src/third_party/skia@e27a503a0a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ic5a740097d501e805895c483772d5a3a93dd95af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848967Reviewed-by:
-
Robbie Gibson authored
According to the spec, the srcset attribute does not need each URL to have an associated descriptor. Just the URL is valid. srcset is also a valid attribute on a <source> tag, so the data should be inlined there as well. Bug: 1006216 Change-Id: I0f782035dfdbf514423cdd430536ed962340c9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829711 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704220}
-
Connie Wan authored
This addresses #7 and #8 in the attached bug. Here we selectively repaint only the necessary underline because otherwise there can be weird interactions where the dragged tabs appear underneath unassociated group underlines. Bug: 1008438 Change-Id: I63038a958249800a2d3df97d8609b8dfe5963410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846045Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704219}
-
Sammie Quon authored
Dimming is already applied in OnPaint so the filter is not needed, requested by UX. Test: manual Bug: 1012042 Change-Id: I2467e4a927c6786f1289e7417bea8bb05716b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846473 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#704218}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLShadowElement> as new downcast helper 2. Use IsA<HTMLShadowElement>(element) in place of IsHTMLShadowElement(element) Bug: 891908 Change-Id: I9b202b810eae9fe10d9b3f0dd84ef9043ab28088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847699Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704217}
-
John Z Wu authored
This fixes an issue where supportedLanguages becomes stale, which causes translate to be offered with a nil CWVTranslationLanguage. Bug: 1012518 Change-Id: Iaed82b4c539443e38ba5198b0c87ae6bab28c7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848652 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#704216}
-
Peter Boström authored
Adds standard highlight-path generators to MoreButton in unified_volume_view.cc as well as RoundedLabelButton and UserAvatarButton. Bug: chromium:1007546 Change-Id: I9f409bf7bd1058c5e4b1d6f41993bb3c42835dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848653 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704215}
-
Tim van der Lippe authored
Bug: 1006759 Change-Id: I2aa0c1df1f4d2ae12c328782d2aa4de63c57161a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845716 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704214}
-
Abhijeet Kandalkar authored
This CL uses DynamicTo<HTMLPortalElement> as new downcast helper Bug: 891908 Change-Id: I42e021335c6167888414d6e190a0974c3f0e13db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847454Reviewed-by:
-
Alexander Nohe authored
Noticed that the stylus tool was not launching android apps due to a permission error with the content provider. Updated the ARC++ container to a more preferred method of launching the Android note taking app. Bug: b/138960936 Change-Id: If9d5e5fbdce610df24bfe94a5c40c160b7f7a347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783221 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704212}
-
Arthur Hemery authored
Some sharding was not properly configured, and shards timed out. Increasing overall sharding to match standard CI bots. Bug: 976218 Change-Id: I8e6c196b5b58e4e5a9a4ed21e6c37d34671158ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849378 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#704211}
-
David Roger authored
Bug: 995720 Change-Id: I40cf6420119e34aa7f2b45460d032a24aee52d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849895Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704210}
-
Raul Tambre authored
This is a reland of 465e6173 gLinux has the html module from python-future, but it's missing unescape(). Switched the import order to import the html module only if importing HTMLParser fails. Original change's description: > tools/metrics/histograms/extract_histograms.py: Python 3 support > > Example error: > Traceback (most recent call last): > File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module> > import extract_histograms > File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module> > import HTMLParser > ModuleNotFoundError: No module named 'HTMLParser' > > Also fixed deprecation warnings: > C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead. > return HTMLParser().unescape(line) > ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead. > self.assertEquals('This is a summary with & and " and \'', > > The changes are backwards compatible. > > Bug: 941669 > Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657 > Auto-Submit: Raul Tambre <raul@tambre.ee> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701265} Bug: 941669 Change-Id: Ib42aa6819103fde6a388765867890589ea4ced82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834001 Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#704209}
-
Justin Cohen authored
Bug: 1011944 Change-Id: Ie05f722e6fd79571d062d0250986002867b503f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849137 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#704208}
-
Etienne Pierre-doray authored
with comments and unittests. Intent-to-ship: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Mkk6ZFChUUA/discussion Bug: 839091 Change-Id: Ie8f81b5403d0d9088796c99224a36a29cfa42a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829916 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#704207}
-
Robert Kaplow authored
A couple notes: I realize that just adding in the middle of StoreRecordingsInReport() is messy, but it is already so messy. I think it might be best to have a seperate CL that thoughtfully splits it all out. Please note http://crbug.com/1010643. Because of this, I expect these numbers to *not* match. But I'm not sure by how much yet. Bug: 1010635 Change-Id: I19fadd9b2e5b331603545a5228523b41a3f964ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834891Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Donn Denman authored
Fixes an interaction issue with Duet by dismissing the panel quicker. Changes the behavior of the peeking panel for the longpress resolve experiment to always dismiss the panel on scroll, just like we do on Tap. Adjusting the selection handles will trigger a new search so the panel will always come back when adjusting (we used to suppress this). Also get rid of the experiment arms for the ContextualSearchLongpressResolve experiment that we know we're not going forward with. There are now just 2 arms: plain and preserveTap. BUG=1011039, 956277, 489461 Change-Id: I0a0c7d43f5d332153ada8bab1d2d3b28f7f49588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848056Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#704205}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/5a1a79c0e8de..1e9229f0fcb4 git log 5a1a79c0e8de..1e9229f0fcb4 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 John.Tytgat@esko.com [cff] Fix FT_FACE_FLAG_GLYPH_NAMES for CFF2 based fonts (#57023). Created with: gclient setdep -r src/third_party/freetype/src@1e9229f0fcb4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I147f9564099e4040c1cc6e0d5d8b46906c51bd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849797Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b5d26b7cffb..d903e9334991 Created with: gclient setdep -r src-internal@d903e9334991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I963d364823210d63da0e01f4b199dc6650986229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704203}
-
Chris Mumford authored
InterceptedRequest::CallOnComplete was resetting the URLLoaderPtr (target_loader_) while the URLLoaderClient bindings (proxied_client_binding_) was still open. Closing the bindings before resetting the loader fixes this ordering issue. This was verified manually. This failure only occurred when two or more WebView's shared the same renderer. The manual test was able to reproduce this failure approx. 50% of the time suggesting a race condition. Attempted to write a regression test in AwContentsClientOnRenderProcessGoneTest, but was unable to reproduce this failure without using the public API (android.webkit.WebView). Bug: 1002212 Change-Id: Id4c1e8e8e283cdbd22a3b718c4fa0419ebfd2fbc TESTING: See note above. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845828Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#704202}
-
Roman Sorokin authored
Bug: 1002100 Change-Id: I64fc0840356c189f9c02be5d89ebb24ddb7817f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845220 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#704201}
-
Tim van der Lippe authored
- Rename Persistence.js to PersistenceImpl to avoid a name clash with the namespace Bug: 1006759 Change-Id: I330bd680c8a92984c4a75a0614efa78b4f1e1ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845715 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f63c64e3..dd575424 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id224d0d6be83c8abc1316ee9badad672747f3e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849753Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704199}
-
Karolina Soltys authored
Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: Id42a643d2f4693518c4a3b018065c2181c2d5f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847302 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#704198}
-
Maksim Ivanov authored
Don't apply the quota (how many times the API can be called by an extension during 1 minute / 10 minutes) to the chrome.certificateProvider.requestPin API when it's called for the first time with the new maximum request ID. This should, in particular, resolve the UX issues in the Chrome OS smart card login feature, where the user may quickly trigger a significant number of PIN requests by clicking on user pods and declining the PIN requests. To simplify the implementation, we're relaxing the quota under the assumption that the requestId are monotonically increasing (which is guaranteed by Chrome) and that the caller extension doesn't call reorder them (which is not guaranteed by an extension, but that's how they are typically expected to work). Nothing bad, however, would happen if these assumptions will be violated in some cases - the quota will only become slightly stricter (as it was before this CL). Bug: 989641 Test: repeat 20 times an attempt to log into Chrome OS via a smart card, check that the PIN request is shown each time, and abort it Change-Id: I189d5e97d51f1f4262869c17e532e0571f74f0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845009Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#704197}
-
Peter E Conn authored
The reproduction steps for this crash are a bit complex - and they rely on a feature I'm implementing at the moment, but basically they involve clicking on an Android notification that calls client.focus and then client.navigate. The client.navigate call triggers the DCHECK at the start of initiator_origin). It looks like it isn't copied over in NavigationControllerImpl: :LoadURLWithParams (checking for a non-empty WebContentsDelegateAndroid: :OpenURLFromTab. Change-Id: Id7319d4cf107d8452d546cfe8e8af6af76628ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849384Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#704196}
-
David Roger authored
Change-Id: Iff5a926e97bbe177c510b44414a47b4c28a94715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849379Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704195}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I99dcfd050ab1784ea1ecf3a171cafa8df94e06a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849632Reviewed-by:
-
Yusuke Sato authored
BUG=b:142141480 TEST=sign in, launch play store, ssh into dut, run 'pkill vm_concierge', launch play store again, verify it launches Change-Id: Id5352795046de2e57d153b64eb75c2487d9a69ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845957 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
