- 10 Dec, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607601127-f1e339917d2389833bdc9a06d67f5d834b6fad5c.profdata to chrome-linux-master-1607622801-752d4072c7d48988cef666b2cc2834c70f6a2f6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ff9e1dbd95b24cf175d8ecbeaeefb5ab82799be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585545Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835802}
-
Chris Lu authored
Remove the now launched default browser fullscreen promo experiment and add a new feature flag for fullscreen promo UI experimenting. Bug: 1155778 Change-Id: Id5177c59cb02f355df5e5e806da33d5d9ee51c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575902 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#835801}
-
Michael Thiessen authored
Bug: 1139437 Change-Id: I71789d696eab9e692c30d963d16382f9105e8a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485307 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835800}
-
David Dorwin authored
When explicit_sites_filter_error_page is present in CreateFrameParams, use SafeSitesNavigationThrottle to filter explicit pages. Bug: 1147231 Change-Id: Ie722d9e409ed480fe1956f0aacc7198d7076d4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531653Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835799}
-
Gavin Williams authored
Creates a function in ScanningHandler to centralize the logic for localizing plural strings. Bug: 1059779 Change-Id: I5cdd80ccf04e16945ae1a273941f846e1f39c75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584292 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#835798}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0443332fe2b9..c566c247eb76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I207b8d1c1db2194ea82d6d621506a42c86369639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585227Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607601127-39be490f57372d47d2538fb844f282b5fe546632.profdata to chrome-mac-master-1607622801-911c34fc75b181768a2abc88929167cca3e2a50d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I339d91626d73a1ce8c26471aeb593018f7af6d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585110Reviewed-by:
-
Yi Gu authored
During the initial implementation of recording |UserCancelled| as an |Outcome|, we didn't use |kUserCancelled| because it could not resolve the promise upon user dismissing the prompt. We used |kCancelled| as a temporary workaround to resolve the promise. This patch removes the workaround because we are now able to resolve promises after crrev.com/c/2569946. Bug: 1138454 Change-Id: Id91180b7624e5f0687b37a0864a1d64e406baf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579988 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835795}
-
Dominic Battre authored
Bug: 1080636 Change-Id: Ifde1a1196d214de0e19fd42a0877d500008b958f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579964Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#835794}
-
Guillaume Jenkins authored
Makes the sign-in promo view mediator aware of the kSigninAllowed pref and makes it skip the sign-in promos in the bookmarks and the settings if sign-in is disabled by policy. Also makes a similar change in the sign-in utils so the sign-in promo after a version upgrade is skipped if sign-in is disabled by policy. Change-Id: Ia84e43f9db317f9454d662ea998758be66ffa801 Bug: 1155745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562778 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#835793}
-
Will Cassella authored
This CL removes the call to `media::InitializeMediaLibrary` in the browser main loop. Initializing the media library in the browser process should not be necessary, and it's done elsewhere for the renderer process. Change-Id: I0b430245019b519fe1614dc9d3e9263b59a3b2a0 Bug: 1003535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577877Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#835792}
-
Lloyd Pique authored
The overlay window should be closed if the host window is closed, or if the controller is destroyed. BUG=crbug:1156540 TEST=Close Test app while overlay is displayed Change-Id: I7d0dadc697535694952bc9be02c88d4c7a28977a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582816 Commit-Queue: Lloyd Pique <lpique@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#835791}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ice40a50cfcf4768f5d08ee3142f2fad0a1b76901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584352Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e28aa0ca9448..b2522b5f9832 2020-12-10 miu@chromium.org LoopingFileSender uses same Environment as SenderSession (and Senders). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I925224f2e5dec0bd1f06e63653a3b2b17b56f73f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584692Reviewed-by:
-
Xianzhu Wang authored
We assume that a) ShouldCheckForPaintInvalidation is set if ShouldCheckGeometryForPaintInvalidation is set, b) ShouldCheckForPaintInvalidation is set if any non-display-locked descendant has ShouldCheckForPaintInvalidation, c) DescendantShouldCheckGeometryForPaintInvalidation is set if any non-display-blocked descendant has ShouldCheckGeometryForPaintInvalidation. Previously, the assumptions were broken in 2 cases: 1. When a LayoutObject having ShouldCheckForPaintInvalidation only was inserted into the child list of a parent, the parent would not set ShouldCheckForPaintInvalidation. Then when the child is set to also need to check geometry, this might set the parent's DescendantShouldCheckGeometryForPaintInvalidation only. If the child had both flags, the parent would not set either of the flags. 2. When a LayoutObject in a display-locked subtree was marked to have both flags, depending on the current flags, the parent might set DescendantShouldCheckGeometryForPaintInvalidation only. To fix 1, now we call parent->SetShouldCheckForPaintInvalidation(). To fix 2, now when we set ShouldCheckGeometryForPaintInvalidation or DescendantShouldCheckGeometryForPaintInvalidation, always set ShouldCheckForPaintInvalidation at the same time. For 2, we could also stop at display locking boundary and mark DisplayLockContext for dirty descendant flags and propagate the flags to ancestors on unlocking, but because setting paint invalidation flags in a locked subtree is rare, I choose the simpler method instead. Bug: 1157226 Change-Id: I261ee6f51e34a610ddf5c837b058cd9f786429b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583158 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#835788}
-
Leonid Baraz authored
Added has_encryption_key to relevant modules. Bug: b:170054326 Change-Id: Ic1a0b8cc548e5c29015a4fd604bcc3138092d867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581006 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#835787}
-
Stefan Zager authored
This fixes an bug with the recently-added feature to allow an observer's explicit root to be a document. In such cases, if a target element is not in the root document, it should be reported as "not intersecting". Change-Id: Iea6bc2444fc5b2bf2dca50cf242d46324a502dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583217 Commit-Queue: Stefan Zager <szager@chromium.org> Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835786}
-
Ian Kilpatrick authored
It was possible to have some zero sized shelves in the NGExclusionSpace. This typically didn't cause any issues, but it was possible for zero sized elements, and things with shape exclusions to be placed in invalid places due to this. The updated unittest actually shows an invalid layout opportunity. The updated png-test was also something which appears we got wrong when we rolled out LayoutNG initially. (we are now changing it "back" to the original ref). Bug: 1156154 Change-Id: Ia275255683764376d4d9e343bacb063d628fbaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581885 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#835785}
-
Michael Thiessen authored
This test is probably still flaky, but I can't repro and there isn't enough data on the flakiness dashboard to figure out what configurations this test is flaky on. If this test is still highly flaky I'll revert this change. Bug: 1153686 Change-Id: Icf2d73c4e9901a4a590dd03a668cb72cb609971f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584648Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835784}
-
Ben Pastene authored
Machines are allocated in crrev.com/i/3459783 This'll be the last builder in the 8-core xenial builderless to be migrated. chromium_presubmit will remain since it's not as affected by cache age, and it will also provide signal to how the pool is doing since it'll be the only alertable builder that remains. Bug: 1140727 Change-Id: I5b78d52e67e48f4dc0dc6c7edc20b6f2faa559b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585385Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#835783}
-
Nico Weber authored
...and a few more, final simplifying touches. No behavior change. Bug: 1147069 Change-Id: I0b3d1ffbf7f8ea89facd1fc6bb4776c7a4deade5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584609 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835782}
-
Majid Valipour authored
This patch introduces the basic API for IDP to provide an id_token. The id_token is passed to the pending id request callback. The callback is simply held as part of UserData for the provider's web contents. This works because we create a new web content for each request. To enable this without introducing new content/public changes we moved the creation of the idp web contents to occur inside FederatedAuthRequestImpl which also adds the callback and then passes it to the ui dialog controller. Bug: 1141125 Change-Id: Ic5d48642c952ac510ce8aa8cfaf53962a916f9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576432Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#835781}
-
Garrett Beaty authored
This is being modified so that the builder function can be modified to accept multiple console view entries. Change-Id: Ifb42b098cdd0a6d07a42ded71d88fee1a485a836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585049 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#835780}
-
Joel Fernandes authored
Core-scheduling tests have completed and is stable/performant. Make it default enabled. Finch experiment will be set to launch process. Bug: b:152605392 Signed-off-by:
Joel Fernandes <joelaf@google.com> Change-Id: I902e282b23cb95b2f78bf52042fdc5f76aa959c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584608Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835779}
-
David Tseng authored
One test was disabled prior to the migration to changes in SpeechMonitor. Both tests pass locally under heavy load. Let's see if they still flake. R=akihiroota@chromium.org Bug: 1114854, 950049 Change-Id: I6ab79c828e0bcdf3c6e3ae5034b2c3db54d4d68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584684 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#835778}
-
Torne (Richard Coles) authored
Throw IllegalArgumentException if we are passed invalid header names or values via loadUrl() or setUserAgentString(), as this violates a network stack invariant. Remove the metrics collection code (since throwing the exception will generate a crash anyway if the app doesn't handle it), but update the expiry on the existing metric to keep collecting it on older versions until this change goes to stable, for outreach purposes. Bug: 1106002 Fixed: 1153855, 1153856 Change-Id: I84dc2a45ed42e004f1154fe4053d60ea9d0f0167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579913 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835777}
-
Nick Burris authored
* Create LegacyExternalAuthUtils and related classes, which are empty subclasses of the ExternalAuthUtils classes. These will be referenced downstream temporarily while ExternalAuthUtils is moved to //components. * Create empty new target //components/externalauth/android:java so we can add the downstream dependency before the migration. This is patch 2/6 for refactoring ExternalAuthUtils into //components. Bug: 1144858 Change-Id: I928ee2998f7042c85e64d8e91e275d23b789fc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568689 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835776}
-
Yulun Wu authored
Bug: 1155762 Change-Id: I964f4a01300fc2c173b6e1244c0f64da773f2d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582633Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835775}
-
rajendrant authored
This CL changes how resource URL check for robots rules is returned. If results are immediately available they are returned, otherwise nullopt is returned and callback is invoked with the result when available. This CL also introduces an enum to differentiate whether resource was disallowed by robots rules due to rule fetch already timedout or due to new timeout. Bug: 1144836 Change-Id: I55fa7c57b749dd53907c9deb3e045beafd74463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583846 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#835774}
-
Greg Kerr authored
This is a reland of d24c918a Original change's description: > CrOS: Enable Hyper-Threading by default if core scheduler is available. > > If the kernel supports core scheduling, Hyper-Threading is enabled by > default. Users, admins and Finch may still override this setting. > > BUG=b:152605392 > > Change-Id: Iffcec33455ec277ec6f79f03908d02015c7d1f6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209676 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Auto-Submit: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774920} Bug: b:152605392 Change-Id: I50590824454aa5d33267d0c6783b002c1925fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584566Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012100600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/yEb6ecEc9J9wemIY47NfFUY-LveAjJpCX06ML5tGgJYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/168265723,b/168422458,b/171154801,b/172376551,b/174442020,b/174603791 Tbr: media-app@grotations.appspotmail.com Change-Id: I4385c4c6edac367ee3af82f0017d6725af0dec0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584343Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835772}
-
Monica Basta authored
This CL adds a tooltip with the label of the avatar. The tooltip is shown on hover and keyboard focus. Change-Id: I4a64be6f4646353ae65dd941df2dc7ea347357ba Bug: 1157391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581481 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835771}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59df85b5457e..9f89587dc4fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie3e89e19d11eec2dff31256febe98161ce2b611e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585125Reviewed-by:
-
Eugene But authored
All these metrics are useful monitoring metrics. Bug: 1156197, 1156198, 1156199, 1156200 Change-Id: I09f024f1e0777b7c31ace21dca5ea6227016999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576944 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#835769}
-
Yashar Dabiran authored
ChromeActivity is used to provide WindowAndroid, BrowserControlsManager and the activity creation time. These dependencies are instead given through direct constructor injection. Bug: 1155786 Change-Id: Ibcdaaf9be26142f7ce3a5d4f0b3ba0667b966627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575858Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#835768}
-
Jan Wilken Dörrie authored
This change adds post increment operations to WTF::Deque's iterators. Without these operations the iterators fail to fulfill the requirements for bidirectional iterators [1] they claim to implement, making them potentially unusable in generic algorithms. [1] https://en.cppreference.com/w/cpp/named_req/BidirectionalIterator Bug: None Change-Id: I72e3371333fe8adcc609c9b05c13693c9e512f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584026Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835767}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d94a77b304f4..35f077086ef3 2020-12-10 sugoi@google.com Context refactor: from OpenGL-like state to Vulkan-like state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I66b984eb939d5639d76e4b250756813a29caef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584353Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I5d3cc0260d9b4611a54f94e5cd7a94f62b7bbbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584690Reviewed-by:
-
Adam Langley authored
In order to have a smooth A/B test, this change duplicates the existing spinner screen used by Play Services for caBLEv1 so that it appears for server-linked caBLEv2. BUG=1002262 Change-Id: I36b4c9fc30693cb94bfd4b82a7dc78921384e59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580839Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#835764}
-
Yue Zhang authored
AllPasswordsBottomSheetViewTest# testCredentialsChangedByModel is failing on "Lollipop Phone Tester". TBR: fhorschig@chromium.org Bug: 1157497 Change-Id: Ic36507ed53a68a13fe06d441ab4eda712c21b689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585445Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835763}
-
