GitLab

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/301353002

git-svn-id: svn://svn.chromium.org/blink/trunk@175097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add unittests for WebCore::WebSocket class.

BUG=NONE

Review URL: https://codereview.chromium.org/298893008

git-svn-id: svn://svn.chromium.org/blink/trunk@175096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=379032

Review URL: https://codereview.chromium.org/301243004

git-svn-id: svn://svn.chromium.org/blink/trunk@175095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=100004, 105447

Review URL: https://codereview.chromium.org/249133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow up CL to https://codereview.chromium.org/305783004/

BUG=357163
NOTRY=true

Review URL: https://codereview.chromium.org/308793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes two issues:
- Add clang support for InstanceCounter type resolver
- Add a mutex when writing to objectgraph map.
-- Oilpan GC marking phase is only run on single thread, however, weak processing are not.
-- Heap wtf collection implementations may mark their back store on weak processing phase.

BUG=378157
NOTRY=true

Review URL: https://codereview.chromium.org/304033004

git-svn-id: svn://svn.chromium.org/blink/trunk@175092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

if the browser is in OOM situation and PartitionAllocReturnNull is set,
it returns null instead of OOM crash.

BUG=374087

Review URL: https://codereview.chromium.org/295803005

git-svn-id: svn://svn.chromium.org/blink/trunk@175091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

GraphicsLayer.

In particular, do so for squashing layers. This allows us
to track repaints for squashed layers where the layer itself
does not change but the layer moves with respect to the
layer it squashes into.

BUG=370664

Review URL: https://codereview.chromium.org/301843002

git-svn-id: svn://svn.chromium.org/blink/trunk@175090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In a previous CL we disabled main frame impl-side scrolling if there is a
fullscreen element because the fullscreen element can balloon up scroll events
to the (invisible) main frame layer and cause weird artifacts.

However if the element that enter fullscreen is the main frame document itself,
we should allow it remain scrollable.

BUG=376699

Review URL: https://codereview.chromium.org/305833002

git-svn-id: svn://svn.chromium.org/blink/trunk@175089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In oilpan builds, |m_syncBaseDependents| and |m_syncBase| are changed to weak references from manual detach in d-tors.

|m_syncBase| is changed from Element* -> SVGSMILElement* as its only valid value is SVGSMILElement*.

BUG=357163

Review URL: https://codereview.chromium.org/305783004

git-svn-id: svn://svn.chromium.org/blink/trunk@175088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This does not fix the clusterfuzz testcase in the bug, but I found it while
investigating that bug. See also the comment at the top of doUpdateElement.

I was unable to write a crashing testcase for this...

R=eseidel,esprehn
BUG=376748

Review URL: https://codereview.chromium.org/296343002

git-svn-id: svn://svn.chromium.org/blink/trunk@175087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method is only called from destructors or document teardown. We
apparenly also skip it when in Oilpan mode. That would seem to indicate
that by the time we get here there should be no subframes left connected.

Lets change the loop into an ASSERT to verify that.

Review URL: https://codereview.chromium.org/303653005

git-svn-id: svn://svn.chromium.org/blink/trunk@175086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should omit closest-side value, wherever is possible. Specification:
​http://www.w3.org/TR/2014/CR-css-shapes-1-20140320/#basic-shape-computed-values
This change aligns the behavior to the specification.
Added new test cases for the shape-outside parsing tests.

This is a merge of http://trac.webkit.org/changeset/169406 by Zoltan Horvath <zoltan@webkit.org>.

BUG=371934

Review URL: https://codereview.chromium.org/300843011

git-svn-id: svn://svn.chromium.org/blink/trunk@175085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is stubbing Blink security features that operate on
frames across origins, so that they can deal with RemoteFrames
being in the FrameTree. They will not yet work with cross-process
frames because there is not enough information in most cases, but
this allows us to put the frame infrastructure in place before
we implement cross-process information sharing to correct the
relevant behavior.

BUG=346764
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/303793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/307973002

git-svn-id: svn://svn.chromium.org/blink/trunk@175083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the protocol.

BUG=376194

Review URL: https://codereview.chromium.org/303113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Part of the larger task of creating an unprefixed Pointer Lock API.
Intent to Implement and Ship approved April 21 2014
http://goo.gl/uQTJjH.

BUG=359738

Review URL: https://codereview.chromium.org/281383010

git-svn-id: svn://svn.chromium.org/blink/trunk@175081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The srcset parser spec (http://picture.responsiveimages.org/#parse-srcset-attr )
have recently changed to have better future compatibility.
It will enable us to add future descriptors of the form "descriptor(value, anotherValue)".
It will also ease the envisioned addition of the 'h' descriptor.

BUG=376726

Review URL: https://codereview.chromium.org/293423002

git-svn-id: svn://svn.chromium.org/blink/trunk@175080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the editing commands and style objects to the Oilpan heap, along
with having them use transition types throughout.

R=zerny@chromium.org,haraken@chromium.org,tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/299353004

git-svn-id: svn://svn.chromium.org/blink/trunk@175079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some tests in style-with-shadow-pseudo-element.html and
style-with-deep-combinator.html did check if a style rule
in a shadow tree can be applied to its sibling shadow tree(s),
which is against the current spec.

I will add some test *against* such case, that a style rule
doesn't apply to its sibling shadow tree, along with the fix for
bug 355674 later.

BUG=355674
TEST=pass layout tests.

Review URL: https://codereview.chromium.org/304123002

git-svn-id: svn://svn.chromium.org/blink/trunk@175078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We shouldn't call ensureUserAgentShadowRoot() from inside an element's
constructor since not all constructors in the inheritance chain may
have run, and also since it means going into DOM methods that may want
to ref |this| before it's ever been adopted.

This patch fixes this and also fixes the RefPtr protects inside
notifyNodeInserted.

Review URL: https://codereview.chromium.org/304003002

git-svn-id: svn://svn.chromium.org/blink/trunk@175077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r174546 a v8::TryCatch object is in scope when calling a method's
C++ implementation early due to missing optional arguments.  If the
implementation throws an exception, we need to call ReThrow() on that
v8::TryCatch object for the exception to be propagated correctly.

BUG=362388

Review URL: https://codereview.chromium.org/307883002

git-svn-id: svn://svn.chromium.org/blink/trunk@175076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/308743003

git-svn-id: svn://svn.chromium.org/blink/trunk@175072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/303223003

git-svn-id: svn://svn.chromium.org/blink/trunk@175068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/304323003

git-svn-id: svn://svn.chromium.org/blink/trunk@175065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175044

TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/303213002

git-svn-id: svn://svn.chromium.org/blink/trunk@175063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Due to the upcoming split of the "sdk" module, certain types will not be able to access
ConsoleModel. As such, a specific message logging API should be exposed to all modules
to use in place of direct WebInspector.console.log/showErrorMessage calls.

R=sergeyv@chromium.org, yurys@chromium.org, pfeldman, sergeyv

Review URL: https://codereview.chromium.org/298333003

git-svn-id: svn://svn.chromium.org/blink/trunk@175061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DevTools frontend now runs an app: screencast app, simple undocked app or advanced app with docking support.
There will be a toolbox app soon (the always-docked part of DevTools).

This patch mostly moves the code into the new WebInspector.App hierarchy.

BUG=none
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/307623003

git-svn-id: svn://svn.chromium.org/blink/trunk@175060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The regression was caused by r174810. The root cause is the
implementation of WebInspector.StaticViewportElement which doesn't
support lazy DOM element creation. So every time the viewport processed
cumulative heights of inner elements, it actually forced all DOM elements
for viewport to be created.

To keep things simple, the patch moves fastHeight calls out of
ViewportElement interface into ViewportProvider.

BUG=377749
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/305813005

git-svn-id: svn://svn.chromium.org/blink/trunk@175059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DatabaseManager::manager should return a singleton of DatabaseManager. However
it had no mutex. It was possible to create two DatabaseManager.

BUG=378250
NOTRY=true

Review URL: https://codereview.chromium.org/308593004

git-svn-id: svn://svn.chromium.org/blink/trunk@175057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman

Review URL: https://codereview.chromium.org/308633003

git-svn-id: svn://svn.chromium.org/blink/trunk@175056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/306803004

git-svn-id: svn://svn.chromium.org/blink/trunk@175055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test callback was called from within the ProfilesPanel.showProfile()
and put the panel in a non-expected state.

BUG=378389
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/306693003

git-svn-id: svn://svn.chromium.org/blink/trunk@175054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/304073003

git-svn-id: svn://svn.chromium.org/blink/trunk@175053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/304913002

git-svn-id: svn://svn.chromium.org/blink/trunk@175052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/302943002

git-svn-id: svn://svn.chromium.org/blink/trunk@175051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/304113004

git-svn-id: svn://svn.chromium.org/blink/trunk@175050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/304803005

git-svn-id: svn://svn.chromium.org/blink/trunk@175049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/301663002

git-svn-id: svn://svn.chromium.org/blink/trunk@175048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes InsertTextCommand::insertTab before HTML element because
we can't set Text node as document element.

BUG=348209
TEST=LayoutTests/editing/execCommand/insert-tab-to-html-element-crash.html

Review URL: https://codereview.chromium.org/306583005

git-svn-id: svn://svn.chromium.org/blink/trunk@175047 bbb929c8-8fbe-4397-9dbb-9b2b20218538