GitLab

The bug is that after searching for a string that is not on the page, if
you then navigate to a page that DOES contain that string, find-in-page
will still find no matches.

What is actually happening in the search after navigation is that even
though TextFinder::find() is returning true (to indicate that a match is
found), the field |m_lastFindRequestCompletedWithNoMatches| is still
false (from the last page, which had no matches). This prevents any
matches from being highlighted during the subsequent scoping effort.

The simple (and correct) fix is to set
|m_lastFindRequestCompletedWithNoMatches| to false if a match is found
in TextFinder::find() (since the find request no longer has no matches).

BUG=644448

Review-Url: https://codereview.chromium.org/2316203002
Cr-Commit-Position: refs/heads/master@{#417095}

BUG=628057
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2300243004
Cr-Commit-Position: refs/heads/master@{#417094}

Textfields:
- handle disabled state for text, border

Comboboxes:
- update enabled text color (matches textfield)
- handle disabled state for text, arrow, border (matches textfield)
- draw a solid background so that subpixel aa works

BUG=644709,635164,635160

Review-Url: https://codereview.chromium.org/2319193002
Cr-Commit-Position: refs/heads/master@{#417093}

This patch asserts that the document url passed into the scanner is valid.
This fixes a fuzzer issue where the fuzzer was passing in an empty (invalid)
url.

BUG=644667

Review-Url: https://codereview.chromium.org/2318283002
Cr-Commit-Position: refs/heads/master@{#417092}

There are existing DomKey and keyCode values for ContextMenu, we
should support them on all platforms.
(Even though ContextMenu key is not natively supported on mac OS,
it could have other usage such as remote apps.)

DomCode is already mapped to corresponding value.

After CL we will match FireFox.

BUG=168845

Review-Url: https://codereview.chromium.org/2309253006
Cr-Commit-Position: refs/heads/master@{#417091}

https://pdfium.googlesource.com/pdfium.git/+log/1df1efa39218..f56d93f8ea1c

$ git log 1df1efa39..f56d93f8e --date=short --no-merges --format='%ad %ae %s'
2016-09-07 dsinclair Verify image dimentions before using
2016-09-07 dsinclair Verify pattern start values.

BUG=639160,637984

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2320823002
Cr-Commit-Position: refs/heads/master@{#417090}

In order to allow on-demand crash report uploads for Android
users, first show not uploaded or skipped crash reports.

BUG=641628

Review-Url: https://codereview.chromium.org/2301943003
Cr-Commit-Position: refs/heads/master@{#417089}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6d6af9a..71740ff

$ git log 6d6af9a..71740ff --date=short --no-merges --format=%ad %ae %s
2016-09-07 deadbeef@webrtc.org Fixing stack buffer overflow (read) in SctpDataEngine.
2016-09-07 aleloi@webrtc.org Simplifications of the mixing algorithm.
2016-09-07 solenberg@webrtc.org Moving/renaming webrtc/common.h.
2016-09-07 ehmaldonado@webrtc.org GN: Move variables from //build_overrides/webrtc.gni to //webrtc/build/webrtc.gni
2016-09-07 perkj@webrtc.org Change OverUseFrameDetector to use a task queue instead of ProcessThread to periodically check for overuse. It is made to only operate on a single task queue.
2016-09-07 aleloi@webrtc.org Several lock acquisitions and one of the two lock members are removed. ENSURE_LOCKS_REQUIRED and CalledOnValidThread annotations are added.
2016-09-07 danilchap@webrtc.org Implement PlayoutDelay extension as a trait to be used with rtp::Packet class
2016-09-07 danilchap@webrtc.org Relax expectation in EndToEndTest.CallReportsRttForSender test to reduce flakiness by ignoring potentional rounding errors and minor ntp time adjustments.
2016-09-07 henrik.lundin@webrtc.org Setting up an RTP input fuzzer for NetEq
2016-09-07 danilchap@webrtc.org Merge min_ms and max_ms accessors in PlayoutDelayOracle to reduce CriticalSection enterencies and avoid potentional synchronisation issues.
2016-09-07 stefan@webrtc.org Only parse PPS up to PPS and SPS ids in the depacketizater.
2016-09-07 kjellander@webrtc.org Disable -Wsentinel warning for Linux 32-bit builds.
2016-09-07 stefan@webrtc.org Add time line for acked bitrate.
2016-09-06 skvlad@webrtc.org Fixed flaky StunRequestTests which depended on the wall clock
2016-09-06 skvlad@webrtc.org Increase timeout for flaky tests for ProcessThreadImpl
2016-09-06 glaznev@google.com Add dynamic bitrate tracker and adjustment for Exynos VP8 HW encoder.
2016-09-06 aluebs@webrtc.org Fix chromium-style errors in IntelligibilityEnhancer
2016-09-06 nisse@webrtc.org Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2315703002/ )
2016-09-06 aleloi@webrtc.org Improvements to UI to python event log analyzer tool.
2016-09-06 kwiberg@webrtc.org iSAC float: Handle errors in upper band decoding
2016-09-06 nisse@webrtc.org Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #2 id:150001 of https://codereview.webrtc.org/2310043002/ )
2016-09-06 nisse@webrtc.org Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2306953002/ )
2016-09-06 danilchap@webrtc.org Remove dedicated unittest file for remb format RembStatus moved to RtcpSender unittest where it fits better Creating remb in Compound/ReducedSize modes already covered by RtcpSender unittests. Parsing remb already covered by RtcpReceiverTest.ReceivesRemb
2016-09-06 kjellander@webrtc.org MB: Cleanup no-longer-used GN configurations
2016-09-06 ehmaldonado@webrtc.org GN: Set WEBRTC_RESTRICT_LOGGING as is set in GYP.
2016-09-06 sakal@webrtc.org Remove stop method from VideoTrackSourceInterface.
2016-09-06 hbos@webrtc.org Significantly increased max_num_buffers_ of Vp9FrameBufferPool.
2016-09-06 henrik.lundin@webrtc.org neteq_rtpplay: Add an error message for unmatched SSRC
2016-09-06 kjellander@webrtc.org MB: Add Linux 32-bit Debug and Release trybots
2016-09-06 kthelgason@webrtc.org Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ )
2016-09-06 kthelgason@webrtc.org Remove all reference to carbon api
2016-09-05 zijiehe@chromium.org [WebRTC] Two DirectX capturers cannot work concurrently
2016-09-05 zijiehe@chromium.org An early analysis shows in DirectX based capturer, Windows API returns larger dirty region than the real screen change. A similar behavior may happen on other platforms with damage notification support. So it's better to have an individual layer to handle the Differ logic, and remove capturing independent logic out of each ScreenCapturer* implementation.
2016-09-05 ehmaldonado@webrtc.org GN: Apply optimize_max only on windows
2016-09-05 danilchap@webrtc.org RtcpReceiverTest rewritten using public available interface IncomingPacket(const uint8_t*, size_t) is used as entry point instead of IncomingRTCPPacket(PacketInformation* out, RtcpParser* in); Result is validated by checking which callbacks were called instead of checking intermediate structure PacketInformaion.
2016-09-05 kwiberg@webrtc.org rtc::Buffer: Let SetData and AppendData accept anything with .data() and .size()
2016-09-05 danilchap@webrtc.org Use RtpPacketToSend in RtpSenderAudio. this eliminates reparsing of rtp packet on send audio path
2016-09-05 asapersson@webrtc.org Revert of [WebRTC] A real ScreenCapturer test (patchset #8 id:240001 of https://codereview.webrtc.org/2268093002/ )
2016-09-05 ehmaldonado@webrtc.org MB: Add WebRTC FYI bots to mb_config.pyl.
2016-09-05 ehmaldonado@webrtc.org GN Templates: Move common_inherited_config to the template.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2316333002
Cr-Commit-Position: refs/heads/master@{#417088}

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

Also, we believe that always doing work asynchronously is cleaner
than doing it synchronously part of the time.

BUG=622400

Review-Url: https://codereview.chromium.org/2320703002
Cr-Commit-Position: refs/heads/master@{#417087}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1931d2d4322f..576345e444a3

$ git log 1931d2d43..576345e44 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 lpy Add V8 slices for quick selection in related events table.

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2321753002
Cr-Commit-Position: refs/heads/master@{#417086}

We currently have a mixture of using typedefs and type aliases for forward
referencing StaticElementList and StaticNodeElement. Stick to type aliases
since they are more modern and a C++11 allowed feature in Chromium.

Review-Url: https://codereview.chromium.org/2317083003
Cr-Commit-Position: refs/heads/master@{#417085}

SequencedWorkerPool is being migrated to base/task_scheduler and there
is no equivalent to IsRunningSequenceOnCurrentThread() in
base/task_scheduler.

Developers should use SequenceChecker to verify that tasks run
sequentially. Unlike
SequencedWorkerPool::IsRunningSequenceOnCurrentThread(),
SequenceChecker works everywhere in Chrome (MessageLoop,
SequencedWorkerPool, base/task_scheduler...).

BUG=622400

Review-Url: https://codereview.chromium.org/2318133002
Cr-Commit-Position: refs/heads/master@{#417084}

R=kbr@chromium.org
BUG=638744
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2306033003
Cr-Commit-Position: refs/heads/master@{#417083}

Revert of Disable some DumpAccessibilityTreeTest.Accessibility test on Windows (patchset #1 id:1 of https://codereview.chromium.org/2309273002/ )

Reason for revert:
Re-enabling these tests because the change that caused the try flakes was reverted here:

https://codereview.chromium.org/2302353005

Original issue's description:
> Disable some DumpAccessibilityTreeTest.Accessibility test on Windows
>
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> TBR=dmazzoni@chromium.org
> BUG=chromium:643954
>
> Committed: https://crrev.com/b7a4685cc72298483cde031c401007f78538d429
> Cr-Commit-Position: refs/heads/master@{#416527}

TBR=magjed@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:643954

Review-Url: https://codereview.chromium.org/2320673003
Cr-Commit-Position: refs/heads/master@{#417082}

This will be used to precompute macs for use in a callback without
going through a transaction.

BUG=624858

Review-Url: https://codereview.chromium.org/2304573002
Cr-Commit-Position: refs/heads/master@{#417081}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/239067c0b2b9d9f905d8a0925cd13439edead8ae [Android] Set up continuous builder + trybot for cronet. (jbudorick@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=634350

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2318123003
Cr-Commit-Position: refs/heads/master@{#417080}

Use Material Design color Light Blue 100 for a Blimp tab.
See https://material.google.com/style/color.html for details.

BUG=64425

Review-Url: https://codereview.chromium.org/2315953002
Cr-Commit-Position: refs/heads/master@{#417079}

TBR=pdr

Review-Url: https://codereview.chromium.org/2320793002
Cr-Commit-Position: refs/heads/master@{#417078}

BUG=641814

Review-Url: https://codereview.chromium.org/2310223002
Cr-Commit-Position: refs/heads/master@{#417077}

This CL makes it safe to handle Arc events for shelf in case secondary
user is active. It also restores active status when primary user is
activated again.

BUG=b/31316824
BUG=b/31313336
BUG=644053
TEST=Manually on device. When secondary user is active, stop one of
     the Android task. There is no more crash in this case. Switch
     back to primary account and active status is correctly restored
     for the latest Arc app.

Review-Url: https://codereview.chromium.org/2315903002
Cr-Commit-Position: refs/heads/master@{#417076}

BUG=none
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2313253003
Cr-Commit-Position: refs/heads/master@{#417075}

We're not actively using them and they make code hard to read and
change.

R=sunnyps@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2314323003
Cr-Commit-Position: refs/heads/master@{#417074}

When profiling some sites that are slow to build an accessibility tree,
a lot of time was spent retrieving the document, root accessibility object,
or focused accessibility object. Introduce the concept of freezing
BlinkAXTreeSource, which precomputes these once, and then allows them to
be reused through the rest of a function scope.

This is safe because the accessibility tree does not change during processing
of an accessibility event.

For one cs.chromium.org page, this sped up initial load by 50% (1000 ms
to 650 ms) and single-node updates by 400% (90 ms to 23 ms).

BUG=631923,638474

Review-Url: https://codereview.chromium.org/2205083002
Cr-Commit-Position: refs/heads/master@{#417073}

Delete the associated GYP files.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2316293002
Cr-Commit-Position: refs/heads/master@{#417072}

This patch adds some comments to describe the cc ScrollNode members.

BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2310323002
Cr-Commit-Position: refs/heads/master@{#417071}

We shouldn't treat a navigation as NAVIGATION_TYPE_SAME_PAGE if
there is no last committed entry.

BUG=640429
TEST=No known repro steps.  Crashes should go away.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2319843002
Cr-Commit-Position: refs/heads/master@{#417070}

This CL (hopefully) removes all calls to these methods in android_webview:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2315863002
Cr-Commit-Position: refs/heads/master@{#417069}

Some extensions tests had the toolbar redesign disabled by a custom override.
Some of these are testing legacy behavior, but many were just never changed
over. Update
many to remove the custom override, enabling the redesign.

In order to stay targeted, this CL doesn't update behavior expectations
for any tests. That will be done in a followup.

BUG=None

Review-Url: https://codereview.chromium.org/2311533002
Cr-Commit-Position: refs/heads/master@{#417068}

This CL alphabetizes the settings vars by separating the --settings-*
and --paper-* vars.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2315033002
Cr-Commit-Position: refs/heads/master@{#417067}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/h4ooaB_Y9JE/nh7vXshGBwAJ

BUG=425896,640825
R=sigbjornf@opera.com,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2295863002
Cr-Commit-Position: refs/heads/master@{#417066}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f2348b4..391b9e37

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2319803002
Cr-Commit-Position: refs/heads/master@{#417065}

This will give us an upper bound on the % of iframes for which we can
defer loading.

BUG=635105

Review-Url: https://codereview.chromium.org/2212183004
Cr-Commit-Position: refs/heads/master@{#417064}

The fade-out frames were being calculated with the input sample rate
instead of the output sample rate.

Also updated the logging to make debugging easier.

BUG=

Review-Url: https://codereview.chromium.org/2324533002
Cr-Commit-Position: refs/heads/master@{#417063}

This is a reland of https://codereview.chromium.org/2293603002/.

Reason for revert: Build fails with: jmake: Could not find class file
for
/tmp/tmp7BuImL/java/org/chromium/browser/webapps/ChromeWebApkHostSignature.java.

Original CL description:
> [WebApk] Update verification keys.
>
> Update keys to latest test keys and also break it out by channel.
>
> TBR=rsesek@chromium.org,yfriedman@chromium.org
>
> Committed: https://crrev.com/716cc589da62b7cc48ac0542fe01239808687ec9
> Cr-Commit-Position: refs/heads/master@{#416339}

Patchset 1 on https://codereview.chromium.org/2317273002/ is the original
landed patch from https://codereview.chromium.org/2293603002/. Patchset 2
contains the fix in the build file.

TBR=rsesek@chromium.org,yfriedman@chromium.org,dfalcantara@chromium.org,mdjones@chromium.org

Review-Url: https://codereview.chromium.org/2317273002
Cr-Commit-Position: refs/heads/master@{#417062}

https://chromium.googlesource.com/skia.git/+log/62e9b145a13a..ef6a9b7f9393

$ git log 62e9b145a..ef6a9b7f9 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 halcanary android_skp_capture.sh
2016-09-07 mtklein clang_linux: also build an MSAN libc++
2016-09-07 msarett Delete SkColorSpace::gammaNamed() from public API
2016-09-07 egdaniel Merge building of program desc in Vulkan into one step

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2318343002
Cr-Commit-Position: refs/heads/master@{#417061}

This CL pulls in base's proguard flags when compiling
cronet_sample_apk and cronet_package.

Cronet will not need to duplicate proguard flags and can
benefit from base proguard file changes.

This saves about 1882 - 1471 = 411 methods from our dex
count for CronetSample.apk and 10kB(4.35%).

BUG=634998

Review-Url: https://codereview.chromium.org/2214013002
Cr-Commit-Position: refs/heads/master@{#417060}

This CL (hopefully) removes all calls to these methods in ui:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2315003002
Cr-Commit-Position: refs/heads/master@{#417059}

Before this patch, we use blink::WebScreenInfo far more in content than
in blink. Particularly objectionable is that all of the
RenderWidget::Create functions take this blink structure, rather than a
content structure.

After this patch, content traffics (almost) exclusively in a
content::ScreenInfo type, which is converted to a blink::WebScreenInfo
only inside the renderer process, when crossing the boundary to blink.

The reason for making this change now is that we will need to add a
gfx::ICCProfile to the screen info sent to content::RenderWidget::Create
and content::ResizeParams, but we will not be needing this information
in blink (there is no "real" ICC profile structure in Blink, and to the
extent that it does exist, it will be removed).

BUG=644545
TBR=dtrainor
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2317563004
Cr-Commit-Position: refs/heads/master@{#417058}

Missed in https://codereview.chromium.org/12180027

BUG=None

Review-Url: https://codereview.chromium.org/2324463002
Cr-Commit-Position: refs/heads/master@{#417057}

This is part of a refactor to split WebView/WebWidget.

BUG=583347

Review-Url: https://codereview.chromium.org/2315223003
Cr-Commit-Position: refs/heads/master@{#417056}