- 10 Sep, 2020 40 commits
-
-
danakj authored
These (non-include) references should now point to content/browser/renderer_host where the code has moved to. TBR=avi@chromium.org, arthursonzogni@chromium.org Bug: 1091083 Change-Id: I8d0ace9fab6c04e3b498eee8d442ff6bd52fd7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402185Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805760}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bdb38e31199e..13bf12548291 2020-09-10 landrey@webrtc.org Make token logs easier to use in BigQuery. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: skyostil@google.com Change-Id: If1ee1b428a7606f05f4ae4534a063571e96b8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805759}
-
Fritz Koenig authored
Make sure that there is no pending change resolution after the last buffer is received. BUG=b:161904111 TEST=seek test starting to pass on trogdor Change-Id: I7e01216d3f24f19d097d72c99a4f2ed8598c5f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382950Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805758}
-
Randy Rossi authored
Patch set 1 is baseline of unmodified downstream files. Downstream refs will change to point to this ax bridge once this lands. Test: Unittest Bug: None Change-Id: I5157c0a9caa1f662998e1f3222b519008369d621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386102Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805757}
-
Xida Chen authored
We have seen that the kUniversal tracker penalizes the throughput too much, so remove this code. Bug: 1122176 Change-Id: I378eaa1327af7fa065c548abff7e99e822fa2d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392768Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805756}
-
Paula Vidas authored
On sign in, FCM handler starts listening to invalidations. On sign out, it stops listening and deletes instance id. Bug: 1119294 Change-Id: Id6afaa49062662624fd239ba4302367e353340e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400997 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#805755}
-
Morten Stenshorne authored
We usually refrain from creating NG objects inside a force-legacy layout subtree (with the LegacyLayout enum). However, in some cases we might still want to insist on creating NG objects in such a subtree, e.g. if the box type has no legacy layout implementation (which is the case for e.g. MathML). This resolves bug 943574 - albeit as WontFix, since that bug asserts that we shouldn't have NG objects inside legacy subtrees. No behavior changes intended; this is just a preparatory CL for MathML to work inside legacy subtrees. Bug: 943574 Change-Id: Ic3d99c0f072f6bd5b849280ad29b4f4aaedde99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400501Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805754}
-
Rijubrata Bhaumik authored
Origin Trial feedback was that webNFC is better without ignoreRead. Spec changes: PR: https://github.com/w3c/web-nfc/issues/579 https://github.com/w3c/web-nfc/commit/00509fc2df1fa63a0456034afb04eb16d03ca4cd Bug: 520391 Change-Id: I9ed23c65f20f028e4cc6621dc7e8eb29a1abb262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401021Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kenneth R Christiansen <kenneth.r.christiansen@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#805753}
-
Yuki Shiino authored
Fixes the installation of allocator shim at //base/BUILD.gn in the following way. 1. Hook the standard allocator functions. Add appropriate allocator_shim_override_xxx according to the platform so that we hook the standard allocators. 2. Add the default dispatcher of the allocator functions. Add appropriate allocator_shim_default_dispatch_to_xxx according to our own allocator (PartitionAlloc, TCMalloc) or, if we use the system allocator, according to the platform (glibc, MacZonedMalloc, WinHeap, etc.). This is a logical and comprehensive way to install the appropriate allocator hooks and shim. Bug: 998048 Change-Id: Id3d5b5708a94f7894971d2131c83b17f6eada096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392189Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805752}
-
Bret Sepulveda authored
This is a reland of 85ae69b0. Fixes namespace conflict with branded builds. Verified by local compile. Original change's description: > Add new class ColorTrackingIconView to deduplicate subclasses. > > Upon investigating the associated bug, I noticed that there are a few > subclasses of ImageView that exist solely to override OnThemeChanged. > Since I also needed a subclass like this to fix the bug, I decided to > make a utility class to eliminate this ad-hoc subclassing, in the style > of ColorTrackingVectorImageButton (in image_button_factory.cc). > > Bug: 1125510 > Change-Id: I975a9b6a4676bb6b2a454172f211f406934d7869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397737 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804901} Bug: 1125510 Change-Id: Icbe7240ab8159f1c61f510f03dab7e5d6c5d563b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401018 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#805751}
-
Ioana Pandele authored
This reverts commit 551bbd27. Reason for revert: Reland with fix for the status update. TBR=tedchoc@chromium.org TBR-ing since the DEPS file has already been reviewed and hasn't changed. Original change's description: > Revert "[PwdCheckAndroid] Add delay between check status header updates" > > This reverts commit 849b3b5d. > > Reason for revert: The assumption that the progress signal comes after > status signal was wrong, so this change causes a bug when re-running the > check. > > Since this was meant to be merged, reverting + fix is easier than fixing > in a follow-up CL. > > Original change's description: > > [PwdCheckAndroid] Add delay between check status header updates > > > > This CL adds a delay to status updates whenever multiple updates are > > notified to the mediator in a short time window. > > The minimum time interval between updates is set to 1 second. > > > > Bug: 1122026, 1092444 > > Change-Id: I64d9c95a11a5ed9b9d6fcf8941c260bf8b3a64ac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390642 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805236} > > TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com > > Change-Id: I737eee5e355033542dc9ba8393eedc3390baf5de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1122026 > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401620 > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805385} TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com # Not skipping CQ checks because this is a reland. Bug: 1122026 Bug: 1092444 Change-Id: Ib43b92f88393634d958582270d5dd9a1edba5829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403281Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#805750}
-
Benoit Lize authored
Stable 1% experiment shows very positive results on memory with no adverse responsiveness/latency issues, so let's enable the feature by default. More specifically, 95th percentile footprints (from the experiment): - Browser: -12% - GPU process: -12% - Per-renderer: -6% - Total: -7% And for discardable memory, -43%@95th percentile. Also remove the testing config, since it is no longer needed. Bug: 1109208, 926186 Change-Id: I99b1f8d36e2b754879ada98468a4464358652cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403465Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d41d509a6a9..fb5e0ebef07c 2020-09-10 kjlubick@google.com [canvaskit] Pass in paints via reference If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I986e3aa910ba9f0138440f00e6d4f8cce51494b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403315Reviewed-by:
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I3b4442e611378935cbd9f88736f1871ad1971f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375287 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805747}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I83edc3ba736db0a5beece82166906b4a1478921c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401342Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805746}
-
Juanmi Huertas authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2391502 two tests were marked to be skipped as they were flaky. According to https://chromium.googlesource.com/chromium/src.git/+/master/docs/testing/rendering_representative_perf_tests.md#updating-expectations it is better to mark them as experimental rather than skip them. This CL addresses that issue, and marks them as experimental. Bug: 1122037 Change-Id: Iae875773d08d101c6fffb4b274780520f530a8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401337Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805745}
-
Kyle Horimoto authored
Now that BleScanner (and its dependency BleSynchronizer) will be shared with Nearby, these classes cannot be initialized within BleConnectionManagerImpl, since this class only supports connections via BLE GATT connections. This CL moves their initialization to the top- level SecureChannelImpl class. Bug: 1106937 Change-Id: Ic4581ebacdc346441109420bb3778bfd300e7ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402166 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805744}
-
Alice Wang authored
This CL refactors SyncTestRule#setUpAccountAndSignInForTesting() by using AccountManagerTestRule to handle the sign-in instead of handling it directly in SyncTestRule. Bug: 1126814 Change-Id: Ib8c3941ecad3642f6749915142562d68a8ff4a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401345 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for AsyncCallWithBoundArgsBuilder. Move AsyncCallWithBoundArgsBuilder implementations into different nested classes and select implementation using std::conditional. Bug: 819294 Change-Id: Ie46c22896c9166d4b0c3114f2c29f65b01ec3568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401463Reviewed-by:
-
Xi Han authored
Bug: 1121728 Change-Id: Ib2b0c0dcf9ddccfdb9408d2b219c579da083241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398898 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805741}
-
Mario Bianucci authored
Add <limits> and <utility> includes to surface.cc to silence presubmit errors. Change-Id: I6d8cc83099e46608b1caf8372e1410d06dcda82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401587Reviewed-by:
-
Joe DeBlasio authored
To match cl/330736217. Change-Id: Iee3db833ce79b911420960738d7a7b4680e8aafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401307 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Wez authored
If any of these tests exhibit flakes then please disable the test using the normal DISABLED_ prefix mechanism, and set component:Fuchsia on the bug, rather than reverting this CL in its entirety. NetworkContextTest.Preconnect* and TCPBoundSocketTest.ListenError now pass, likely due to improvements to the platform network stack. Most TracingConsumerTest.* tests now appear to pass without flakiness, possibly due to improvements in platform memory-management. URLLoaderTest.ResourceSchedulerIntegration no longer seems to flake, possibly due to network stack improvements. The SimpleURLLoaderTest.OnUploadProgressCallback/* filter entry was no longer being applied, because the tests had been parameterized, causing their names to change. Bug: 952653, 976319, 986544, 1125854, 1125855 Change-Id: Ifc262726675e98e9660b787539ebde5e82ff4872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396337 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#805738}
-
Irina Fedorova authored
This CL improves the PasswordWeakCheck in weak_check_utility by using the zxcvbn-cpp library for passwords shorter than 40 characters. Bug: 1119752 Change-Id: Ic79c63cc8c622a8fe10dcfb9a6e5fa1e6bcd44ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401519 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805737}
-
Mario Sanchez Prada authored
This is a follow-up CL for crrevc.com/c/2387801 to remove the methods SetMouseOverURL() and SetKeyboardFocusURL() from WebViewClient, along with their implementations in RenderViewImpl, and move the logic right into WebViewImpl instead. Additionally, this CL also removes a couple of leftover declarations in render_view_impl.h for methods that were moved to WebViewImpl along with crrev.com/c/2387801 already. Bug: 993189, 1047464 Change-Id: I5e8b13b1db955272308490c82c97ff96e428a64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403260Reviewed-by:
-
Christian Dullweber authored
Create a wrapper that contains the URL and header for subpages and a placeholder that can be filled with either the main page or a subpage. Bug: 1077766 Change-Id: I812ddd8a4e593b8c74cc6fef52bee012a264e5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396239 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805735}
-
My Nguyen authored
The logic in settings side is added in https://crrev.com/c/1600384. Main logic is to turn off kSpellcheckEnable when spell check is off for the 1 supported language. This is equivalent to turning off kSpellcheckEnable when hun_dictionaries is empty as it has similar origin to spellCheckEnable. They both come from users' spellcheck dictionaries pref, forced and blocked dictionaries list. More background: http://go/cros-lang-settings-spell-check-migrate Update the test in languages_page_test.js to better reflect users's action. Side effect: Originally, when users turn off spell check for all languages, spell check is left on. Now, when they turn the last one off, spell check is off as well. Related CL: https://crrev.com/c/2360093 Drive-by: Remove unused SetSingleLanguageDictionary function in test. Bug: 1113439 Change-Id: Id8700c3b357da53e22e5f79420b163c8ef50b2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390300Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805734}
-
Victor Hugo Vianna Silva authored
This class was used in a single place (to observe auto-sync settings via Android APIs), its name was very similar to the exposed AndroidSyncSettingsObserver interface, and its documentation was wrong (it treated it as AndroidSyncSettingsObserver). The CL removes the class and uses an anonymous class instead. Bug: None Change-Id: I73af1acf74b90d50e7412a50b1097668a1cfe17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403462Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599716388-02eae1071f5b6fe6862d29aa135a2ecf5509f01d.profdata to chrome-mac-master-1599738815-ff1bf13166c585a2e1282bb43357481f321e4e87.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I283c1e10a7c46675e0665f6ca93d37e3ec031149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403318Reviewed-by:
-
Benoit Lize authored
base::Lock still regresses multiple benchmarks (see crbug.com/1125866) for a summary of regressions. Bring back the SpinLock for non-DCHECK() builds. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2390066, with a few changes: - base::subtle::SpinLock -> base::internal::SpinLock - lock()/unlock() -> Acquire()/Release(), to match the usual naming. - Remove unused methods Another motivation for a partial revert (with inlining of SpinLock in partition_lock.h) is to prepare further work to make this lock sleep, if base::Lock's fast path doesn't improve enough. Bug: 1125866, 1125999, 1061437 Change-Id: Ia433b6da870f0a843de67f23d906d37e3f8c0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398528Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2bd90e9b1d358b641ffbc4824f5360f179962ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401032Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805730}
-
Ben Kelly authored
Bug: 1010624 Change-Id: I40f2482ee7d81d548706a8cc46ad7669c22a9df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401913Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#805729}
-
Guillaume Jenkins authored
According to the Apple doc below, donating intents is a way for apps to tell Siri "The user just performed this action inside my app". This is used by Siri to give better results to the user when they search in Spotlight, or to give suggestions to the user on the homescreen, such as "Do you wish to Search in Chrome?". According to the doc, donating intents should only happen immediately after the user performs the related action inside the app. Also, donating intents is not needed to register shortcut actions. That happens automatically via the intent definition file. For those two reasons, there is no need to donate the SearchInChrome intent during startup, so this CL removes that. https://developer.apple.com/documentation/sirikit/donating_shortcuts Bug: 1125200 Change-Id: I93c1e71ced03b70d0849ce27390ccbfe9821b4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401761Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#805728}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d1bf91b4dab..b3f3e76c87ac 2020-09-10 rslawik@google.com Merge "Fix unique constraint failed error" 2020-09-10 ssid@google.com Merge "Add source location as typed event argument" 2020-09-10 taylori@google.com Merge "ui: Use id for thread state selection" 2020-09-10 treehugger-gerrit@google.com Merge "UI: allow ?=&; chars from postMessage strings" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2008fc0ae5197550965ca296c8bf10f0505c1957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403311Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic9aac6fe2745df8bfb9f353bee279ba1be4f7fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403312Reviewed-by:
-
danakj authored
It's possible to go through a backdoor now, and this explains that you can do so, while begging you to not do so. R=avi@chromium.org Bug: 1091083 Change-Id: I164f1d39ec99a852dec2ce65662e22f81002a529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402202Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805725}
-
Morten Stenshorne authored
This reverts commit e7bbc732. Reason for revert: Breaks ThreadCacheTest.NoCrossPartitionCache (and possibly the others, too): https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/84939 Original change's description: > base/allocator: Add a thread cache to PartitionAlloc. > > This CL adds a thread cache to PartitionAlloc. It is optional, only > applies to thread-safe partitions, and uses the same freelist encoding > and bucketing as the main allocator. > > The thread cache is added "in the middle" of the main allocator, that is: > - After all the cookie/tag management > - Before the "raw" allocator. > > That is, the general allocation flow is: > 1. Adjustment of requested size to make room for tags / cookies > 2. Allocation: > a. Call to the thread cache, if it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > 3. Handle cookies/tags, zero allocation if required > > On the deallocation side, the process is reversed: > 1. Check cookies / tags, adjust the pointer > 2. Deallocation > a. Return to the thread cache of possible. If it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > > The thread cache maintains an array of buckets, the same as the parent > allocator. A single thread cache instance is only used by a single > partition. Each bucket is a linked list of allocations, capped to a set > maximum size. Elements in this "freelist" are encoded the same way they > are for the main allocator. > Only the smallest buckets are eligible for caching, to reduce the > memory impact. > > There are several limitations: > - Only a single partition is allowed to have a thread cache > - No periodic purging of thread caches is done > - No statistics are collected > > The last two limitations will be addressed in subsequent CLs. Regarding > the first one, it is not possible to use Chrome's native thread local > storage support, as it allocates. It is also desirable to use > thread_local to improve performance. > > Bug: 998048 > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805697} TBR=haraken@chromium.org,lizeb@chromium.org Change-Id: I34ffdb52974d2d996da6eeb0e1b3aac9dd9ef6cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403363Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805724}
-
Irina Fedorova authored
This CL adds a simple version of the StartWeakCheck function to the InsecureCredentialsManager that doesn't use the zxcvbn-cpp library yet. Checking long passwords is implemented as it will be in the final version of password weakness check. It also adds the GetWeakCredentials function to the InsecureCredentialsManager. Bug: 1119752 Change-Id: I50013c9824701fdccabda7a76644f37c90fa6227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398622 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chrome on Android could attempt to use null WebContents* or RenderFrameHost* pointer derived from the corresponding Java objects, while an iframe is being removed, which caused a crash. This patch adds WebContents.isDestroyed() check in Java and null checks for RenderFrameHost* pointers in C++ derived from corresponding Java objects. After this patch, Chrome does not crash when an iframe is being removed on Android during PaymentRequest operation. Bug: 1125614 Change-Id: Id390a6eceaa3c8ccfcc496583ee82c9e6bb2a20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401318 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805722}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b8c3292e. With Chromium commits locally applied on WPT: 6e8ec7a9 "sensors: Drop tests for Sensor.start()/stop() return types." 5083fb9d "sensors: Rewrite the frequency hint test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I98bdb053ac04629ec5b90609f39c12dfc1df96d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403400Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805721}
-
