GitLab

Bug: None
Test: chromeos_unittests
Change-Id: I2f41f49cce38b65db5cf5647be2f8f53689e18bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119523Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#753560}

This change applies changes generated by running the PassedToMoveRewriter
rewriter across a Linux build of the codebase. It changes no functionality,
and only removes base::Passed invocations that can either be completely
omitted, or rewritten in terms of std::move.

TBR=dcheng

Bug: 714018
Change-Id: Ie8af65a571271c2eb77f8f88c2678e8e8abbbb9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120479
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753559}

This CL adds initial integration tests of external intent launching,
covering the following cases:
- That an intent is not launched for a vanilla browsing URL.
- That an intent is blocked if navigated to directly.
- That an intent is launched if navigated to via a redirect.

Future CLs will add tests of more cases.

Change-Id: I6141a6aff81acef40155dfaf74d4a11bc10c7a40
Bug: 1029710, 1031465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119535
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753558}

crrev/753172 removed public method |TabImpl.getProfile| and caused a
compilation error.

TODO: consider to add a CQ bot for the compilation flag

TBR=selakovic@google.com,ioanap@chromium.org

Bug: 1053522
Change-Id: I4a27681b83a70701c14b3dca3764105e3c1d8494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120300Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753557}

This reverts commit 0bbf0f94.

Reason for revert: Suspected to cause flaky test (see crbug/1064896)
BUG=1064896,1058187

Original change's description:
> [Media Feeds] Add feed items to WebUI
> 
> This adds the feed items to the WebUI. You
> can select a feed to show the content.
> 
> BUG=1058187
> 
> Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753441}

TBR=beccahughes@chromium.org,steimel@chromium.org

Change-Id: I89b1447a80ccdeebbc93dd3b8c87cd8f72bbed0d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058187
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120301Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753556}

ServiceWorkerContextWrapper::StartWorkerForScope searches for
registration with active or installing worker through
DidFindRegistrationForFindImpl. For the case where there is an
installingworker, DidFindRegistrationForFindImpl can see a
registration.installing_version(), but the version can be gone by
the time it PostTask-s to FoundRegistrationForStartWorker
if the service worker script rejected the 'install' event.

This CL removes the DCHECK that incorrectly assumes either active
or installing version *must* be present
in FoundRegistrationForStartWorker. The DCHECK failure is evident
in the flaky extension test failure:
ServiceWorkerBasedBackgroundTest.WorkerStartFailureClearsPendingTasks.
The CL also enables the mentioned test.

Bug: 1063476
Change-Id: I12dd3b5f2155bc8b8677f9734443832c1a96fe61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119208Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753555}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0e15e8064fd0..4f77e105e33d

git log 0e15e8064fd0..4f77e105e33d --date=short --first-parent --format='%ad %ae %s'
2020-03-26 sigurds@chromium.org [issues] Add audits capability

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@4f77e105e33d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1064587
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibcc1ab4c32ddea860df97f109a8d134613c890d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121548Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753554}

Bug: 1064209
Change-Id: I08ba090dfbb97efa097e8d574b99a66eaaf00f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117111Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Artur Kochowski <akochowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#753553}

NavigationLoaderOnUI landed. Some comments about it are still there.
This patch remove them.

This disambiguate the fact this variable can be safely used:
NavigationURLLoaderImpl::URLLoaderRequestController::browser_context_

Bug: 824840
Change-Id: Icb6dc5050a604878531958acbc0fdc2a7739d420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120717
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753552}

Removes TabModelList from IncognitoWebStateObserver. Instead the
observer uses an AllWebStateListObservationRegistrar and an inner
observer class to perform the same updates.

Bug: 1050149
Change-Id: I70d77dcd228e75cb6769b44279cd2a604bc9b0a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117737Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753551}

Bug: 1015841
Change-Id: I03a5fff56c973663e307cd01fb75bbac1aff162e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117731Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753550}

The method testAllowPermissionDoNotLeakFromIncognitoToIncognito failed
when CustomTabIncognitoManager#hasIsolatedProfile returns true.

This happened because the test was missing a method call to request
permission.

This CL adds the method invocation and updates comments.

Bug: 1035770
Change-Id: I4ca71b082a6140d79c2e4835d3e803099fb26232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120415Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Rohit Agarwal <roagarwal@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753549}

Add component and strings for parent info screen.
Move edu-login-button position CSS to shared CSS file.
Update template to allow scrollable content.
Screenshot: http://screen/ty41uTYuCQO

Bug: 1043108
Change-Id: Iea78f81e8469a41ca17357e891355676bf57d8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010963Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753548}

https://skia.googlesource.com/skia.git/+log/d8c6c0e0f3a6..ee2ec6de995b

git log d8c6c0e0f3a6..ee2ec6de995b --date=short --first-parent --format='%ad %ae %s'
2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 107e4e989e94..6719f54ac7ce (6 commits)
2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 772d2084..16171704 (389 commits)

Created with:
  gclient setdep -r src/third_party/skia@ee2ec6de995b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: robertphillips@google.com
Change-Id: I837d2815d36b92c241a094e0b286a16c3ca93f7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121761Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753547}

Use AppGround to open "learn how" link.

Bug: 1045455
Change-Id: Ic9c8bb4c12a51804f2d95510d401777fa576da87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115543
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753546}

To fix

[..:INFO:test_launcher.cc(1498)]
 The following parameterized test case is not instantiated:
  UninstantiatedParamaterizedTestSuite<
      BrowserNonClientFrameViewAshTestNoWebUiTabStrip>
  UninstantiatedParamaterizedTestSuite<
      ImmersiveModeBrowserViewTestNoWebUiTabStrip>

These test suite aliases were added in r748410.

Bug: 1059514
Change-Id: I6a60a2d862a08e0e8f3cad8083de7966cdf19823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121520
Auto-Submit: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753545}

We make the kWebAppFileHandlers key available on stable rather than
trunk.

The ExtensionFromWebApp unit tests now use a test fixture that sets up
a testing environment (by inheriting from ExtensionServiceTestBase).

This is a speculative fix for a bug (crbug.com/1062239) that seems to
have been introduced by a change to ConvertWebAppToExtension
(crrev.com/c/2087327).

The test WebAppFileHandlersAreCorrectlyConverted is re-enabled.

This CL replaces
https://chromium-review.googlesource.com/c/chromium/src/+/2108208

Bug: 1062239
Change-Id: I107a0731ab5b17faa51660384c10cab400e3cb7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120676
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753544}

Currently, either the country field in an address form is used to
determine the address requirements for autofill profile creation, or the
the app_locale is used as a fallback option.

This change adds the country code supplied from Chrome Variations as a
primary fallback before the app_locale is used to deduce the country of
a user. Also the country code is used to as a source for the default
country for address creation.

Change-Id: Ia7d28c66a31775b26d7d33153670b1db6eade74c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107981
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753543}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5a3755f19aa..0e15e8064fd0

git log d5a3755f19aa..0e15e8064fd0 --date=short --first-parent --format='%ad %ae %s'
2020-03-26 sigurds@chromium.org [coverage] Disable save button if there is nothing to save

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0e15e8064fd0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id0f793f72de9b90406ad02a88f794a1da189dba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121760Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753542}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I5fc94e77c5636e33c8cce31006c21534ccdd7011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753541}

It sets itself as the root window's client on construction and nulls
that out on destruction.  DesktopScreenPositionClient already did this,
this just hoists that to the base class.

This makes it harder to introduce bugs like "constructed the client
but forgot to set it on the window" or the more likely (and insidious)
"failed to null the client on shutdown, leaking state into another test
and triggering test flakiness".

Bug: none
Change-Id: Ib8ddb193d78d7d7e5b0cf48683a7ef9653d31f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117335Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753540}

MediaAppIntegrationTest.MediaAppLaunchWithFile and
MediaAppIntegrationWithFilesAppTest.FileOpenCanTraverseDirectory have
been flaking at low rates, but got flakier in r753464.

Haven't been able to reproduce locally.

https://crrev.com/c/2108400 adds some robustness, but without a local
repro I haven't been able to verify this.

Disabling to investigate further.

TBR=zafzal@google.com

Bug: 1064863
Change-Id: I1b27f9b9b89f3ad72d45b2548c2115b8361620f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121119Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753539}

This adds a new IDR resource id, to decouple the shown-icon from any
icon asset that gets brought in via DEPS.

Bug: b/150637102
Change-Id: I55b98e9fe7cf0d3fde4a87661d9dfbd39dc12ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120661
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753538}

...into ComputePendingCredentialsState and BuildPendingCredentials.
This will allow us to call ComputePendingCredentialsState twice in
MultiStorePasswordSaveManager - separately for the account matches and
the profile matches.

Bug: 1012203
Change-Id: Ie017474b84e4dc8b0b82bb4bb35a483dfb1a9175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116039
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753537}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/056caa9eda32..22ff3cfaf62e


Created with:
  gclient setdep -r src-internal@22ff3cfaf62e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1052460,chromium:1058597
Tbr: jbudorick@google.com
Change-Id: Ic3dc696055b5c39692f82a319eda7353847f9d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121536Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753536}

chrome://media-app-guest runs unprivileged code that doesn't require
any of the implicit powers that chrome:// schemes get. Switch it over
to the new chrome-untrusted:// scheme that was built to cater for this
use case. The approach here follows the approach used for the help app
in r744077.

But since the test harness for media-app-guest no longer has a webui
it can piggyback off, the tests need to be migrated into a framework
which allows the tests to be injected into the unprivileged frame
within the context of the test harness that exists for the privileged
webui.

Bug: 996088
Change-Id: I41c9866375f86a032eff752ce9a3b9c1c00ed212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108400Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753535}

Fixed by

Suppress -Wpredefined-identifier-outside-function in SpeechMonitor

TBR=dtseng@chromium.org

Change-Id: I5e583e9b9c7c35778ca081ec7b3bd7e82da81af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121474Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753534}

This CL makes the test load an actual extension from test dir instead
of just creating a test extension object that is not loaded in
extension system.

The test flakily fails because the first call to
network::BlockingDnsLookup doesn't resolve dns lookup. This CL is
based on the wild intuition that as we use the extension's url in
NetworkIsolationKey and the extension is not present in extension
system, the test fails. Therefore, loading the extension would
remove the failure cause. Two thousand runs with this fix survives
in bots, where the test wouldn't without this CL.

Bug: 1064832
Change-Id: Id75af472f9457b1205f1caef34b4e6686bbcaeee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121344
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753533}

https://skia.googlesource.com/skia.git/+log/c2d325c1d67a..d8c6c0e0f3a6

git log c2d325c1d67a..d8c6c0e0f3a6 --date=short --first-parent --format='%ad %ae %s'
2020-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 540bdf92531d..77090261dabc (10 commits)

Created with:
  gclient setdep -r src/third_party/skia@d8c6c0e0f3a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: robertphillips@google.com
Change-Id: I5ce93795ea54ef374ae007458d221f72cff8f08a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753532}

DirectoryTree displays focus rings when the keyboard or pointer device
(mouse/pointer/touch) is used for interaction in files-ng.

Change that: only show focus rings for keyboard interaction, using the
global focus-outline-visible class provided by the cr.ui.focus_outline
visibility manager.

Bug: 1062902, 992819
Change-Id: Idb94a7be5582cfa4ae7429f04d53b95c8c855596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114512Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753531}

This function might be called after the frame is removed now.

Bug: 1064683
Change-Id: I3092d2f77eeb0652c072277b9724fe4191e2e580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120777Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753530}

Use enum class instead of enum for views::LayoutFadeType.
enum class is more type safety.

Bug: 940736
Change-Id: I9c026d131835d77d212e4084bc84cb703a0638a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120837
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753529}

Store PDF version of the document as an enum field in DocumentMetadata.

Bug: 93619
Change-Id: Ied76c6fd4cdaf379e822046af0fff4ab4ff8af12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118682Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753528}

This reverts commit 105f5197.

Reason for revert: build failure

https://ci.chromium.org/p/chromium/builders/ci/android-archive-dbg/4471

Failure
Step compile failed. Error logs are shown below:
[86291/95274] SOLINK ./libvk_tests__library.cr.so
FAILED: libvk_tests__library.cr.so libvk_tests__library.cr.so.TOC lib.unstripped/libvk_tests__library.cr.so
/b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long)
ld.lld: error: undefined symbol: gfx::GpuMemoryBufferHandle::GpuMemoryBufferHandle(base::android::ScopedHardwareBufferHandle)
>>> referenced by vulkan_android_unittests.cc:133 (../../gpu/vulkan/android/vulkan_android_unittests.cc:133)
>>>               obj/gpu/vulkan/android/vk_tests__library/vulkan_android_unittests.o:(gpu::VulkanImplementationAndroidTest_CreateVkImageFromAHB_Test::TestBody())


Original change's description:
> Reland "VulkanImage: support create from GpuMemoryBufferHandle on Android"
> 
> This is a reland of 838eb034
> 
> Original change's description:
> > VulkanImage: support create from GpuMemoryBufferHandle on Android
> >
> > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace
> > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace
> > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well.
> >
> > Bug: None
> > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#753394}
> 
> TBR=rjkroege@chromium.org,vasilyt@chromium.org
> 
> Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng
> Bug: None
> Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753501}

TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org

Change-Id: Ifbb45c4dbb1017d26d68c1216f3b5bdaece36991
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120995Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753527}

https://chromium.googlesource.com/catapult.git/+log/8351d2182b54..a8bbccaabeff

git log 8351d2182b54..a8bbccaabeff --date=short --first-parent --format='%ad %ae %s'
2020-03-26 phoglund@google.com Remove histogram proto JSON converter code.

Created with:
  gclient setdep -r src/third_party/catapult@a8bbccaabeff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1029452
Tbr: skyostil@google.com
Change-Id: Id827eea4c6b4c36a48769007e06059f0afb5a4a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#753526}

This allows us to remove the cases where a TestABMD and ABMD coexisted
and the workaround for that ie. all observers previously had to
implement OnAppBannerManagerChangedForTesting.
This is in prep for adding a new observer.

Change-Id: I0fb1e87a1e7072a2ef28d6b5bb57c2a296659794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111253Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753525}

Migrate this test out of third_party/blink/web_tests/css3/flexbox
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.

Bug: 1063749
Change-Id: I11a272729c422a3eb48d07ea21493f7998fc226e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119465Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753524}

Linters are cool.

PRESUBMIT.py is the one that was in ui/file_manager, but with the path
adjusted so it can find `web_dev_style`.

.eslintrc.js is the one from ui/webui but with

  'parserOptions': {
    'ecmaVersion': 2018,
    'sourceType': 'module',
  },

added. This is needed to support `await` and spread syntax, and matches
our closure typechecking flags.

Note we also inherit the .eslintrc.js configuration in src/.eslintrc.js.


Fixes were mostly achieved by
  ./third_party/node/linux/node-linux-x64/bin/node \
      third_party/node/node_modules/eslint/bin/eslint.js \
      chromeos/components/media_app_ui/{test,resources/{js,mock}} --fix


The remaining bits were:
 -  document.getElementById is a restricted keyword. Recommendation is
to use resources/js/util.js, but I'm not sure we need/want that
dependency. Found a workaround (querySelector), but we might add that
dependency in a follow-up. (Where we use getElementById is placeholder/
experimental code currently).
 -  linter didn't like declaring a "namespace" like media_app. Changed
to declare pageHandler directly.
 -  linter also couldn't automatically fix the `==` -> `===`.

Bug: b/152284689
Change-Id: Ib12765ade3cc5f3a9f46448ad8741eb3b8434737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119336Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753523}

Change-Id: I0782ba0e2879110475831d7e1d56b8cb91ddb0da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118581
Auto-Submit: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753522}

Bug: 1064478
Change-Id: Ief97408a822f6ff1ed2be2e1366d1d261ffc7062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121117Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753521}