- 20 Aug, 2020 40 commits
-
-
Alexander Hendrich authored
This reverts commit c4de5e43. Reason for revert: failing test, see https://crbug.com/1104083#c8 Original change's description: > Use document background color as active tab color for tabbed web apps > > This CL hooks up the document's background color as the active tab > background color for experimental tabbed web app. > Tabbed web apps are hidden behind the DesktopPWAsTabStrip feature flag. > > This CL plumbs background color through from the renderer process along > the same route as document theme color. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460591&signed_aid=NcgKQaq5Y47QkcbQbbgNiw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460590&signed_aid=RlnBzb7mQq1SIW1fGBY-oA==&inline=1 > > Bug: 1104083 > Change-Id: If1c3e2172f80375a1a4619c17ee52594ef813005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342426 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800051} TBR=avi@chromium.org,msw@chromium.org,alancutter@chromium.org,haraken@chromium.org,dominickn@chromium.org Change-Id: I9ed61a2044703edcac2127d1a50c3ae47b12b872 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366757Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#800099}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1cb771bfe063..1e53cb87ed5e 2020-08-20 jacktfranklin@chromium.org Load runtime stylesheets in to the components server 2020-08-20 szuend@chromium.org [ts] Improve types in ui/Context.js 2020-08-20 szuend@chromium.org [ts] Type-check ui/PopoverHelper.js with TypeScript 2020-08-20 jacktfranklin@chromium.org Fix empty function bodies in component bridges 2020-08-20 alexrudenko@chromium.org [Metrics] UMA tracking for suggest color feature in Color Picker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093227 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ad51e3c12d46f7e5f5d0252ba46a33e86b13b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367017Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800098}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..2d613f1e1be9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id61297f54b0bec7fd5d39736bbea26e5c1f96257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367016Reviewed-by:
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I6685b09c455156ad21a62d18546c61bd6a966cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362595 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#800096}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/1beb3191c2..dc969f34a7 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/1beb3191c2..dc969f34a7 Bug: None Change-Id: Ic1c197cc401aec83ac7c974003b50b7902ca399f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367093 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#800095}
-
chrome://managementAndreea Costinas authored
Change the wording and location of the proxy server disclosure in the transparency panel. First landed as CL:2360073, reveted due to failed MSAN tests. TBR=glevin@chromium.org Bug: 1116961 Test: unittests Change-Id: I133ad760e41d03ad3edf2ba3685c552257c8e9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366772Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#800094}
-
Changhao Han authored
Change-Id: Iecbf7ff7d7a8f636b55d251cc105bac1e22f4b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362921 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800093}
-
Christoph Schwering authored
This CL moves the probable-form-submission detection from the renderer process to the browser process. The new behaviour is active iff kAutofillEnableProbableFormSubmissionInBrowser is enabled. The current state is that probable form submission is detected in FormTracker::DidStartNavigation(), which forwards the event to AutofillAgent::OnProbablyFormSubmitted(), which then notifies ContentAutofillDriver::FormSubmitted(). The 'submitted form' is the one returned by AutofillAgent::GetSubmittedForm(). This CL moves the event detection to the newly added ContentAutofillDriverFactory::DidStartNavigation(), which calls the newly added ContentAutofillDriver::ProbablyFormSubmitted(). The 'submitted form' should again be the one returned by AutofillAgont::GetSubmittedForm(). For the browser process to have access to that form, AutofillAgent now proactively sends it to the browser process by calling SendPotentiallySubmittedFormToBrowser(). See the referenced bugs for further details. Bug: 1113740, 1117451 Change-Id: I46be9e8b7058f4a309e3e9c64f34ca4d8852e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332622 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#800092}
-
Koji Ishii authored
This patch moves |FontHeight| to |platform/fonts|, so that classes in platform can use this class. This class was renamed from |NGLineHeightMetrics| in r800012 <crrev.com/c/2366375>. This is preparation to add BASE table support. With this change, |FontMetrics| can return |FontHeight| instead of constructing from |FontMetrics|. Also changed the default constructor to create zero- initialized instance to match other classes. |Empty()| static function returns an empty instance. This patch has no user-observable behavior changes. Change-Id: Icd289dff0c90b4fb19c497a4e64b31ea42ed7952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363514 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800091}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..2d613f1e1be9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7b30cd28c84946461cc7fe4ed80bf9768805687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366145Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/eff9ef0f2212..7f265d1d4074 2020-08-20 tommek@google.com Fixing offset alignments when using DynamicUploader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I09715a0696b4d4de2cad7d0cd9ce7d1777adbaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366247Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/193cfbd67529..bbb2038a3f14 2020-08-20 tsepez@chromium.org Nest CFWL_ListItem as CFWL_ListBox::Item. 2020-08-19 tsepez@chromium.org Make ~CFWL_CheckBoxTP() be the default destructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I13a6f0d6ac9b91974e760a6842fa292c2e5c4b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366245Reviewed-by:
-
Guido Urdaneta authored
These changes are intended to address a crash that occurs in WebRtcAudioRenderer::SwitchOutputDevice. Android behavior left unmodified due to issues with the test version of frames, but this is not an issue because setSinkId() is not supported on Android. Bug: 1116409 Change-Id: Icb88c32b29cb8450fed48e6961e123b3c25917af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355926 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#800087}
-
Ryan Daum authored
The callback wrapper being local stack allocated means the asynchronous callback invocation may fail if invoked after the method returns; this has been causing crash/JNI failure. Switch to a unique_ptr and move it along. Additionally the callback argument itself may go out of scope, so needs to be switched to the correctly scoped JNI handle. Bug: internal b/162882383 Test: manual on device Change-Id: I4bb4c87531e9a4b099f61ad9133ad1b3922de4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364559 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800086}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d613f1e1be9..56d9df4fa53f 2020-08-20 simonmacm@google.com Merge "Fix suspend detection." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4a99964746a33a501a5aa1a44fadd698ece9bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366244Reviewed-by:
-
Nohemi Fernandez authored
TBR=marq@chromium.org This fixes a BUILD issue due to a deprecated API in MDCSnackbarManager. Bug: 1117399 Change-Id: I27a9c5ce03e319bb4f402236d32f593a4d7f073e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367032Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#800084}
-
Stephen Chenney authored
An error introduced in a previous patch caused background-position calculations to be broken due to incorrect source rect transforms. Fix it and add a more thorough test. The test fails pending fuzzy matching in Chrome. Bug: 1108698 Change-Id: Iabdc332474daa0c5dc4aeb61df338c6028212c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365914 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#800083}
-
Titouan Rigoudy authored
It was mistakenly added in crrev.com/c/2282932 after a bad rebase operation. Bug: chromium:986744 Change-Id: Iefdfac6cfa564f7d4cd3b12b7a322f56a2945ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366734Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800082}
-
arthursonzogni authored
Reenable two test: -CoopReportingOriginTrialBrowserTest.AccessReportingWithToken -CoopReportingOriginTrialBrowserTest.CoopStateWithToken They were disabled by: https://chromium-review.googlesource.com/c/chromium/src/+/2365362 We think this might be fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2366778 Feel free to immediately revert this patch if the two tests start to fail. We will also monitor them today. Bug: 1119555 Change-Id: Ibd6fc4af82fcc4cbd3dcf5fe2b1472d81cb9c8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366894Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#800081}
-
Rainhard Findling authored
This reverts commit 1708a344. Reason for revert: I forgot that there was an explicit reason why we did exclude the "Check now" button and the safety check parent element secondary label from Settings search: it breaks another user journey: 1. In the main page, the users searches for "Check now" (or for any other string that is matched only by the button or the parent element secondary label). Safety check is shown as a the only result of the Settings search in the main page. 2. The user runs a safety check. The "Check now" button is replaced by the re-run icon button, and the string of the secondary label changes. 3. The user navigates from the main page to another Settings page through safety check to inspect some details. 4. The user navigates back from the Settings page to the main page. Safety check is no longer shown and the main page is empty, as the search term does no longer match anything inside safety check. Original change's description: > Safety check: include "Check now" button in Settings search > > * Include the previously excluded "Check now" button in the Settings > search. This lists safety check as a result when searching for "Check > now" if the button is visible at the moment the search is done. > > Bug: 1015841,1114020 > Change-Id: I09ba5e15b27371cf6a4aff2105a7bc8f4a33d706 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339996 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Rainhard Findling <rainhard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795996} TBR=dpapad@chromium.org,rainhard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015841 Bug: 1114020 Change-Id: Id824aca8bc74b52872e3986cc8b0cb5084183bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362936Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#800080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0f11b9355f5..81f4ba7e7dbf 2020-08-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9709b84237bdaba25ca876e8807799518ce84373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366243Reviewed-by:
-
Sreeja Kamishetty authored
This CL deletes all bfcache specific test filters after fixing/disabling the tests in various CLs. Bfcache bot is enabled on waterfall, this would prevent from filtering out failing tests with BackForwardCache and directly consider BackForwardCache during implementation. Bug: 1100315 Change-Id: I7696ceeccd7508f7f61a214d4d187f9fe3fa63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364512 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#800078}
-
David authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/JQTAos4h3Oa75AxNtHuNkrsTQWBJNw6CYEf6hBaQVWkC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200820_RC00.html Bug: b/327563303, b/327565472, b/327573527, b/327573581, b/327580703, b/327576696 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I22b654c486cda40b446e11ce9d37bda7d0a8a3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366257 Commit-Queue: David Lei <dlei@google.com> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#800077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/550dc4dab51d..1cb771bfe063 2020-08-20 alexrudenko@chromium.org Improve adorner test 2020-08-20 sigurds@chromium.org Query the model late for the target 2020-08-20 wolfi@chromium.org Add icon for not reachable top frame to frame tree 2020-08-20 alexrudenko@chromium.org Fix LayoutPane icon appearance in dark mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093247,chromium:1109177,chromium:1115421 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9e93304db6172dd6c76871507b3812feabe121ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366912Reviewed-by:
-
Arnaud Mandy authored
Taking in use new testharness.js API assert_implements instead of assert_true. Bug: 1119345 Change-Id: I4155d90968952e7bfa63a0c8755ba3c79e3145c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364494Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#800075}
-
Jit Yao Yap authored
When a Remote App's icon has not been downloaded, or the icon download has failed, a placeholder icon will be used. The placeholder icon is a gray circle with the app's name's first letter drawn over it. Bug: 1101208 Change-Id: I2c35e5dead98783004ce01aa00e87d6a98d8dca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359074 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800074}
-
Fergus Dall authored
This reverts commit 8db30317. Reason for revert: Corresponding concierge change has been reverted because it broke testing flows and we will be taking a different approach to specifying paths to trusted VMs. Revert this one too because it also breaks some testing flows and will need to be re-written anyone to match the new approach in concierge. Original change's description: > Reland "Start setting StartVmRequest.vm" > > This is a reland of 6d67f881 > > Original change's description: > > Start setting StartVmRequest.vm > > > > This is currently ignored by concierge when starting termina, but > > since termina can now be installed in multiple different locations we > > need concierge to start taking the value that chrome sets. > > > > Bug: 953544 > > Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126 > > Commit-Queue: Fergus Dall <sidereal@google.com> > > Reviewed-by: Nicholas Verne <nverne@chromium.org> > > Reviewed-by: David Munro <davidmunro@google.com> > > Cr-Commit-Position: refs/heads/master@{#795346} > > Bug: 953544 > Change-Id: Ib741759a5b61dc810d66c9d182131766247a5a30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341224 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Cr-Commit-Position: refs/heads/master@{#796450} TBR=nverne@chromium.org,sidereal@google.com,davidmunro@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953544 Change-Id: Iedc695989c7a3af01b57d5718dfc379796e3c3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366396Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#800073}
-
JunHo Seo authored
1. GCC doesn't support clang pragma. Below is an example: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] Fortunately, clang supports GCC pragma, even though some warnings are not compatible each other. 2. A warning "-Wdelete-non-abstract-non-virtual-dtor" is a clang-only flag. It looks like suppression "-Wdelete-non-virtual-dtor" is better because it is supported by both compiler. This CL changes to use GCC pragma, and suppress "-Wdelete-non-virtual-dtor" warning. Change-Id: I33e42f7465276e60729f9071af96693f57d0f2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366532 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#800072}
-
Camille Lamy authored
This CL adds CrossOriginOpenerPolicyReporting to runtime_enabled_features as an Origin Trial. Bug: 1116413 Change-Id: I61c475629034665fba464e15cab5ec3ab8304fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366778Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800071}
-
Anastasiia N authored
resources/chromeos/account_manager/ folder contains the following pages, which are opened from the different dialogs: - account_manager_welcome ("Sign in changed" welcome page) - account_migration_welcome ("Update your account" page) - account_manager_error ("Cannot add account" error page) Bug: 1111846 Change-Id: I60b3806b4651842ccc587851f2a948c3cd25acf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352882 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#800070}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ef0fb4c2707e..2d613f1e1be9 2020-08-19 fmayer@google.com Allow people register heap in static initializer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4c317217f2af70bb07b5561c5291e7dabcd98d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366240Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5cc965e1. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 49fd0e16 "Origin isolation: add initial popup WPTs" 9f52c7e4 "COOP: add reporting to redirects" f4e154cc "Origin isolation: finish off popup test coverage" a6460afd "[RTCInsertableStreams] Add support for readable/writable fields" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ia7e13543237bdaf2bf5ae0de69ecb97bbb9c9aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366277Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800068}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3434cb0b006d..a711c594b8cc 2020-08-19 antonikarp@google.com spirv-fuzz: add FuzzerPassAddCompositeInserts (#3606) 2020-08-19 antonikarp@google.com spirv-fuzz: Support pointer types in FuzzerPassAddParameters (#3627) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Ic25c5f594ffa7e95bb28e2d289b6110b542439d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366239Reviewed-by:
-
Alan Cutter authored
This CL adds a new "offline_manifest" field to default web app JSON configs. Example: { "app_url": "https://example.org/", "launch_container": "window", "user_type": ["unmanaged"], "offline_manifest": { "name": "Example", "start_url": "https://example.org/", "scope": "https://example.org/", "display": "standalone", "icon_any_pngs": ["icon.png"], "theme_color_argb_hex": "FFFFFFFF" } } This is to support installing default web apps on Chrome OS without spawning a WebContents and fetching the install URL of every default app. Additionally this is to avoid overwhelming the default web apps when every Chrome user is migrated over to default web apps instead of the current default Chrome apps. Design doc: https://docs.google.com/document/d/1pk8aLnp24AVsWwC6OaCgYZHGGqvyNxekB04rzuTGDVM/edit#heading=h.9f9lhtrsvs1k Bug: 1119710 Change-Id: Ibe36631e4dbb540165cd67944b5ec6c8a47e8a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352450 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#800066}
-
Alexey Baskakov authored
Scale factor of 2 is default on pixelbook, but it could be {1.0, 1.2, 1.4, 1.6, 1.8, 2.0, 2.2, 2.5, 3.0} My previous CL calculates scale factor as integer by mistake. It worked for 1/2/3 scale factors but not for fractional scales. This bug was found by glenrob@ while reading the code. We need this fix ASAP to merge into M85. Bug: 1119709 Change-Id: I451fd00c735d188f280632bcb4b14547c8964478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366259 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800065}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5dff6075d29f..dff47d5fdaac 2020-08-20 timvp@google.com Vulkan: Optimize MSAA using subpass resolve attachments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: FramebufferTest_ES31.*Blit*Test: Test: VulkanPerformanceCounterTest_ES31.MultisampleResolveWithBlit Change-Id: Ib9f7496ec05e2bc4d83e2e25ca8740f0b7e28ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366571Reviewed-by:
-
Swapnil authored
When the installation times are reported, it may be possible that we do not come across the previous stage and thus it would access the optional field to report the installation time which would then lead to a crash. It is safer to report the time when we are sure that the initial stage and the next stage are reported. For eg, it is possible to report the kComplete installation stage even when the extension fails to install. Bug: 1119352 Change-Id: I20a5ee31451106832f8f0791f95b78efb8b3d66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362803Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#800063}
-
Andrey Zaytsev authored
* Takes the user to the Sign in page when the passwords status is signed out, to the Password Check page when there are check results, and to the Passwords page otherwise. * Created a delegate interface for SigninActivityLauncher, so modularized code can launch a SigninActivity. Bug: 1070620 Change-Id: Ib7927a7f08819b6473630df6430be29535843cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352818Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#800062}
-
hscham authored
* Add copyright header to app.typemap * Remove HandleUrlListDeprecated in intent_helper.mojom; it was deleted on pi-arc and rvc-arc already (ag/q/I5a0c28adfc77fe68710b1efd3d8db02a156a25a4) BUG=b:147599855, b:149070836, 163091058 TEST=autoninja -C out/Default chrome Change-Id: I1b88c146327f165111462cd74c455ada12611892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352306 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Grace Cham <hscham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800061}
-
Sreeja Kamishetty authored
Previously, we have fixed all the tests with BFCache. This CL cleans all the tests in the filters. BUG=1102629 Change-Id: If7610d1327955d42daa3d8172d180b2684bb24b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354244 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
-
