- 12 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82e0d524143f..346dd53ac087 2020-12-11 ethannicholas@google.com Reland "Reland "Reland "Revert "Initial land of SkSL DSL."""" 2020-12-11 kjlubick@google.com [canvaskit] Remove filterquality on paint. 2020-12-11 bsalomon@google.com Revert "Add new SkCanvas methods for Android Framework WebView queries." 2020-12-11 brianosman@google.com SkSLSlide: Add shadertoy iResolution & iMouse 2020-12-11 egdaniel@google.com Store command buffer usages to GrSurface's on GrVkCommandBuffer. 2020-12-11 jvanverth@google.com Increase QuadEdge precision on all platforms 2020-12-11 brianosman@google.com SkSLSlide: Add geometry options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I9af1bfab027e2fe37776ea7680f665060e8945ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836380}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8bf9fbd7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/variables rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I16e4731a3cf12b0b800ead0fdb5a860ad445811a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586854Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836379}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607709601-325646cf3b47651e58817955f6116187a5cde36c.profdata to chrome-linux-master-1607731149-f9d7b6048f47267213c698b8417226050a69f328.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee67c91a4c64b41358f1230196ef69e87fe7d7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587627Reviewed-by:
-
Julie Jeongeun Kim authored
This is a reland of 9b07e5e0 with a fix of a failure on Linux MSan Test builder. Added an initial value for |action_data.target_rect| to AccessibilityTest.TestSelectionActionHandling. Original change's description: > [a11y] Add scrolling action to PP_PDF_SET_SELECTION > > This CL adds scrolling when PDFiumEngine::HandleAccessibilityAction > is called with PP_PDF_SET_SELECTION and the selection is not > visible since Blink triggers also scrolling with setting selection. > So, this change makes PDF document scroll the page when a selection > is set. > > AX-Relnotes: When SetSelection action is handled on pdf, it also > triggers scrolling if the selection is not in the visible area. > For instance, atk_text_set_caret_offset() on pdf scrolls the page > if the text is not in the view port. > > Bug: 993456 > Change-Id: I8323eff293b3216e2b862f8df3e896380b1c9945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573975 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: K. Moon <kmoon@chromium.org> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#835994} Bug: 993456 Change-Id: Ie7c683d062c50d4eade2b5fb4990bc6ca2be12ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586644Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#836377}
-
Chris Lu authored
Bug: 1152900 Change-Id: Id9b1db55a09487cf3e237d2d5de390c5afb9b5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587388 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836376}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dbfb3029b9ff..86263397d149 2020-12-11 tsepez@chromium.org Pass new flags to cppgc heap initialization. 2020-12-11 tsepez@chromium.org Roll v8/ 61f3e6140..c52956d09 (100 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156170 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I513306f17d1237a5ef067ee04d25e8a2ab4b88bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587405Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..778b2c216924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I02e120e4a0a487308f615fac30fc25fde22d56b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587504Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates AwViewMsg_SetTextZoomFactor to LocalMainFrame interface. Bug: 1157121 Change-Id: Ieece64440d74fe38b6e7ee6073f98f495aebe058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583667 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836373}
-
Patrick Noland authored
Bug: 1147581 Change-Id: I95664f5d6e28041143de27a1a7d2798b0ba5ae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586093 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836372}
-
Gordon Seto authored
Add switch to toggle high visibility mode in nearby_share_subpage. Screenshots: https://screenshot.googleplex.com/7gpoKJmsBx7GW9c.png https://screenshot.googleplex.com/Ak79VN82QFsGSkK.png https://screenshot.googleplex.com/6aVSR3FqyfvMRz6.png Fixed: 1154830 Change-Id: I2c59c8cb5a90ee7469eddfe04d691280044967d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584355 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836371}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d5c00517887..6798d1b9dc14 2020-12-11 yiorsi@gmail.com Fix: no space at the bottom of the image in ImageView 2020-12-11 cpinnamaneni@microsoft.com adding link support for markdownview 2020-12-11 chrche@microsoft.com [Loc] Migrate components to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1154783,chromium:11574664 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia153ef44fe3239e4f122608dfcd221568999baf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585662Reviewed-by:
-
Xing Liu authored
Read later needs to be added to ChromeCachedFlags. TBR=dtrainor@chromium.org Bug: 1157113 Change-Id: Ie6dc92314603df4e8e44cd684a74a9ad64f4f1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587622Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836369}
-
Rouslan Solomakhin authored
Before this patch, the expiration month, year, and CVC text fields in the CVC unmask dialog were all 45dp tall, which is smaller than the 48dp required for accessibility. This patch sets the minimum height to 48dp for the expiration month, year, and CVC text fields. After this patch,the expiration month, year, and CVC text fields are at least 48dp tall. Bug: 977272 Change-Id: I955bc9a4ca88e4d813119d7e1f3f1f697a27aafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585689Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836368}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..778b2c216924 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I534ce04cb32e1a241014f27a722c214776ea6374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587696Reviewed-by:
-
Tom Anderson authored
* Get rid of XEventDispatcher and just use XEventObserver. The difference is that 1. XEventDispatcher allows stopping of further event dispatching. However, this is dangerous because there's no guarantees of what order the dispatchers will run in. IIRC, this caused a subtle bug in the past that was difficult to fix. Stopping event dispatching is not necessary because all dispatchers already check if the event is meant for them or not. I checked the number of registered dispatchers, and it's less than 10 for the normal case, so performance isn't a concern either. 2. XEventObservers always run before XEventDispatchers. This is no longer relevant now that we've gotten rid of the "stop further dispatch" behavior from (1). * Change observer function signature from void WillProcessXEvent(x11::Event* xev) to void OnEvent(const x11::Event& xev) since the "XEvent" in "WillProcessXEvent" is misleading, since we're no longer using Xlib XEvents. Also "WillProcess" can be removed too since the corresponding "DidProcess" function was removed in the previous CL. Finally, pass the event by const& instead of by pointer to ensure dispatchers don't mutate the event, and to make it clear that the event will never be null. R=sky Bug: 739898 Change-Id: If7ce28514eb4207d8a58e71cb3e39d7ace336b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582832Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836366}
-
David Tseng authored
These tests appear to be stable on release and debug. R=akihiroota@chromium.org Bug: none Change-Id: I838022efab03c267f27e68b642ca3c0749935b37 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587689 Commit-Queue: David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#836365}
-
edchin authored
This test was already disabled for iOS 12 devices. But looking through the notes, it looks like it only affects iPads. Furthermore, I found it affects iOS 13 iPad devices as well. ios_chrome_settings_eg2tests_module_iPad 7th Gen 13.5.1 https://ci.chromium.org/ui/p/chrome/builders/ci/eg2-device-runner/2400/overview Nov 3, 2020 ios_chrome_settings_eg2tests_module_iPad 7th Gen 13.5.1 https://ci.chromium.org/ui/p/chrome/builders/ci/eg2-device-runner/2174/overview TBR=jlebel@chromium.org Bug: 1140400 Change-Id: I0ec87a993e01258051c0d9facbb6bbabd62f591e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587407 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836364}
-
Trent Begin authored
This change adds the captive portal routine and group to the connectivity diagnostics application. Bug: chromium:1142857 Change-Id: I64759b54a34ee2291ebdfac273da85f9157740fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583030Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836363}
-
Sammie Quon authored
This requires adding support to context menus to close without animation, otherwise it will still be visible as the default close has a fade out animation, and the screenshot will capture a near-opaque version of the menu. Accelerators by default will also close menus with fade out, so add the desk activation acclerator to the exception list and let the desk animation code handle the closing. Fixed: 991939 Test: manual Change-Id: I273042a216c651022215929594a2cedd1efecc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586013 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#836362}
-
James Vecore authored
Change-Id: Iafa6c4057fde064553ece03b3c90009184fbf868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578008Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836361}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bf3f26cf343..8093cb08ef89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056387 Tbr: alexmos@google.com Change-Id: Iccce963d4f19d0ed7feee154320c1a901e1eafbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587752Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836360}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607687924-42a73eb0331784066b7e53d64e9d9a239913c74b.profdata to chrome-win64-master-1607698715-e13d73f1fde8c8ea06b6de4bb97b90c11d1836bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I87f542471a2da868c78368896d73155384b72d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587390Reviewed-by:
-
Brian Sheedy authored
Moves the splitting of expectations based on staleness out of the output code and uses it to automatically remove stale expectations from the expectation file if specified by the user. Bug: 998329 Change-Id: I317ded44447203b8fddc2c6277ed3f5f5b66a0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585846Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836358}
-
Artem Bolgar authored
Dev and debug versions throw DCHECK in OnDecodeDone due to wrong syntax of logging statement: ``` FUNCTION_DVLOG(status.is_ok() ? 3 : 1) << ": " << status.code(); ``` The FUNCTION_DVLOG is defined as follows: ``` DVLOG(level) << __func__ << "<" << GetStreamTypeString() << ">" ``` The issue is that the condition "status.is_ok() ? 3 : 1" should become "level", but in reality, since there are no braces around it, it gets parsed incorrectly and the number "3" becomes a severity level (see base/logging.h), which corresponds to "FATAL" severity level, which ends up which crash / assert. Here is the code after preprocessor for that line 524 BEFORE the fix: !(((status.is_ok() ? 3 : 1) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code(); and this is the fixed version: !((((status.is_ok() ? 3 : 1)) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code(); Pay attention to this part: LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream()) and LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream()) So, basically, before the fix the negative sign is applied to the wrong statement, therefore the LogMessage will get +3 instead of -3. +3 means FATAL, while -3 means verbosity level 3, as far as I understand. Fixed: 1157701, 1156942 Change-Id: I3132dde1dbd7d18460b74715016b74228e52ad7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586656Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Artem Bolgar <artyom@fb.com> Cr-Commit-Position: refs/heads/master@{#836357}
-
Alex Moshchuk authored
Bug: 1157263 Change-Id: I0a02c2db8ec6a68f0fe2dec26269d72db9d9653e Tbr: mlamouri@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587208Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836356}
-
Julie Jeongeun Kim authored
This CL updates DCHECK for checking the child count of the text field on GetTextContainerForPlainTextField(). The text field could have a sibling of the static text when it has a placeholder break element. So, this change increases the child count. AX-Relnotes: n/a Bug: 1137292 Change-Id: Ib6d6826ce23156e8d5562d9561ad8061d46b6946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578718 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836355}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/ccc67252ffa4..4226b6a1d8bf 2020-12-11 dsinclair@chromium.org Add Symbol to alias. 2020-12-11 dsinclair@chromium.org Add a symbol to the Identifier AST node 2020-12-11 dneto@google.com spirv-reader: refactor, add ToI32 helper 2020-12-11 dsinclair@chromium.org Add a demangler 2020-12-11 dsinclair@chromium.org Add a symbol to the Function AST node. 2020-12-11 dneto@google.com spirv-reader: Support multisampled textures 2020-12-11 bclayton@google.com ast: Merge DecoratedVariable into Variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I9d45cf7cfdfb89b15e9d4df07b3ac40a8c818f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587223Reviewed-by:
-
Fergal Daly authored
It was very surprising to me, in a NavigationRequest for a subframe, that these are not the previous URL of the subframe that is navigating. Bug: 1068965 Change-Id: I9765f176fc7dacffa522a80d520ec5660ea175b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230428 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836353}
-
Chris Lu authored
Updates to the insets in response to rotations are necessary for iphones with notches so that they match the new intrinsic safe area insets. Bug: 1151932 Change-Id: I2405550da8e9d75899d422ea58a63d54b6780b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568543 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#836352}
-
edchin authored
This reverts commit 32c3c769. Reason for revert: ReadingListTestCase/testSwipeDownDismiss is failing again. Oct 21 2020 https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-sdk-simulator/510/overview Dec 11 2020 https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-sdk-simulator/712/overview Original change's description: > [iOS] Reenable disabled test > > It seems to pass now. > > Fixed: 1129589 > Change-Id: Id2fd68a6e3f860f593871c4a223bc0a8f034cefd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460825 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815142} TBR=olivierrobin@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id32622132efa0535dff419886cf859b18594b074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587697Reviewed-by:
-
Natalie Chouinard authored
Move ChromeStartupDelegate instantiation to after the native FeatureList is initialized. Bug: 1158020 Change-Id: I782eb5750078e7f56aa4f1d540c88b03231c0503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587621Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#836350}
-
Alexander Cooper authored
There were currently two issues with the lighting estimation page: the ambient light was brighter than expected and the reflection map wasn't being rendered onto the sphere. The first issue was likely a result of the sphere's texture having 0 "metalness" and thus being more "stone" like. This caused the light to get applied to a broader area, and thus made it seem more washed out. In addition, we now also set the intensity of the light probe to 1 each frame. While this likely doesn't impact the ambient light intensity, it is a better pattern having it mirror what happens with the directional light. The second was partially due to the metalness value (nothing reflects with a metalness of 0); however, the environment map wasn't actually getting set up in Three's renderer. There's also two additional issues that are fixed here. The first is that the reflectionchange event was incorrectly subscribed (both the name and to the wrong object). However, even with that fixed there is some form of known issue with the event, that means we instead need to rely on a simple interval timer. Finally, this change also ensures that the appropriate GL extensions are enabled for the two possible texture types that we support. Fixed: 1151501,1151491 Change-Id: Id6ff4f5e4cc237a5e9c4a8aefb82a96827a48205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587554 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836349}
-
Takumi Fujimoto authored
Change-Id: I4ae5949e13899a09f2d1471902d8ea2112476469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587557 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836348}
-
Mila Green authored
There are 2 issues being fixed here: 1. base::ReplaceFile is used to move the downloaded file from the temp location to the desired file location. base::ReplaceFile fails if the temp file and the destination file are on different volumes. Using base::Move instead, as it doesn't have that limitation. 2. Getting the size of the downloaded file directly from the NSURLSessionTask instead of from the file system. Bug: 1153304 Change-Id: I6d38a34a9893e2dfb59d605f657b42d381ec9e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583338 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836347}
-
Koji Ishii authored
Bug: 1154531 Change-Id: I28fae7f200063d3f6abf29f8bca0ec143e33f520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586292 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#836346}
-
rbpotter authored
Bug: 1158048 Change-Id: I68b7a7ecacd407bde2a331681ad36a53f74f159c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572676 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836345}
-
Rahul Arakeri authored
Context - This CL is specific to Impulse-based-scrolling [1]. Design doc summary is that if the flag is turned on, scroll animations will use a different curve. (i.e the new curve is also Bezier based but with different control points). The CL that added this new curve is crrev.com/c/1901628. Problem - The new curve causes minor jerks for flings on non-PTP touchpads that send WM_MOUSEWHEEL(s). The reason this happens is because the steep initial slope of the curve. Fix - Start off as an impulse based curve but when subsequent GSU(s) come in, update the curve to the old ease in/out style curve. That way, individual mousewheel ticks, keyboard presses, scrollbar clicks will still feel impulse based and the fling will be smooth. Misc - Why can’t we just fix this by changing the control points on the new Bezier curve? If we do this, we’d be changing the personality of the Impulse curve itself which defeats the purpose of adding this new curve in the first place. [1] https://docs.google.com/document/d/1A3VmlY3ZR6UtJt3QQ5uuqaCOgPjV6vCMxvkpvPBe0g0/edit#heading=h.ji0n9h8v0xez Bug: 1157698 Change-Id: I91b90080f6eac4c268f443daf2345716374a1927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553869 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#836344}
-
Jeffrey Kardatzke authored
This adds support for Widevine L1 HW decryption support on Chrome OS to the key systems. It also adds explicit support for encrypted HEVC to the supported type checker used by the key systems if the corresponding buildflag is on. BUG=b:153111783 TEST=Widevine UAT site plays for HEVC and other codecs w/ HW_SECURE_ALL Change-Id: I35c6ae35b6aafa9704524d6be05201e74e3a2748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580321Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#836343}
-
Ben Pastene authored
These instructions should let folks manually symbolize any Chrome crash dumps generated during Tast tests on bots, which will make test debugging a bit easier. Bug: 1155738 Change-Id: I5cd9f11d53721b82fd23003d1f89c6e921a0a122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587583Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#836342}
-
Victor Costan authored
The current comment is slightly misleading, causing extra code review round-trips. Change-Id: I899147eab2bc3afdb2717955ad0f2cc4d31524ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582817 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836341}
-
