GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f76613520ff..b5aaf6416b08


Created with:
  gclient setdep -r src-internal@b5aaf6416b08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ia3cc2fe3d3203aad38975a9cf06f2785fc546343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884632Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710216}

This reverts commit 5cd504f9.

Reason for revert: Failed NTPHomeTestCase tests. crbug.com/1019070

Bug: 1019070
Original change's description:
> [iOS] Convert NTPHome test to EG2
>
> OmniboxWidth and OmniboxWidthBetween are moved to the egtest.mm file
> directly to avoid having a more complicated interface.
> Suggestions() uses are replaced by -addNumberOfSuggestions:
> additionalSuggestionsURL:.
>
> Bug: 987646
> Change-Id: I58535b52919fbd1d907c8a72c611e2fbb7f63f67
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871888
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709521}

TBR=eugenebut@chromium.org,stkhapugin@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 987646
Change-Id: If3418f1cc097867fa1ef011d5036f171c3cc3fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885971Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710215}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 1018887
Change-Id: Ifd7c2f17a6be0dcc075020d090f62af299d46708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885012
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710214}

https://chromium.googlesource.com/angle/angle.git/+log/6f23b4b7038e..e78527989c4c

git log 6f23b4b7038e..e78527989c4c --date=short --no-merges --format='%ad %ae %s'
2019-10-29 jmadill@chromium.org Vulkan: Clean up redundant vk:: prefixes.
2019-10-29 jmadill@chromium.org Vulkan: Move readPixels logic to ImageHelper.

Created with:
  gclient setdep -r src/third_party/angle@e78527989c4c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I12cfa5fd4c73df18c7e3218db6a9beb9ebcdc3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710213}

This CL converts URLLoader from //content to new Mojo types
using PendingReceiver and Receiver.
It also updates CreateLoaderAndStart from url_loader.mojom
and implementations for it.

Bug: 955171
Change-Id: I3c3b12774e22c1aa239b22e1a86d7018e2259f9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880987
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#710212}

Using wpt-import in Chromium 3b57a5e8.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I048adc3ebb19a8c357119a766f5a0a0de7432c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884771Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710211}

Now group previous multiple virtual test suites with the same
prefix and args together.

For example, previous configuration
  {
    "prefix": "composite-after-paint",
    "base": "compositing",
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }
  {
    "prefix": "composite-after-paint",
    "base": "paint",
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }
now becomes
  {
    "prefix": "composite-after-paint",
    "bases": ["compositing",
              "paint"],
    "args": ["--enable-blink-features=CompositeAfterPaint"]
  }

This shortens VirtualTestSuites by nearly half, avoids accidental
inconsistent args (We should create different virtual test suite
for different args), and allow "pure physical" virtual test suite
which is an alternative of physical test suite.

A "pure physical" virtual test suite has empty "bases", and the
"virtual/<prefix>" test path contains real tests only.

Normal vitual test suites can still contain real tests.

Bug: 1014162
Change-Id: I8d24be0e62b44ec8987aef65cb6f9ff0423b2d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873504
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710210}

BUG=976952, 958020

Change-Id: Ied9361ae735c702b3989eb18ab36bf579917bf45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877651Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710209}

I forgot to normalize the app IDs feeding into the Roselle model at
inference time, leading to some (not all) apps erroneously never being
ranked by the model.

Bug: 1019068
Change-Id: I0288c3cf591b92f9f0a9c356630b2212d29d16a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885852
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710208}

Bug: 1015141
Test: policy_test_cases.json
Change-Id: I0865bc5cf631b142388ed52a3e35f492d6edd468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865769
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710207}

We follow https://html.spec.whatwg.org/C/#dom-tabindex by this CL.
The old behavior of default tabIndex was something like "Returns 0
if the element is focusable, -1 otherwise". But it didn't match to
the HTML standard, and was not interoperable.

Since this CL, some elements return -1 if "tabindex" attribute is
missing or invalid regardless of their focusability.

Implementation:
Node::tabIndex() is not a virtual function any longer. We have only
Element::tabIndex(), and it calls virtual DefaultTabIndex() if
"tabindex" attribute is missing or invalid.

DefaultTabIndex() for elements listed in the specification returns 0.
Otherwise, it returns -1.
 - HTMLAnchorElement affects <a> and <area>
 - HTMLFormControlElementWithState affects <input>, <select>, and
   <textarea>.
 - HTMLFrameElementBase affects <frame> and <iframe>

Blink can't use Element::tabIndex() for the purpose of focusability
check any longer.  This CL updates existing tabIndex() callsites to
avoid behavior changes.

Change-Id: Ib1728d6be98ccf589fc0e3e153d07eb973532e25
Bug: 982350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883350Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710206}

This does the move by removing the blacklist checks for commit-time
previews from the navigation start portion and will be checked for
real at ShouldCommitPreview

Bug: 1018799
Change-Id: I04248c87176376586c7ff07b8ff7c5bcea68c265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885637Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710205}

This fixes a bug where modules can miss an ABI and fail the bundle
packaging step. This is due to two factors:

1. crrev.com/c/1876975 added an allotment step to each bundle that
   determined in which module native libs are packaged into. If a module
   only depends on libs that are also depended on by other modules this
   module will package no libs even though libs are specified when
   instantiating the module target.

2. Bundletool requires that all modules support the same set of ABIs.
   To make modules appear to support the WebView ABI for Monochrome and
   Trichrome we add placeholder libs for the WebView ABI. We do this in
   the chrome_feature_module template if we specify real libs for the
   browser ABI.

Given 1. and 2. it can happen that a module is only left with the
placeholder lib and appear single ABI, failing packaging. This CL fixes
that by telling the packaging step that the module should be multi ABI
and the packaging step will add a placeholder lib if necessary. This
makes placeholder logic in chrome_feature_module obsolete and therefore
it is removed.

This new multi ABI logic can likely be reused for other APKs that use
lib placeholders simply to make the APK multi ABI.

Bug: 870055
Change-Id: I25cf4edd56bf253cff2aef54d1857cbe9167cae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881814
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710204}

Bug: 1003238
Change-Id: I829684e1b9959948c3deb70649ce590aac6347c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877500
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710203}

Change-Id: Ie15668cb56f165060f85d6fa11735b6823ad1793
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877872
Auto-Submit: calamity <calamity@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710202}

This CL converts PlatformVerification{Ptr, Request} in media and
chrome to the new Mojo type.

Bug: 955171
Change-Id: I5d40f530680578cadb21be430b85ef096d55e7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883267
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#710201}

* fixes .role = ...; vs setAttribute(role, ...) booboo
* makes #realbox politely live so that up/down utter something

R=dpapad@chromium.org

Bug: 1017915
Fixed: 1017877
Change-Id: I9ed26ebe0ff3fe9cfa71ee4a9d2f73e80c28e101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885631
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710200}

This CL fixes an issue where the app list would launch new instances of
the Settings App because it didn't run through the same System Web App
launch code path that the rest of Chrome OS does.

Bug: 1012558
Change-Id: I60aead0adee4cc13082648ae67a50a03f811f673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868354Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710199}

Although EncodeJob is treated with scoped_refptr, its ownership is not shared at
all. Therefore, this CL lets EncodeJob treat with std::unique_ptr in order to
clarify its ownership and improve a performance a little bit.

Bug: 1016219
Test: vaapi_video_encode_accelerator_unittest on atlas
Test: https://appr.tc/?debug=loopback&vsc=vp8
Change-Id: Ib7f5c5fda806b11e590e9dd219c585900ae52b57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874992Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710198}

This is needed for Page Controller or other UI-Automator based tests that can't
use the CommandLineFlags mechanism.

Bug: 1009529
Change-Id: If0364f37c2fe3f49e2111c2ed505fd4ed9392e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860144
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710197}

This CL converts DemuxerStreamPtr and InterfaceRequest<T> in media to
the new Mojo type.

Bug: 955171
Change-Id: Ia10bed44d9133f3e15ad16d724e95db6c6e945ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882258
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#710196}

* Add a basic main activity that shows some info about the webview
  package in use:
  - WebView package name.
  - WebView version name and code.
  - Device build fingerprint.
* Use activity action bar menu to provide navigation options to other
  existing webview dev UIs, Crash UI in this case.
* Use device default theme for more natural look.
* Copy info content to clipboard when tapped.
* Add the shared navigation menu to Crash UI, and show the refresh
  option outside the menu "ifRoom" available.
* Set DevUI activities launch mode to be "singleTask" and "SingleTop"
  for more intuitive navigation.

Fixed: 981154
Test: Manually verify it on SystemWebView and Trichrome on Android Q and MonoChrome on Android P
Change-Id: I61dbcbb714b1b5a18cc4a61a894257a77bcd20b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877267
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710195}

Bug: 963165,1001566
Change-Id: I507240025a8fd0870f5b6e4e7c860441c7564826
Fixed: 998976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881713
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710194}

This lets BundledExchangesReader use a Data Decoder service created
with content::LaunchDataDecoder(), instead of going through Service
Manager.

Bug: 977637
Change-Id: I0b96ef8ab29e7823400acf813ac91c650e254273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875350Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710193}

To migrate rule-based to Chromium C++, we need to have a separate code
path for the official XKB keyboard. The new code path needs to use Mojo
directly instead of sending extension messages.

Currently, IMF communicates to the extension via an "IME observer" which
takes native events like OnActivate and converts them to extension API
events.

To start off this migration, we create a new IME observer that basically
intercepts events from IMF and forwards them to the existing
extension-based IME observer. This allows us to migrate event-by-event
by routing a certain event directly to the IME service instead of
through the extension system.

In this CL, we hook into the OnActivate event to create a connection
to the IME service. All events are still forwarded to the old extension
system, so nothing should change.

In a followup CL, we will route OnReset directly to the IME service
as our first migration.

Bug: 1009903
Change-Id: Id4df50c8688474c76a498f5f2746f9ad2cbadabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847701
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710192}

https://chromium.googlesource.com/catapult.git/+log/28ef213de9e5..090f35f08a00

git log 28ef213de9e5..090f35f08a00 --date=short --no-merges --format='%ad %ae %s'
2019-10-29 bsheedy@chromium.org Deduplicate desktop/CrOS minidump code

Created with:
  gclient setdep -r src/third_party/catapult@090f35f08a00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:994274
Change-Id: I806f9dd18b9c67366277afeac8c69349a49a10e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710191}

BUG: b/143232594

Change-Id: I76b160ad565649db32a21b984fbed1594b0ae6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875347Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710190}

I previously changed the --primary-color to a light gray for dark mode,
but didn't update the highlighted text when one links to a flag via

chrome://flags#deep-link

Which highlights the background in yellow (which looks bad and has
terrible contrast with light gray in dark mode).

Just force dark mode into the same light mode UI for this. Screenshot on
bug.

Fixed: 999031
Change-Id: I34b3933a08d96523eeac9bdd1a80b91e402b96bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885344
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710189}

The crash used to happen when a transient popup child is
added to a window while alt-tab window cycling is active,
and cycling stops before that transient is removed.

This CL fixes the crash and adds a test for it.

BUG=1014543
TEST=Added a new test that crashes without the fix.

Change-Id: Ib3abf9aee9332859ea00e6a54d3f8fc93d00449f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885496
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710188}

TBR=rsesek

Bug: 961769
Change-Id: Id991ef7b9a5b85313ee62fb711cafad7ac6967c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885651Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710187}

CL produced with ESLint --fix and clang-format.

This is in preparation for turning on the 'prefer-const' ESLint rule for that
folder.

Bug: 720034
Change-Id: If8287f806766c6addfe8ca32753f50ba3a5d29fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884764
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710186}

This CL converts old Mojo types to the new Mojo types
in P2PSocketClent. To apply them, this CL needs to
migrate P2PSocketManager::CreateSocket as well.

  - Convert FooRequest to mojo::PendingReceiver.
  - Convert FooPtr to mojo::PendingRemote or mojo::Remote.
  - Convert mojo::Binding to mojo::Receiver

Bug: 955171, 978694
Change-Id: Icc242028f6ef440de2fe3b3febbca91e3f3e0a31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877787
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710185}

This CL applies pending_remote to RequestNotifications in
NetworkChagneManager interface.

  - Convert FooPtr to mojo::PendingRemote or mojo::Remote.
  - Convert mojo::Binding to mojo::Receiver

Bug: 955171
Change-Id: I3b730b082bdb64b8b49c7df181bb2fb3bd0e7eb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883951
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710184}

The registration dialog is only shown when offering opt-in and during the fetch
challenge call. Any other scenarios, it is not showing. This fix updates the
dialog only when it is showing, to avoid any nullptr issues.

Bug: 949269
Change-Id: I26b850ac4e7e51bf32a62a2a967a803b3ffe9479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885101Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#710183}

CL produced with ESLint --fix and clang-format.

This is in preparation for turning on the 'prefer-const' ESLint rule for that
folder.

Bug: 720034
Change-Id: Idbe5bf109d7e547a8c309e5596f226a7616be936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885550Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710182}

This CL adds a few UMA metrics to track the top-level functioning of the
BinaryUploadService.

Bug: 1017333
Change-Id: I02767b09182ccdef2b9cfd531fd40d9c6fab782a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884283
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710181}

This metrics will help us understand how long users clicks a play store
result after seeing it, and what is the right value of the latency for
play store result impression. Right now we just guess and pick a number
(1 second).

Bug: 1016026
Change-Id: Id148ca9f2056eb93e74056b664783753913bc5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879206Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710180}

WebUI handling in the navigation code is more complex than necessary at
this point in time. The navigation model has changed to require each
WebUI to be isolated from the rest in r681094, which means we no
longer need the concept of pending WebUI on the RenderFrameHost.

This CL also removes the restriction of WebUIs being created only for
main frames, enabling support for site isolated WebUIs in subframes.

Bug: 557116, 713313, 1002276, 1005506
Change-Id: I996550c6611f5d327d87189dbb88ff657bdc709c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853865
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710179}

This unifies the ImageFetcher into the mediator (ensures we keep
only one copy) and unifies the cleanup logic.

This does decrease the cache size of the Entity images.  Previously,
entities used a 20mb limit, and answers 5mb.  This converges on the
answer limit.

BUG=1015997

Change-Id: I84f23c1b1150f9e651516b946ba2de265f2345f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879815
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#710178}

which I removed in https://crrev.com/c/1850273 because
some EVT devices still have this bug in their panel.

Bug: b/74845106
Test: none
Change-Id: I71fb2d461aef10ccd9889638e99cb16dc2d1570f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885259Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710177}