- 14 May, 2018 40 commits
-
-
Chris Kuiper authored
This is a temporary change until P becomes available which makes this a public function. Bug: internal b/76437011 Test: verified via volume table dump at Cast startup. Change-Id: Ie3d736f70429147dfd30c4abb8f9311c0d82c83f Reviewed-on: https://chromium-review.googlesource.com/1031100Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#558334}
-
Charlie Harrison authored
It also looks like we can remove the ShouldBeginRequest from RDHD, which I've done here. TBR=pasko@chromium.org Bug: 841473 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I238fe589cc192ccec47242350e6bc847f8da65cc Reviewed-on: https://chromium-review.googlesource.com/1052889Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558333}
-
Wez authored
ResourceDispatcherHostImpl is a UI-thread-owned class which also does work on the IO thread. It is built to intrinsically rely on being destroyed only after all threads but the main thread have been torn- down - the BrowserMainLoop invokes a Shutdown() API which posts a task to perform teardown of state which is used on the IO thread, which is thereby guaranteed to have run before the object is deleted. Internally a WeakPtrFactory is also used, to ensure that replies posted to the object on the IO thread are dropped if the object has already performed its IO-thread teardown. However, although the WeakPtrs were bound to tasks run on the IO thread, the factory itself was being left to implicitly InvalidateWeakPtrs() on destruction (i.e. on the UI thread). This CL adds explicit InvalidateWeakPtrs() on the IO thread, during the IO-thread teardown task. Bug: 729716 Change-Id: Idce31d52476df529dd5a877dc06747426c4e19c6 Reviewed-on: https://chromium-review.googlesource.com/1056255 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Alexandros Frantzis authored
Add an unowned GpuFence parameter to the GLImage::ScheduleOverlayPlane method and forward it to internal consumers (e.g., NativePixmap) where needed. Bug: 828393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I195f4ee9d0a9af886cb12ce27d2ce26ebd47684a Reviewed-on: https://chromium-review.googlesource.com/1021511Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#558331}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5140f9a8e424..4c3cb3767f5a $ git log 5140f9a8e..4c3cb3767 --date=short --no-merges --format='%ad %ae %s' 2018-05-13 reed implement SkScalar versions in terms of float versions 2018-05-14 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 5fd1cfaae..2a0def7f6 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ib7de6e241cc17f43b75a2181d6d3a3efd3e229f9 Reviewed-on: https://chromium-review.googlesource.com/1057361Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558330}
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the GetNearestFindResult function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CLs: Mojoify FindInPage::FindMatchRects (parent of this CL) crrev.com/c/1049770 Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: Id4852ed3902128594f3a29f7aa55d80d7f1f9a06 Reviewed-on: https://chromium-review.googlesource.com/1051143 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558329}
-
Adithya Srinivasan authored
Bug: 781655 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I1345c5084f5dfe6788710d96d37103125f6cb6c0 Reviewed-on: https://chromium-review.googlesource.com/1036230Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#558328}
-
Friedrich Horschig authored
With this CL, the KeyboardAccessory is wired up to add icons of provided tabs to a TabLayout that replaces the previous Recyclerview. The existing LazyViewBinder is used to simplify the old implementation. Bug: 828832 Change-Id: I60569a3be6c99c23cc17b9838967ef3ab0a1c8df Reviewed-on: https://chromium-review.googlesource.com/1047669 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#558327}
-
Alexandr Ilin authored
The autocomplete predictor database contains entries related to a page the user has visited even after this page was removed from the history. These entries are cleaned up after only the startup. This CL adds this clean up after every removal from history. Bug: 838897 Change-Id: Ia56de868cddf8bb0a28d288265b884c0e67458d5 Reviewed-on: https://chromium-review.googlesource.com/1043868 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#558326}
-
Gauthier Ambard authored
This CL adds the accessibility labels and ordering for the popup menus. Bug: 833425, 842032, 831587 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I06bd6821144aee96c47374fd44e4a811831fc704 Reviewed-on: https://chromium-review.googlesource.com/1057307 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558325}
-
François Beaufort authored
As part of the origin trial, we should record usage with UseCounter, as that can be automatically monitored by the origin trials infrastructure. Bug: 806249 Change-Id: I7978d33f57c9d31ecc2b18a410c66475f3971ddb Reviewed-on: https://chromium-review.googlesource.com/1055396 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#558324}
-
Liquan(Max) Gu authored
User Timing L3 allows user to use arbitrary timestamps and add custom information for performance timeline (performance.mark and performance.measure). This CL implements the performance.measure part of Custom User Timing, Basically, it allows custom start and end timestamps of performance.measure, and support passing in custom details via an overloaded API. The new feature is hidden behind a runtime-enabled-flag called "UserTimingL3". This feature is set to <Missing> status. Bug: 758385 Change-Id: I5722f5e99a0188e3a5b191bf3bfe007e8b274086 Reviewed-on: https://chromium-review.googlesource.com/871507 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/2157d8fa6f7e..9e345c911714 $ git log 2157d8fa6..9e345c911 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 alan.coopersmith Further fix to visibility flag testing with Solaris Studio compilers. 2018-05-08 wl [autofit] Avoid potential SEGV if running out of memory. 2018-05-07 madigens CMake: Allow using project as subfolder in other project 2018-05-07 wl [build] Suppress configure's `nothing to be done' message. 2018-05-04 mpsuzuki Support symbol visibility features of Sun / Oracle C compilers. Reported by Kiyoshi Kanazawa: https://lists.gnu.org/archive/html/freetype-devel/2018-05/msg00008.html Thanks to the suggestions by Alexei and Alan Coopersmith. 2018-05-02 madigens Unbreak CMake Windows installation 2018-05-02 wl Remove FT_CONFIG_OPTION_PIC and related code. 2018-05-01 wl * Version 2.9.1 released. ========================= 2018-04-26 wl Another fix for handling invalid format 2 cmaps. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1084 Change-Id: Id8538bd3a13b2b8dd504a7de3d737b13104e7c7b Reviewed-on: https://chromium-review.googlesource.com/1055728Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558322}
-
Ryan Sleevi authored
https://crrev.com/550137 introduced base::data(), along with a specialization for strings to return mutable pointers. Update callers of base::string_as_array() to use base::data() instead. Note that this does come with an observable behaviour change: string_as_array() returns nullptr for empty strings, while base::data() returns the pointer to the NUL terminator (in line with std::data()). However, this can be observed to be safe from the existing callers, due to the preceding resizes that ensure non-empty() strings, or the existing logic to handle empty strings. Bug: 828324 TBR=caitkp@chromium.org, lazyboy@chromium.org, miu@chromium.org, sergeyu@chromium.org Change-Id: I1fb5824b7115ff2b9ebf032f74a860e4cf3f52c6 Reviewed-on: https://chromium-review.googlesource.com/1056014 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/66aafcb4641c..5d2ccc534d26 $ git log 66aafcb46..5d2ccc534 --date=short --no-merges --format='%ad %ae %s' 2018-05-14 hans Use DefWindowProcA for window created with CreateWindowExA Created with: roll-dep src/third_party/angle BUG=chromium:842408 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I01da66d6a726675f2362ecc4206c1ae11578d247 Reviewed-on: https://chromium-review.googlesource.com/1057357 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558320}
-
Florent Castelli authored
The bug it was blocked on is now fixed, merging with the other tests. Bug: webrtc/9141 Change-Id: If662ef9dfc4f58c0d8d43b41d32f745212ef462f Reviewed-on: https://chromium-review.googlesource.com/1057668Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558319}
-
Sahel Sharify authored
This cl adds the equivalent of fling traces in InputHandlerProxy to the FlingController class. Bug: 249063 Change-Id: I6a5478d6e02fe47f729b8310659997eb4b4dc485 Reviewed-on: https://chromium-review.googlesource.com/1052900Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558318}
-
Devlin Cronin authored
Change the default behavior of the kRuntimeHostPermissions feature to allow extensions to have origin access, rather than defaulting to withholding permission. In the first stage of click-to-script, we don't want to change any defaults. Reland notes: the original patch caused ExtensionApiTestWithManagementPolicy.WebRequestProtectedByPolicy to fail because it relies on the permissions being withheld, but the patch didn't update it with a call to withhold permissions. TBR=karandeepb@chromium.org Bug: 841099 Change-Id: If913aee7e14b7ea89c751528b8402d07a514b047 Reviewed-on: https://chromium-review.googlesource.com/1057433Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558317}
-
Emily Hanley authored
Change-Id: Ie6fcc3e9140da5232e10583db2fc7f85c1d928b8 Reviewed-on: https://chromium-review.googlesource.com/1057350Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#558316}
-
Evan Stade authored
When a notification was updated (same ID, new properties), the appearance --- title, image, etc. --- was updated, but the old delegate wasn't replaced with the new delegate. Fix that and add a test. Bug: 840105 Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3 Reviewed-on: https://chromium-review.googlesource.com/1056091Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#558315}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/162ca8aa..d936a701 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4d77ac7bcd040a15ae4de27d9ed252f7732263f3 Reviewed-on: https://chromium-review.googlesource.com/1057411Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558314}
-
Rayan Kanso authored
Update the backgroundfetchfail & backgroundfetchabort event types to instantiate BackgroundFetchUpdateEvent & BackgroundFetchSettledEvent respectively. https://wicg.github.io/background-fetch/#service-worker-global-events Bug: 822765 Change-Id: Iea5311fdbedf805ec8d4d54daca0257078dc050d Reviewed-on: https://chromium-review.googlesource.com/1005177Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558313}
-
Doug Horn authored
This API changes in AT O. Bug: internal b/77915277 Test: Compile Change-Id: Id3c651378d9ac12319cd5aa437e9c56d48ea3096 Reviewed-on: https://chromium-review.googlesource.com/1033472 Commit-Queue: Doug Horn <doughorn@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558312}
-
Hitoshi Yoshida authored
Before this CL, overload resolution algorithm was based on old version, and had some Blink specific customizes. This CL updates it to be almost compatible with current spec, except for types that Blink does not support. Bug: 828401 Change-Id: Ia2ee07a08f45390f39258268608fd71fdd06da89 Reviewed-on: https://chromium-review.googlesource.com/1013798 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
erikchen authored
This is a speculative fix for Chrome being unusable after unlocking the machine after several hours/days of not being used. Our current best theory is that the browser process goes to sleep but the renderer keeps running [and sending IPCs]. When the browser wakes up, it must spend all its time processing those IPCs, many of which involve writing to disk. Bug: 808031 Change-Id: Iff94f6a14cb3f3037ba43da19f32cec915b9fdb3 Reviewed-on: https://chromium-review.googlesource.com/1057458Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558310}
-
Rayan Kanso authored
Modify Cache Storage API to include an ownership field. This gives the ability to create private caches for internal usage, without exposing the cache entries to developers. The ownership enum will be part of the key for cache storage map look-ups. The ownership enum will also be part of the path where the cache is saved to disk. This way we can have more than one cache for the same origin, and they are written to different places. All caches will update the same quota client. TBR=kenrb@chromium.org,mek@chromium.org Bug: 838908 Change-Id: I5494d696d9837abbbe2ef428be0f03e4360f2bda Reviewed-on: https://chromium-review.googlesource.com/1037264 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558309}
-
Justin Cohen authored
Speculative fix for pre-Refresh content test failures. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I743bb7e99a702ea300f0505d6d64a87b906db383 Reviewed-on: https://chromium-review.googlesource.com/1057460Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558308}
-
Bence Béky authored
Change-Id: I16c960c107169bf1ae254587926c02349844a7a2 Reviewed-on: https://chromium-review.googlesource.com/1057412 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#558307}
-
Dan Sinclair authored
Bug: chromium:839695 Change-Id: I062d9a97559a4d26062e8a4932527765f06025a4 Reviewed-on: https://chromium-review.googlesource.com/1050584 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558306}
-
Peter Wen authored
This way Android Studio makes use of our existing android ndk rather than having to download a whole new ndk in third_party/android_tools. Bug: 840542 Change-Id: Idcf06675f5e5f74cd860570102c38ae20dd97807 Reviewed-on: https://chromium-review.googlesource.com/1054439Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558305}
-
Boris Sazonov authored
This reverts commit d4c4b89c. Reason for revert: broke official build on Android. Builder link: http://uberchromegw/i/official.android/builders/official-arm/builds/3206 Original change's description: > Add ruleset indexing action as data_dep to telemetry tests > > This allows telemetry to have access to an indexed ruleset, without > having to specify one in the source tree (which would need to be > updated every time the format version changes). > > Follow-ups will copy this into telemetry's user-data-dir. > > Bug: 823982 > Change-Id: Iba551b1cd6137d73bed8dfbb0bc69d00f32be7ab > Reviewed-on: https://chromium-review.googlesource.com/1052860 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557855} TBR=jkarlin@chromium.org,nednguyen@google.com,csharrison@chromium.org Bug: 842573, 823982 Change-Id: I954fcbaec79ace212d252864f8d48c115a28cd37 Reviewed-on: https://chromium-review.googlesource.com/1057308Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Andrew Grieve authored
This generates an html report that shows java method counts rather than binary size. Change-Id: I6d6ba23969fa495e714ea3d1264cd1dbf61bd4bc Reviewed-on: https://chromium-review.googlesource.com/1055855Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#558303}
-
glevin authored
As per crbug.com/788026 Comments 1,11: - Change title text - Consolidate text into one paragraph - Remove excess whitespace near bottom - Width = 448px - Remove X (Close) button from upper right Bug: 788026 Test: Set whatever policy is needed to disallow multi-signin from an account, try signing in from that account, observe Harmonious dialog. Change-Id: I1b5f2d2bf3ae092a28aa8ee48069cfead7c1559d Reviewed-on: https://chromium-review.googlesource.com/944258Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558302}
-
Peter Wen authored
Bug: None Change-Id: I7b802032b414404bb6604d155c7c78f7b3437e3c Reviewed-on: https://chromium-review.googlesource.com/1057431Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558301}
-
Elly Fong-Jones authored
Even when the parent MenuButton has keyboard focus, mnemonics should never show on Mac. Bug: 836964 Change-Id: If3906f664387c2730bc18f2c2bf638de6025c597 Reviewed-on: https://chromium-review.googlesource.com/1050068Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#558300}
-
Helen Li authored
network::ProxyResolvingClientSocket supports connecting using tls. This CL switches P2PSocketHostTcp to using that. Bug: 721401 Change-Id: I7cbdafb92268e54104d22288baadeda528b4a95d Reviewed-on: https://chromium-review.googlesource.com/1053833 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558299}
-
Devlin authored
This reverts commit 1c397d3d. Reason for revert: Causes crashes, https://crbug.com/842581. Original change's description: > [Extensions] Remove GetAssociatedWebContents() calls from file manager API > > The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is > unpredictable and can return surprising values in certain circumstances. > It is deprecated and should be removed to ensure that callers are using > the WebContents they expect. > > Update the fileManagerPrivate API to use GetSenderWebContents() instead. > > The fileManager API was using GetAssociatedWebContents() to find a > WebContents to use for an opaque ID for the SelectFileDialogExtension > dialog. However, the WebContents that is used for the dialog is > determined by FindRuntimeContext() is SelectFileDialogExtension, > which uses the window from the dialog to determine which WebContents > to use. In practice, GetAssociatedWebContents() only worked because > both GetAssociatedWebContents() and FindRuntimeContext() fell back to > using the active tab if all else failed. > > Instead, make the opaque ID for a WebContents be based on the > WebContents that would actually be used by the > SelectFileDialogExtension. > > Bug: 461394 > Change-Id: Id8607fd60a2cc6a6fb1cd14b3174c33bda79c8b4 > Reviewed-on: https://chromium-review.googlesource.com/1021680 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Naoki Fukino <fukino@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557936} TBR=ellyjones@chromium.org,fukino@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 461394 Change-Id: I76fcb52ef14637abbf8bf9fbda48c83c889cd45d Reviewed-on: https://chromium-review.googlesource.com/1057355Reviewed-by:
-
Charlie Andrews authored
This reverts commit b8b2dcd2. Reason for revert: Problem has since been fixed. Original change's description: > Disable failing wasm stories > > NOTRY=true > TBR=nednguyen@chromium.org > CC=bradnelson@chromium.org > > Bug: 840935 > Change-Id: I99ec329b99822a800d70da48dcea4a085fe71e56 > Reviewed-on: https://chromium-review.googlesource.com/1050577 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556924} TBR=nednguyen@google.com,charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true TBR=nednguyen@chromium.org Bug: 840935 Change-Id: If27b317e19ae8bfa876b16338102a181868c69f4 Reviewed-on: https://chromium-review.googlesource.com/1057365 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#558297}
-
Vasilii Sukhanov authored
This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. Bug: 842643 Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af Reviewed-on: https://chromium-review.googlesource.com/1054675 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#558296}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b06a1eb4e579..5140f9a8e424 $ git log b06a1eb4e..5140f9a8e --date=short --no-merges --format='%ad %ae %s' 2018-05-11 robertphillips Minor refactoring to image filters Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I6c3a1d580b1e2b0b4cac269489d0e7b081928f34 Reviewed-on: https://chromium-review.googlesource.com/1057428 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
