GitLab

BUG=425176

Review URL: https://codereview.chromium.org/698203005

Cr-Commit-Position: refs/heads/master@{#302735}

BUG=426561,408752
TEST=None

Review URL: https://codereview.chromium.org/693643004

Cr-Commit-Position: refs/heads/master@{#302734}

unit_tests do not have prefs, but branded builds on Chrome OS attempt to read
the brand code out of a null g_browser_process->local_state().

Instead, we now return an empty brand code in tests.

This reduces the number of crashing unit_tests on the official builders from
~300 to ~30.

BUG=430266

Review URL: https://codereview.chromium.org/703623005

Cr-Commit-Position: refs/heads/master@{#302733}

BUG=None.
TEST=None.

Review URL: https://codereview.chromium.org/699203004

Cr-Commit-Position: refs/heads/master@{#302732}

It is now a private implementation detail of the folder_image module.

FolderImage now exposes GetTopIconsBounds to AppsContainerView.

BUG=425444

Review URL: https://codereview.chromium.org/687913003

Cr-Commit-Position: refs/heads/master@{#302731}

GLRenderer expects a BeginDrawingFrame before each
FinishDrawingFrame call.

This also makes sure GLRenderer::BeginDrawingFrame doesn't
early out before creating the read lock fence.

BUG=428071
R=danakj
TEST=cc_unittests --gtest_filter=GLRendererWithOverlaysTest.ResourcesExportedAndReturned

Review URL: https://codereview.chromium.org/669233003

Cr-Commit-Position: refs/heads/master@{#302730}

Also patches in https://codereview.chromium.org/668993002

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/689153007

Cr-Commit-Position: refs/heads/master@{#302729}

- Extends RendererConfig to handle VideoDecoders.
- Extends the MOJO interfaces for DemuxerStreams with VIDEO.
- Adds the VideoFrame type plus converters to media types.
- Extends DemuxerStreamProviderShim to handle multiple streams.

BUG=410451
TEST=YouTube videos play with MOJO renderer!

Review URL: https://codereview.chromium.org/684963003

Cr-Commit-Position: refs/heads/master@{#302728}

externally_connectable is unused in this extension.

BUG=397019

Review URL: https://codereview.chromium.org/687803003

Cr-Commit-Position: refs/heads/master@{#302727}

This makes the GpuMemoryBufferManager instance on the browser
side allocate ids. The result is that each id is unique and
that makes management much easier. This also allows some more
concrete handling of the client id used for GPU service side
allocation of buffers.

BUG=

Review URL: https://codereview.chromium.org/685983005

Cr-Commit-Position: refs/heads/master@{#302726}

BUG=429248

Review URL: https://codereview.chromium.org/703643003

Cr-Commit-Position: refs/heads/master@{#302725}

BUG=414843

Review URL: https://codereview.chromium.org/704623002

Cr-Commit-Position: refs/heads/master@{#302724}

Move the logic for extension action context menus and
close-popup activate-action observations into the cocoa
platform delegate.

BUG=429810

Review URL: https://codereview.chromium.org/703443002

Cr-Commit-Position: refs/heads/master@{#302723}

Required for hasPermission LayoutTests

BUG=401424

Review URL: https://codereview.chromium.org/677073002

Cr-Commit-Position: refs/heads/master@{#302722}

It is possible for an allocation to fail on the gpu side, we should handle it gracefully.
Currently we DCHECK that it succeeded in the browser, which in release leads to unexpected behaviour and NOTREACHED hit during destruction on the gpu side.

BUG=

Review URL: https://codereview.chromium.org/701873005

Cr-Commit-Position: refs/heads/master@{#302721}

Review URL: https://codereview.chromium.org/706473002

Cr-Commit-Position: refs/heads/master@{#302720}

The icon shows the first four icons of the apps grid view, much like a
folder would show the first four icons inside the folder.

BUG=425444

Review URL: https://codereview.chromium.org/682843004

Cr-Commit-Position: refs/heads/master@{#302719}

Review URL: https://codereview.chromium.org/703743002

Cr-Commit-Position: refs/heads/master@{#302718}

This prevents multiple threads from being able to call GetWeakPtr()
at the same time by making sure the lock is acquired when this is
called.

R=vmpstr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/700843004

Cr-Commit-Position: refs/heads/master@{#302717}

For example, previously if chrome.storage.sync.set was called more than 1000
times in an hour it would be throttled forever (until Chrome restart). Now
that quota is restored every hour.

BUG=406406
R=zea@chromium.org

Review URL: https://codereview.chromium.org/704453002

Cr-Commit-Position: refs/heads/master@{#302716}

VC++'s /analyze pointed out that an incorrect operator was being used.
The warning was:

src\chrome\browser\enumerate_modules_model_win.cc(898) : warning C6313:
Incorrect operator:  zero-valued flag cannot be tested with bitwise-and.
Use an equality test to check for zero-valued flags.

This bug dates back to the original code in November 2010. Fixed to 'and' with the INVESTIGATING value, as intended, after discussion with finnur@.

BUG=427616

Review URL: https://codereview.chromium.org/700713002

Cr-Commit-Position: refs/heads/master@{#302715}

BUG=429005

Review URL: https://codereview.chromium.org/690383002

Cr-Commit-Position: refs/heads/master@{#302714}

This fixes a regression in r298758 where if a 64-bit plugin was loaded after
a 32-bit plugin, and the versions were the same, then the 32-bit plugin would
be removed from the list, the 64-bit plugin plugin would be removed and
neither plugin would successfully load.

Solution is to only load the correct architecture plugins from the registry.

BUG=428549

Review URL: https://codereview.chromium.org/674073003

Cr-Commit-Position: refs/heads/master@{#302713}

In pinch virtual viewport mode, the viewport visible to Javascript is sized
to the width of the content and its height is that width multiplied by the
aspect ratio of the true viewport.  So I changed the Android WebView tests
to only do vertical scrolling, and also changed the width of the test page
to not be larger than the viewport (so that vertical scrolling also behaves as expected).

NOTRY=true
BUG=148816

Review URL: https://codereview.chromium.org/694113002

Cr-Commit-Position: refs/heads/master@{#302712}

This way of writing it was considered in
https://codereview.chromium.org/19106007#msg30 but the direct
scroll_delta_ was felt to be slightly cleaner and with no behavior
difference unless "you had some weird stateful scroll offset delegate."
Pinch viewport mode indeed introduced state inside
LayerScrollOffsetDelegateProxy to buffer the values provided by the
inner and outer viewports before calling the delegate, so this is now
more correct.  Specifically, it's now necessary to echo back to the
delegate the values forced by its getter, or they may be clobbered with
older values later.

NOTRY=true
BUG=426891

Review URL: https://codereview.chromium.org/665233004

Cr-Commit-Position: refs/heads/master@{#302711}

Also shows the indicator regardless of pref status.
(For always-on, the opt-in process requires that there
are no errors, so if something goes wrong it is better that the user know why.)

Screenshot in attached bug.

BUG=390086

Review URL: https://codereview.chromium.org/693393004

Cr-Commit-Position: refs/heads/master@{#302710}

When PushPropertiesTo sets the active layer's delta to delta - sent_delta,
LayerImpl attempts to mirror this to the pending twin. However, in doing
so it again subtracts pending_delta. This patch saves the sent_delta and
clears it before setting the scroll offset and delta on the active layer.

BUG=428327

Review URL: https://codereview.chromium.org/698003006

Cr-Commit-Position: refs/heads/master@{#302709}

Thanks to David Michael <dmichael@chromium.org> for condensing the discussion
thread to a recommendation!

BUG=none

Review URL: https://codereview.chromium.org/699283002

Cr-Commit-Position: refs/heads/master@{#302708}

This CL removes the plumbing for the flag to disable the ignoring of
autocomplet='off' for password fields. This plumbing was always intended
to be temporary in case something disastrous happened and we needed to
re-enable autocomplete='off' via Finch. The time we set for this has
past, so this CL makes this a permanent change.

BUG=346708

Review URL: https://codereview.chromium.org/697233002

Cr-Commit-Position: refs/heads/master@{#302707}

This CL implements the ContinueWindow on ChromeOS, which will
be shown to the user for confirmation after 10 minutes into a Remote
Assistance session.

To implement the ContinueWindow, this CL introduces a new class
MessageBox, which is a re-usable component built on top of the
widget framework.

BUG=424908

Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d
Cr-Commit-Position: refs/heads/master@{#302657}

Review URL: https://codereview.chromium.org/690183002

Cr-Commit-Position: refs/heads/master@{#302706}

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/700893003

Cr-Commit-Position: refs/heads/master@{#302705}

For multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed.

The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total
height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger
leading to it getting clipped. Example where this breaks is in the message center notifications where the line height
is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better.

BUG=429108

Review URL: https://codereview.chromium.org/692803004

Cr-Commit-Position: refs/heads/master@{#302704}

[Autofill] Autofill fails to show suggestions for suggested input for forms having credit card number split across multiple fields.

BUG=420323

Review URL: https://codereview.chromium.org/622773002

Cr-Commit-Position: refs/heads/master@{#302703}

This will work better with the new 3 part version, where the minor
version is now the 2nd last element, instead of the last.

BUG=

Review URL: https://codereview.chromium.org/681423002

Cr-Commit-Position: refs/heads/master@{#302702}

BUG=374264

Review URL: https://codereview.chromium.org/688403002

Cr-Commit-Position: refs/heads/master@{#302701}

This patch added Observer in FaviconTabHelper, so the favicon retrieved by FaviconHandler could be used right away.

BUG=428218

Review URL: https://codereview.chromium.org/684983003

Cr-Commit-Position: refs/heads/master@{#302700}

Various things (cr.ui.MenuButtons, checkboxes) call .preventDefault()
while handling 'mousedown' events which messes with focus. Account for this.

R=arv@chromium.org
BUG=424475

Review URL: https://codereview.chromium.org/685783003

Cr-Commit-Position: refs/heads/master@{#302699}

In Chrome OS, chrome://help (the About page) redirects to chrome://settings/help.
But the Settings page should not be loaded in Incognito (and
causes the browser to crash).

BUG=426618
R=ben@chromium.org

Review URL: https://codereview.chromium.org/649053003

Cr-Commit-Position: refs/heads/master@{#302698}

This tidies the code up a bit, and I use these interfaces in a subsequent changelist (for EC keys).

The vision is that jwk.h/jwk.cc should just define these two helpers, and all the other algorithm-specific logic (EC keys, RSA keys, AES keys, HMAC keys etc..) is built using JwkReader/JwkWriter, and lives in the algorithm-specific files.

BUG=399094

Review URL: https://codereview.chromium.org/687063002

Cr-Commit-Position: refs/heads/master@{#302697}

BUG=425651
R=eroman@chromium.org

Review URL: https://codereview.chromium.org/689883002

Cr-Commit-Position: refs/heads/master@{#302696}