- 21 Jul, 2017 40 commits
-
-
Charles 'Buck' Krasic authored
Increase the size of QuicHttpStream::raw_request_body_buf_ based on the size of the body. For large bodies and fast networks, this give a nice reduction in CPU (or boost throughput if CPU bound) (~10-20%). R=rch@chromium.org Bug: 709144 Change-Id: If4fc69f9f89866b75b6d09d728e53a7bfa2054e4 Reviewed-on: https://chromium-review.googlesource.com/581877Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#488765}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/926c65a49ca4..d0856ba49c2b $ git log 926c65a49..d0856ba49 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 thestig Fix nits from commit 67ccef7. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I66ae6e2cf456d549f69879e81ac8ba4ddd24815b Reviewed-on: https://chromium-review.googlesource.com/581933 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488764}
-
pdr@chromium.org authored
The CQ bot was down for a few days (https://crbug.com/746119) and some failures crept in. some of these are for new tests (border radius test) and some are new faiures (filter, https://crbug.com/747511) and some I did not triage. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I26175466116a30b7eb98225215bc6e9f926ad66f Reviewed-on: https://chromium-review.googlesource.com/581609Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488763}
-
Kyle Horimoto authored
This reverts commit 2e75e890. Reason for revert: Breaks build for veyron_minnie and probably other devices. Sample of the compiler errors below: ../../ui/ozone/platform/drm/gpu/drm_thread.cc:120:15: error: use of undeclared identifier 'GBM_BO_USE_TEXTURING'; did you mean 'GBM_BO_USE_RENDERING'? flags = GBM_BO_USE_TEXTURING; ^~~~~~~~~~~~~~~~~~~~ GBM_BO_USE_RENDERING ../../../.cros_cache/chrome-sdk/tarballs/veyron_minnie+9588.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gbm.h:230:4: note: 'GBM_BO_USE_RENDERING' declared here GBM_BO_USE_RENDERING = (1 << 2), ^ Original change's description: > ozone: set the right GBM_BO_ flags > > minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING > implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer. > > GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE. > BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE. > > TEST=run chrome on amd64-generic > BUG=683347 > > Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668 > Reviewed-on: https://chromium-review.googlesource.com/549095 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> > Cr-Commit-Position: refs/heads/master@{#488709} TBR=marcheu@chromium.org,reveman@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org Change-Id: I2a8327004c3ba78ca406d08b02b28515c2b2dcf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 683347 Reviewed-on: https://chromium-review.googlesource.com/582347Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488762}
-
Amirhossein Simjour authored
Add tracking of suppression of the popup ui elements in tab_web_contents_delegate_android. The logging should be removed once we have proper implementation of UI elements in VR. BUG=746979 Change-Id: I75997b9aa644b75e4b673f5ca34335138003f3bd Reviewed-on: https://chromium-review.googlesource.com/579947Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#488761}
-
John Abd-El-Malek authored
Also disable a payments test which is flaky. TBR=kinuko@chromium.org NOTRY=true Change-Id: I7fa7059a7e0c0d0f82ecaa7b0b064537ea778cfe Reviewed-on: https://chromium-review.googlesource.com/581673 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#488760}
-
Nathan Fairhurst authored
Was caused by touchscreen_gesture_target_queue_ + prevent default. The webview target was calculated on TouchStart and pushed to the the queue. It was removed on its corresponding GestureTapDown. However, if the TouchStart had default behavior prevented, no GestureTapDown would ever occur, and the queue would forever have an extra element. Fixed by converting touchscreen_gesture_target_queue_ to a map with unique_touch_event_id as keys and gesture target data as values. Also updates AUTHORS file. Bug: 736623, 739831 Change-Id: If3bf844e2bcfb9a1ca6d6a56cdc7575e0767e6b6 Reviewed-on: https://chromium-review.googlesource.com/547669 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#488759}
-
Ahmed Fakhry authored
The feedback uploader can spam the server with tons of instances of the exact same report due to the following: 1) Corrupted reports will be retied once every 60 minutes and on every login. Each retry will fail with the exact same ClientError, so there's no point in retrying. 2) FeedbackProfileObserver and FeedbackUploader were using two different types of task runners with different threads from their blocking pools. This can lead to a race condition (when corrupted reports are being resent on login) between the thread that reads the unsent file, and the thread that rewrites the file before it's attempted to be resent. This CL: - Fixes (1) by introducing an exponential backoff delay on failures other than ClientErrors, and not retry on Client Errors. - Fixes (2) by using the same type of SingleThreadTaskRunner for all feedback background tasks to ensure sequencing and thread affinity. - Adds some tests. BUG=739885 TEST=adds new tests. Change-Id: Ia80afbb77349444a02321f22754d3d89cd536507 Reviewed-on: https://chromium-review.googlesource.com/564304Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#488758}
-
Michael Thiessen authored
Bug: 746504 Change-Id: Ia7296889916aac759edfef72c34beb01770d79ca Reviewed-on: https://chromium-review.googlesource.com/581851Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#488757}
-
John Chen authored
Change-Id: Ie44eb482868022111fc52ff490702e0a97d0f4d4 Reviewed-on: https://chromium-review.googlesource.com/580053Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488756}
-
Eugene But authored
Disabling and enabling web usage has the same effect of evicting tabs. Bug: 732525 Change-Id: I2ecafe2ddaf419aaeea81500f94d8b5893dee95e Reviewed-on: https://chromium-review.googlesource.com/581848Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#488755}
-
Matt Wolenetz authored
Since M56, we've had .flac and flac-in-mp4 demux and decode support in Chrome, but we haven't included AudioVideoMetadataExtractorTests to confirm expectations. This change adds those. It also calls out expected "double" values for duration metadata that might be needed when bug 747480 is fixed. BUG=666000,747480 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I072ba8561d0912169848e96deaf87dfc636ee54b Reviewed-on: https://chromium-review.googlesource.com/581937Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488754}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/010a464..426cb5e BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I673ed6cf468e9e115184a06a57fbba05cbd5e6bd Reviewed-on: https://chromium-review.googlesource.com/581743Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#488753}
-
Gabriel Charette authored
TBR=robliao@chromium.org Bug: Documentation update Change-Id: Ib2c5b090b8c8187e6ca8cffb20f2efcde17bbf53 Reviewed-on: https://chromium-review.googlesource.com/581635Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488752}
-
Andrey Kosyakov authored
This adds a protocol method to obtain the UUID of a Blob based on a remote object id. The intended usage is in conjunction with IO.read that would be able to read the contents of a Blob on the browser side. Bug: 747508 Change-Id: I18b7395833265665d80493f611888285f9730458 Reviewed-on: https://chromium-review.googlesource.com/580353 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488751}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/950ede098bcd..9629af753335 $ git log 950ede098..9629af753 --date=short --no-merges --format='%ad %ae %s' 2017-07-21 loloangela Fixed errors related to bad-continuation Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3437d4668d76850735dc154cd90223088ba53ce7 Reviewed-on: https://chromium-review.googlesource.com/581581 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488750}
-
Ojan Vafai authored
This reverts commit 317adc6a. Reason for revert: Broke the foillowing unittests. See https://luci-milo.appspot.com/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/28383. LaserPointerControllerTest.LaserPointerPrediction LaserPointerControllerTest.LaserPointerRenderer Original change's description: > Implement metalayer palette tool in ash. > > Add a new "highlighter" tool using the same fast > rendering method as laser pointer (CL extracting > the common base class is to follow). > > Bug: b:63142451 > Change-Id: Id848b77f08ae95c167c527a07aec6ccdf79f49f4 > Reviewed-on: https://chromium-review.googlesource.com/558467 > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488688} TBR=kaznacheev@chromium.org,reveman@chromium.org,oshima@chromium.org,lhchavez@chromium.org,jdufault@chromium.org Change-Id: I8194c045c56777f140ff5850eb3543a23fc55027 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:63142451 Reviewed-on: https://chromium-review.googlesource.com/582149Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488749}
-
Elly Fong-Jones authored
These were using SK_ColorWHITE when they should have been using [NSColor windowBackgroundColor]. BUG=743120 Change-Id: Icf5cff4c1e4451c55580921c0d661fd8381b19da Reviewed-on: https://chromium-review.googlesource.com/575167Reviewed-by:
Jayson Adams <shrike@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#488748}
-
sebmarchand authored
BUG=689520 Review-Url: https://codereview.chromium.org/2881143002 Cr-Commit-Position: refs/heads/master@{#488747}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1bf2e10d..913ccf82 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ibf4ec705544c6f16a6e91e5fa81c93f8456969bb Reviewed-on: https://chromium-review.googlesource.com/581749Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#488746}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 97504bed. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/353 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I6da32a524079d6baa0f7262d2ae3e5babeb87ed1 Reviewed-on: https://chromium-review.googlesource.com/581791 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488745}
-
Steven Bennetts authored
Bug: 741574 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc1a265948cb90c72ee9b9e2fd4447220b5f9f0f Reviewed-on: https://chromium-review.googlesource.com/580369 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488744}
-
Becky Zhou authored
+ Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG=723044,723054 Change-Id: I59461f4d9a73da49d0370661a8d275f8b2699083 Reviewed-on: https://chromium-review.googlesource.com/581801Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#488743}
-
Yuwei Huang authored
Follow up CL for adding AppInitializer. Bug: 746105 Change-Id: I45fd6e39cfd3d748e185bc1e515f5be9ee33cc48 Reviewed-on: https://chromium-review.googlesource.com/578708Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#488742}
-
updowndota authored
- Rename the 'no thanks' and 'continue' buttons to 'skip' and 'next'. - Refactor the code. BUG=b/63909126 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2984023002 Cr-Commit-Position: refs/heads/master@{#488741}
-
Mike Reed authored
NOTRY=True Bug: 747502 Change-Id: I0344ca15013427f6f9f5dcb5f04f0faeb65bcc30 Reviewed-on: https://chromium-review.googlesource.com/581793 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Cary Clark <caryclark@chromium.org> Cr-Commit-Position: refs/heads/master@{#488740}
-
Jeremy Roman authored
There can never be two separate map entries with different event names, so continuing to search is pointless. Change-Id: I4a91e17b99bfa723b965349e564613ab64bfc69a Reviewed-on: https://chromium-review.googlesource.com/581428Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488739}
-
Andrew Grieve authored
This reverts commit f3d8718a. Reason for reland: Didn't cause the bot failure. TBR=wnwen@chromium.org,mgersh@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org Bug: 731159 Change-Id: Idb2140b3c72065778e0d87b96c959eb6f2205543 Reviewed-on: https://chromium-review.googlesource.com/581467 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#488738}
-
Philip Rogers authored
This reverts commit 80d5a3ec. Reason for revert: May be the cause of scroll offset crashes (crbug.com/746718) Original change's description: > Remove LayerImpl dependency from LayerTreeImpl::DidUpdateScrollOffset > > This patch removes the LayerImpl references from DidUpdateScrollOffset. > Instead of looking up scroll and transform property nodes with Layers, > ElementId is used. > > Tests have been modified to ensure property trees exist before updating > scroll offset. This should be true in all real cases but is not for > synthetic testing scenarios. > > A bug has been fixed in UpdateScrollChildPosition where the scroll layer > was not actually scrollable. > > This is a reland of [1] which was rolled out because the active tree can > have a scroll offset for an element id that is not present in the pending > tree. The comment in DidUpdateScrollOffset has been updated to reflect > this. This is tested in PushPropertiesToMirrorsCurrentScrollOffset. > [1] https://chromium-review.googlesource.com/c/560584/ > > Bug: 743241, 742039 > Change-Id: Ia13380d749843064f30de76ccfeeb5e72502e6b2 > Reviewed-on: https://chromium-review.googlesource.com/572426 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487183} TBR=pdr@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 743241, 746718 Change-Id: I3a02c7a22c6db2d2e3eafcb83eace9e37db8c1d6 Reviewed-on: https://chromium-review.googlesource.com/581629Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488737}
-
John Budorick authored
Overall cycle time and compile step time have improved signficantly on all three matching waterfall bots since the hardlink workaround landed yesterday: - ios-device: http://shortn/_ow7Hr0gN6e - ios-device-xcode-clang: http://shortn/_qdlv49pNuS - ios-simulator-xcode-clang: http://shortn/_LlpTYE0H51 Bug: 740301, 739556 Change-Id: Iebf1b1398273d87580d5aaa295231f2a9e33bcaf Reviewed-on: https://chromium-review.googlesource.com/579567Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#488736}
-
Fady Samuel authored
cc/test/scheduler_test_common* contains some classes that belong to the layer compositor and others that belong to the display compositor. This CL pulls out TestDelayBasedTimeSource and FakeDelayBasedTimeSource from the files. This has the net effect of making begin_frame_source_unittest no longer depend on scheduler_test_common* allowing it to be moved into viz in a subsequent CL. Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8e50f5bdae3b3a1f2e3889f9b6cd0f6bfb5a76b2 Reviewed-on: https://chromium-review.googlesource.com/581227 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#488735}
-
Matt Mueller authored
PR_DetachThread is not necessary, because Chromium code never calls PR_Cleanup (which requires threads be cleaned up beforehand), and the thread-specific data itself will be cleaned up by NSPR's pthreads hook. However, PR_DetachThread can cause a crash if NSS hasn't been initialized at all (e.g. with use_byte_certs=true in unittests), so it's not just unnecessary, but actively harmful. Bug: 671420 Change-Id: I294ac988c53c7b5109b80eec2aef547cb46f650a Reviewed-on: https://chromium-review.googlesource.com/558605Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#488734}
-
Gauri Manikpure authored
Bug: chromedriver:1878 Change-Id: If8ae5de00f3a2e679631134e5790018b53b59049 Reviewed-on: https://chromium-review.googlesource.com/581849Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#488733}
-
Mohsen Izadi authored
The activation threshold for touchscreen overscroll is updated to be based on display width/height rather than window width/height. Touchpad has already been using display size. BUG=668296 TEST=none Change-Id: Id21c2089aaed3e4f2d3628968ba64c7a231e0063 Reviewed-on: https://chromium-review.googlesource.com/578250 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#488732}
-
Jeremy Roman authored
canMoveWithMemset was renamed to kCanMoveWithMemset, etc. These were left behind. Change-Id: Id3b56a99d1890ee3b69dadc9c53d7ae9abf40147 Reviewed-on: https://chromium-review.googlesource.com/581387Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488731}
-
Mattias Nissler authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/69b19fbcbec5..6c45bba6ac21 $ git log 69b19fbcb..6c45bba6a --date=short --no-merges --format='%ad %ae %s' 2017-07-19 mnissler Add StartTPMFirmwareUpdate session_manager constants. Created with: roll-dep src/third_party/cros_system_api Change-Id: I71c670e16b266b3e70377a217ccb7da0b98da567 Reviewed-on: https://chromium-review.googlesource.com/580931Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#488730}
-
Rouslan Solomakhin authored
This patch adds an integration test for the Android payment app finder using the real parser and downloader instead of mocks. This patch adds payment app manifest files in components/test/data/payments/<hostname>.com/. Because the embedded test server uses HTTP, but payment manifests must use HTTPS, a URLSubstituteParser wraps the PaymentManifestParser to replace https://<hostname>.com with the test server URLs, e.g., http://127.0.0.1:12345/components/test/data/payments/<hostname>.com. Because integration tests should not depend on the state of locally installed applications, a MockPackageManagerDelegate is used to simulate installed native Android apps in memory. Bug: 620173 Change-Id: I8184a84f9f9daa05b5cc8da6e343378b62333b1a Reviewed-on: https://chromium-review.googlesource.com/571943 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#488729}
-
nednguyen authored
NOTRY=true # This doesn't affect any code Bug: 713222 Change-Id: Ie2fd992e7b99dbfb81e74c0028e9190f3d9df226 Reviewed-on: https://chromium-review.googlesource.com/581873 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#488728}
-
Quinten Yearsley authored
This simplifies rebaseline_cl_unittest and wpt_expectations_updater_unittest. Change-Id: I11ecc38af5fffcd3bba1def071ea63d814dd2abf Reviewed-on: https://chromium-review.googlesource.com/581737Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488727}
-
Christian Fremerey authored
This CL is part of the Mojo Video Capture work. Design doc for dev work [1]. Before this CL, the ServiceVideoCaptureProvider had to be uninitialized manually by its client, in our case VideoCaptureManager, in order to close the connection to the video capture service and, in turn, allow the service to shut down. VideoCaptureManager only called Uninitialize() at the end of a video capture session. But it would not call it after enumeration-only use of the service. This would lead to the service potentially staying alive indefinitely after enumeration-only usage that is not followed-up by a capture session. Usage logs indicate that this actually happens quite frequently. After this CL, ServiceVideoCaptureProvider uninitializes the service connection automatically as soon as there is no active usage. Bug: 584797 [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Change-Id: Ia33507f4fe0a36b804b2636c41af6d807fab8c0d Reviewed-on: https://chromium-review.googlesource.com/578558Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#488726}
-