- 11 Aug, 2020 40 commits
-
-
Orin Jaworski authored
This CL causes the translation prompt to show when triggered from an omnibox Pedal, even when the page is in user's primary language. The language state logic usually prevents it, but in the case of Pedal activation, the user is explicitly requesting translation. Bug: 893183 Change-Id: Id3e99268a759d97dd148b5ddb2d32f36d5f51a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350230 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797033}
-
Yicheng Li authored
When the user enters password, authenticate the user by checking the password. PIN auth will be supported in a follow-up change. Also add unittests around this authentication. "testing/xvfb.py out/Default/ash_unittests" build unit_tests and "testing/xvfb.py out/Default/unit_tests" Bug: b:156258540 Test: build ash_unittests and Change-Id: I571f34d1cfc3849729240147635f9b685d68dd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340499 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797032}
-
Josh Nohle authored
Even if a metadata encryption key is decrypted successfully, i.e., bytes are returned, it might not correspond to the intended key. This is expected for Nearby Share because we try to decrypt the metadata encryption keys for all public certificates until we find the right one. Key decryption failures and mismatched key commitments will be common, so do not log errors. Change-Id: Ia916db644dc5e33bb7647a6cd0b3f925b22d3630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350301 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#797031}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2454323cb6e..f6ca01b98c51 2020-08-11 jalyn@microsoft.com Infobar: Don't expand without details If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1115211 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00b7e4b2c9d2c39c61cb494fd961644576055d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797030}
-
Daniel McArdle authored
The constructors for BigEndianReader and BigEndianWriter currently check that |ptr_ <= end_|. Given that |end_| was constructed from |ptr_| plus an unsigned length and that the constructors' inputs must correspond to a valid buffer, CHECK_LE(ptr_, end_) can never fail. Bug: 1114803 Change-Id: I9ae6c454e28967b036a8e1343d8e9a4cba166cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350151Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797029}
-
chrome://media-appTrent Apted authored
Over time launchWithFiles() has evolved to support all the use-cases that load*File() needed. launchWithFiles() has better coverage of real code paths; poking around less in the internals of launch.js which makes them hard to maintain. The launchWithFiles() calls also tend to be more succinct. Bug: b/163287386 Change-Id: I58e7aaa455266efd56614e0561493fd7519b8f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345938Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797028}
-
Nate Fischer authored
No change to logic. This adjusts the following colors: * Brighter red for warning text (dark theme only) * More contrast for text color of flag names (darker in light theme, brighter in dark theme) Fixed: 1111172 Test: Manual - verify colors in screenshot Change-Id: Ib8d1e5a8cbd10c8b7e3483adb31c893d220389f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347376Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797027}
-
Gavin Williams authored
These enums need to be changed to enum classes so they can be used as metric enums. Without being enum classes, when 'kMaxValue' is added to both, the compilation fails. Bug: 1059607 Change-Id: I36c6167efe93e45eb6b00daed686e52454e85397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349431Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#797026}
-
Yuly Novikov authored
From default 120 seconds to 180, to mitigate gtests shards timing out due to phone busy with other tasks. TBR=bsheedy No-try: true Bug: 1115157 Change-Id: I5e7f09947eca47038a91ea1da578ce5d9232e5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348582 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797025}
-
Peter Kasting authored
No intended behavior change. Bug: none Change-Id: Ib0496c5dcb42fb6388c3b68ab330ed36d39556dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345089Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797024}
-
Dan Harrington authored
We were not copying the prefetch data from wire to store protos Bug: 1044139 Change-Id: I85731b25af9e845b6fe274d47458a2de9c65952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350229 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797023}
-
Joshua Berenhaus authored
metrics_log.cc had a typo, fixed in this CL :) Change-Id: I51838078d29ff7747c4a208b6822ed1fac763b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350153 Commit-Queue: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#797022}
-
Daniel Rubery authored
This CL changes the URLLoaderFactory used be the ClientSideDetectionService. Pings to Safe Browsing will return to using the Safe Browsing network context (with profile keying). Model loading will continue to use the profile network context with credentials omitted, to support caching. Bug: 1049833 Change-Id: I963265b011c0f56b5e8634cd1fc9d0259e133a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349397Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#797021}
-
Nick Harper authored
Domain ownership verified via DNS TXT record. Change-Id: I0db37e0b8c2aa4340a1a5a2a23b6fa52ffa35e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350143 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797020}
-
Adam Rice authored
This test is flaky, so disable it for now pending further investigation. BUG=1113999 Change-Id: If2b4063281bbc83fc369d64dfb7b4eb342b8b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349588 Auto-Submit: Adam Rice <ricea@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#797019}
-
Jan Wilken Dörrie authored
This change adds the algorithms from [alg.set.operations] to //base/util/ranges and adds appropriate tests. Bug: 1071094 Change-Id: If974fa8d4a204aa6ec3b3caa255bb6f07eef500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349608 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797018}
-
Tamir Duberstein authored
This allows the features field to be changed to a FIDL |bits| type without breaking the Chromium build. The |static_cast|s introduced in this change will be removed after the next Fuchsia SDK roll. tools/fuchsia/local-sdk.py $FUCHSIA_DIR autoninja -C out/fuchsia net:net_unittests Test: with https://fuchsia-review.googlesource.com/c/fuchsia/+/399816: Bug: 1099393 Change-Id: I02a8612ccf6dfa2fe1157afa77ab1ac752fa0f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349488 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797017}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1553832ddd6c..61ca10cb63d0 2020-08-11 thestig@chromium.org Roll third_party/libjpeg_turbo/ 0241a1304..9d4f8005b (4 commits) 2020-08-11 thestig@chromium.org Check more headers in OpenJPEG. 2020-08-11 tsepez@chromium.org Remove CFWL_Widget::SetOuter(). 2020-08-11 thestig@chromium.org Remove an unnecessary check in CPDF_RenderTiling::Draw(). 2020-08-11 tsepez@chromium.org Remove CFWL_WidgetMgr::NextTab(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114577 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I179842dbbac097815d1e274dc3783907f59f763d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350136Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 2020-08-11 cfijalkovich@google.com Merge "Utilize FB app suite tracepoints in trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I773198ebbd0ddc2e513a7095c040790a4653372a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350138Reviewed-by:
-
Nico Weber authored
Bug: 1107955 Change-Id: Ibfa333618be9d1d0296998a5fc53d10a6d59065d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349923 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Add a python test suite for the Docserver. Currently these tests are run using presubmit scripts. However our logic for when to run presubmits is not completely correct, which has caused multiple regressions in the past. (crbug.com/1114299, crbug.com/1105211, crbug.com/700234) Fix this by introducing a test suite. Since the isolate requirement for tests needs us to list all the dependencies exhaustively, it also means that we'll always be able to catch regressions. A subsequent CL will remove these tests from being run on presubmits. Skipping presubmits since they flakily timeout (most probably due to the docserver presubmit checks, which should also be fixed once we remove these tests). BUG=1114299 No-Presubmit: true Change-Id: I805874908d7f622102809ac342168fb40f23155a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311823 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#797013}
-
Elly Fong-Jones authored
Bug: 1115238 Change-Id: I480c06b3c95c6eec3471ff470db4b104bbfc3d46 Tbr: beccahughes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797012}
-
Yusuf Sengul authored
Bug: 1115255 Change-Id: I29378e7a30a1997480e09580ff172e2e8ac1029b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350112 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Auto-Submit: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#797011}
-
Weilun Shi authored
Remove fieldtrial related logic in extract_histograms.py as these fields are not used. Bug: 1115228 Change-Id: Ifd5e654203c12e573da02f133f339005c68ebe56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350130 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797010}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4d3ff474abe..d56f379356d9 2020-08-11 fdegans@chromium.org Set screenshot alpha channel to white. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1088062 Tbr: sadrul@google.com Change-Id: I1b5e50847854ddae9b7bded03a57791ff16be3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350128Reviewed-by:
-
Maksim Sisov authored
Some tests are still failing, but we need to remove the experiment to avoid further regressions. Bug: 1029240 Change-Id: I4f32b876ef4caee350d30dbcb44cba40a91d1740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346267Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#797008}
-
Stephen Chenney authored
Bug: 1112771 Change-Id: I6deb0aff7fbbe9d2bd7fd00f7452d5fc5cb2a2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348538Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#797007}
-
Ilia Samsonov authored
Some baselines have changed, baselines are from https://test-results.appspot.com/data/layout_results/linux-blink-optional-highdpi-rel/67/high_dpi_blink_web_tests%20%28with%20patch,%20experimental%29/layout-test-results/results.html Bug: 1068400 Change-Id: I2deb34a41ee910e0e07ec444dea95427e2eb65c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348204Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#797006}
-
Thomas Guilbert authored
This CL changes the semantics of releasing the resources held by a blink::VideoFrame, after one is done with the frame. Previously, every frame created had to be explicitly closed or GC'ed before the underlying media::VideoFrame was released. This CL adds a blink::VideoFrame::Handle which can be shared across frames. Destroying one frame destroys all frames sharing the same handle. This makes it easier to handle serialization/desirialization cases, during which there can be dangling reference held by intermediary objects that are impossible to close. blink::VideoFrames constructed from a media::VideoFrame reference will create a new Handle, whereas those constructed from a Handle will share it. Bug: 1096715 Change-Id: I775abe4e697d01ac14d98af81c78dbc3fd6bd5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343846 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797005}
-
Dave Tapuska authored
Toggling of the fullscreen state can now happen solely in blink in the UpdateVisualState method. It was only implemented by FrameWidgets so it can be implemented inside WebFrameWidgetBase. BUG=1097816 Change-Id: Iba47519ee15166e00c698e477cbed6ca740d7d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317990 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797004}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5401bad7015d..c2cfd18ab8ca 2020-08-11 philipp.hancke@googlemail.com Reland "peerconnection: prefer spec names for signaling state" 2020-08-11 eshr@google.com [Adaptation] Don't toggle EncoderUsageResource on/off 2020-08-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5246cdb2..c0ac7e51 (796691:796807) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101699 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I43c90b65bd0ebcd1fea142afba9d5e3e9026f6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349917Reviewed-by:
-
Matthias Körber authored
This CL adds support to identify permuted name tokens as mergeable. Change-Id: I048818625aaa95f1dabd163abf5a2efe6868cca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349349 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#797002}
-
Sven Zheng authored
Data is based on the latest FYI job: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-fyi-rel/349? https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-fyi-rel/348? Some test suites are stable now, so remove the experimental. Some test suites are failing with some tests, so run them on CI with experimental, and using filter to exclude failing tests. Bug: 1111979 Change-Id: Idd53dc2a8df7bb1d2988071ac3e15ffdfe86fa66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347912Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797001}
-
Joey Arhar authored
When using beforematch to expand a content-visibility: hidden-matchable element asynchronously with an animation, the active match usually doesn't get highlighted. This patch makes sure highlighting happens after the scroll, fixing the issue. Bug: 1114208 Change-Id: I8dc60aa39461e05d43f94a863514a261e19e4e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342577Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797000}
-
chrome://signin-reauthAlex Ilin authored
The reauth dialog CSS overrides the background illustration in dark mode using the `background` shorthand CSS property which sets all background style properties at once. In this case, `background-size` attribute gets implicitly overridden with a default value. This behavior isn't desired, so this CL uses `background-image` CSS property instead of the `background` shortcut. Bug: 1114701 Change-Id: I32232b540b7feb3d76c524af589497382d6f12f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346293Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796999}
-
about://flagsEric Seckler authored
Adds an entry for the kCpuAffinityRestrictToLittleCores feature and moves its entry to chrome_features.h/cc to accomplish that. Bug: 1111789 Change-Id: I1a99b4eaf5e07111a0bcc7725081e3871edfe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348774 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796998}
-
Andres Calderon Jaramillo authored
Problem: In the new direct VD, we create a SharedImage for the decoded video frame using the visible size. This is (mostly, see solution below) correct because we don't want the GPU to sample outside that area (otherwise, we might get artifacts). However, the coded size of the VideoFrame sent to the client still contains the non-visible area. This can cause PaintCanvasVideoRenderer to issue GL commands with incorrect dimensions thus failing command buffer validation which results in some videos not being drawn at all on a canvas. Solution: The solution implemented by this CL is simple: the coded size of the VideoFrame that goes out to the client should only include the "usable area." For most videos, this is simply the size of the visible rectangle. However, some H.264 videos specify a visible rectangle that doesn't start at (0, 0). For these videos, the usable area needs to include everything from (0, 0) to the bottom-right corner of the visible rectangle: the client will calculate the UV coordinates to exclude the non-visible area on the left and on the top of the visible area. Note that this usable area should also be used to create the SharedImage because this size is used to import the frame into a graphics API. Bug: 1092806 Test: tast.video.DrawOnCanvas.* on nami Change-Id: I25f70a1b21fc9b4ff7037d6fb3b4575ad3dd66e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242834 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796997}
-
Miguel Casas authored
AFAICT this code is untested and unused, since VideoDecoderPipeline doesn't create ImageProcessors for VA-API. Left a NOTIMPLEMENTED() as in-code documentation. Bug: b:162962069 Change-Id: Icdd0e15749d58b98d91143d6d4cf1eec8a993b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346908Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796996}
-
rajendrant authored
Enabling the redirection by default simplifies enabling the feature in chrome-flags. Change-Id: I9b4b0bd870ac431d4579c59c1b1d95331a57472c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349972Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#796995}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie8b34e9e69969ee28cb79def717be865af2d1e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350008Reviewed-by:
-
