- 07 Dec, 2020 40 commits
-
-
Robbie McElrath authored
This CL renames most of WebLayer's Site Settings files to just Settings in preparation of introducing more Settings UIs. This introduces a new ISettingsFragment rather than renaming ISiteSettingsFragment because renaming the interface results in a "SecurityException: Binder invocation to an incorrect interface" exception when launching Site Settings. Bug: 1106393 Change-Id: Ifbeb15a8ff51776a901e0136dfbdcb4b19543a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572689 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#834358}
-
Reilly Grant authored
The manual data transfer tests are known to work on all platforms while the tests which generate error conditions do not. Break these up in order to simplify regression testing. Bug: 884928 Change-Id: I8b8e5559fe7babf21395b3c836ff8ff0f60be8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576080 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834357}
-
Ben Pastene authored
crrev.com/i/3452789 allocates the machines for this. Bug: 1146481 Change-Id: I0c271016eae64d0e99f205b31efe635cf707cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576949Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834356}
-
Jan Wilken Dörrie authored
This change prepares //mojo and //ipc for the upcoming switch of base::string16 to std::u16string by replacing current Windows only usages of base::string16 with std::wstring. Furthermore, it adds a std::wstring specialization of IPC::ParamTraits. Bug: 911896 Change-Id: If09078ba43a381f7210f89bba04a729024812d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572842Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#834355}
-
Azeem Arshad authored
This fixes issue with eSIM networks incorrectly appearing in pSIM group. This was caused because the eid property was not being checked properly. Bug: 1093185 Change-Id: I9c3f2f72810e186dd35f47dedff61bf7efd2c06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575149Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1924d3f068ef89f8c5b48a5e628083c020056700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834353}
-
Tibor Goldschwendt authored
This is a reland of 0b7367ff with a fix for msan builders, which failed on the original change. See https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26482/steps?succeeded=false&debug=false Original change's info: > Change-Id: I735506c3e0efff1f92582498400bea0a914cf215 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566374 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833561} TBR=caitlinfischer@chromium.org,mahmadi@chromium.org Bug: 1110075 Change-Id: Ic311a03eb09860d0cc8b40c55f93bb97caa095bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576788Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834352}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I5e835e779fcd6e6096886d7bf38869ae19e25bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569384Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#834351}
-
manukh authored
This does not enable the drive feature by default as it's currently limited to enterprise users. Sets: - DocumentUseClientScore to true - DocumentProviderMaxQueryLength to 200 - DebounceDocumentProviderDelayMs to 300 Change-Id: Idf85fcf6b25a844b196fa5ae82d5ac7617e6dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575378 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#834350}
-
Shawn Gallea authored
This removes the burden of parsing from the client. Bug: b/169054926 Test: On device Change-Id: If02b37169aca921429658305284e94738350a822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574999Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#834349}
-
Shrek Shao authored
Reland "Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support" This is a reland of 80b096ab The culprit was identified in Issue 1154356. Original change's description: > Fix readPixels incorrectly allowing RGBA / UNSIGNED_SHORT without EXT_texture_norm16 support > > Add readPixels validation for RGBA / UNSIGNED_SHORT combination. This is > only valid with EXT_texture_norm16 extension enabled. > > Bug: 1152259 > Change-Id: I0e10b7d29f3b362c4054500270bbad87dcde599f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559797 > Commit-Queue: Shrek Shao <shrekshao@google.com> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832141} Bug: 1152259, 1154356 Change-Id: Ie9ceed14e705380e9d1d07f008f4ec86ea7b7421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575048Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834348}
-
Sebastien Lalancette authored
- Increased LinkGeneration timeout from 200ms to 500ms, - Added a new kTimeout LinkGenerationError enum value, - Added LinkGeneration latency UMA logging. - Lots of plumbing of the latency value to allow logging from the same scenario-aware location. - Added a way to force timing out JavaScript execution requests in the FakeFrame class. Bug: 1155329 Change-Id: I396457db946a756c799a4fddb0d7185c3e12b30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577002Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#834347}
-
Caroline Rising authored
Bug: 1109316 Change-Id: Id8f9c23c6b1526800ae7366c68cc4c8b4c02a23b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577484 Auto-Submit: Caroline Rising <corising@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834346}
-
Evan Stade authored
Having a target named "browsertests" means that trying to compile browsertests from the command line, i.e. ninja -C out/Release browsertests will work, when the user probably meant to type ninja -C out/Release browser_tests So the name of the payments target is changed to browser_tests, which is one of two conventions throughout the rest of Chrome. (The other being myfeature_browsertests, which also avoids the afore-mentioned issue.) Now if the user tries to compile `browsertests`, they will see ninja: error: unknown target 'browsertests' Bug: none Change-Id: Ia6b679847744d7edfbfae3b0e20e395e9a4e226b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574751 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#834345}
-
Alice Gong authored
Expand OAuth2ApiCallFlow class to allow multiple lines of headers & customizable expected http response code BUG=1154032 Change-Id: Ia92533a9e8d0fa08d1156940d232314633057f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577004 Commit-Queue: Alice Gong <alicego@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834344}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607341806-857507b5a91b3ce5824fe454e7d197a8b05189bf.profdata to chrome-mac-master-1607363880-e91185c7ee902dd489788046475ba4c3a284e8fb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9211eb9e11042827de3f701504748e4f400c753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834343}
-
Leonid Baraz authored
Bug: 1078512 Change-Id: I2a49977934366c11f5d7a5d41f59162f6b93a2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574804 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#834342}
-
Becca Hughes authored
We need the favicon of the page that hosted the Media Feed for the UI so this stores the URL of the favicon in the Media History store. Change-Id: I98148726a2734fadb8106fa124624a37474d9035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568754 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834341}
-
Lijin Shen authored
If a11y is enabled when password is submitted, show infobar instead. Bug: 1153946 Change-Id: Ic5dc35b2596b995e62493fae211aad0c1e191362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566727 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#834340}
-
David Tseng authored
R=dmazzoni@chromium.org Change-Id: Ic8c51de3c4ac96cdcc496842a9a3698a976778e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577543Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834339}
-
Jeremy Roman authored
This will do a single allocation of the right size. Bug: None Change-Id: I777f61ff740f5d375c8aa461431f92dee1fbb6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570412 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#834338}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1502e7972cb..48b2aad780bf 2020-12-07 lalitm@google.com Merge "perfetto_cmd: remove reference to legacy dropbox" 2020-12-07 eseckler@google.com Merge "Add json_agent_label_filter to chrome_config proto configuration." 2020-12-07 primiano@google.com Merge "GN: Add standalone build rules for Windows" 2020-12-07 lalitm@google.com Merge "ui: improve perf of query for CPU stack samples" 2020-12-07 eseckler@google.com Merge "processor: Fix memory leak in MemoryTrackerSnapshotParser" 2020-12-07 lalitm@google.com Merge "Add new dynamic table to look up ancestors of CPU stack samples." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic3baf8c291f643144cad59ddf3d5663e3a0e9eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834337}
-
Jeffrey Young authored
Privacy notice that searches are powered by assistant is no longer necessary as of crbug.com/1103703. Users now see a single assistant search result with a visible assistant icon that makes it clear that specific search result is powered by assistant. BUG=b:174506130 TEST=Open launcher on new account, search, see no assistant privacy disclosure Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I7a587218cddeb23aec0004478861ec156d29ee72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567093 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#834336}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0f0bcb39f3fc..bc7e5ac1c908 2020-12-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 29886952..c24aab83 (834077:834189) 2020-12-07 sprang@webrtc.org Update how FEC handles protection parameters for key vs delta frames. 2020-12-07 alessiob@webrtc.org AGC2: Fix GetAvailableCpuFeatures() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9480c297858830dbd5b0d24bb525513e2fee77e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834335}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95a2d3216488..9f2e7d4d1359 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ellyjones@google.com,avi@google.com Change-Id: I52eaad6c75961e5b2dccfba194be5cba60592023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834334}
-
John Abd-El-Malek authored
Change-Id: Ib46c3dfbcbd26ec3338d5aace58a670c9eaf33d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574753 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#834333}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88efddc6a162..4565794f5eda 2020-12-07 cduvall@chromium.org Add ProcessCreateToApplicationStart metric to androidStartup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1150600 Tbr: wenbinzhang@google.com Change-Id: I9a2b627e8cfc841d9d4d906a480169c83c56865b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834332}
-
Sigurdur Asgeirsson authored
Bug: 1155660, 1145565 Change-Id: Ib7ce976d409169daeeda57a056ef71c655d1b29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576013Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834331}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/512ff75a0bad..b21fac24817a 2020-12-07 johnstiles@google.com Detect cases in Metal where out params are swizzled. 2020-12-07 bsalomon@google.com Remove rendundant tests/GrTestingBackendTextureUploadTest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I9489c53d4ab7ec6b38254dc32615b1d1b750fc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834330}
-
Erik Chen authored
This CL creates a new user-visible flag: Lacros stability. By default, users will receive a less stable version of Lacros. Users can enable the flag to release a more stable version. This CL adds two new lacros components, in addition to the existing component. This is necessary since lacros is moving from build numbers to milestone numbers, e.g.821112 -> 89.0.X.Y, and component updater does not support updating to a lower integer. This CL fixes about://flags to show the Lacros support flags if the feature is enabled on Stable channel via Finch. Change-Id: I33ea84805740c588d15f27e6dd7c31c00282576a Bug: 1154911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570386Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834329}
-
Eugene But authored
This is a follow up cleanup to crrev.com/c/1884550 where didFailOpenInMenuPresentation method call was removed. Bug: None Change-Id: I15f5f6982776681139397adbf937b28d6caea56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572781Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#834328}
-
Kramer Ge authored
wl_surface.commits of a frame can happen asynchronously due to wl_buffer import delay, frame callbacks, etc. This asynchrony can cause visual glitches when the root_surface commits before its subsurfaces commit. This CL ensures that a root_surface commit always happens after other commits in a frame. Change-Id: I7c83e122c4cdee42e6b8aca74875fa71b6c1ab5a Bug: 1144179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547395 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#834327}
-
Dominique Fauteux-Chapleau authored
This is done now to keep messages in sync in both code repos See cl/345275972 Bug: 1147036 Change-Id: Id779bdcebb68498daabb541d570f0d66c40b84a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570746Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834326}
-
Jeffrey Cohen authored
[Project Code Inclusion] Remove all uses of whitelist/blacklist in chrome/android/.../keyboard_accessory Bug: 1149543 Change-Id: I333d790ab61033d576e245c0e7ee243461c05aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572687Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834325}
-
Daniel Rubery authored
The metrics: SafeBrowsingBinaryUploadRequest.AdvancedProtectionScanVerdict and SafeBrowsingBinaryUploadRequest.MalwareScanVerdict had already been stopped being logged in https://crrev.com/c/2505943, so mark them obsolete and document the replacements. Fixed: 1153857 Change-Id: I9d732bdcebaffe312063dd749ebb69873f6fe12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577601 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#834324}
-
Fredrik Söderqvist authored
To avoid future clash with the member function with the same name. Bug: 1028063 Change-Id: I60dbf53c1949a7ee6e1000ea20629f10d35e6778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577223 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#834323}
-
chrome://kaleidoscopeBecca Hughes authored
This is so it can be used on the NTP. Change-Id: I6c3f2ee45a5b8c570661618191c81f1fb24a9e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441260Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#834322}
-
Sky Malice authored
Bug: 1155365 Change-Id: I2744a73368c450aa1cae0844a67503a1c0cd5347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573776Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#834321}
-
Garrett Beaty authored
Now that we no longer have multiple milestone-based buckets, it is safe to refer directly to the bucket when referencing another builder, so the builder_name function provides no value. Change-Id: If64a68d4d6e3c153c5d832a656fc2976ef18c7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576945 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834320}
-
Tim Volodine authored
Move the client side model loader code which currently lives in chrome/browser/safe_browsing/ to components/safe_browsing/content/ browser/ in order to be reused by both the chrome and weblayer implementations. The client_side_model_loader code is used by the ClientSideDetectionService and the PhishingDetector for setting the phishing model. This CL also moves the corresponding unit test, so that it will be running as part of the components unit tests. BUG=1115700,1152490 Change-Id: I5347884ae8c7f808f4b73858edba30237437a36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558399 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#834319}
-