- 14 Dec, 2017 40 commits
-
-
Xing Liu authored
Currently we have an issue that the Control group always read the default configuration of parallel download defined in the code. However, when tweaking the server config, we can use different slice size, which will result in experiment groups comparing different sample sets. This CL adds a Finch parameter to alternatively disable parallel download in an enable experiment group, and also read configs from the server. Bug: 794718 Change-Id: I9cf91233cbaf3dd22917af2e026c736803bd8e19 Reviewed-on: https://chromium-review.googlesource.com/825984 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#524109}
-
Yves Arrouye authored
This will allow certificates to be typed even if we send an empty PEM certificate which the server can act on. Bug: 778535 Test: unit_tests Change-Id: Iadc2d94c4cdd558dc46086b7cea629f7f92e8ae7 Reviewed-on: https://chromium-review.googlesource.com/822164Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#524108}
-
Robert Ma authored
Bug: 765334 Change-Id: I8b88d07d40314fb3c4554530e3e1918f301b0202 Reviewed-on: https://chromium-review.googlesource.com/827035Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524107}
-
Quinten Yearsley authored
Change-Id: Ib01ff5242683a9d67c89558ab0c52d9a08d61196 Reviewed-on: https://chromium-review.googlesource.com/826263Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#524106}
-
kylechar authored
Create directly with std::make_unique instead. TBR: boliu@chromium.org, tedchoc@chromium.org Bug: 792192 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I97442118fef4efb6dd0be4e64b5f140499a469f2 Reviewed-on: https://chromium-review.googlesource.com/826428Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524105}
-
Eric Stevenson authored
Bug: Change-Id: Ia17a468fdbb5b70ddac99594aa2c2a9903b55a4f Reviewed-on: https://chromium-review.googlesource.com/825103Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524104}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/63789ccc03f6..e9188850ec2f $ git log 63789ccc0..e9188850e --date=short --no-merges --format='%ad %ae %s' 2017-12-14 kjlubick Revert "Revert "Disable extra CPUs during Nanobench"" 2017-12-14 mtklein add back purgeResourcesNotUsedInMs() temporarily 2017-12-14 mtklein Revert "Disable extra CPUs during Nanobench" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I6fea8c36e32eb67487da8bda42201291d529f544 Reviewed-on: https://chromium-review.googlesource.com/827083Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524103}
-
Aaron Leventhal authored
Do not return ROLE_SYSTEM_WINDOW ourselves as that is a special MSAA system role used to indicate a real native window object. It is automatically created by oleacc.dll as a parent of the root of our hierarchy, matching the HWND. For AX_ROLE_WINDOW, we should expose something similar to what Firefox exposes, namely ROLE_SYSTEM_APPLICATION. This helps NVDA not read superfluous text when the user navigates to the toolbar or location bar. Bug: 794931 Change-Id: I123f07cb477304da1f016d65ea8c2b23b7a92ef4 Reviewed-on: https://chromium-review.googlesource.com/826866Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524102}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/97e6e42e3e39..4b9d944868d0 $ git log 97e6e42e3..4b9d94486 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 simonhatch Dashboard - Remove call to GetOrCreateAncestors in /add_histograms Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia440f4c31039dea476abad558c74f0c4b32b43b4 Reviewed-on: https://chromium-review.googlesource.com/826803 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524101}
-
Vladimir Levin authored
This patch enables checker imaging subject to heuristics for images that were explicit marked as decoding=async by the developer. R=khushalsagar@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I460402d0f0ff9eb0bbb1262f87b275f5410d5c2a Reviewed-on: https://chromium-review.googlesource.com/825650 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524100}
-
Nicolas Dossou-Gbété authored
This reverts commit 241cb0e4. Reason for revert: Internal Android ToT broken, please review and update downstream usage before relanding. Original change's description: > [WebPayments] Drop trans. layer for Mojo structs > > Full Title: Drop Translation Layer for Some PaymentRequest Mojo Structs > > Currently we have C++ classes duplicating our Mojo structs; it turns out > this is unnecessary and adds a lot of complexity. This change removes > two of them (PaymentAddress, PaymentCurrencyAmount) as a first step > towards removing all of them. To allow using these structs on iOS, which > does not use WebKit, we have to move these back to the components > directory, where they originally lived. My tentative plan is to move > the remaining mojo structs to components, split between the > payment_request_data file added in this CL, and a new > payment_request_interface file for the bits which will not be included > on iOS (where communication with the renderer does not use Mojo). > > Bug: 775631 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I7e4a4b21fe8c75c37b95fb12658114d1994f4a66 > Reviewed-on: https://chromium-review.googlesource.com/738515 > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524087} TBR=palmer@chromium.org,dcheng@chromium.org,rouslan@chromium.org,sdefresne@chromium.org,tedchoc@chromium.org,tmartino@chromium.org,mahmadi@chromium.org Change-Id: I02b048666c4b510ec98bacb8f52bfffbee00d18a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775631 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/826224Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524099}
-
arthursonzogni authored
The issue was in: AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies() AwContentsIoThreadClient::FromID(render_process_id, render_frame_id) was used, but at this point a navigation request is not associated with a renderer process yet. It caused the cookies not being sent with the request. The solution was to use AwContentsIoThreadClient::FromID(frame_tree_node_id) instead. Bug: 793648, 794939 Change-Id: I5bda7affab67645cfd64c105b06c8a628047dd79 Reviewed-on: https://chromium-review.googlesource.com/827018 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#524098}
-
Gabriel Charette authored
The Client interface was diluted down to a single method at this point. Different implementations of overriding Delegate's Run() methods will need different behaviors from ShouldQuitWhenIdle(). Making it easily overrridable is key. One such example behaviour is when overriding a MessageLoopForUI/IO. When waiting inside a Run() with no more tasks, control needs to remain in the hands of the overridden MessageLoop as it may receive work first (from the system) and therefore shouldn't quit-when-idle when the overriding Delegate is out of work (the overriding Delegate can let it know to wake by posting a task to it if it gets work first). R=thestig@chromium.org Bug: 708584 Change-Id: I27a449bc3be5858b0e8d4d6482714523ad5e2b67 Reviewed-on: https://chromium-review.googlesource.com/817962 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#524097}
-
Robert Sesek authored
Bug: 598854 Change-Id: I9cfe27590794d63903347f50daa1698ee6961bb1 Reviewed-on: https://chromium-review.googlesource.com/826442 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Somewhere along the way we stopped listening to recycler events, which breaks the mechanism that invalidates old (outdated) requests for decoding. This CL reinstates that. Bug: 793934, 656015 Change-Id: I0df070c851bb75a1dccd1e7b5854c8846905ceb9 Reviewed-on: https://chromium-review.googlesource.com/827015Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524095}
-
Ian Vollick authored
With this change, rects can now have individually configurable corner radii. This does not apply to textured quads, and the utility for this is not as clear. (Also converts a few arguments to const refs and updates shadow to set the corner radius automatically). Bug: 782703 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id49a1cce69dc59178c1b4a8ce15df8f8016bf709 Reviewed-on: https://chromium-review.googlesource.com/827026 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#524094}
-
Aleks Totic authored
https://chromium-review.googlesource.com/c/chromium/src/+/727781 broke printing of DataRefs This commit makes DataRef print like this: (gdb) p container_style.box_data_ $2 = DataRef(scoped_refptr((blink::ComputedStyleBase::StyleBoxData *)0x1e6143288 170)) Bug: 763844 Change-Id: I6ebcdd2d32b032659d3cc00973859c23ccb8b693 Reviewed-on: https://chromium-review.googlesource.com/826262Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524093}
-
Eric Stevenson authored
The default implementation simply calls the original method. Bug: 793816 Change-Id: I2ac147d5318d6a04db2d9cec46659d574383b005 Reviewed-on: https://chromium-review.googlesource.com/824722 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
Ian Vollick authored
In the conversion to SetAndDirty, a regression was introduced: the URL was not marked as dirty when the color scheme changed. The result was that a portion of the URL bar would update (eg, the security icon), but the URL itself would not update. With this CL, we set dirtiness. Bug: 794956 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I02fec20ede52eb165a19445a6b28b2b5bcb2ca4b Reviewed-on: https://chromium-review.googlesource.com/827028Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524091}
-
rnephew authored
Bug: 781409 Change-Id: I89a3561584e18dc56e411bceb0ee25d72e996989 Reviewed-on: https://chromium-review.googlesource.com/818331Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#524090}
-
Marc Treib authored
Currently there is a race condition between IPC messages from the browser to the renderer, and the page load in the renderer. This CL makes SearchBox (on the renderer side) accept those messages a bit earlier, which should mitigate the problem somewhat (though it won't actually fix it). Bug: 793818, 794942 Change-Id: Iad3bf3afbc0d46093ee2eb06bcf60de99849991c Reviewed-on: https://chromium-review.googlesource.com/827068 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#524089}
-
yiyix authored
Users are now able to turn on draw occlusion by set flag enable draw occlusion to true in chrome://flags. TEST: build to chrome os device and verify if draw occlusion is turned on when the flag is set to true. Bug: 672929 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibfca7fd5f91a8f7c04ea20db62029b0ab3a78870 Reviewed-on: https://chromium-review.googlesource.com/826103 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Tommy Martino authored
Full Title: Drop Translation Layer for Some PaymentRequest Mojo Structs Currently we have C++ classes duplicating our Mojo structs; it turns out this is unnecessary and adds a lot of complexity. This change removes two of them (PaymentAddress, PaymentCurrencyAmount) as a first step towards removing all of them. To allow using these structs on iOS, which does not use WebKit, we have to move these back to the components directory, where they originally lived. My tentative plan is to move the remaining mojo structs to components, split between the payment_request_data file added in this CL, and a new payment_request_interface file for the bits which will not be included on iOS (where communication with the renderer does not use Mojo). Bug: 775631 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e4a4b21fe8c75c37b95fb12658114d1994f4a66 Reviewed-on: https://chromium-review.googlesource.com/738515 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#524087}
-
arthursonzogni authored
This CL disable "Convert Enter-in-omnibox to a reload" when the navigation entry are created by WebView. Some WebView initiated navigation were misclassified as "reload". Bug: 794020 Change-Id: I443bc00601c33c94005aec0eb4f1592f83b6f64b Reviewed-on: https://chromium-review.googlesource.com/824682Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524086}
-
Victor Costan authored
The mojo typemaps for BlinkCloneableMessage and BlinkTransferableMessage specify that the structs are move-only, so the code in the mojo bindings uses std::move. However, since the structs declare a custom constructor (the constructor is defaulted in the .cpp, but the compiler can't see this from the .h), no move constructor or move-assignment is generated, and the structs are copied rather than being moved. The mismatch causes extra reference increments / decrements. When the underlying type uses thread-safe reference counter (like SerializedScriptValue does), increments and decrements use atomic operations, which are not cheap on ARM. This CL adds move constructors and move-assignment operators to BlinkCloneableMessage to allow moving, and adds DISALLOW_COPY_AND_ASSIGN to prevent accidental copying. This CL also adds DISALLOW_COPY_AND_ASSIGN to the browser-side structures corresponding to Blink{Cloneable,Transferable}Message, to make it obvious that they are move-only. Bug: 794791 Change-Id: Iffe8f1e65bf9ccc2cd98082c341c2bdc3246fa33 Reviewed-on: https://chromium-review.googlesource.com/826260 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#524085}
-
Jonathan Metzman authored
Bug: 794796 Change-Id: I28c6579ebe3062f342f19748b2b1b1b21e185104 Reviewed-on: https://chromium-review.googlesource.com/826684Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524084}
-
Nico Weber authored
No intended behavior change. Bug: 774209 Change-Id: Iffa593253058c5ab8a81712be216b903be23b0c4 Reviewed-on: https://chromium-review.googlesource.com/826173 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#524083}
-
Marc Treib authored
This fixes a problem where both Omnibox and fakebox could have visible focus at the same time. Bug: 792850 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id4801641c1ee192ffef943ecb738abf41fecc348 Reviewed-on: https://chromium-review.googlesource.com/827076Reviewed-by:
-
danakj authored
This reverts commit 1050c3ac. Reason for revert: Did it's job. Original change's description: > Look for why ChromeOS bots are flakily using software compositing. > > This adds some NOTREACHED() on ChromeOS to figure out why tests are > disabling gpu compositing. > > R=zmo@chromium.org > > Bug: 793303 > Change-Id: I6ee99fc334c34c292bcb1e3568108e422d43da4c > Reviewed-on: https://chromium-review.googlesource.com/826382 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523958} TBR=danakj@chromium.org,zmo@chromium.org Change-Id: I439a4775e1dfa9329da9cbbd416a4bad11bd71e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 793303 Reviewed-on: https://chromium-review.googlesource.com/827142Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c617901..327c9d94 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4680fca86bd30e7721b8de4dee8725e9797bb22a Reviewed-on: https://chromium-review.googlesource.com/827024Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524080}
-
Allen Bauer authored
Per this comment on linked bug: https://crbug.com/651643#c62 Bug: 651643 Change-Id: Ic90a7a83232d4c3eace025872ef839d68d68d45c Reviewed-on: https://chromium-review.googlesource.com/823083Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524079}
-
Shivani Sharma authored
This CL adds a browser test that tests that globally allowing ads should work as expected. We had a unit test for this earlier but not a browser test. Bug: Change-Id: Ieb43a5512eb5c54a94fee79f7d39fe8d51c6796f Reviewed-on: https://chromium-review.googlesource.com/826165 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#524078}
-
kylechar authored
These tests were failing because of a flag not being passed. Try enabling on FYI. TBR: jonross@chromium.org Bug: 793302 Change-Id: Ic780a2545199c7c7d81014f3650c95de1b19f57c Reviewed-on: https://chromium-review.googlesource.com/827027Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524077}
-
Justin Novosad authored
BUG=793667 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifc75e2d1545346cf618a6a2303dc659369040674 Reviewed-on: https://chromium-review.googlesource.com/824983Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524076}
-
Mike West authored
Bug: 794098 Change-Id: I7f2e05edcf08b67b09a00a6707857d38a0d2028e Reviewed-on: https://chromium-review.googlesource.com/827007 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#524075}
-
Morten Stenshorne authored
This is a reland of 4e246b2e Original change's description: > [LayoutNG] Don't let legacy layout re-enter layout of a scrollable block node. > > We'd end up re-entering NGBlockNode::CopyFragmentDataToLayoutBox() for > the same node. > > After layout of a fragment, NGBlockNode::CopyFragmentDataToLayoutBox() would > call LayoutBlock::UpdateAfterLayout(), which would call > scrollbar was toggled, it'd go ahead and call UpdateLayout() on the object, > which would take us back into the NG layout machinery, on the same node, via > Finally we'd re-enter NGBlockNode::CopyFragmentDataToLayoutBox(), causing misc > kinds of misery, such as not being able to paint the block at all. For > multicol, there'd even be a DCHECK failure "Variable fragment inline size not > supported", because the code got confused as to whether a fragment was a first > fragment or not. > > LayoutBox: :UpdateAfterLayout(), which would call > PaintLayer: :UpdateSizeAndScrollingAfterLayout(), which would call > PaintLayerScrollableArea: :UpdateAfterLayout(). If this code detected that a > LayoutNGBlockFlow: :UpdateBlockLayout(), further to NGBlockNode::Layout(). > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I832372223e324682bb4e38b3177dce30093df2e1 > Reviewed-on: https://chromium-review.googlesource.com/824265 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524039} TBR=eae@chromium.org Change-Id: I5aceb5c45c8fa60b20fa481318f05c609ca2b46b Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/826985Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#524074}
-
Miguel Casas-Sanchez authored
Our code search doesn't linkify crbug[.com] if they are not prefixed with http[s]:// (e.g. [1]). This CL adds a warning on upload that this is happening and suggests prefixing https://, since it seems like we are not going to be able to linkify them automatically in CS anytime soon (see bug). It looks a bit like: ** Presubmit Warnings ** Found unprefixed crbug.com URL(s), consider prepending https:// ui/ozone/platform/drm/gpu/gbm_buffer.h:107 // TODO(mcasas): crbug.com ui/ozone/platform/drm/gpu/gbm_buffer.h:108 // TODO(mcasas): crbug/123 [1] https://cs.chromium.org/chromium/src/BUILD.gn?type=cs&q=crbug.com&sq=package:chromium&l=65 Bug: 762061 Change-Id: Ib58bc6b58dfa61a7bf421b0ed55184705cee767c Reviewed-on: https://chromium-review.googlesource.com/822973Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524073}
-
David Bokan authored
VisualViewport:pageLeft and pageTop returns the visual viewport's offset from the document origin. This means it's a combination of the layout viewport's offset and the visualViewport's offset within the layout viewport. Currently, this uses the effective root scroller as the layout viewport. However, this can be used to leak information through a cross origin iframe and will break down for OOPIFs. The sensible thing to do here is to redefine these values to always use the original layout viewport. Bug: 505516 Change-Id: I616d497cc6f1ebe003ff48701da3d6691dc38326 Reviewed-on: https://chromium-review.googlesource.com/806479Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524072}
-
Marc Treib authored
This info is already sent in NavigationEntryCommitted, which covers all relevant cases. No need to re-send almost immediately. Bug: none Change-Id: I125b8dd53a2c487c129cee98eb2d09527394263a Reviewed-on: https://chromium-review.googlesource.com/827071Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9daae51c4ad8..63789ccc03f6 $ git log 9daae51c4..63789ccc0 --date=short --no-merges --format='%ad %ae %s' 2017-12-14 mtklein Revert "Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB" 2017-12-13 kjlubick Disable extra CPUs during Nanobench 2017-12-13 rmistry [Infra] Automatically submit docs updates 2017-12-12 update-docs Update markdown files 2017-12-13 rmistry [Infra] Fix skiaserve source location again 2017-12-13 brianosman Remove SkColorSpace_Base::MakeNamed, along with most uses of Adobe RGB 2017-12-13 robertphillips Add GrBackendTexture & GrBackendRenderTarget access methods to GrTexture and GrRenderTarget 2017-12-13 liyuqian Add strip 2pt conical GM Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ied30e2d339414d1eb2772d5a837c8870a2cd1053 Reviewed-on: https://chromium-review.googlesource.com/826563Reviewed-by:
-
