- 03 Aug, 2017 40 commits
-
-
Lucas Garron authored
Bug: 744703 Change-Id: Ibbded8b3ea454856543802eacc46cab8ff766cfc Reviewed-on: https://chromium-review.googlesource.com/599009Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#491763}
-
Daniel Kenji Toyama authored
This CL was cloned from https://codereview.chromium.org/2965173002/. Create a new class `ContextualSuggestionsService` to fetch experimental contextual suggestions for the omnibox. Bug: 692471,609084, 750985 Change-Id: Ib54be91b1c0e2cb1fcdaf9a7a43b71984e5c358c Reviewed-on: https://chromium-review.googlesource.com/576284 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491762}
-
Jérôme Lebel authored
Bug: 661794 Change-Id: I9e9844e73583288581e9700228708edc39dfd580 Reviewed-on: https://chromium-review.googlesource.com/561147Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491761}
-
Jérôme Lebel authored
Bug: Change-Id: Iddb5e3162a028dbd805e2a823e2244fc8ddf4214 Reviewed-on: https://chromium-review.googlesource.com/600430Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491760}
-
Robert Sesek authored
After changing to the __builtin_available() syntax in 51938fff, crdmg's sandbox blocked reading the SystemVersion.plist, which caused crdmg to not properly detect the OS version. Bug: 752128 Change-Id: I2d1035c4de8c2f0559ccabc06eaf046da2f6522b Reviewed-on: https://chromium-review.googlesource.com/600129Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491759}
-
Ken Rockot authored
If a channel error is triggered from off-thread and posted to the IPC thread, we weren't ensuring that a RequestContext was in TLS. If the error lead to event notifications this would cause a nullptr deref. Fixes that. BUG=752137 TBR=jcivelli@chromium.org Change-Id: Iae167a712c9b7d8d853fe805c06afef36d2c4572 Reviewed-on: https://chromium-review.googlesource.com/600291Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491758}
-
Robert Hogan authored
This is a reland of b4ee3ace Original change's description: > Position fixed backgrounds in table sections correctly > > Bug: 35697 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62 > Reviewed-on: https://chromium-review.googlesource.com/594987 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491294} Bug: 35697 Change-Id: I99cabe9c8808eb973b88087c5be1115d18e80313 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/598240Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#491757}
-
Danyao Wang authored
Bug: 734150 Change-Id: I934af65ec2e0841aed86e0753071a8d6b091fc10 Reviewed-on: https://chromium-review.googlesource.com/596908 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#491756}
-
Vasilii Sukhanov authored
This is a reland of d95936bd Original change's description: > Move the task runner creation to password store from the factory. > > In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop. > > Bug: 741660 > Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d > Reviewed-on: https://chromium-review.googlesource.com/584908 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491693} Bug: 741660 Change-Id: I9ef1b4304f69dbf6fb3dc98dcec5843e92fc6371 Reviewed-on: https://chromium-review.googlesource.com/600207Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491755}
-
sebsg authored
Bug: 752122 Change-Id: I90870a875855161b49e03bd1b4e7870f76dec694 Reviewed-on: https://chromium-review.googlesource.com/600289Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491754}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c3faf19..ee634fd9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I5a703f9defaf33531957446efa9839d6b6efde8c Reviewed-on: https://chromium-review.googlesource.com/600171Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491753}
-
Greg Thompson authored
Specifically, staged files are now ignored regardless of case and containing directory. BUG=673900 Change-Id: I72ded358fbde1c525eaec538ebdb184a79b58c6e Reviewed-on: https://chromium-review.googlesource.com/598091Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491752}
-
Tommy Martino authored
Changing behavior when clicking on the currently selected item in an ItemList. Was a no-op; now goes back to the main sheet. Bug: 748552 Change-Id: I43f716145c059b6d95d5f01526b1224528fb0ad3 Reviewed-on: https://chromium-review.googlesource.com/585370Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#491751}
-
David Benjamin authored
This is a reland of https://chromium-review.googlesource.com/c/595155 with a fix to a field that wasn't initialized. Until we do https://crbug.com/458365 and remove the global session cache, consumers making SSLClientSockets with the default empty shard should not enable session caching, as they'll interact with other sockets which do that. Bug: 458365 Change-Id: Ib8d0ecf72584b687a768e080dc31439c625ac412 Reviewed-on: https://chromium-review.googlesource.com/598709 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491750}
-
Danyao Wang authored
This uncovered a bug where GetLastCommittedItemIndex() returned the incorrect value because it assumes WKBackForwardList's |currentItem| is always the last committed item. This is not the case if the pending navigation is a back-forward navigation. It turned out that this can't be fixed 100%, but implemented a heurstic and documented the edge case. Bug: 734150 Change-Id: Ie2c026a2c5231cbd4151c106cd0db664dcf6d587 Reviewed-on: https://chromium-review.googlesource.com/596828Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#491749}
-
gaschler authored
Refactor ImageFetchedCallback to be a move-only type callback, which has a clear lifetime. Bug: 752051 Change-Id: I46c8f47f60d88afd3f3825f20404189ff7cb5cc1 Reviewed-on: https://chromium-review.googlesource.com/600052 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491748}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/562197/, we introduced the concept of document paint definition, such that we can have two paint worklet global scopes. However, we didn't Implement the logic to switch between these two global scopes. This CL implements the logic. In particular, after every 120 frames that has called the paint function, we switch to use another global scope. Bug: 728595 Change-Id: Ie48a7e597deb10342ede64c42e595c0b11d779f1 Reviewed-on: https://chromium-review.googlesource.com/593633 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491747}
-
spqchan authored
Create a feature flag for this feature. Bug: 751784 Change-Id: I49ba9af40f68496b1e59f3e5f9fc5e0fa068ae6f Reviewed-on: https://chromium-review.googlesource.com/598628Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491746}
-
Stephen McGruer authored
Bug: 699244 Change-Id: Ie7d573bbda8e57cc718137f04a4b1fb0bde14355 Reviewed-on: https://chromium-review.googlesource.com/598589Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491745}
-
Anthony Vallee-Dubois authored
Bug: 735103 Change-Id: I54ac93cf34a37144dbf257d5f3768af64e319151 Reviewed-on: https://chromium-review.googlesource.com/595027Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491744}
-
Stephen McGruer authored
Bug: 699244 Change-Id: Iab42a2b1363fd3a55ae3bb77e0452157dc66ef89 Reviewed-on: https://chromium-review.googlesource.com/598708Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#491743}
-
gogerald authored
This CL changes the stored data scheme of the web payment app, so users have to re-register the web payment app after this patch. This should be fine since this feature is still behind the flag. Bug: 751737 Change-Id: I396960273dca51f82a4490fa2dd5f7756e3a0bf0 Reviewed-on: https://chromium-review.googlesource.com/598636 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491742}
-
John Mellor authored
dummy.c was failing to link under the orderfile build due to undefined references to __cyg_profile_func_enter and __cyg_profile_func_exit. This is because the orderfile build enables -finstrument-functions. This patch attempts to fix that by explicitly disabling cygprofile instrumentation for dummy.c BUG=750120 TBR=agrieve@chromium.org,pasko@chromium.org Change-Id: Ibe3cbbc5b55103840e7b55c3921cae242b185bba Reviewed-on: https://chromium-review.googlesource.com/600311Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#491741}
-
Justin Donnelly authored
This is controlled by the "Use a prediction service to help complete searches and URLs typed in the address bar" setting at chrome://settings/privacy. Bug: 751813 Change-Id: Iedf25fbb95e4fe1133fa994843068b26b749e36b Reviewed-on: https://chromium-review.googlesource.com/598933Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#491740}
-
Eugene But authored
WebState's WasShown/WasHidden is called from Tab, so WebStateObserver callbacks are actually work. WebStateObserver's WasShown/WasHidden callbacks will allow to move code from Tab to TabHelpers. Bug: 616244 Change-Id: I2d8f3eb0f5854dd7204b9aec6db2aac593309638 Reviewed-on: https://chromium-review.googlesource.com/596783Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491739}
-
Ian Kilpatrick authored
Add xidachen@ and flackr@ to modules/csspaint OWNERS. Change-Id: Ic7da1068210941673604d39351633ab4888bed52 Reviewed-on: https://chromium-review.googlesource.com/600193Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#491738}
-
Jérôme Lebel authored
Bug: Change-Id: I499cebffcc86aa708cfa99c7b5cdf556305dd0ce Reviewed-on: https://chromium-review.googlesource.com/600210 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#491737}
-
Charles Harrison authored
Bug: 751696 Change-Id: Ic306f3ce59d38e752503304f62bcd26e39b284cb Reviewed-on: https://chromium-review.googlesource.com/598988Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#491736}
-
Koji Ishii authored
Following bot results are included. 88{0..2} 884 888 896 68 lines were removed by consecutive passes since 873. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ic80527887a39c4e73fbf351fc22f01bef4fc54aa Reviewed-on: https://chromium-review.googlesource.com/600447Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491735}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/5788d24..a0bcc50 BUG=750813 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I54127f2ed6fa648e85a104a925fd3a6affaf5407 Reviewed-on: https://chromium-review.googlesource.com/598942Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491734}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ae532f68a035..698edfecef12 $ git log ae532f68a..698edfece --date=short --no-merges --format='%ad %ae %s' 2017-08-02 rmistry Chromium lkgr is no longer updated. Use lkcr Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I74d99a371eeb472761d6a0f52defea2745b78dda Reviewed-on: https://chromium-review.googlesource.com/600250Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491733}
-
sunxd authored
We used to unconditionally return not_solid_color when analyzing the op ClipRRect. This lead to huge memory usage of composited border-radius scrolling because we need to store the texture for the whole mask layer. This CL makes SolidColorAnalyzer capable of determining whether a tile is fully covered by the clip rrect, so we can save memory by not storing textures of solid color quads. Bug: 567293, 567296, 740720 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I24b10a2d68c0c608aec8e5a8bafaabb9800cd466 Reviewed-on: https://chromium-review.googlesource.com/591913Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491732}
-
Marc Treib authored
This CL adds a script to download a number of test doodle configs from the ddljson API. It also adds a captured snapshot of those configs, and a test that they all get parsed without errors. Bug: 690467 Change-Id: Idf8375a4199fc129b905c7f8cd32f12d071389e9 Reviewed-on: https://chromium-review.googlesource.com/597647 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491731}
-
Elly Fong-Jones authored
This change: 1) Makes FirstRunBubble::ShowBubble take an anchor point and a window to observe instead of both of these being implied by the anchor view; 2) Adds a class called FirstRunPresenter to share the logic used to wait to present the first run bubble between platforms; 3) Untangles LocationBar and ToolbarView from showing the first run bubble; 4) Adds chrome::ShowFirstRunBubbleViews() on Mac, to expose the Views first-run bubble Bug: 728160 Change-Id: I67de01f518a38120eb016ea2c6cd163dcf1c1356 Reviewed-on: https://chromium-review.googlesource.com/535735Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#491730}
-
John Mellor authored
This reverts commit d95936bd. Reason for revert: this caused PasswordStoreTest.GetLoginsWithAffiliationAndBrandingInformation to fail on KitKat Tablet Tester with the following error: [ERROR:connection.cc(1964)] Passwords sqlite error 5, errno 0: database is locked, sql: PRAGMA auto_vacuum [FATAL:connection.cc(1979)] database is locked https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FKitKat_Tablet_Tester%2F8506%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests_on_Android%2F0%2Flogs%2FPasswordStoreTest.GetLoginsWithAffiliationAndBrandingInformation%2F0 Original change's description: > Move the task runner creation to password store from the factory. > > In addition the CL changes some tests to use ScopedTaskEnvironment where appropriate instead of MessageLoop. > > Bug: 741660 > Change-Id: I9993eaba6bd92e30dfe4a39a5fb89518d5ba4a3d > Reviewed-on: https://chromium-review.googlesource.com/584908 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491693} TBR=vasilii@chromium.org,cfroussios@chromium.org Change-Id: Ifa8c22c62bab7f0200437e3c2ab7661b5fddc78a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 741660 Reviewed-on: https://chromium-review.googlesource.com/600211Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#491729}
-
Dominik Röttsches authored
Addressing remaining feedback from https://chromium-review.googlesource.com/c/581149 Bug: 749091 TBR: rune, eae Change-Id: I734d8115b021ea6f996a2d62064208326c8032df Reviewed-on: https://chromium-review.googlesource.com/598948Reviewed-by:
Rune Lillesveen <rune@opera.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491728}
-
Vasilii Sukhanov authored
Bug: 355145 Change-Id: I9627c0f70f4f9f27023c937e0d2a3a9db48de63f Reviewed-on: https://chromium-review.googlesource.com/600328Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491727}
-
Matt Menke authored
Bug: 715695 Change-Id: Ie0d1c6b22b96c9d144721953ba09fbe3a7528484 Reviewed-on: https://chromium-review.googlesource.com/596804 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#491726}
-
Justin Schuh authored
* Applied BASE_NUMERICS_LIKELY to all predictable clamped and checked branches. (I skipped things like abs, where the branch is not reliably predictable). * Simplified CheckedAddOp and CheckedSubOp, and optimized the generic code for smaller types (although Clang will always use the builtins). * Expanded the cases where CheckedMulOp will use the Clang builtin (this branch is compile-time determined, and should be an improvement on 64-bit). * Restructured CheckedDivOp to allow the compiler remove more of the overflow checking based on compile-time type checks. * Simplified CheckedModOp by putting all the logic in one function. * Simplified branching and eliminated multiplication in CheckedLshOp and ClampedLshOp (much more compact code on Arm, but still unavoidably a bit branchy). * Removed branch in CheckMathOp (variadic template wrapper). Note: Arm code should remain mostly non-branching, unless Clang's optimizer behavior changes in the future to assume better branch prediction (at which point it should branch on the exceptional conditions, like Intel currently does). Bug: 750184 Change-Id: I9948b94722d64e9a5bf363690acf9086dae0c65d Reviewed-on: https://chromium-review.googlesource.com/592852 Commit-Queue: Justin Schuh <jschuh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#491725}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a14a5f4f..6c3faf19 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ic36ec4f4a237839e3bbe3860d4edadf9c0d7977a Reviewed-on: https://chromium-review.googlesource.com/600167Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491724}
-