GitLab

This allows us to address one of the top user-reported problems with
Chrome Remote Desktop on Linux; namely that when users run Chrome
inside their virtual desktop, it simply opens a new window in their
existing Chrome instance (or, worse, if the first run of Chrome is in
their virtual session, then it prevents them running Chrome on the
console).

Once this change hits Stable, we will be able to update our
virtual session start-up scripts to set the environment variable,
letting the user run Chrome on both their console and virtual
desktops. They can then use Chrome Sync to keep bookmarks etc.
synchronized.

BUG=253614

Review URL: https://chromiumcodereview.appspot.com/23651006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222160 0039d316-1c4b-4281-b951-d872f2087c98

Linux/GTK only.

BUG=282509
TEST=ln -s fake.com-123 SingletonLock, then run Chromium, then check that [ Quit ] and [ Unlock and Relaunch ] work.

Review URL: https://chromiumcodereview.appspot.com/23506011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222159 0039d316-1c4b-4281-b951-d872f2087c98

Sets the mapped memory reclaim limit for the renderer compositor on Android. Also moves the max_bytes_pending_upload limit of the PixelBufferRasterWorkerPool to the RenderWidgetCompositor since the mapped memory reclaim limit depends on it.

BUG=272591

Review URL: https://chromiumcodereview.appspot.com/22900018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222158 0039d316-1c4b-4281-b951-d872f2087c98

Per latest designs from UX, move to the 3 line format provided by the
Notification Center, remove all multi-line notification data, and always
use the first profile image photo instead of the app icon for multiple
senders.

BUG=281520

Review URL: https://chromiumcodereview.appspot.com/23981004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222157 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements DesktopMediaPicker for the Mac used by the Desktop Capture API to present the user with a list of sources (including live thumbnails) to use.

BUG=237907

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221874

Review URL: https://chromiumcodereview.appspot.com/23944003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222156 0039d316-1c4b-4281-b951-d872f2087c98

Redo the code for handling the tabs API and tab ID translation to make
it more generic.  Make it table driven: there is now a table of API
calls that can contain URL arguments, so it is easy to add additional
API calls that we want to have URLs extracted from.  Add a couple of
others I've come across in testing.

BUG=253368, 275701

Review URL: https://chromiumcodereview.appspot.com/23545012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222155 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a new object to communicate cross-thread cancellation signals.
This new object, the CancellationSignal, is protected by a lock.  It
allows the receiving thread to query whether or not a stop has been
requested.  It also allows the receiving thread to safely register a
cross-thread callback to be invoked immediately when a stop is
requested.

This class is used to reimplement the UI thread to sync thread early
shutdown signal.  Previously, the UI thread would try to call in to
objects owned by the sync thread.  This required a workaround if the
signal arrived very early, since we couldn't guarantee the sync thread
had actually created those objects until later.  The CancellationSignal
is owned by the UI thread, so it is safe to call its RequestStop() at
any point during sync initialization.  The sync thread will receive the
signal when it's ready.

The new scheme has a few advantages over the old:
- Thread ownership is simpler.  The SyncBackendHost::Core, SyncManager,
  ServerConnectionManager, SyncScheduler and Syncer can now claim that
  all their member functions run on the sync thread.
- We no longer need to implement special case logic for when a shutdown
  is requested before the SyncManager has initialized.
- In a future CL, we can take advantage of the fact that we no longer
  require the special case to reduce inter-thread communication during
  sync startup.  This will make startup simpler and, in some cases,
  improve sync startup time by as much as a few hundred milliseconds.
- This will make it easier to address crbug.com/236451.

BUG=236451

Review URL: https://chromiumcodereview.appspot.com/23189021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222154 0039d316-1c4b-4281-b951-d872f2087c98

ActivityLogPrerenderTest.TestScriptInjected browser test failed on win xp.
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%28dbg%29%283%29/builds/39433

> Remove unsafe access hacks from ScopedPersistent.
> 
> BUG=236290
> 
> Review URL: https://chromiumcodereview.appspot.com/23636015

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/23724028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222151 0039d316-1c4b-4281-b951-d872f2087c98

Rather than throwing a generic LookupError exception when the timeline marker
cannot be found in the trace, throw a MissingTimelineMarker which is a subclass
of page_measurement.MeasurementFailure. These exceptios get caught by the page
runner.

Stop catching LookupError exeptions in _RunPage.

BUG=238864

Review URL: https://chromiumcodereview.appspot.com/23766009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222150 0039d316-1c4b-4281-b951-d872f2087c98

can be identified in stack traces, and filtered out when showing to developers.

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/23604050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222149 0039d316-1c4b-4281-b951-d872f2087c98

When window caption buttons are placed on the right side of the window,
they now look identical to the GTK port.

BUG=281788

Review URL: https://chromiumcodereview.appspot.com/23447015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222148 0039d316-1c4b-4281-b951-d872f2087c98

Original patch from dgwallinga@chromium.org at
https://codereview.chromium.org/23505003.

TBR=estade
BUG=258626,258649

Review URL: https://codereview.chromium.org/23454019

Patch from Dane Wallinga <dgwallinga@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280512
BUG=278899
TEST=See bug for repro steps.

Review URL: https://chromiumcodereview.appspot.com/23978003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222146 0039d316-1c4b-4281-b951-d872f2087c98

keep_test_server_ports to BrowserOptions (this should probably go into AndroidBrowserOptions). android_rndis is a new ctor arg to AndroidBrowserBackend.

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/23619022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23467008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222144 0039d316-1c4b-4281-b951-d872f2087c98

Per vandebo's suggestion, this is a minimal fix to the security-hole meant
for backporting/merging.

https://codereview.chromium.org/23760004/ is the long-term fix.

BUG=284792

Review URL: https://chromiumcodereview.appspot.com/23461031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222143 0039d316-1c4b-4281-b951-d872f2087c98

* Added getting_started/ parallel to examples/
* Added getting_started/part1/ which is a quick port of hello_tutorial from the
  NaCl SDK documentation page.
* Added support for examples not using auto-generated Makefiles
* Disbled testing of getting_started/part1 (it doesn't have the test hooks)
* Moved examples/getting_started/simple_hello_world =>
        examples/tutorial/using_ppapi_simple

BUG=none
R=eliben@chromium.org

Review URL: https://codereview.chromium.org/23661005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222142 0039d316-1c4b-4281-b951-d872f2087c98

Failed unit tests on chromeos-asan:
  ChromeLauncherControllerTest.UnpinWithUninstall
  ChromeLauncherControllerTest.PendingInsertionOrder
  ChromeLauncherControllerTest.PersistLauncherItemPositions

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/9780

> Makes BrowserStatusMonitor remove observers in destructor
> 
> I'm seeing a crash where we have a dangling TabStripModelObserver,
> this is one possible place. At the same time I'm making the class only
> look for HOST_DESKTOP_TYPE_ASH browsers.
> 
> BUG=286162
> TEST=none
> R=skuhne@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/23455037

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/23538010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222138 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286468
TEST=tree

Review URL: https://chromiumcodereview.appspot.com/23513025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286029

Review URL: https://chromiumcodereview.appspot.com/23819034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222133 0039d316-1c4b-4281-b951-d872f2087c98

Update UIResource tests to obey the restriction that ScopedUIResource
create and destroy calls may only be made on the main thread.

BUG=279438

Review URL: https://chromiumcodereview.appspot.com/23804004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222132 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=hongbo.min@chromium.org
BUG=268924

Review URL: https://chromiumcodereview.appspot.com/23549026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222131 0039d316-1c4b-4281-b951-d872f2087c98

Configure Views HTML authentication and tab modal confirm dialogs to be
closed when interstitial WebUI is displayed (e.g. for SSL warnings prior
to page load).

This is effectively a no-op for these dialogs, but is desirable so that
all web contents modal dialogs have consistently configured behavior;
these dialogs are already closed at load start time which occurs before
interstitial WebUI is displayed.

BUG=240575
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23903025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222130 0039d316-1c4b-4281-b951-d872f2087c98

Failed on mac-asan bot:
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Tests%20%281%29/builds/14510

AcceleratedCompositingBlockedTest.AcceleratedCompositingBlocked: 
[7719:3847:0909/155847:1828989999085:INFO:gpu_control_list.cc(1043)] Control list match for rule #48.
[7719:3847:0909/155847:1829419815783:INFO:gpu_control_list.cc(1043)] Control list match for rule #48.
[7719:3847:0909/155847:1829591550844:INFO:gpu_control_list.cc(1043)] Control list match for rule #.
../../chrome/test/gpu/gpu_feature_browsertest.cc:143: Failure
Value of: 0U
Actual: 0
Expected: event_count
Which is: 1

> Enable GPU blacklist in tests.
> 
> Partial re-land of https://codereview.chromium.org/22198004/) -- Always enable FCM on Windows -- Part 1/3.
> 
> On top of fixing some of the issues there; only lands the part that enables the GPU blacklist in tests as the former CL is too hard to land all at once.
> 
> Also keeping --skip-gpu-data-loading around for now to be able to deal with failures caused in layout_tests by this on their own later (this needs to land ASAP and layout_tests don't need this ASAP).
> 
> Another CL will follow to always enable FCM on non-blacklisted Windows machines.
> 
> This part re-enables loading the blacklist in tests (and adds a content_browsertest to make sure that the configuration we expect to be testing is indeed the one we are testing -- this uncertainty is basically the only reason the blacklist was explicitly disabled before).
> 
> This CL also cleans up compositor_util.cc which was enforcing the blacklist twice.
> 
> The original plan was to do this only for Windows as Mac/Linux was causing trouble, but it turns out to be harder to do it only on Windows; so taking care of http://crbug.com/277242 in this CL too after all... 
> 
> BUG=233830, 267038, 190942, 277242
> TBR=jcivelli, piman 
> 
> Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219132 
> Then Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=219159
> 
> Then re-committed (part 1/3): https://src.chromium.org/viewvc/chrome?view=rev&revision=221114
> Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=221145
> 
> Review URL: https://chromiumcodereview.appspot.com/23534006

TBR=gab@chromium.org

Review URL: https://codereview.chromium.org/23983019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286538
TEST=gpu_unittests, webgl conformance tests

Review URL: https://chromiumcodereview.appspot.com/23819037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222128 0039d316-1c4b-4281-b951-d872f2087c98

We currently decode them as UTF-8, but they should be interpreted as Latin-1.
(XHR specs the relevant parameters as WebIDL ByteString.) For response headers,
this matches Firefox, IE, Opera 12, and Safari.  For status text, this matches
Firefox nightly, IE, Opera 12, and Opera. For request headers, this matches
Firefox nightly, Opera 12, and Safari.

Preparatory Blink CL disabled a layout test:
  https://src.chromium.org/viewvc/blink?revision=157238&view=revision

This CL will be followed by a Blink CL to fix and re-enable the test, throw
exception on non-Latin-1 setRequestHeader argument, and add a new layout test
to verify this behavior.

BUG=276769

Review URL: https://chromiumcodereview.appspot.com/23553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222127 0039d316-1c4b-4281-b951-d872f2087c98

r214685 failed to add user to the per-file OWNERS of
chrome/chrome_android.gypi.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23654016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222125 0039d316-1c4b-4281-b951-d872f2087c98

I'm seeing a crash where we have a dangling TabStripModelObserver,
this is one possible place. At the same time I'm making the class only
look for HOST_DESKTOP_TYPE_ASH browsers.

BUG=286162
TEST=none
R=skuhne@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23455037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222124 0039d316-1c4b-4281-b951-d872f2087c98

Browser test WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting
failed on win xp:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/24239

> <webview>: Cleanup WebRequest event listeners when embedder destroyed
> 
> <webivew> WebRequest event listeners should survive reparenting of the <webview> within the same embedder WebContents. Currently, event listeners are lost when the <webview> is removed from the DOM. This CL solves this problem.
> 
> Note that there is still a problem where custom elements break if the original page that created the element is closed. I have written a test that exercises this problem and I've left the test disabled until we fix the problem.
> 
> BUG=281551
> Test=WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting
> 
> Review URL: https://chromiumcodereview.appspot.com/23514016

TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/23965004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222123 0039d316-1c4b-4281-b951-d872f2087c98

These are used by chrome_browser_backend.

BUG=269131
TEST=trybot

Review URL: https://chromiumcodereview.appspot.com/23619021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222122 0039d316-1c4b-4281-b951-d872f2087c98

These days, the SDK is already checked out by DEPS in
src/third_party/android_tools/sdk, so trying to download it again from a
different location at a later stage does not make much sense.

R=peter@chromium.org,bulach@chromium.org,craigdh@chromium.org,frankf@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23621025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222121 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23640009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23458013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276900

Review URL: https://chromiumcodereview.appspot.com/23484018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222117 0039d316-1c4b-4281-b951-d872f2087c98

Both OSX and Views' App List implemetnations use a kIconDimension of
32x32 for icons shown in search results. This change uses a prescaled
32x32 icon asset for attaching to the "Search in webstore" result type,
rather than rescaling a 128x128 icon asset to 32x32 each time it is
shown.

BUG=285735
TEST=On OSX, perform a search in the app launcher that shows a webstore
search option - it should show the webstore icon next to it.

Review URL: https://chromiumcodereview.appspot.com/23494037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222116 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222115 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157453:157457&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/23498024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222114 0039d316-1c4b-4281-b951-d872f2087c98

Interfaces only at this point.  Implementation to follow.  API mirrors
that which is provided to the CDMs in http://crrev.com/221019

CanChallengePlatform() can be synchronous since it will just check a
command line flag passed to the process.

BUG=270294
TEST=none
R=ddorwin@chromium.org, dmichael@chromium.org

Review URL: https://codereview.chromium.org/23569005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222113 0039d316-1c4b-4281-b951-d872f2087c98

This change includes intercept code to dispatch eject calls on
MTP devices for all platforms. By and large, MTP devices don't need
specific ejection APIs to be called -- the devices are safe to remove
without notice. So the implementations mainly just simulate their
removal and signal OK to the caller. When the device is then actually
removed, the removal will be swallowed without additional notification.

R=thestig@chromium.org
BUG=257179

Review URL: https://chromiumcodereview.appspot.com/23383009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222112 0039d316-1c4b-4281-b951-d872f2087c98