- 31 Jul, 2019 40 commits
-
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 968047 Change-Id: Iff33707395af8d9edff34551ba90787c2bf8cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729079 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682879}
-
Avi Drissman authored
BUG=817024 Change-Id: I60d8e6b269c0c8f565e689508789713f73703e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729470Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682878}
-
Wez authored
The script was looking in the wrong place for the legacy SDK files. Bug: 977018, 989335 Change-Id: Ibd7d3f8e35633af579c27f282e47487a8fc20f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726959 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682877}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5588ed40788d..fee597729b1d Created with: gclient setdep -r src-internal@fee597729b1d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ia4d7a81322d60444d4aa7c144eb7c07c047b6723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729557Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682876}
-
Josh Nohle authored
Bug: 951969 Change-Id: I102d0cfe3de99276eb157f7b0c00f1b48a74b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728544 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#682875}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f99c5871..748b4c7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I83467dffe1f180cd5240fee91b5b4d154cca4976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729472Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682874}
-
Clark DuVall authored
This should help debug the Clank renderer hangs with network service. Bug: 934317 Change-Id: I78f69d5fafd05e4b8984601bc652b1d086d0ca49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726911 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#682873}
-
Ben Kirchman authored
This is a reland of 5a08e77e Revert of this CL was due to a build failure. Fix the build failure by adding the dependency for the new utils target to the Java Cronet implementation's package target. Original change's description: > Move Java classes needed by all Java Cronet implementations to utils. > > To minimize code duplication, code that can be shared between the > JavaUrlRequest and the FakeUrlRequest should be moved to a new shared > file: JavaUrlRequestUtils. > > Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 > > Bug: 669707 > Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Benjamin Kirchman <kirchman@google.com> > Cr-Commit-Position: refs/heads/master@{#681835} Bug: 669707 Change-Id: Ifd4f6118e1bc3f41a151f942199e69451d5ac5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724502Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#682872}
-
Wez authored
The test is supposed to create a new sub-job of its parent job, so that it can watch for the job becoming empty. Instead it was just duplicating the handle to its existing job, causing the test to flake if any other test batch process happened to be running in that job at the time. Bug: 989085 Change-Id: I17a287dcb6e5b0a7351294f6297ed355eb3e15ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728440 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682871}
-
Adrienne Walker authored
Currently, gpu::CommandBufferHelper::GetLastState locks a mutex to check the latest token state for every outstanding block in the transfer buffer. Instead, take the lock once, and reuse the cached value when looping over all the blocks. On vmiura's "300 invalidation" repaint test in callgrind on Linux, the number of cycles spent per library changed like this, filtered to RasterBufferImpl::Playback and CommandBufferService::Flush: | gpur | oopr | % diff -------------+--------+--------+------- total cycles | 256.2m | 235.3m | 8.1% libbase.so | 19.9m | 13.1m | 34.3% libgpu.so | 16.1m | 8.7m | 45.9% libpthread | 5.7m | 1.5m | 72.8% The callstack this avoids is: gpu::FencedAllocator::GetLargestFreeSize -> gpu::FencedAllocator::FreeUnused -> gpu::CommandBufferHelper::HasTokenPassed -> gpu::ComamndBufferProxyImpl::GetLastState -> base::internal::LockImpl::Lock -> pthread_mutex_lock Change-Id: Ic7d7a93ff6b6833ce978318d3ad406afeca76c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725030Reviewed-by:Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#682870}
-
Owen Min authored
The test is flaky. Bug: 986904 Change-Id: I670a6b99b5ec6448b4cc8cbf7f1569112d2d8bcb Tbr: tbansal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729396Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682869}
-
Robert Ogden authored
Bug: 988679 Change-Id: Ifaee6742dc098c1c2fb90aceb8a4ef97766e52bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728433 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Scott Violet authored
These were added for mash, now that mash is no more they can be removed. BUG=none TEST=none Change-Id: I56c1d89a168f03b31e5cf5bd8b7ab7b886dc1479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729060Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682867}
-
Justin Cohen authored
Change-Id: I2a5bf8228c91fea4740e3716781e5e0a91189784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729575Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682866}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d0b67c2a70b3..53571c75c695 git log d0b67c2a70b3..53571c75c695 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 srte@webrtc.org Adds config based creation of frame generator capturer. Created with: gclient setdep -r src/third_party/webrtc@53571c75c695 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I6c5318c8963c41c6137d3eac22ec50a824745719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682865}
-
Dana Fried authored
Currently we draw tab outlines around the active tab when contrast ratio between tab and background for the active tab is less than 1.3 to 1. This works reasonably well for light themes but not for dark themes. UX have requested the ability to try rendering a stroke around the active tab in dark, low-contrast themes. This CL adds a flag which, when enabled, causes an additional check to be performed: if there is less than a 20% absolute luminance difference between the tab and background, the stroke is also drawn. Because this is a prototype for UX/internal evaluation purposes only it may be removed. Bug: 968459 Change-Id: I67668ba53ed528b5fdfd9b7c58547338daded011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725221Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#682864}
-
Caitlin Fischer authored
Bug: 924136 Change-Id: I5c360800f32e65855d6107f190d66f78abf622d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724409 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#682863}
-
Armando Miraglia authored
I have received various emails from chirp indicating that this histogram does not have data. After searching for it in Code Search, it looks to me as this histogram is never used hence I am removing it. BUG=None Change-Id: I9cf654d4e4f4ccfdc18936338a962c9e3ecb76e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722843 Auto-Submit: Armando Miraglia <armax@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#682862}
-
Eric Roman authored
Android WebView uses the system's PAC support (via localhost proxy) rather than Chromium's PAC implementation. Bug: 989222 Change-Id: Ia0dcc436890fe5d92fb5124c1bc278d61979f8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726763Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#682861}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 968047 Change-Id: I11dd0befca765ffa4b25c8df66bd7557621b2b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729223 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Nathan Parker <nparker@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682860}
-
Nick Burris authored
Revert TextFragmentAnchor matching behavior back to case insensitive. Case sensitive reduced ambiguity, but also reduced match rate on CSS transformed text and   (see bug 982031). Ambiguity can, in most cases, be reduced by providing more context terms, so case insensitive is probably best. Bug: 982031, 982035 Change-Id: I633c674affb16b571294e5d81b6ae3b24ec9a731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729550Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#682859}
-
Christopher Grant authored
Change-Id: Ifd1be95869fa4b3c8bea29fff2e07671abe82e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725189 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#682858}
-
Wez authored
This reverts commit bd32f816. Reason for revert: Reverted the CLs that appear to have introduced the flakiness. Original change's description: > [Sheriff] Disable CacheStorageManagerTest.TestErrorInitializingCache. > > Disable CacheStorageManagerTest.TestErrorInitializingCache in Fuchsia > (flaky). > > TBR=wanderview@chromium.org > > Bug: 989313 > Change-Id: I18802fc677a99b9a83fc99a356f7c02ff568d11b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729150 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682694} TBR=vitaliii@chromium.org,wanderview@chromium.org Change-Id: I56f467459e882d5586a3aa57c1ae8bc94ae1ead8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729833Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#682857}
-
James Cook authored
Sort headers and include what you use. Bug: none Change-Id: I5173a232342a6288d6d1a67ca0705e1e963e15ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728542 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#682856}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2248cbc238c..2c1dec165ba6 git log e2248cbc238c..2c1dec165ba6 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 treehugger-gerrit@google.com Merge "shmem: Avoid synchronous commits if in kDrop mode" 2019-07-31 ilkos@google.com Merge "Add trace duration and rename the metadata proto" 2019-07-31 treehugger-gerrit@google.com Merge "Add ability to generate UUIDs" 2019-07-31 treehugger-gerrit@google.com Merge "Log if max. number of data sources exhausted in client API." Created with: gclient setdep -r src/third_party/perfetto@2c1dec165ba6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I221f6655b9df14124f91a0a43110bb78bc814541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729555Reviewed-by:
-
Jordy Greenblatt authored
This is a CL to minimize os-settings's dependency on pageVisibility. This includes removing some references to non-existent paths as in [1] and replacing any pageVisibility path that only depends on guest mode in OS Settings with an explicit check on whether the machine is in guest mode from loadTimeData. This doesn't completely eliminate the pageVisibility fork [2] bug because the people-page still provides a pageVisibility subpath to sync- settings, but it removes the vast majority of the dependencies on the browser settings' pageVisibility. The people-page issue will be handled in a later CL to avoid bloating. LOGGED IN SCREENSHOTS: Screenshots for OS Settings logged into a GAIA account with this change deployed. Page 1 http://screen/Tcbdf04X2Q4 Page 2 http://screen/9t80k4pRAGj Page 3 http://screen/dRCw3iZcQUU Compare to the top level 'settings-section's in UX mock [1] (modulo reordering and renaming). GUEST MODE SCREENSHOTS: As per specs sent out by jessejames@, in guest mode, the visible sections[2] are Network, Bluetooth, Device, Search engine, Date and time, Privacy and security, Languages and input, Files, Printing, and Accessibility. Compare this with screenshots of guest mode with this change deployed: Page 1 http://screen/AriC9twWUi3 Page 2 http://screen/qnrUthAru3G [1] https://chromium-review.googlesource.com/c/chromium/src/+/1716338 [2] http://crbug.com/974906 [1] https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZQLWgsMW9gCl/files/MCEJu8Y2hyDScYKiC7u07no3e21TaxzYd_w [2] There is a possibility that 'People' may be shown in guest mode depending on the outcome of a UX design discussion on the correct place for Kerberos settings, but this CL is working under the assumption that it is not shown. This can easily be changed after. Bug: 987349, 974906 Change-Id: I7f384437f9008742926eb7cf9d4d623bd8415591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724828Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#682854}
-
Danton Vu authored
The new positioning logic is hidden behind a flag. R=sammiequon@chromium.org Test: added test Bug: 978112 Change-Id: If9a565f3587e588041245be3f2dd8a2baa28c643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685517 Commit-Queue: Danton Vu <dantonvu@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#682853}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=jam@chromium.org Bug: 968047 Change-Id: I61bc20b765ad68c07e33d14e7ef3e28ee2282c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729153 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682852}
-
Chase Phillips authored
This relands https://crrev.com/1725318 with a fix for the crash that can happen under certain circumstances. The error in that CL was that dispatch_context() shouldn't be used outside of the context of a Mojo connection. Here's the updated commit message: As part of cleanup from CL https://crrev.com/c/1626660, this CL moves creation of CursorImpl into IndexedDBDispatcherHost by refactoring AddCursorBinding into CreateCursorBinding. As a result, the OpenCursor calling path no longer needs to pass the sequenced task runner into the OpenCursorOperation task and ownership of CursorImpl and the mojo binding steps is made simpler. Bug: 988868 Change-Id: I8444f53b0c4f362d3152cb9bea232d65f99375a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728540Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682851}
-
Owen Min authored
SSLErrorHandlerDateInvalidTest. TimeQueryStarted NoTimeQueries are not disabled properly. TBR=agl@chromium.org Bug: 989225, 989128 Change-Id: I7dbf620da6d5d542ab4a5bbcbf531c5155ba6a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729393Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682850}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a607e7b6e9a..38037fb44311 git log 1a607e7b6e9a..38037fb44311 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 ianloic@google.com [fuchsia] Update for new FIDL API 2019-07-31 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-07-31 halcanary@google.com tools/sk_app/macos: support command key 2019-07-31 benjaminwagner@google.com Set mac_sdk_min=10.13 for CommandBuffer builds 2019-07-31 halcanary@google.com SkPDF: SkPDFMakeShader handles pathological inputs better. 2019-07-31 bsalomon@google.com Remove GrCaps::SupportedRead::fSwizzle and supporting code Created with: gclient setdep -r src/third_party/skia@38037fb44311 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Id392d7c07146e701b091ac9be37f1a9c0c627505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729693Reviewed-by:
-
Mark Yacoub authored
When TestPageFlip, choose the FourCC format that takes opacity into consideration. BUG=983937 TEST=GPU doesn't crash anymore on Kefka Change-Id: I72af7f1755c9cd9c4464246fc73d38adbec57b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724558Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#682848}
-
Kyle Horimoto authored
(1) The class originally assumed that every Cellular-capable device must provide a MEID value. However, it turns out that this is not the case, so this check was removed. (2) The class assumed that it would always notify its delegate via InvokeOnFinishedCallback() asynchronously. However, if the device has already been activated before the process starts, the reply comes synchronously. This CL starts the activation flow as part of a new task to ensure that the process is asynchronous. Bug: 968858 Change-Id: Ie1d57a2a38465c6e2f1eb93632c6dbc7dcaf40bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726821 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682847}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 968047 Change-Id: I87eaadb182875ed512ed3527a506aad45a881be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728663 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#682846}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5aab967f546e..f7b43d76692c git log 5aab967f546e..f7b43d76692c --date=short --no-merges --format='%ad %ae %s' 2019-07-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@f7b43d76692c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I158504c133f71adfaddab3a5b67d72c0a1f2b29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728472Reviewed-by:
-
Adrienne Walker authored
My ssd ran out of space to build Android so in the meantime, I symlinked it into my home dir. However, when I did this, my Android build resulted in an exception where it would try to symlink a file to itself: ~/out/gn_android/gen/components/version_info/android/java/org/chromium/components/version_info/VersionConstants.java This patch checks and avoids this case. Change-Id: I0d0f6b90e40a1e9af710ccca8a626116f0ec6f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710783 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
-
Ken MacKay authored
Bug: internal b/138104456 Change-Id: I8d68f1b9cae2bab415ca0093ac8b94268d3efe2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729512Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#682843}
-
Shakti Sahu authored
This CL fixes 1 - Overall OMA download flow for DownloadOfflineContentProvider 2 - Fix auto-open for downloads that should be auto-opened immediately. 3 - Fixed a bug, where OMA mistakenly assumes the given download path and queries mime type from it, rather than content Uri, since the given file path and actual file path can be different. Bug: 989110 Change-Id: I7bad385f0a72d40b555e94b47ee760377519e6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727382Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682842}
-
Edvard Thörnros authored
When a receiving a new interval from a syncbase it is meant to take precedence, we now clear the old interval so it gets updated with the new time. This solves some sorting bugs related to syncbases. A new test has been added "onhover_syncbases.html" which tests repeted "mouseover" and "mouseout" events. Bug: 740541 Change-Id: I7a8e3691593a537c4dbc1da3bdbbe09eaf30e500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718704Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#682841}
-
Eric Seckler authored
Currently, we only support thread instruction delta values on PHASE_COMPLETE events. Since we'll soon replace complete events (at least on TrackEvent proto level) with begin/end event pairs, this patch adds support for emitting absolute thread instruction count values on begin/end events. Also ensures that we write sensible timestamps for all metadata events in TraceLog. Bug: 925589 Change-Id: Ie01339aefb3d148457f51057e0722c4506dda82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729262 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682840}
-
