- 27 Dec, 2019 40 commits
-
-
Pavel Yatsuk authored
Snackbar layout is a RelativeLayout with top, left and right shadow views and Linear layout with content. Because left and right shadows' bottoms are not anchored to anything RelativeLayout allows them to grow to maximum height. This causes snackbar to push to the top of the screen. Anchoring bottoms of side shadows to the bottom of content view forces RelativeLayout to set their heights explicitly to the height of top shadow and content, instead of letting shadow views expand to full height. BUG=1035954 R=mdjones@chromium.org Change-Id: I39be9b8db5136fb726ae9cdec5dc5df24823a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977824 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#727606}
-
Andrey Kosyakov authored
This reverts commit ded6a689. Reason for revert: re-landing with a fix to address headless test flakyness. Original change's description: > Revert "Headless: fix a crash in ~HeadlessWebContentsImpl" > > This reverts commit 20cefba5. > > Reason for revert: suspected cause of crbug.com/1037652 > > BUG: 1037652, 1034954 > > Original change's description: > > Headless: fix a crash in ~HeadlessWebContentsImpl > > > > ... due to reentrancy while waiting for a [sync] call to > > FrameSink::DestroyCompositorFrameSink() from Compositor destructor. > > > > Bug: 1034954 > > Change-Id: I8b47560d18bdab38e40e67e6506d30a2043f1474 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977741 > > Reviewed-by: kylechar <kylechar@chromium.org> > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#726858} > > TBR=caseq@chromium.org,kylechar@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1034954 > Change-Id: I244a6d9a9e36b8edb1297e9a3aa523b133f764e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982223 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727504} TBR=caseq@chromium.org,kylechar@chromium.org Change-Id: I7fa661b8ba366ca15a91fac741b49ea9170b93c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982773 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#727605}
-
Mia Glaese authored
Show HOMEPAGE, when entering Start Surface through Home button in top or bottom toolbar. Show TABSWITCHER, when entering through Tabswitcher button in top or bottom toolbar. Allow for switching between the HOMEPAGE and TABSWITCHER surfaces when both buttons are visible. Not switching to Tabswitcher bottom bar in start surface. Screenshots: https://drive.google.com/drive/folders/1E4VDh_QA8Ac3MJ3R3ORflMKFaampHnJu?usp=sharing In follow up: New top tabswitcher toolbar for Start Surface. Full UX design here: go/clank-start-ux Bug: 1025296 Change-Id: Ib6058596355125f682ab18f30731c01effada667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956187 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#727604}
-
Tarun Bansal authored
Use WebContents::GetLastCommittedURL to compute the last URL. Change-Id: I829c01287a9902c302c87d7a127bde70303558a3 Bug: 1037945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982235 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#727603}
-
Devlin Cronin authored
Allow page actions to trigger if they are "overflowed" (not visible on the main toolbar). Instead of gating on view visibility, gate on the enabled state of the page action (which, historically, indicated visibility as well). This allows users to overflow a page action and not have it visible all the time on the main bar, while still being able to trigger it via a keyboard shortcut. Add a regression test for the same. This also fixes the following tests with extensions menu feature: - CommandsApiTest.PageAction - CommandsApiTest.PageActionKeyUpdated - CommandsApiTest.PageActionOverrideChromeShortcut Bug: 1037685, 984654 Change-Id: I64b65abcd79cf746b4428653de505f53b60eff43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982595 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#727602}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df2c1ee4f270..0a7ca7a2a393 git log df2c1ee4f270..0a7ca7a2a393 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 bsalomon@google.com Avoid div by zero in ProcessorTest to please UBSAN 2019-12-27 herb@google.com Move updating a single texture coordinate to SubRun 2019-12-27 fmalita@google.com Revert "GrGLMakeNativeInterface_{iOS,mac,win}: clean up" Created with: gclient setdep -r src/third_party/skia@0a7ca7a2a393 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I42d4503466f04d7aa28f203ff077fbcdcc8a168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727601}
-
Xiaocheng Hu authored
Timeouts on https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3561 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3564 Change-Id: Ibcc0a9aefb2203e673670b2f55d0c32430b5a834 NoTry: True Tbr: xiaochengh@chromium.org Bug: 856601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982878Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#727600}
-
Roman Sorokin authored
The extension was used before on the login screen. Not used anymore Bug: 1036348 Change-Id: I6d3c917a36168e43977a0b311ef3270546c4a667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978745Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727599}
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Ia6d467c287027902d8d3b40d68774c0de73c75b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979246Reviewed-by:
-
Xiaocheng Hu authored
Bug: 1037798 Change-Id: I655acfb5814d15233c4f7b42056dc6d33e6259da NoTry: True Tbr: xiaochengh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982876Reviewed-by:
-
Andrew Grieve authored
Bug: None Change-Id: Idf9d9de3a6e899e09fd302e4b1b545d437e3fdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982768 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#727596}
-
Philip Rogers authored
Experimental data unfortunately showed that it is not straightfoward to simply remove the directly composited image feature (see: https://crbug.com/875110#c22). This patch removes the plumbing added for the flag. Bug: 875110 Change-Id: Ib09f3ba13d3ab8759f9188ffb60cb80360ac24de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982140 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727595}
-
Omer Katz authored
We currently have no real data on time spent marking roots Bug: 986235 Change-Id: Ie7ad46421740f8ee1f2bd8fbf7e20fbbc1d15498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983224 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#727594}
-
Devlin Cronin authored
De-flake BrowserActionApiTest.CloseBackgroundPage. The test could fail if the C++ side clicked on the browser action icon before the extension registered a listener for browserAction.onClicked(). If this happened, the event would be dropped, and the test would time out waiting for the extension host to close. Fix this by waiting for the extension to send a "ready" message when it has finished setting up listeners. The test now passes 100 runs on the bots with no flakes (before, it would flake multiple times on 100 runs). Bug: 1035075 Change-Id: Ic56ff1026b68db8cd5296098f719b660ad7a4918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981835Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c5d66ab..eb1fb6a0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad13de42d0b4a6bf242966a10d577dc7f63bebc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727592}
-
Oksana Zhuravlova authored
This CL adds an implementation of EnumerateNamedProperties() that ends up calling a remote GetMethods() method on a RemoteObject mojo remote. The remote will be connected to a RemoteObject implementation in follow-up CLs. Bug: 794320 Change-Id: Ia3748d6842608e56b5c7985147f28985feabde93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962985Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#727591}
-
Chris Harrelson authored
This is now possible due to past work to separate layout and visual overflow recalc. Change-Id: Icc1a9236390005949048d817f7660c26dfc91dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904871Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#727590}
-
Dominic Mazzoni authored
Adds an AXLiveRegionTracker class to keep track of live regions in an AXTree. Uses it to fix a bug where we weren't firing the LIVE_REGION_CHANGED event on the live root when a node was removed, only when a node was added or changed. I'm going to follow this up with code that optionally computes the text of a live region change, that we can use on Android, Chrome OS, and some older versions of macOS. So AXLiveRegionTracker is simple now, but it will be a convenient place to put that logic. Bug: 560599, 930763 Change-Id: Iaff11e5adbdde533b8868226ed563567edc5589e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464325 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#727589}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/85240a12ed2b..50ea92a176ba $ git log 85240a12e..50ea92a17 --date=short --no-merges --format='%ad %ae %s' 2019-12-26 renjietang Record the frequency of stream frame coalescing at QuicSession.CoalesceStreamFrameStatus. 2019-12-24 vasilvv Add a proper API to create memslices from the QUIC code. Created with: roll-dep src/net/third_party/quiche/src R=zhongyi@chromium.org Change-Id: I8688b4c43c66035e789c9628eb45d8f0d75fc3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982780 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#727588}
-
Lukasz Anforowicz authored
After r694827 and r710554, request_initiator=website and the isolated world origin is propagated separately. Correct propagation of the isolated world origin is needed for 1) picking an allowlisted URLLoaderFactory that might disable CORB and 2) for relaxing CORS based on the isolated world origin (in addition to the request initiator origin. Before this CL, such propagation did not correctly happen for redirects handled by InBlink-CORS. Bug: 1034408, 940068 Change-Id: Ic4d20b2a8fea02e7bb07e4914240c5a6847e05bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974683 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727587}
-
Boris Sazonov authored
Fixes a timeout in SigninTest by changing how the test waits for the bookmark model to be loaded. It also cleans up the test and removes some outdated chunks. Bug: 1036532 Change-Id: Ic7124a46eea6d3088ebfbb921f13f735460a7d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982544 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Avoid using content::ConsoleObserverDelegate in LocalNTPDoodleTests. Instead, use: - content::WebContentsConsoleObserver, when we're awaiting a specific message. - A new helper class, FailOnConsoleMessage, when the console observer was only used to record all console messages and fail whenever one was present. This allows us to avoid overriding the existing WebContentsDelegate, if any (which can mask behavior unintentional changes, and also required extra code to set the original delegate *back* in some scenarios). Additionally, correct cases where the console observer was monitoring for messages (presumably for failure), but never checking the result. FailOnConsoleMessage automatically adds a failure when a console message is received, rather than needing to explicitly check for one. Bug: 1034150 Change-Id: I161ba6256bdcd8db6b2d65d5cc0b345874db5727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980959Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc73eb4fcc89..df2c1ee4f270 git log bc73eb4fcc89..df2c1ee4f270 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 herb@google.com Simplify color and translate updates 2019-12-27 halcanary@google.com GrGLMakeNativeInterface_{iOS,mac,win}: clean up Created with: gclient setdep -r src/third_party/skia@df2c1ee4f270 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: Ia141922bf62394e9c6196076c72a5de546255df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983186Reviewed-by:
-
Adam Ettenberger authored
ToString converted the text to UTF8 before wrapping the focused character with '<' and '>'. This can cause confusion if a developer uses standard output logging with an AXPosition because |text_offset_| is relative to the UTF16 character position, not UTF8, which could result in wrapping the wrong character or wrapping a portion of a UTF16 character. Converting the final |annotated_text| to UTF8 instead fixes this. Bug: 1037921 Change-Id: I1c4ed0f8847197ac2d97d6abbda5899a479ae03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981636Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727583}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/364fc41c517e..aca963f8ae30 Created with: gclient setdep -r src-internal@aca963f8ae30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie24333a2534f62d3c7eab4e06dd60c93d8128bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983185Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727582}
-
haozhe authored
Both Chrome and Firefox pass all tests Bug: 1034538 Change-Id: I796c3ef77c7a4e384b4c82a18876d6630707fbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976555Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#727581}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic1ac694646902160c3f98e85779845a7ee9b26e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983184Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit 1e9bd7b2. Reason for revert: Tests crash on MSan. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17015 Original change's description: > Initial implementation of the FileSystemScanner > > This implements the initial version of FileSystemScanner > (go/arc-fs-scanner). > > Bug: b:145254635 > Test: unit_tests --gtest_filter="Arc*" > Test: Manually populated a big file system and triggered different file > Test: system events. > Change-Id: I14bebb3719532afac54e1913229045fb2740a9ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946177 > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Commit-Queue: Umut Barış Öztunç <umutoztunc@google.com> > Auto-Submit: Umut Barış Öztunç <umutoztunc@google.com> > Cr-Commit-Position: refs/heads/master@{#727555} TBR=hashimoto@chromium.org,yusukes@chromium.org,fukino@chromium.org,hidehiko@chromium.org,elijahtaylor@chromium.org,mnissler@chromium.org,kerrnel@chromium.org,risan@chromium.org,umutoztunc@google.com Change-Id: I9b27f3bdd8d74586efdd6e141d0debc8b85b4a70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:145254635 Bug: 1038049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981267Reviewed-by:
-
haozhe authored
Both chrome and firefox passed all tests Bug: 1034538 Change-Id: I4d315ea6283496a98bf928ee5f965df6cd685462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974390Reviewed-by:
-
haozhe authored
Both Chrome and Firefox pass all tests Bug: 1034538 Change-Id: Id6fca2ac5eb08123bd8817a46fc48985df5979de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974841Reviewed-by:
-
haozhe authored
Both Chrome and Firefox pass all tests Bug: 1034538 Change-Id: I7e5c37769b268628e72ad04bf2ac1b882eedc5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974952Reviewed-by:
-
Christopher Cameron authored
This function never returned a top level widget, rather, would just return the root widget. Bug: 957362 Change-Id: I8d757fecfd8eddd02d92200516a21c3576eb4468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982682Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#727575}
-
Xiaocheng Hu authored
The following two tests are timing out on Windows DiceSigninUiUtilTest.GetAccountsForDicePromos DiceSigninUiUtilTest.ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin See https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/62809 Bug: 1014790 Change-Id: I1f3dc81f3aff11e22a9ac767809c857a20cd3169 NoTry: True Tbr: droger@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982838Reviewed-by:
-
Xiaocheng Hu authored
Multiple flakes are seen, for example: - https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/60589 See dashboard: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaW1hZ2VzL2V4aWYtb3JpZW50YXRpb24taW1hZ2UtZG9jdW1lbnQuaHRtbAw Bug: 1037798 Change-Id: I9957010177183b585a7cb2a4af2c1d44434d8990 NoTry: True Tbr: sashamcintosh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983259Reviewed-by:
-
Mikhail Khokhlov authored
Results Processor expects some options (e.g. trace_processor_path) to be set before it processes results. It can be done via calling results_processor.ProcessOptions(). This CL ensures that this method is called in all places where ResultsProcessor is used. Bug: 1028612 Change-Id: I7e62c54b123f02b1c4b8f183dd00704ad5f0fc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982554Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#727572}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82462f237bb1..bc73eb4fcc89 git log 82462f237bb1..bc73eb4fcc89 --date=short --first-parent --format='%ad %ae %s' 2019-12-27 bsalomon@google.com Make ProcessorOptimizationTest for canTweakAlphaForCoverage more robust Created with: gclient setdep -r src/third_party/skia@bc73eb4fcc89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: fmalita@google.com Change-Id: I067596659a847f3da673f1bea2f4012088306a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983183Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: I4ff4225a9601a8fce52cf59e6502f3ed3e0cfa28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982552Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#727570}
-
Adithya Srinivasan authored
Tests are currently failing on chromeos-betty-chrome. I'm not sure how to just disable the tests on the bot, so I'm disabling generally on chromeos. Bug: 1038043 Change-Id: I2ae30a98157164889fb6acb305409091028bdf3b Tbr: achuith@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981261Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#727569}
-
Maria Kazinova authored
Now Fill On Account Select on password field displays all credentials, including the ones with empty usernames. If the credential with non-empty username is chosen first, and the empty username credential is chosen on password field afterwards, the username is not refilled. Bug: 926844 Change-Id: Iacd62b9c17680fbebbee8199be7c4e2b0b41c83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982550 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#727568}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05626c706990..364fc41c517e Created with: gclient setdep -r src-internal@364fc41c517e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib115b09166a9a92f895bc9ea48e29fb289732633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983179Reviewed-by:
-
