- 16 Apr, 2020 40 commits
-
-
rbpotter authored
The flag is no longer respected. Delete the flag and all references to it. Bug: 1069258 Change-Id: I0d5040eef178ab5d93cd45d244374f17a424f264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150277 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759822}
-
Xianzhu Wang authored
Since crrev.com/c/1979258, we have been painting view backgrounds differently when the root element adds/removes paint properties. We should invalidate view background. Bug: 1070952 Change-Id: If263f32bb80b7654a9f4e01f3fd41ff28e4a848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152992Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759821}
-
Sigurdur Asgeirsson authored
Bug: 1071090 Change-Id: Ife9302216120de63a59614427e88e786426131d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152890Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759820}
-
Patrick Monette authored
A future CL will use those IDs without their associated worker service. Bug: 993029 Change-Id: I40391971b8ee673e00b8865a82bc6ce9b8d8f162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148681 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#759819}
-
Charlie Harrison authored
What:This CL adds per-top-level-page metrics for the number of conversions that took place over the course of the page load. Why: To measure potential abuse in conversion registration, and guide any limits we might put on the feature. How: via a new per-page scoped class ConversionPageMetrics that aggregates this data. Bug: 1044099 Change-Id: I41f7910a6f07cbe0d00a7445a2bb48c77fd25c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145254 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759818}
-
Dana Fried authored
This both simplifies the code and allows us to make changes to explore fixes to the two bugs below. It should not change any existing behavior, as this change just moves the existing code to a new private implementation class. Bug: 1057713, 1059862, 1068459 Change-Id: I0d7868aadcd4a5adf29b2dc670f7a7d523da24b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141041 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#759817}
-
Matt Jones authored
This patch converts the ReaderModeManager to be a tab helper, replacing access of the TabModelSelector with a single tab. Bug: 1069815, 1051184 Change-Id: I3f16a4b053aed006ed8b232393d12396ad7e24fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151469Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759816}
-
David Black authored
Assistant should only contribute search results iff: - Assistant is allowed, and - Assistant is enabled Bug: b:146673437 Change-Id: Ic37968c0cd7264290d9ac391d6377a63ea48250d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146172 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759815}
-
Becca Hughes authored
Retains refs to the store when using callbacks and also change the fatal -> error for sql errors since it is making bots crash. Change-Id: Ie27d43f2044700e1b299d2a34406b1eb2fc9412b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149405Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759814}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/efebaa2a1152..4e3ceb96b8a1 git log efebaa2a1152..4e3ceb96b8a1 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 robertphillips@google.com Fix up GPUDDLSink for Vulkan 2020-04-16 mtklein@google.com GP64 Operand conversion 2020-04-16 senorblanco@chromium.org Reland "Refactor GL and Metal FinishCallback into a helper object." 2020-04-16 bsalomon@google.com Revert "GrDisplacementEffect uses GrTextureEffect." 2020-04-16 reed@google.com change Overdraw colorfilter to be pure sksl 2020-04-16 jlavrova@google.com getRectForRange with HeightStyle == kTight should ignore strut metrics 2020-04-16 westont@google.com Remove Debian10 Flutter_Android, change BuildStats to use Debian9 Docker 2020-04-16 bsalomon@google.com GrDisplacementEffect uses GrTextureEffect. 2020-04-16 michaelludwig@google.com Rename GrShape to GrStyledShape 2020-04-16 michaelludwig@google.com Respect wrap mode when decimating for blur 2020-04-16 mtklein@google.com lots more refactoring 2020-04-16 westont@google.com Dockerize Flutter Android job. Created with: gclient setdep -r src/third_party/skia@4e3ceb96b8a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I4c42256bef5a52f46303e43ecf99e5bc7ae3ca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759813}
-
Matt Jones authored
This patch replaces most usages of the TabModelSelector with Tab to facilitate the transition of the ReaderModeManager to be a per-tab object. The patch also includes a few other mechanical changes around accessing the web contents and removes some now unnecessary null checks. Bug: 1069815, 1051184 Change-Id: Ica37a9781fd299494403174f46aa5b3a9c27939e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147675 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7339a08855d5..a0145e0512c2 Created with: gclient setdep -r src-internal@a0145e0512c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049042 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Ie3ffb2ac99d0b3c14ee82f5fa413025efdde26a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759811}
-
Sean Topping authored
These are trace categories used by internal Cast code. Merge-With: team/719699 Bug: internal b/135325494 Test: CQ Change-Id: I87f4c35200e7f2b5f54b9d70b38bce3c370dae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153322Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#759810}
-
Eric Orth authored
Bug: 1065338 Change-Id: I95826e4c124f312411284a44b49b6f2fe2c32ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153685 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbdc14be1be4..8116c488ae96 git log cbdc14be1be4..8116c488ae96 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 geofflang@chromium.org Remove the merge command from roll_aosp.sh 2020-04-16 geofflang@chromium.org Remove some bad files when generating an ANGLE roll into Android 2020-04-16 jian.li@arm.com Vulkan: Fix transform feedback on AMD platform 2020-04-16 geofflang@chromium.org Remove --preserve-root from roll_aosp.sh 2020-04-16 geofflang@chromium.org Roll VulkanMemoryAllocator into Android Created with: gclient setdep -r src/third_party/angle@8116c488ae96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I90fbc48daf87fcdd6cda091776033712f5ef5fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153477Reviewed-by:
-
Nigel Tao authored
This commit spins some test cases out of JSONParserTest.ErrorMessages and adds some more. Line and column counting is buggy, both before and after this commit (which just adds tests). Future commits will fix the bugs, but the first step (this commit) is to add test coverage. Also remove two FRIEND_TEST_ALL_PREFIXES lines that should have been part of crrev.com/c/2150527 "Move some JSONParser tests to JSONReader tests". Bug: 1069271 Change-Id: I333da3462a7ec75f58550594f9148be8f89a9321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152334Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759807}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f4308e08dc82..c117a70b3913 git log f4308e08dc82..c117a70b3913 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 btolsch@chromium.org Rename CastSocket::SendMessage to Send Created with: gclient setdep -r src/third_party/openscreen/src@c117a70b3913 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050913 Tbr: jophba@chromium.org Change-Id: I7f55b5ff8b00bd4de182eaef042e0ed0088425b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153481Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6cd016d2d0e0ccfc743ec4ebdc47936d31767532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153635Reviewed-by:
-
Piotr Bialecki authored
Currently, the anchor creation is not deferred and may fail if the application attempts to create an anchor when ARCore's session is not in correct state. To avoid exposing those failures to the application, we will defer anchor creation to happen at well-defined point in time during GetFrameData request. This also means that anchor creation methods exposed via mojo need to change - since anchor creation can be deferred, the pose needs to be computed device-side using latest information of the state of the transforms. Fortunately, there already exists a mechanism to describe that - XRNativeOriginInformation is used to identify frame of reference on the device and the passed in pose can be interpreted as relative to that frame of reference just prior to calling ARCore's anchor creation method. Changes: - XREnvironmentIntegrationProvider mojo adjusted to pass native origin information to the device - ArCore's CreateAnchor* methods now accepts a callback that will be called once the result of the operation is known; the callback type matches with mojo's callback so mojo callback can be passed as-is - ArCore now exposes a method that when invoked will attempt to process all outstanding anchor creation requests, invoked by ArCoreGl during GetFrameData / ProcessFrame - ArCoreImpl's implementation of CreateAnchor* methods now store all relevant information about the request; added necessary structs - when ArCoreImpl processes anchor creation requests, some failures are considered fail-fast, but others will cause the request to be postponed so that it can be re-tried later - XRSession is now more explicit that there is a difference between plane-attached and free-floating anchor; adjusted method signatures to account for the fact that the actual computation of the anchor pose will happen on the device - XRSession no longer expects CreateAnchor callbacks to be invoked in the subsequent GetFrameData - XRHitTestResult adjusted to account for changes in API exposed by XRSession - XRFrame adjusted to account for changes in API exposed by XRSession - XRNativeOriginInformation can be created using mojo's XRReferenceSpaceCategory enum - this also caused a minor refactor to re-use some code paths - move obtaining plane information data to ArCoreGl::ProcessFrame for consistency with anchors - mark newly created anchors as updated and fetch their tracking state instead of hardcoding - converted few if-elses into an equivalent switch statement to get rid of unncecessary UNREACHED() macro use in ArCoreImpl Change-Id: Ie84ce4ae2b777c36af5f995282057b6dfaf6bf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142716Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#759804}
-
Eric Orth authored
The server template never got updated on a previous format change, but still managed to compile. Add a validation in the constructor to ensure only valid server templates are listed. Also add a test to make sure the list can be loaded without error (not completely necessary since other tests load the list, but a specific test helps make it extra obvious). Bug: 1065338 Change-Id: Ie2b131a37bf7bd82c46747b5ab4e67d5b2f7eb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153319 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Dan Harrington authored
Just trying to make things a bit clearer. Change-Id: Ifb6835e70e0ece88e3ed0dd3d63c6cb0e46af25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151473 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759802}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e42feaad..7d3bcd17 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d2946cf9d81cadd67972b6ce5aecab74313030a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153295Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759801}
-
rbpotter authored
The icon was missing from the Polymer 3 code because cr_fingerprint_progress_arc.html contained both an <iron-iconset-svg> and a <dom-module>, which is not supported by the polymer.py autogeneration script. Split the icon into its own HTML file and add an assertion to the script so that it fails at build time in this case instead of silently ignoring the <iron-iconset-svg>. Bug: 1070823 Change-Id: I530c49b051491bdd680b53ed3d1d0d5cf4e6c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153570Reviewed-by:
-
Frédéric Wang authored
* Forward declare MathMLElement instead of including the header. * Use new isA<MathMLElement> cast syntax. Bug: 6606 Change-Id: I5f8d95668849dc76f2bf05c8c4efb72004466310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153146Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#759799}
-
Xiaocheng Hu authored
FontDescription has a mutable bit field subpixel_ascent_descent_ that can be modified via a const method. This patch removes the mutable keyword and changes the callers so that FontDescription no longer has mutable fields, and the code maintainability is improved. Change-Id: I53fab83b3a8c00e2827aa19b0ba640bb59765fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145072Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759798}
-
Nathan Zabriskie authored
Clusterfuzz picked up a potential error if we can't retrieve shared memory when deserializing an SkColorSpace. Bug: 1071441 Change-Id: I9cefd0cf3cee92c2ad2556e914522203f88e282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153344Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759797}
-
Xiaoqian Dai authored
Bug: 1071598 Change-Id: I950ebd930cc06de05c65426bfa14081dc1c58dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153689Reviewed-by:
-
Devlin Cronin authored
Extend the expiry date of still-useful metrics. Extended to 2021-04-01: - ExtensionOverrideBubble.SettingsApiUserSelectionHomePage - ExtensionOverrideBubble.SettingsApiUserSelectionSearchEngine - ExtensionOverrideBubble.SettingsApiUserSelectionStartupPage - ExtensionOverrideBubble.NtpOverriddenUserSelection - ExtensionBubble.DevModeUserSelection - ExtensionBubble.ExtensionsInDevModeCount Extended to 2020-12-01: - ExtensionToolbarModel.BrowserActionsVisible - ExtensionToolbarModel.BrowserActionsCount Bug: 1052982, 1052981, 1016423 Change-Id: Ie4b126f4a83571745c73e058cb17cd17f4e2ead1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148115Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759795}
-
Darwin Huang authored
Return early if utf_text.data() == nullptr. utf_text.data() can be nullptr if the Clipboard was empty. Previously, this would trigger a DCHECK in Blob::Create(). Tested manually using `pbcopy < /dev/null`, as per bug repro steps. Unfortunately, Chrome's test infra doesn't seem to have a way to simulate clearing the clipboard. Therefore, there isn't an automated test being added here to verify this behavior. Bug: 1071279 Change-Id: I95cdc6ed2df25394ca1ffa78d4cde96782d9a10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151132 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759794}
-
Toni Barzic authored
The containers are currently ranked with 0, which seems to be a valid result rank. We should ensure that containers with results are always ranked before empty containers (code to manage search result selection depends on this assumption). Change-Id: Ie72ef9f93e2216a6a910c47f53028572d21cc465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106509 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759793}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efdff53176d6..6415dcad7a71 git log efdff53176d6..6415dcad7a71 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 mbonadei@webrtc.org Remove WebRTC-ExperimentalScreenshareSettings. 2020-04-16 danilchap@webrtc.org Delete generic frame descriptor v1 trait and enum value Created with: gclient setdep -r src/third_party/webrtc@6415dcad7a71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc5956b6a9f20e0815ecc4ad57caa334d61bd305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153631Reviewed-by:
-
Jon Mann authored
When configuring a local network from a synced proto, this change implements the required logic for applying manual proxy settings. Bug: 966270 Change-Id: I43bc884d9c7b64cc44266cc7587caf5682c0abcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151837 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#759791}
-
Sammie Quon authored
On reconnection, windows are moved to another display via a call to Window::SetBoundsInScreen, which will add to the correct container on the other display. Windows are currently added (if meets conditions) in the order of the MRU, which means they are added to the new container in that order. Stacking order of a window's children is in order of the indexes, so visually the windows are the opposite of the MRU order. Adding the windows in the reversed order would solve this. On disconnection, windows are squashed onto the primary display and stacked according to the MRU list. The formula is: Find window in MRU list, and after that, the next window with the same parent will be the window stacking on top target. If none is found, stack window at bottom. Attached a video for more context in the bug. Test: manual, PersistentWindowControllerTest.MRUOrderMatchesStacking Bug: 1071246 Change-Id: I10a145081603a505491b4885fd2091aa4ea1c55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151180Reviewed-by:
-
Dominic Mazzoni authored
In http://crrev.com/c/2017662, I attempted to fix an issue with the Android implicit root scrollers, but that patch ended up breaking pinch-zoom. To fix it properly, we need to keep track of which node is the root scroller - which may not be the root element. Then, on Android only, we ignore the scroll offsets from that node (actually we unapply them) and instead apply the scaling and offset from RenderCoordinates. Bug: 1066809, 1005121 Change-Id: I0d717a563a6b5d480b68c35916243e848fe53bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142101 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#759789}
-
Xinghui Lu authored
This feature is not launched. Remove the feature flag and other unused code. Add a default implementation in the SafeBrowsingApiHandler interface. The interface will be removed eventually, once the internal repository code is removed. The field in the csd proto will be deprecated in a future CL together with the same field on the server-side. Bug: 1070836 Change-Id: Ia18aff08c008006898ae7886b5a07203d6f9b7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150067Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759788}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8b32f96. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools panicker@chromium.org: external/wpt/longtask-timing panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I61ef1820f9f50b1d702ee3a53072223be094e94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153267Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/77750704ab85..c4fb400988c9 git log 77750704ab85..c4fb400988c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tross@microsoft.com Add keyboard accessibility to Issues panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4fb400988c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067773 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5310c84bd45c19ebdcc635c530ab2e21bdc44d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153471Reviewed-by:
-
Ryan Daum authored
Have the ui_devtools server launch for all devices that are BUILD_ENG or is_debug=true. Bug: internal b/148931987 Test: manual Change-Id: I55b58c51e0a4a080aae269e7d985975b3ae75e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144616Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#759785}
-
aknobloch authored
Adds a new member variable to the `CastMetricsServiceClient`, rather than reinitializing the `CastSysInfo` object each time the `GetChannel()` method is called. Bug: 145136478 Change-Id: I04cdc10ecbb7ff6761a24cedd4ab88e8098913c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123508Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Aaron Knobloch <aknobloch@google.com> Cr-Commit-Position: refs/heads/master@{#759784}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/671aece845dd..2dd3f0f2c0f7 git log 671aece845dd..2dd3f0f2c0f7 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 thestig@chromium.org Add unit tests for comparison operators in CPDF_PSEngine. 2020-04-16 tdusnoki@inf.u-szeged.hu Remove CPDF_PSEngine.Truncate test case 2020-04-16 shwali@microsoft.com Add API for removing an inklist for an ink annotation. 2020-04-15 nigi@chromium.org [SkiaPaths] Embolden SkFont if substitute font is bold or extra-bold. 2020-04-15 asweintraub@google.com Add explicit casts in pdfium_test_event_helper.cc 2020-04-14 nigi@chromium.org Update the expected results in FPDF_RenderPageBitmapWithMatrix for Skia. 2020-04-14 nigi@chromium.org Update the expected results of FPDFTransformEmbedderTest for Skia. Created with: gclient setdep -r src/third_party/pdfium@2dd3f0f2c0f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If7fe5cf796a2a80a47c00fe9b13c3e74fde5791f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153480Reviewed-by:
-
