- 25 Nov, 2019 40 commits
-
-
Kevin McNee authored
|mojo::ReportBadMessage| does not automatically close the relevant receiver (|frame_host_associated_receiver_|). We return immediately after the |ReportBadMessage|, so the callbacks are not run. Since the pipe is not closed, this DCHECKS. Bug: None Change-Id: I521fe8c29679a92c9d5689e78758e4adde814b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929911 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718690}
-
Owen Min authored
Bug: 1028129 Tbr: dpapad@chromium.org Change-Id: I19337a65e4cb12d91d87f9decd2626788b6026cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933590Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718689}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ice39e92722d0434f66a85dd53de30ad65804ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718688}
-
Dominic Battre authored
This CL introduces a --force-disable-variation-ids parameter to prevent variation ids and trigger variation ids from being sent via the X-Client-Data request header for debugging purposes. Bug: 1027576 Change-Id: Iacaaee31b1a62e50cc9b61a709cca5651038ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930958 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#718687}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b44da5f..c4a36ad5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I391da318c13f4e5fab5ebf3ed32e5eaa0a3b7e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933485Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718686}
-
Andrew Grieve authored
This fixes compatibility with JDK 11. use_errorprone_java_compiler GN arg cannot be re-enabled until newly added checks are either fixed or silenced. Bug: 894616, 1027541 Change-Id: Ic3727188867623b05228c58157818b500a886194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933767Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718685}
-
Christopher Grant authored
This reverts commit 0c8f0867. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/arm-unpublished-builder-rel/15653 TBR=agrieve Bug: 1027573 Original change's description: > Android: Support pure-32-bit version codes on 64-bit build configs > > See the associated bug for reasons why this work is happening. > > Refactor the version number generator script to be more explicit, and do > away with the hack that was in place to support multiple version numbers > in 64-bit config. > > Also, add the new pure 32-bit Mono and Trichrome numbers, as well as an > alias 32_64 version number, which is equivalent to the ambiguous > "Monochrome" version. > > Bug: 1027573 > Change-Id: Iae270f84ad3cf3c28e9001460a016aa7f75237e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931100 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718671} TBR=cjgrant@chromium.org,agrieve@chromium.org Change-Id: Ic5874955be3e1c723635accb5f9381540f3d6b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934428Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#718684}
-
Danyao Wang authored
Refactored test using ::testing::WithParamInterface to remove duplicate logic between the two test modes: StrictHasEnrolledAutofillInstrument and legacy mode. This allowed the NoShow logging histogram check to be applied to all test scenarios. A subsequent patch relies on this refactor to add testing of delayed show to all test scenarios (crbug.com/1028114). Bug: 1027322 Change-Id: I312fb3db3146e86c3d0baf504d0db91d5ce097e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933122 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718683}
-
Dave Tapuska authored
unique_ptr in its header. BUG=1026685 Change-Id: Iffeb041b8542bcbf40de29c7d3e0150bf887cedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934238 Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718682}
-
Hans Wennborg authored
The test doesn't pass in that build config. TBR=alexchau Bug: 1028113 Change-Id: I985e84c6971986f66cc3166bd59e26b53a50b8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932552Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#718681}
-
Alex Vallée authored
Add description of the timestamp. Bug: 1006899 Change-Id: I80a94ce923ffc7a0d7a462dbd91a6dddc97f9b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933736 Commit-Queue: Alex Vallee <avallee@chromium.org> Auto-Submit: Alex Vallee <avallee@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
can_upload_data_ was always set to true upon calling MaybeUploadForDeepScanning. Removed this and changed tests so reintroducing this bug will result in failing tests. Change-Id: I49b63670aec2f95157103b51d59dd197278e87df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933733Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718679}
-
Rouslan Solomakhin authored
Before this patch, a compromised renderer could bypass the feature policy check for Web Payment API. This patch adds a feature policy check in the browser process. On desktop, the renderer process is killed if the feature policy is violated. On Android, the Mojo pipe is closed. After this patch, it is not possible for a compromised renderer to bypass the feature policy check for Web Payment API. Bug: 1027176 Change-Id: I7ff69fef37d2c6998850e5bbd6a2513e3bc81f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928207 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#718678}
-
Ben Mason authored
Bug: 1028130 Change-Id: Iea128cde9bc83cfc962776c48d4037e1d0ba75d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934240 Commit-Queue: Ben Mason <benmason@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718677}
-
Yuki Shiino authored
Adds a quick hack to support a case of "attribute FrozenArray<T>?". Bug: 1028047 Change-Id: Ib3cecc4beb6bcc0fb0dbc667aca595454cc90c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933866Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#718676}
-
Alexander Dunaev authored
This CL adds the missing methods that allow setting minimum and maximum sizes of the Wayland top level surface. R=msisov@igalia.com Bug: 994558 Change-Id: I35bd764b59070d266947301f5c02fe65d42b9ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928691Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#718675}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56b1f53bcd83..731aba0ef889 git log 56b1f53bcd83..731aba0ef889 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 delphick@chromium.org Add a new category for shared memory in v8 Created with: gclient setdep -r src/third_party/catapult@731aba0ef889 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I50ed22224982f1fa82f7b5da48575bb343035072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934106Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/78ae849159ac..bcda22bca456 git log 78ae849159ac..bcda22bca456 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 vapier@chromium.org cbuildbot: build_status: drop validation pool support 2019-11-25 vapier@chromium.org run_tests: enable build_stages_unittest 2019-11-25 drinkcat@chromium.org Revert "cros_setup_toolchains: update sdk toolchain targets in parallel." 2019-11-25 fqj@chromium.org config: fix android package name for VM master. 2019-11-25 vapier@chromium.org cidb_unittest: make sqlalchemy import optional 2019-11-25 vapier@chromium.org afdo_unittest: fix mock typo 2019-11-24 vapier@chromium.org logdog/som: delete more unused som related modules 2019-11-24 vapier@chromium.org cbuildbot: lkgm_manager: drop validation pool support 2019-11-24 vapier@chromium.org commands: use encoding=utf-8 when capturing command output 2019-11-24 achuith@chromium.org flash: Suppress spurious error message. 2019-11-24 vapier@chromium.org gerrit_unittest: fix test after cq-depend syntax changes 2019-11-23 vapier@chromium.org cros_sdk_lib: rework IsChrootReady logic 2019-11-23 lamontjones@chromium.org Revert "paygen: protect just downloaded file, more logging." 2019-11-23 lamontjones@chromium.org Revert "paygen: log output for gs downloads" 2019-11-23 lamontjones@chromium.org Revert "paygen: more logging when download fails." 2019-11-23 fqj@chromium.org add vmmst pfq 2019-11-23 andrewlamb@chromium.org Add replicate_private_config PUpr endpoint. 2019-11-23 cjmcdonald@chromium.org Sync proto definitions to tree 2019-11-23 mmortensen@google.com BuildAPI: Add unit tests and mocks for Android service. 2019-11-23 lamontjones@chromium.org cros_setup_toolchains: update sdk toolchain targets in parallel. 2019-11-23 lamontjones@chromium.org lib: correct modes on tmpdirs, better tmpdirs for parallel. 2019-11-23 achuith@chromium.org OWNERS: Add OWNERS.au to nebraska files. 2019-11-23 vapier@chromium.org clactions_metrics: drop unused module 2019-11-23 vapier@chromium.org kernel_cmdline: add hashing to KernelArg 2019-11-23 tbegin@google.com chromite/api: add guest VM as an image type 2019-11-22 vapier@chromium.org cidstore: drop unused module 2019-11-22 vapier@chromium.org cros_build_lib.run: merge append_to_file into stdout 2019-11-22 vapier@chromium.org launch_control: drop unused module 2019-11-22 vapier@chromium.org pylint: use vpython for python2 linting 2019-11-22 asavery@chromium.org hatch-diskswap: add builder configuration 2019-11-22 vapier@chromium.org cbuildbot: drop CommitQueueCompletionStage 2019-11-22 vapier@chromium.org cbuildbot: abort on all chrome pfq build code paths 2019-11-22 vapier@chromium.org autotest_rpc_errors: drop unused module 2019-11-22 philipchen@google.com hatch: Add factory builder 2019-11-22 fqj@chromium.org config: betty-arcvm-pi should run no tests 2019-11-22 vapier@chromium.org licensing: fix generation under Python 3 Created with: gclient setdep -r src/third_party/chromite@bcda22bca456 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ide813d8e9e4c80aca105e69a04f52047baef3992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934350Reviewed-by:
-
Kramer Ge authored
ANGLE by default disables requestable extensions for WebGL. To support GL passthrough interop with VkImageBacking, GL_EXT_memory_object, GL_EXT_memory_object_fd, GL_EXT_semaphore, GL_EXT_semaphore_fd are needed. Bug: 1025451 Change-Id: If3849d7a3ddd8bf33616b57c67703e9eb7d40340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927977Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#718672}
-
Christopher Grant authored
See the associated bug for reasons why this work is happening. Refactor the version number generator script to be more explicit, and do away with the hack that was in place to support multiple version numbers in 64-bit config. Also, add the new pure 32-bit Mono and Trichrome numbers, as well as an alias 32_64 version number, which is equivalent to the ambiguous "Monochrome" version. Bug: 1027573 Change-Id: Iae270f84ad3cf3c28e9001460a016aa7f75237e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931100 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/3aaae716b25b..d4f9c249893a git log 3aaae716b25b..d4f9c249893a --date=short --no-merges --format='%ad %ae %s' 2019-11-23 jstracke@Google.com [base] Really fix #57194. 2019-11-23 wl@gnu.org [truetype] Avoid sanitizer warning (#57289). 2019-11-23 prince.cherusker@gmail.com [truetype] Fix integer overflow (#57287). 2019-11-23 bungeman@google.com [sfnt] Avoid sanitizer warning (#57286). 2019-11-23 jstracke@Google.com [base] Fix `NULL + offset' sanitizer warnings (#57194). 2019-11-23 wl@gnu.org * include/freetype/internal/ftmemory.h (FT_OFFSET): New macro. 2019-11-23 bungeman@google.com [sfnt] Ensure OTTO fonts have tables (#57285). 2019-11-23 behdad@behdad.org Minor fixes for recent compilers. Created with: gclient setdep -r src/third_party/freetype/src@d4f9c249893a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: chromium:1027032,chromium:10269104,chromium:977845 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4fa3c77314d6b1af1a83e490587412765bde9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932027 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Owen Min authored
This reverts commit 2e8d15a1. Reason for revert: It's flaky on linux-trusty-rel https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/4905 Original change's description: > Enable test CertificateManagerModelTest.ListsCertsFromPlatform > > The test was marked as flaky more then a year ago. The bug from the > TODO is fixed and closed. And I was not able to reproduce the problem > localy and via several runs on test servers. > > Bug: 877416, 787602 > Change-Id: Iae0d816c94dedbfb0db779a7b492e7619eba1939 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926480 > Reviewed-by: Matt Mueller <mattm@chromium.org> > Commit-Queue: Michael Ershov <miersh@google.com> > Cr-Commit-Position: refs/heads/master@{#718568} TBR=mattm@chromium.org,miersh@google.com Change-Id: I63c0b241b99b483b8c048f56074cb4cdd9a32467 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877416, 787602, 1028183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933951Reviewed-by:
-
Mike Reed authored
Change-Id: I390126f3393daee530021cf854d88e7c880b974c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933734 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#718668}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd5ba942eb1e..d07418c4577e git log dd5ba942eb1e..d07418c4577e --date=short --no-merges --format='%ad %ae %s' 2019-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 68d3f3a95f1b..ef3043bd8110 (1 commits) 2019-11-25 michaelludwig@google.com Use just GrSurfaceProxy in pipeline management. 2019-11-25 michaelludwig@google.com Lock down GrQuad ctors, avoid resetting Ws when known to be 1.0 Created with: gclient setdep -r src/third_party/skia@d07418c4577e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: Iecff0b70fc4efea64ff4c453a3416a165252e899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934349Reviewed-by:
-
Antonio Gomes authored
... and rename it to rtc_data_channel_init_platform.h. The "platform" suffix is needed so it does not collide with the existing autogenerated header rtc_data_channel_init.h. The struct name is also renamed accordingly, RTCDataChannelInitPlatform. In a follow up CL, this struct will cease to exist, and the direct use of webrtc::DataChannelInit will take place. [1] https://crrev.com/c/1933486 BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I50ce900c228aa23b28066b85b148bf4f2fbc7b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933484Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#718666}
-
Mia Glaese authored
Problem description and design doc: https://docs.google.com/document/d/1e1t3DgrtTkcluXz14xywwhJYq4isVfvVZbh1ZPvkL7M/edit?usp=sharing Current: Autocomplete uses url and page classification of current tab. This leads to: ZeroSuggestions not available on Start Surface (available on NTP). Different suggestions for same input on StartSurface omnibox. No omnibox suggestions if no tabs open. Clank crashes on DCHECK in Debug mode if no tabs open. Now: Autocomplete uses NTP url for both StartSurface and NTP, even with no open tabs. ZeroSuggestions available on start Surface. Same Autocomplete suggestions for NTP and StartSurface. No crashes in Debug mode. Bug: 982018 Change-Id: I8de9b2e3822c5d08c71705466936245d6d0d44f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894293 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#718665}
-
Andrew Grieve authored
This reverts commit 9e256bdc. Reason for reland: Fixed incremental_install=true error > Original change's description: > > Android: Fix secondary_abi_loadable_modules being ignored > > > > They worked in bundles, but not in apk targets. > > > > As identified in the linked bug, this was broken by: > > e1dc23f1 > > > > Verified contents of apks are same with & without this change: > > * Monochrome.apk (with & without build_apk_secondary_abi) > > * TrichromeChrome.aab > > * TrichromeLibrary.apk > > * SystemWebview.apk (with & without build_apk_secondary_abi) TBR=agrieve # reland Bug: 1024862 Change-Id: I2ae7c6f4e1b70245a6320df54cd17ccef865909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933631Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718664}
-
Andrew Grieve authored
TBR=agrieve # ErrorProne fixes. Bug: 894616 Change-Id: Ib1ad6130ce52c3f939423de99840e1e1977cf50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933470 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
TBR=agrieve # ErrorProne fixes. Bug: 894616 Change-Id: I713a3218cd7bce2983b1f0cd52ffe9e3dc96ce70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933768 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Andrew Grieve authored
TBR=agrieve # ErrorProne fixes. Bug: 1027541 Change-Id: I34f255431159cc9e99899ccf24f6126b490b8c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933809 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1028095 Change-Id: I819348d820cd71325edcc84f8801c876022ade37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932784 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#718660}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b4b5033445f5..bc1e7ba9a982 git log b4b5033445f5..bc1e7ba9a982 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 janscheffler@chromium.org Add missing semicolons Created with: gclient setdep -r src/third_party/devtools-frontend/src@bc1e7ba9a982 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94a6f21f9813fff958131bf0204368da9fee201d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934348Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/912b3b83b380..63dced9f4598 git log 912b3b83b380..63dced9f4598 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 jonaso@webrtc.org Add class for ExponentialMovingAverage 2019-11-25 ivoc@webrtc.org Make it possible to inject a custom NetEqFactory from the java interface. 2019-11-25 sprang@webrtc.org Makes sprang@ owner in modules/pacing 2019-11-25 henrik.lundin@webrtc.org Fixing a buffer overflow in Merge::Downsample 2019-11-25 sprang@webrtc.org Makes all of RtpVideoSenderTest use simulated time Created with: gclient setdep -r src/third_party/webrtc@63dced9f4598 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:1016506 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I712c8ec77200a80103520550b95ecd0f0b4581c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934347Reviewed-by:
-
Sebastien Marchand authored
Tabs that are allowed to display notifications should never be frozen or discarded as they clearly expressed that they'd like to use notifications and the user allowed it. The ukm.xml change simply add an enum value to a metric that has already been approved here: https://bugs.chromium.org/p/chromium/issues/detail?id=753486#c26 Change-Id: Iccdf1a026d59bbcc826a97388f8cf34fb50b44e8 Bug: 1026874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929087 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#718657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f26135c33f22..3f24db461826 Created with: gclient setdep -r src-internal@3f24db461826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: Ia2752ea0d28785a62846d5d5c0a8f135449f8b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934308Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718656}
-
Arthur Hemery authored
In order to reuse COEP in other objects, we move its definition into an easy to include single struct mojo file. It replaces the massive network_context.mojom include. Change-Id: I245d68d3fe1880b369c3c65801c502a1aee8b027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930738Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#718655}
-
Egor Pasko authored
Pushing to internal repo does not require a netrc any more (uses a more fancy auth with role accounts and ACLs). Hence removing the support code for it. A downstream test instantiates the OrderfileUpdater. Make the constructor argument optional to avoid changing downstream code simultaneously. Bug: 1021528 Change-Id: Ie902bdd1d7272f7d884f6ce2e99e9983a1aa5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934330Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#718654}
-
Kevin Ellis authored
GetPlayState is a reasonably efficient method and there appears to be little benefit in caching its value. Previously, we had 3 variants of the play state cached: the last state used for devtools notifications, and 2 for tracking the extended and spec-compliant play state. The devtools one is still needed to avoid spamming devtools notifications; however, the later two can be removed as part of the refactoring effort. The extended play state (internal_play_state) is required as long as PlayStateUpdateScope is in use. This patch removes use of animation_play_state_. A minor bug was exposed and fixed in removing this variable. Previously we explicitly marked an animation as finished after calling the finished method (what else could it be?) rather than computing the new play state. Per spec, the start time is not set if there is no active timeline and thus the animation transitions to paused and not finished. https://drafts.csswg.org/web-animations-1/#finishing-an-animation-section Bug: 960944 Change-Id: Ia07213d83bb9645251849a548b19b37dd30b3086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931158 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#718653}
-
David Roger authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1930818 Change-Id: I974c44b0cbffc5621f1fd9b0c9f7358061f907a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932801Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#718652}
-
Hans Wennborg authored
while we figure out how to handle this new warning. TBR=rnk Bug: 1028110 Change-Id: I88be5c763bd0f2fcb40ebecc20990f96853d70c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932804Reviewed-by:
-
