- 07 Nov, 2018 33 commits
-
-
Dmitry Gozman authored
Bug: 775132 Change-Id: I95a91e28bd67343c1b26c719edd0aaffc9fe9179 Reviewed-on: https://chromium-review.googlesource.com/c/1321089 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#605912}
-
Hao Zhang authored
Change-Id: I764f1cccc3dbf40e2580bc3bdf89bc789422a8d1 Bug: 899057 Reviewed-on: https://chromium-review.googlesource.com/c/1300314 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#605911}
-
Tarun Bansal authored
Currently, Network Quality Estimator (NQE) stores prefs on the disk. These prefs are managed (written t0 and read by) in the browser process, and then notified to the network quality estimator object. With network servicification, NQE object would live in the network process, and would no longer be accessible in the browser process. This CL moves the management of prefs from the browser process to the network process. Bug: 878844 Change-Id: Id533c2260201c0c665ae3bde1a0fe955a140a70e Reviewed-on: https://chromium-review.googlesource.com/c/1312977 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#605910}
-
Dmitry Titov authored
This reverts commit 06b39212. Reason for revert: to fix the test external/wpt/workers/semantics/structured-clone/shared.html first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530 Original change's description: > Remove WebDataConsumerHandle usage from DataPipeAndDataBytesConsumer. > > As a step towards removing WebDataConsumerHandle stop using the type in > DataPipeAndDataBytesConsumer. Instead this code can instead use > DataPipeBytesConsumer to read the mojo::DataPipe. > > Bug: 894819 > Change-Id: Ie9cad46dfa9d67998d23bf0efd6300870428f3cb > Reviewed-on: https://chromium-review.googlesource.com/c/1313389 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605689} TBR=yhirano@chromium.org,wanderview@chromium.org Change-Id: I6a792df67c062020085362929f402c433d3fa60e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894819 Reviewed-on: https://chromium-review.googlesource.com/c/1321856Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605909}
-
Chase Phillips authored
Verify that the current version of IndexedDB can read an IndexedDB instance created by a previous version of Chrome stable. These DBs were created with Chrome stable version 70.0.3538.77 (Official Build) (64-bit) on Linux. The webapp used to create the instances was provided in https://crbug.com/899446 by Victor Costan <pwnall@chromium.org>. The noai version is modified from that case to disable autoincrement. Bug: 717812 Bug: 899446 Change-Id: I0b293f68cde4d637c53faaabd52b3b27a0ac147c Reviewed-on: https://chromium-review.googlesource.com/c/1320693Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#605908}
-
Shakti Sahu authored
The width of the recycler view used for computing span count and decorations needed to account for the huge padding that is added on a wide screen which limits the view width to 600dp. Fixed the issue. Bug: 902369 Change-Id: Idffd31813fdfcaaac3be5a1ffbd9b5e6c0119f25 Reviewed-on: https://chromium-review.googlesource.com/c/1321576Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605907}
-
Noel Gordon authored
Reformat to be consistent with the other create_new_folder test cases. Bug: None, no change in behavior. Change-Id: I1a3bf2d7fa923b42149630e0da34c5a46865e9a7 Reviewed-on: https://chromium-review.googlesource.com/c/1321650 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605906}
-
Hiroshi Ichikawa authored
Bug: 884055 Change-Id: Ib5a93bf85d877dfdaef7491a99295be305107398 Reviewed-on: https://chromium-review.googlesource.com/c/1318514 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
-
Dmitry Titov authored
This reverts commit a97710c5. Reason for revert: Reland the original change, since speculative revert did not fix the failing test. Original change's description: > Revert "Fix 64 bit truncation warnings in renderer/core/fetch." > > This reverts commit 406c50b3. > > Reason for revert: Speculative revert to fix the test external/wpt/workers/semantics/structured-clone/shared.html > > first started to fail in build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75530 > > If this won't fix the test, I'll reland the patch. > > Original change's description: > > Fix 64 bit truncation warnings in renderer/core/fetch. > > > > Use appropriate types in fetch code. > > > > BUG=879657 > > > > Change-Id: I7f26d8a6651abafbb185193cc2670bcdb5eff05e > > Reviewed-on: https://chromium-review.googlesource.com/c/1298329 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605685} > > TBR=bokan@chromium.org,dtapuska@chromium.org > > Change-Id: I36f8751112daf958ef849549b2c94a57c297ab8f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 879657 > Reviewed-on: https://chromium-review.googlesource.com/c/1321251 > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Commit-Queue: Dmitry Titov <dimich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605855} TBR=bokan@chromium.org,dimich@chromium.org,dtapuska@chromium.org Change-Id: I30b8ce404b5abb5450d0762598a5332d761c3c62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879657 Reviewed-on: https://chromium-review.googlesource.com/c/1321855Reviewed-by:
-
Noel Gordon authored
Similar to the issue 891197 fix, wait for the directory tree row attribute [has-children=true] before clicking the expand icon. Bug: 899664 Change-Id: I26d0f96feba85b6bd0cd9d03b76b438f1b1b7f0b Reviewed-on: https://chromium-review.googlesource.com/c/1321649Reviewed-by:
-
Takuto Ikuta authored
https://chromium.googlesource.com/external/github.com/googlei18n/sfntly.git/+log/2804148152d2..b55ff303ea2f $ git log 280414815..b55ff303e --date=short --no-merges --format='%ad %ae %s' 2018-10-17 tikuta Specify const for operator() 2018-09-27 nyshadhr Add tests for EOT's 255SHORT encoding 2018-09-26 nyshadhr Fix encoding for EOT's 255SHORT Created with: roll-dep src/third_party/sfntly/src Also removed unnecessary flag. TBR: thestig@chromium.org Bug: 683349 Change-Id: I0a00b965126ad4ff10855ae24835706c397dc8af Reviewed-on: https://chromium-review.googlesource.com/c/1320989Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605902}
-
Ella Ge authored
The pointerlock spec defines MovementX/Y follow the scale of screenX/Y, which is not scaled by pinch-zoom scale. https://w3c.github.io/pointerlock/#dom-mouseevent-movementx Although currently in chrome, it is movement is in physical pixel, it should still be unscaled value. We should not apply frame_scale to movement_x/y. Note that right now WebMouseEvent::MovementInRootFrame is not used anywhere other than test. we only scales the touch PointerEvent but not mouse event. This CL removes unused WebMouseEvent::MovementInRootFrame, and also makes touch pointer event movementX/Y not scaled by pinch zoom. Bug: 837004 Change-Id: I4bb39b3b01ecbd77c58fd4501a5c63ccb44e5a5b Reviewed-on: https://chromium-review.googlesource.com/c/1313280Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#605901}
-
Min Qin authored
The logic in loading the download history is quite complicated today. When DownloadManagerImpl is created, it first loads the download from in-progress manager. And then it starts to load the downloads from History DB. That's causing several issues: 1. Due to the mismatch between history DB and in-progress DB, DownloadManagerImpl need to resolve the conflicts when history DB is loaded. Normally it just takes the information from in-progress DB. However, due to the latency during database commit, history DB might contain fresher information than the in-progress DB if the download is in a terminating state (Cancelled/Completed). And that's causing crbug/898859 as an extra OnDownloadCreated() call is called for those terminating downloads. 2. DownloadHistory used to call CreateDownloadItem() and expect a reentrant OnDownloadCreated() call when loading history downloads. However, this may no longer happen as OnDownloadCreated() may have already been called when loading the in-progress DB. So DownloadHistory have to handle the case that there is no reentrant call, which makes the code hard to understand. 3. DownloadHistory might get a OnDownloadCreated() call even before history is loaded. And some of the downloads might have already existed in the history DB. This will cause a failed sql insert LOG in the console. Although the behavior is expected, it is not quite clean. This CL fixes all above issue by loading the in-progress DB records and the history DB records at the same time. Once CreateDownloadItem() is called, DownloadManagerImpl will find the corresponding in-progress download and return it to DownloadHistory, and calling OnDownloadCreated() at the same time. BUG=898859 Change-Id: I0f1da0ecea99e72e8c5507ea005c56261a46f3cd Reviewed-on: https://chromium-review.googlesource.com/c/1318692Reviewed-by:
-
Jun Cai authored
The "Initial upload" patch of this CL is the same as: https://chromium-review.googlesource.com/c/chromium/src/+/1274585 The above original CL was reverted at: https://chromium-review.googlesource.com/c/chromium/src/+/1319614 The major changes since the "Initial upload" patch set 1: Removed some unnecessary include files and removed the "//services/network/public/cpp" dep from "components/metrics/BUILD.gn". These include files and dep caused the build error Cronet for Android. TBR=olivierrobin@chromium.org, michaelbai@chromium.org, jam@chromium.org, fdoray@chromium.org, asvitkine@chromium.org Bug: 883121 Change-Id: Ifcaf40ea1b72ddc3a6a72be16e4d52190740e5a4 Reviewed-on: https://chromium-review.googlesource.com/c/1320710Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#605899}
-
Christopher Cameron authored
Move from using Cocoa to using Views. The Cocoa version was was causing problems with app exit dialogs showing up in the wrong process in RemoteMacViews. This issue was solved by the views version. Bug: 898604 Change-Id: I30bd1e543fa98a1503d80b4ad3947f676eb5e0c6 Reviewed-on: https://chromium-review.googlesource.com/c/1298300 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#605898}
-
Bill Orr authored
This change defines Graphics, Input, and Scheduler delegates that can interact with BrowerRenderer to render in-headset VR UI. With this change, the delegates are mostly defined and parts necessary to render are implemented, but VR UI doesn't yet actually render any UI on desktop. BUG=819448 Change-Id: I8d50e200e2380ae2113454eaf77cd1c53f369554 Reviewed-on: https://chromium-review.googlesource.com/c/1306402 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#605897}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe454acf5ef1..0e50a38dcaee git log fe454acf5ef1..0e50a38dcaee --date=short --no-merges --format='%ad %ae %s' 2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader dc2966a15b0c..6e8ec338eb25 (1 commits) 2018-11-06 mtklein@google.com make float divide-by-zero fatal 2018-11-06 scroggo@google.com Remove SkBitmap::[setH/h]asHardwareMipMap 2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1d8c8dba995a..dc2966a15b0c (1 commits) 2018-11-06 benjaminwagner@google.com Add subset of Ubuntu18 jobs. 2018-11-06 mtklein@google.com send 3D masks through raster pipeline blitter Created with: gclient setdep -r src/third_party/skia@0e50a38dcaee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:837351 TBR=allanmac@chromium.org Change-Id: I9c34a7e8db8e1dde0630808371fb0bcc62477b39 Reviewed-on: https://chromium-review.googlesource.com/c/1321173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605896}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02924fce9a91..3ca5cecde5b0 git log 02924fce9a91..3ca5cecde5b0 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 hjd@google.com perfetto-ui: Update examples and fix loading ui bug Created with: gclient setdep -r src/third_party/perfetto@3ca5cecde5b0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6ee35bebadf54f4b04e50e9784543739ae069d0 Reviewed-on: https://chromium-review.googlesource.com/c/1321169Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/70df4ea4898e..2e722b007d34 git log 70df4ea4898e..2e722b007d34 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 dpranke@chromium.org Rename 'conditions' to 'tags' in the parser. Created with: gclient setdep -r src/third_party/catapult@2e722b007d34 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690 TBR=sullivan@chromium.org Change-Id: I0b55520ce5c2b2a2d55691e151a0f54ec369be43 Reviewed-on: https://chromium-review.googlesource.com/c/1321329Reviewed-by:
-
Leo Zhang authored
This flag will provide entry for users to enable the IME service. Bug: 888885 Change-Id: Ie21e5d1afd001db6968ce69d248304fad35bc31e Reviewed-on: https://chromium-review.googlesource.com/c/1319223Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605893}
-
Luciano Pacheco authored
This can be used by users as fallback plan to access old Downloads if the migration of Downloads to MyFiles/Downloads fails. allows access to old Downloads. Test: manually checked on a test device that switching off this flag Bug: 873539 Change-Id: Icc104b4f9464c25937be990c41baf05a77e544b0 Reviewed-on: https://chromium-review.googlesource.com/c/1321529Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605892}
-
Christopher Cameron authored
The function OnBrowserCompositorSurfaceIdChanged made redundant calls to - BrowserCompositorMac::UpdateRendererLocalSurfaceIdFromChild - Every caller of this function had just updated the surface id - DelegatedFrameHost::EmbedSurface - Every caller of this function had also just called EmbedSurface In RenderWidgetHostViewMac, merge RequestRepaintForTesting and EnsureSurfaceSynchronizedForLayoutTest because they do the same thing, and make them call BrowserCompositorMac::ForceNewSurfaceId. Delete several BrowserCompositorMac functions that were only needed due to poor organization: RequestRepaintForTesting, AllocateNewRendererLocalSurfaceId, and UpdateRendererLocalSurfaceIdFromChild. Bug: 897156 Change-Id: I0bb2d6645bb8c9b4e91a469c17c1415dac7293e1 Reviewed-on: https://chromium-review.googlesource.com/c/1317032 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605891}
-
Sean Topping authored
This aids in debugging various crashes that might occur during navigation. Bug: internal b/118459412 Test: CQ Change-Id: Iacb798075dde879bb45a41827b155b96004c2130 Reviewed-on: https://chromium-review.googlesource.com/c/1321150Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#605890}
-
Manuel Rego Casasnovas authored
In the first version of this optimization r578233 we were skipping the cases when text-alignment was not the default one. This patch adds support for center and right/end text alignments, as we know for sure we're in left-to-right the operation is pretty simple. Justify alignment is still skipped as we need to layout the text anyway in that case. Thanks to this patch the optimization can be applied in more cases, the perftest is modified to include different text-align values. Probably there would be some changes on the number, but without this patch the results are much worse. BUG=805785 TEST=fast/css/containment/change-text-node-data-center.html TEST=fast/css/containment/change-text-node-data-right.html Change-Id: I71a87973b357fc492a7ddd9d238b8779d6152d8d Reviewed-on: https://chromium-review.googlesource.com/c/1318690Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#605889}
-
Nate Fischer authored
No change to logic. This adds an UMA metric to see if the WebViewClient is a WebViewClientCompat or not. This will only ever be boolean (at least for the foreseeable future), so this should be safe to keep as a boolean histogram for now. R=changwan@chromium.org, isherman@chromium.org Bug: 901581 Test: N/A (not feasible to test metrics right now) Change-Id: I9e6ba219d4f5f26f1fec947ef9974549490e2258 Reviewed-on: https://chromium-review.googlesource.com/c/1318748 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605888}
-
Nate Fischer authored
loadDataWithBaseURL doesn't always accept encoded content. This moves the histogram code into the branch which actually accepts encoded content (since it's reasonable to expect an unencoded '#' in unencoded content). R=smcgruer@chromium.org, torne@chromium.org Bug: 902223 Bug: 823666 Test: None Change-Id: If5c912640ea81a4d6e333496233958f3323d9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1319347 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 902138 Test: Builds locally. Change-Id: If898f335dc9600d0de3996ecf45498bddb1322d9 Reviewed-on: https://chromium-review.googlesource.com/c/1321029 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#605886}
-
Dan Sanders authored
This UMA counts pictures output to Pepper clients, categorized by size and decoder type (HW vs SW). This will be used as a proxy for watch time / compute resources when evaluating PPB_Video_Decoder deprecation. Bug: 880984 Change-Id: Ifac8de6ada9ae8a700dc61db91830307a99aa85c Reviewed-on: https://chromium-review.googlesource.com/c/1306917 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605885}
-
Varun Khaneja authored
Server side change: http://cl/219735922 Tested by checking the "ClientSafeBrowsingReportRequests" tab on chrome://safe-browsing Bug: 867518,901215 Change-Id: I04356eb38f7b2306c5b74baed6ca3f73969a3dbd Reviewed-on: https://chromium-review.googlesource.com/c/1313881Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#605884}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/34fc346a0c77..dc98b9b975fa git log 34fc346a0c77..dc98b9b975fa --date=short --no-merges --format='%ad %ae %s' 2018-11-06 peah@webrtc.org AEC3: Corrected include 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7841106b..793c8566 (605607:605715) 2018-11-06 sprang@webrtc.org Update Android encoder to use GetEncoderInfo() 2018-11-06 gustaf@webrtc.org AEC3: Compensate comfort noise level for loss due to filter bank 2018-11-06 gustaf@webrtc.org AEC3: Computation of comfort noise gains from suppression gains Created with: gclient setdep -r src/third_party/webrtc@dc98b9b975fa The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:902262,chromium:902262 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3e5de56c6457fe51e999dd549f6f476401e4f482 Reviewed-on: https://chromium-review.googlesource.com/c/1320613Reviewed-by:
-
Dmitry Titov authored
This reverts commit f3fe6cc9. Reason for revert: Broke compile: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/58434 Snippet: In file included from ../../chrome/browser/devtools/devtools_window.cc:31: In file included from ../../chrome/browser/ui/browser_window.h:31: ../../chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h:13:10: fatal error: 'chrome/browser/apps/foundation/app_service/public/mojom/types.mojom.h' file not found #include "chrome/browser/apps/foundation/app_service/public/mojom/types.mojom.h" Original change's description: > Move the app_service code to //chrome/services > > The app_service code was originally created under //chrome/browser, > specifically //chrome/browser/apps/foundation. This was because of an > early concern that the app_service implementation would need to be > tightly coupled to browser concepts, especially a Profile. More recent > prototyping suggests that this won't be the case. > > This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping > "#include" lines sorted. > > Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 > Reviewed-on: https://chromium-review.googlesource.com/c/1312435 > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605876} TBR=avi@chromium.org,battre@chromium.org,rockot@google.com,dominickn@chromium.org,nigeltao@chromium.org Change-Id: I24d6e63366a96f0bf24ce62c74951187e2151bca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1321771Reviewed-by:
-
Jonathan Metzman authored
Bug: 901836 Change-Id: I086972b916d5b46d497a4b57ae60f64627d25551 Reviewed-on: https://chromium-review.googlesource.com/c/1321569Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605881}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e5f6a771e82..0ab40518b6d4 Created with: gclient setdep -r src-internal@0ab40518b6d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9c0c40390dbfbff10b09fa19edbc88071e01261b Reviewed-on: https://chromium-review.googlesource.com/c/1321171Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605880}
-
- 06 Nov, 2018 7 commits
-
-
Qiyu Hu authored
CQ-DEPEND=CL:1316428 Bug: chromium:887029,b:118334521 Test: unittest Change-Id: I02bf1d4af3f08762c7ecf0ff69637ad53f0e014b Reviewed-on: https://chromium-review.googlesource.com/c/1313412 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605879}
-
CJ DiMeglio authored
This CL makes sure that the |video_frame_compositor_context_provider_| and references to it get dereferenced to the thread it is bound to (in this case, the |video_frame_compositor_task_runner_| Bug: 898989 Change-Id: I98654bb5a6b29a43a384ce0308b4b97d575903a0 Reviewed-on: https://chromium-review.googlesource.com/c/1303178 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This is a follow-up CL of https://crrev.com/c/1307015. We don't use |dispatch_event_time| any longer. Change-Id: If14e295eb6c0a8d9b83f499e3b7f65d4ff6d1d27 Bug: 898020, 872567 Reviewed-on: https://chromium-review.googlesource.com/c/1319398Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605877}
-
Nigel Tao authored
The app_service code was originally created under //chrome/browser, specifically //chrome/browser/apps/foundation. This was because of an early concern that the app_service implementation would need to be tightly coupled to browser concepts, especially a Profile. More recent prototyping suggests that this won't be the case. This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping "#include" lines sorted. Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 Reviewed-on: https://chromium-review.googlesource.com/c/1312435Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#605876}
-
Istiaque Ahmed authored
Add caching for ContentHash instances for a particular version of an extension. Since ContentHash is required for all extension resource requests when content verification applies, this should speed up ContentVerifyJob. Note that we should expect gains in "ExtensionContentVerifyJob.TimeSpentUS" UMA. Bug: 796395 Test: No visible behavior changes expected. Change-Id: I4d03bcd95f00215628eb9b3f143e15e7bd2c84d5 Reviewed-on: https://chromium-review.googlesource.com/c/1266604 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605875}
-
Brandon Wylie authored
- Allows java to interact with the native CachedImageFetcher. - Android-side tries to read from disk directly, so the JNI can be skipped if the image is cached. Binary-Size: Temporary increase to support quick rollback. Bug: 897362 Change-Id: Ifd7c77e0eeef56ea49ec53b398b83f7cc134a479 Reviewed-on: https://chromium-review.googlesource.com/c/1297639Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605874}
-
Lan Wei authored
Since we are not updating hover during mouse wheel scroll, we should update hover when we handle the GestureScrollEnd event on compositor or main thread. Bug: 877132 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I732aea455db927ff5ad44b89e7a446917ad94e35 Reviewed-on: https://chromium-review.googlesource.com/c/1265555Reviewed-by:
-
