GitLab

This patch is to split sandboxed-iframe-fetch-event.https.html into small
chunks. Each promise_test has smaller number of assertions, so that now we can
see the results for each situation.

Bug: 771815
Change-Id: I75cdd67f92bbb07d6b538b209e1f0819752c3bc8
Reviewed-on: https://chromium-review.googlesource.com/923901
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537606}

(Partly as a preparation to add more logic for htxg-specific prefetch
plumbing)

Introduce prefetch-specific URLLoader which does:
- Basically just forwards the request to the underlying network loader
- Doesn't forward back the data to the renderer process, which used to
  be just discarded in the renderer process anyways.

This is hooked as follows:
- When NetworkService is enabled LinkLoader gets PrefetchURLLoaderFactory
  via PrefetchURLLoaderService and sets it as ResourceLoaderOptions.
  url_loader_factory.
- When NetworkService is NOT enabled this is directly hooked from the
  ResourceMessageFilter.

In both cases the URLLoaderFactory is owned by StoragePartition,
partially because it makes various plumbing (including tests) easier.

Optionally we can make it live longer than the client process, though
it is not currently implemented. (So no behavior change is expected
with this one)

Bug: 803776
Change-Id: Ia4b33048a7c6d27a80044d99b62a1cc5faad5681
Reviewed-on: https://chromium-review.googlesource.com/912051
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537605}

This should not have been removed in https://crrev.com/536430

Move tracking from RenderWidgetHostImpl (where it is tracked only in
non-viz mode) to BrowserCompositorView, where it is tracked in both
modes.

Bug: 772576, 812505, 812156
Change-Id: I006c1c78f2dc148602f08253745993f8a57a7e16
Reviewed-on: https://chromium-review.googlesource.com/923379
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537604}

Trace calls should just dispatch and register at the visitors. This is
in preparation to override visitation behavior.

Bug: chromium:802273
Change-Id: I0d7d6f95a7adcf121123316af7cb5b837c9e262f
Reviewed-on: https://chromium-review.googlesource.com/923731Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537603}

It is flaky. Disabling it for now.

not run anything.

Bug: 813483
Test: unit_tests --grest_filter=FileManagerFileWatcherTest.WatchLocalFile did
Change-Id: I826f3f4ca942c939916207bca97569661d92351d
Reviewed-on: https://chromium-review.googlesource.com/923616Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537602}

This CL removes the deprecated rotations methods. Those methods are not
called on iOS 8+ devices.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9093e24645c7adbe16ec220fac5cb4d0a32669a8
Reviewed-on: https://chromium-review.googlesource.com/924021Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537601}

This CL reports whether an OOPIF is causing invariants violations.

Bug: 791154, 672962
Change-Id: Ida943b8a6bb21cd5baed00bd0065f77e5a358033
Reviewed-on: https://chromium-review.googlesource.com/923041
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537600}

Bug: 813320
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia7434352408d5327a72d4c9a80da31542ddeba05
Reviewed-on: https://chromium-review.googlesource.com/923770Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537599}

- Decide when to call ProceedWithResponse depending on the loader option
  (rather than checking kNetworkService flag), so that the same loader
  code can run for subresource loading too
- Decide when to return SSLInfo back also depending on the loader
  option

Bug: 803774, 803776
Change-Id: I1e5d4bddcfc054339ca4cd4b83068af6c1d0ec24
Reviewed-on: https://chromium-review.googlesource.com/923664
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537598}

Mark a layout test external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.html as flaky

Bug: 813462
Change-Id: I1218269ed75ff50b991505f6f67f770c29e2d593
Reviewed-on: https://chromium-review.googlesource.com/923743
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537597}

Add me as an owner of these directories.

Change-Id: I0baadafda1c4989956dd477b6e6ddab0195916ea
Reviewed-on: https://chromium-review.googlesource.com/923746Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537596}

This patch introduces test cases for |PreviousWordPosition()| to record current
behavior as a preparation of the patch[1].

Note: The patch[2] introduces test case for |NextWordPosition()|.

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection
[2] http://crrev.com/c/895236 Introduce test cases for NextWordPosition()

Bug: 778507
Change-Id: Ie1b3933336ddd9d6afca246700a9f7e9a588d61d
Reviewed-on: https://chromium-review.googlesource.com/923686
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537595}

and handle empty or missing rpIds.

Add layout tests for various combinations of origins and rpId to
get(publicKey) just like the existing ones for create(publicKey).

Bug: 807774, 664630
Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b
Reviewed-on: https://chromium-review.googlesource.com/896384
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537594}

This reverts commit d9b74d0c.

Reason for revert: See the FindIt message. It looks this CL has broken the "Linux Chromium OS ASan LSan Tests" bot

Original change's description:
> Add user to active sessions reporting.
> 
> Previously, active sessions and recent users were reported separately,
> that is confusing on the server side.
> This change adds 'user_email' field to ActiveTimePeriod proto message
> and populates it for affiliated users that are eligible for reporting.
> Also, user email is reported only if user reporting is turned on.
> 
> BUG=810093
> TEST=Browser tests added.
> 
> Change-Id: I92fec6725349972895ec0a439f78efa59853670e
> Reviewed-on: https://chromium-review.googlesource.com/904527
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537435}

TBR=xiyuan@chromium.org,emaxx@chromium.org,poromov@chromium.org,pmarko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 810093
Change-Id: I96152915d5da8d763c32132bade51b2bc5a4bcd7
Reviewed-on: https://chromium-review.googlesource.com/923228Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537593}

We no longer have multiple shadow roots, <shadow> behaves almost
identical to <content> without select attribute.
We only have to care for the case when <content> and <shadow> are
used in the same shadow root.

This CL simplifies code that used to handle multiple shadow cases
for <shadow> elements in V0 distribution logic.

No visible behavioral change is expected.

Bug: 624724
Change-Id: I88f237f2d26519cd400ef13605f4b3115843b4b7
Reviewed-on: https://chromium-review.googlesource.com/923446Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537592}

StaticSocketDataProvider and SequencedSocketData do not modify the
MockRead and MockWrite arrays that they are passed. Mark them const.

Change-Id: I0eea9dce572e2fd1c9c8cf8e2f08cdfb14b4fc1c
Reviewed-on: https://chromium-review.googlesource.com/917886Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537591}

This reverts commit b104c05a.

Reason for revert: Now SPv175 is live on M66, so return the bot
to SPv2.

Also update LayoutTests/FlagExpectations/enable-slimming-paint-v2.

Original change's description:
> [SPv175] Borrow the SPv2 bot for SPv175
>
> We are near to finish SPv175 development, and we need more test
> coverage. Borrow the SPv2 bot for SPv175 until we switch SPv175
> on for experiment.
>
> Bug: 771643
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I05f36f168269507961cdc102446e4b23159555dd
> TBR: testing/buildbot
> Reviewed-on: https://chromium-review.googlesource.com/860726
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528517}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771643
Change-Id: Ib0e31c9e542936a0ac3baddf17b4896eff7aed47
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/925021Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537590}

Revert "Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation."

This reverts commit 537ea336.

Reason for revert: The newly added tests are failing on the "WebKit Linux Trusty" bot

Original change's description:
> Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation.
> 
> Bug: 792783
> Change-Id: Icdc8423c50eaa051b348c5226af4936e97b39251
> Reviewed-on: https://chromium-review.googlesource.com/923141
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537568}

TBR=jsbell@chromium.org,szager@chromium.org,aboxhall@chromium.org,haraken@chromium.org,altimin@chromium.org

Change-Id: If686ff2c3db54ff3492b46ee528c79a4250ff4c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792783
Reviewed-on: https://chromium-review.googlesource.com/923251Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537589}

HostedAppTest now use https for all tests other than http-specific ones
(otherwise, all tests would show a location bar, and we wouldn't be
properly testing any of the other behaviour).

Bug: 811158
Change-Id: I0fe220055fb6574c3950f65971e06feadaeabcd9
Reviewed-on: https://chromium-review.googlesource.com/913191Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537588}

This is part of efforts to replace default timer task runners with
other appropriate task runners in the renderer.

Bug: 624694, 804694
Change-Id: Ic6983b6f0a2b5039db1473662d2e7627dd67b5e1
Reviewed-on: https://chromium-review.googlesource.com/903903Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537587}

Following bot results are included.
3800 3802 3812 3817 3830 3832 3833 3834

2 lines were removed and 28 lines were deflaked by consecutive results
since 3750.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5d2c0a665f013a4143ab31cfa98e39a0c6ce0af7
Reviewed-on: https://chromium-review.googlesource.com/923243
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537586}

Traffic annotation auditor file filter is expanded to ignore all files
that end with test.cc or test.mm.

Bug: 690323
Change-Id: Iac0eb5aca403f4fa40b6b81dd85a46c317fd6684
Reviewed-on: https://chromium-review.googlesource.com/924062
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537585}

The first implementation of CSS list in LayoutNG adds the logic to
NGInlineLayoutAlgorithm, and supports only when content of the list
item is inline level. Extending this to when list items have block
level children wasn't easy. Making them as inline blocks is likely not
web-compatible when floats affect part of the blocks.

The most common case is nested lists, because a list is block level.
This patch renders basic nested lists correctly.

This patch supports list marker as an unpositioned object in
NGBlockLayoutAlgorithm, similar to floats or out-of-flow objects, and
positions them when it lays out the next block, relative to its first
line baseline. It is much simpler than floats or out-of-flow objects,
because it is contained only within the list item.

The approach is still being discussed with Francois (msft) and Cathie.
Also this patch still doesn't support images, and customized
positioning of markers by setting padding/margin. These will be in
following patches.

Two tests that were incorrectly rebaselined were re-rebaselined.
Some image failures turned to text failures that need manual reviews
to rebaseline.

Bug: 725277
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I2e7f46fc6320c6986e4894a263ef99873db2f092
Reviewed-on: https://chromium-review.googlesource.com/919443
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537584}

This reverts commit 673d8eb6.

Reason for revert: Looks this has broken linux-chromeos-rel build. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EGLApiTest.DisabledExtensionBitTest&testType=gl_unittests_ozone

Original change's description:
> GpuMemoryBuffer: add image_xb30 capability and RGBX_1010102 BufferFormat
> 
> This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer
> Capabilities to signal support for image_xb30, in parallel to the
> existing image_xr30. The new flag is used on platforms supporting
> glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3
> or those with the appropriate GL extension.
> 
> This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to
> be used where image_xb30 is signalled.
> 
> With all this, Mac will use image_xr30 <-> BGRX_1010102, and the
> GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102.
> 
> Bug: 803975, 776093, 803451, 808172
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611
> Reviewed-on: https://chromium-review.googlesource.com/920361
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537561}

TBR=avi@chromium.org,reveman@chromium.org,dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,rsesek@chromium.org,piman@chromium.org

Change-Id: I08563c74c65ed18ea7dd78e41220a3607b7c9ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803975, 776093, 803451, 808172
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/923448Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537583}

History:
At some point in the past, SpokenFeedbackEventRewriter did not have the notion of |capture| (a boolean set by a calling extension). As a result, we had to hard code values into the rewriter so that they get rewritten by things like KeyboardDrivenEventRewriter. For example, F1->back.

This leads to us not being able to capture and prevent default on F1-F12 which map to hardware keys.

Bug: 687748
Test: Search+o, k; verify f1-f12 announce and don't trigger.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3ca70a8fc1159f9b5f60332ef5a77ecfe95482b7
Reviewed-on: https://chromium-review.googlesource.com/905283Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537582}

This is probably not going to fix the leak but will make things
clearer.

Bug: 808390
Change-Id: I625ed2fde63d1eb1bb09fcb5ed3e522929d9f025
Reviewed-on: https://chromium-review.googlesource.com/923447Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537581}

ResourceFetcher/ResourceLoader now saves the result of the CORS check on
the Resource object. Though the result of the CORS check varies
depending on the source origin, reusing an existing resource fetched by
a different source origin is allowed by mistake.

This patch introduces a logic to prevent MemoryCache entries from being
reused for requests with a different source (requestor) origin by saving
the source origin on the Resource object and comparing that with the new
source origin in Resource::CanReuse(), so that the result of the CORS
check is reused only when the source origin is the same.

An alternative possibly-better approach is to isolate MemoryCache for
different origins by changing the cache identifier to take into account
the source origin of requests. However, to keep the patch small and fix
the issue quickly, this patch just prevents reuse.

Bug: 799477, 809350
Change-Id: Ib96c9e728abe969a53f3d80519118a83392067b4
Reviewed-on: https://chromium-review.googlesource.com/897040
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537580}

When creating a ResourceResponse from another ResourceResponse,
we need to copy WasFetchedViaServiceWorker and
ResponseTypeViaServiceWorker.

Bug: 737648
Change-Id: I9405738221ef5232e235f9fc400f204b7b558596
Reviewed-on: https://chromium-review.googlesource.com/907012
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537579}

Make Element::CloneElementWithoutAttributesAndChildren private back.
This CL has no behavior changes.

Bug: 812089
Change-Id: I69b91ebcb436d721f8d54d904dd8b145cdc12607
Reviewed-on: https://chromium-review.googlesource.com/923506
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537578}

ContainerNode::CloneChildNodes() does the same thing.
This CL has no behavior changes.

Bug: 812089
Change-Id: Ida9fb4c6dbc34654b54e74285263f70411d50d36
Reviewed-on: https://chromium-review.googlesource.com/924108Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537577}

TBR=inferno@chromium.org

Bug: 813188
Change-Id: I70b1d84cc6e9f0538b7faac7ba27ce09c5bffab6
Reviewed-on: https://chromium-review.googlesource.com/923922Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537576}

virtual/gpu-rasterization/images/color-profile-image-filter-all.html
(likely) started failing from the patch for SlimmingPaintV175. As noted
in the patch, marking it as failing instead of reverting it.

Additionally, marking it as SLOW as it's failing for timeout also on
Mac in addition to Linux and Win which are already specified.

Bug: 771643, 726075
Change-Id: I15771a9e018428d3b729da40491d7bea3f7e2917
Reviewed-on: https://chromium-review.googlesource.com/923768Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537575}

Reviewed at https://crrev.com/c/920961 reverted because `gn gen` failed
when args.gn contained `enable_stripping = true`. Fixed by removing the
output_name override and updating the literal in code.

- Resurrects shell_dialogs_unittests on Mac
- Fixes 2 tests that had regressed since the gn transition.
- Tweaks the code to be more robust around complex object lifetimes.
- Adds test SelectFileDialogMacTest.Lifetime

TBR=avi@chromium.org,rsesek@chromium.org

Bug: 788271
Change-Id: I650f804386854d5fd05f76dfb0b55667786c8578
Reviewed-on: https://chromium-review.googlesource.com/925122
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537574}

Contextual search needs a full screen height to display its
contents but the height returned from the class OverlayPanelBase
was shorter by toolbar height. This CL sets it right.

Tested on mobile/tablet in both portrait/landscape mode.

Bug: 772205, 810297
Change-Id: I8a863ee2e53075a31d9dc8d61bd8482aa8454455
Reviewed-on: https://chromium-review.googlesource.com/910128
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537573}

Pull out a couple of hard-coded layout constants in LocationBarView and put them
in layout_constants.*. Also audit the uses of these layout constants and update
places that should be using them.

Bug: 801583
Change-Id: Ia157cd313020a17fa4f8ebda662545395c29855b
Reviewed-on: https://chromium-review.googlesource.com/923503Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537572}

ash/system/tray/tray_constants.h has number of constant values that are
not used anymore.

BUG=none

Change-Id: I4156f0b48951144416316b60d2bdf556b01e784f
Reviewed-on: https://chromium-review.googlesource.com/923742Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537571}

Bug: 801583
Change-Id: I7841e175a0aba57020775465cd191083bf8b19a4
Reviewed-on: https://chromium-review.googlesource.com/914984
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537570}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=raymes@chromium.org

Change-Id: Ic204074056ad3a3a7060c520c34a0a6728340d3b
Reviewed-on: https://chromium-review.googlesource.com/923347Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537569}

Trying to re-re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation.

Bug: 792783
Change-Id: Icdc8423c50eaa051b348c5226af4936e97b39251
Reviewed-on: https://chromium-review.googlesource.com/923141
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537568}

This went all wrong, with a branch being duplicated and comments
to variables that no longer exist.

R=ericrk@chromium.org
TBR=ericrk

Bug: 730660
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaf5d331798ed2b4343c57120e558546c40489b63
Reviewed-on: https://chromium-review.googlesource.com/919661
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537567}