GitLab

A simple cloud extension example that uses the file system provider API
This example is different from https://codereview.chromium.org/360673004
as it is an extension and not an app.

BUG=415847

R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/587293002

Cr-Commit-Position: refs/heads/master@{#296579}

Metric exists but is spelled wrong in JS.

R=tim@chromium.org,estade@chromium.org

Review URL: https://codereview.chromium.org/572113002

Cr-Commit-Position: refs/heads/master@{#296578}

This has to be landed first. After the recipe change, I'll remove the old ones.

BUG=414808
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/599993003

Cr-Commit-Position: refs/heads/master@{#296577}

App Shims are small .app bundles for Mac, which run in their own
process to provide packaged apps with an OSX Dock icon, using IPC to
communicate with the browser process.

Most of the app_shim code currently lives in src/apps/app_shim, but app
shims are very much a browser feature, so it doesn't belong there. It's
causing DEPS problems for athena efforts.

This CL moves most of apps/app_shim to chrome/browser/apps/app_shim
(c/b/apps didn't exist until a few months after src/apps/app_shim).

The shim itself (i.e. chrome_main_app_mode_mac.mm) doesn't run in the
browser process - it has its own, shim process. Those parts are moved to
a new folder: src/chrome/app_shim, consolidating files currently spread
across src/apps/app_shim and src/chrome/app.

app_shim_launch.h and app_shim_messages.h are used in both the shim
process and the browser process. They're moved to chrome/common/mac.

Summary of changes:
  {apps => chrome/browser/apps}/app_shim/*
except
  {apps => chrome}/app_shim/chrome_main_app_mode_mac.mm
  {apps/app_shim => chrome/common/mac}/app_shim_launch.h
  {apps/app_shim => chrome/common/mac}/app_shim_messages.h
  app_shim.gypi renamed to browser_app_shim.gypi
  chrome/app_shim/app_shim.gypi added
and
  chrome/{app => app_shim}/app_mode-Info.plist
  chrome/{app => app_shim}/app_mode_loader_mac.mm

- apps/app_shim/DEPS now just generated_resources.h
- 'app_mode_app' target moved from chrome.gyp to app_shim.gypi

BUG=266705

Review URL: https://codereview.chromium.org/585123004

Cr-Commit-Position: refs/heads/master@{#296576}

With this change they take about 1 hour 25 minutes to cycle.

Next step is likely swarming net_unittests.

BUG=387743
R=jam@chromium.org

Review URL: https://codereview.chromium.org/525613003

Cr-Commit-Position: refs/heads/master@{#296575}

In followup patches, I'll remove the now empty testers.

BUG=414808
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/603013002

Cr-Commit-Position: refs/heads/master@{#296574}

Revert of Revert of [AiS] Merge answers into highest-scoring result (patchset #1 id:1 of https://codereview.chromium.org/598253002/)

Reason for revert:
Broken GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/13101

Original issue's description:
> Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/)
>
> Reason for revert:
> The new tests are flaky:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > [AiS] Merge answers into highest-scoring result
> >
> > Answer contents and type must always be copied to the highest-scoring
> > suggestion, to ensure answers are not lost due to suggestion
> > deduplication.
> >
> > BUG=415836
> > R=mpearson
> >
> > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922
> > Cr-Commit-Position: refs/heads/master@{#296520}
>
> TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=415836
>
> Committed: https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7
> Cr-Commit-Position: refs/heads/master@{#296555}

TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415836

Review URL: https://codereview.chromium.org/599273002

Cr-Commit-Position: refs/heads/master@{#296573}

Lots of crash reports from SGS devices running JB, mostly galaxy S3
A driver bug is filed against samsung

BUG=365494

Review URL: https://codereview.chromium.org/602953002

Cr-Commit-Position: refs/heads/master@{#296572}

Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #4 id:60001 of https://codereview.chromium.org/589213003/)

Reason for revert:
May be crashing Chrome:
https://code.google.com/p/chromium/issues/detail?id=417511

Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}

TBR=raymes@chromium.org,dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384528

Review URL: https://codereview.chromium.org/601923003

Cr-Commit-Position: refs/heads/master@{#296571}

This CL adds a few more tests to app_shell_browsertests:
WebViewAPITest.TestAllowTransparencyAttribute
WebViewAPITest.TestAutosizeAfterNavigation
WebViewAPITest.TestAutosizeBeforeNavigation
WebViewAPITest.TestAutosizeHeight
WebViewAPITest.TestAutosizeRemoveAttributes
WebViewAPITest.TestAutosizeWithPartialAttributes

BUG=352293

Review URL: https://codereview.chromium.org/604443003

Cr-Commit-Position: refs/heads/master@{#296570}

There were several consumers assuming that the returned hosts had no brackets.

BUG=417417

Review URL: https://codereview.chromium.org/602973002

Cr-Commit-Position: refs/heads/master@{#296569}

This gets two changes:

  Rename GN public variables.

  Lock page in LoadFXAnnot to prevent unintended page closing

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/594383004

Cr-Commit-Position: refs/heads/master@{#296568}

This is to make sure the starting list of account
mapping properly reflects the mappings present in the
previous Chrome session.

BUG=374969

Review URL: https://codereview.chromium.org/600053002

Cr-Commit-Position: refs/heads/master@{#296567}

BUG=416829
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/598233002

Cr-Commit-Position: refs/heads/master@{#296566}

The test has been broken since MojoBootstrap was introduced.
The change makes it impossible to inject failure from the ChannelMojo
subclass.

This change uses large data as pending message to trigger failure,
instead of overloading IPC::ChannelMojo functions.

R=viettrungluu@chromium.org
BUG=417439

Review URL: https://codereview.chromium.org/598093006

Cr-Commit-Position: refs/heads/master@{#296565}

I VNCed into a bot and learned that the Buildbot scripts munge the environment
variables, so that PROGRAMFILES(X86) doesn't exist. Using platform.machine()
is a more robust, cross-platform way of checking if the OS is 64-bit.

The Windows XP bots still worked, because their OSes are all 32-bit.

BUG=336559
TEST=None.

Review URL: https://codereview.chromium.org/603763002

Cr-Commit-Position: refs/heads/master@{#296564}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5777092..e229507

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/603453004

Cr-Commit-Position: refs/heads/master@{#296563}

On Windows 8, always enabled accessibility for editable text controls.
So the base accessibility is AccessibilityModeEditableTextOnly.

R=aboxhall@chromium.org

BUG=

Review URL: https://codereview.chromium.org/545863002

Cr-Commit-Position: refs/heads/master@{#296562}

See bug for more context; this makes the "Accessibility" section show up
on all platforms, not just Chrome OS, and adds a link to the special
web store page with curated accessibility extensions.

BUG=416983

Review URL: https://codereview.chromium.org/599683002

Cr-Commit-Position: refs/heads/master@{#296561}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/597413002

Cr-Commit-Position: refs/heads/master@{#296560}

This way the size should always remain the same regardless of the
origin. Also, it's important that we ceil here otherwise a round trip
for DIP to screen to DIP could result in a smaller value resulting in
all sorts of wierdness.

BUG=417392
TEST=see bug
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/600103002

Cr-Commit-Position: refs/heads/master@{#296559}

This adds a rasterizer implementation explicitly used for
rasterizing to bitmap resources. Each rasterizer is already
aware of specific resource details and it is much easier
and less confusing to implement a different rasterizer that
handle bitmap resources then trying to emulate support for
GL-ish APIs that are used by other rasterizer implementations.

This allows us to clean up LTHI a bit and reduces the
complexity of the ResourceProvider class significantly.

It also makes future changes that will allow GpuMemoryBuffers
to be created and mapped in worker threads easier implement.

BUG=

Review URL: https://codereview.chromium.org/602493003

Cr-Commit-Position: refs/heads/master@{#296558}

This CL adds automatic "last used keyboard layout" for active user POD
on User Adding screen.

BUG=292774
TEST=manual

Review URL: https://codereview.chromium.org/602593003

Cr-Commit-Position: refs/heads/master@{#296557}

Revert of Revert of Fix doodle verification URL. (patchset #1 id:1 of https://codereview.chromium.org/599243002/)

Reason for revert:
The original revert was a mistake. Relanding this with no changed.

Original issue's description:
> Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)
>
> Reason for revert:
> Caused test failure:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > Fix doodle verification URL.
> >
> > When verifying that the cached doodle is still valid, we load the doodle
> > URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> > the ":" was being escape to "%3A", causing the server to respond with a
> > 400 error. This mollifies the server by keeping the colon unescaped.
> >
> > BUG=413845
> >
> > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> > Cr-Commit-Position: refs/heads/master@{#296512}
>
> TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=413845
>
> Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051
> Cr-Commit-Position: refs/heads/master@{#296546}

TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,groby@chromium.org,jiayl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845

Review URL: https://codereview.chromium.org/606443004

Cr-Commit-Position: refs/heads/master@{#296556}

Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/)

Reason for revert:
The new tests are flaky:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944

Original issue's description:
> [AiS] Merge answers into highest-scoring result
>
> Answer contents and type must always be copied to the highest-scoring
> suggestion, to ensure answers are not lost due to suggestion
> deduplication.
>
> BUG=415836
> R=mpearson
>
> Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922
> Cr-Commit-Position: refs/heads/master@{#296520}

TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415836

Review URL: https://codereview.chromium.org/598253002

Cr-Commit-Position: refs/heads/master@{#296555}

This race should be benign, because the count is just used for a heuristic and can't truly be synchronized anyway, but best to use a lock with the access.

BUG=417194

Review URL: https://codereview.chromium.org/604583002

Cr-Commit-Position: refs/heads/master@{#296554}

Revert of [Suggestions] Move ImageManager to the component (patchset #6 id:220001 of https://codereview.chromium.org/543753002/)

Reason for revert:
One of the new unit tests failed with uninit memory access: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/43137/

Original issue's description:
> [Suggestions] Move ImageManager to the component
>
> Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.
>
> BUG=387751
> TBR=blundell
> TEST=ImageManagerTest,ImageFetcherBrowserTest
>
> Committed: https://crrev.com/5a25f30080dd57d200679546c970d70f2247def9
> Cr-Commit-Position: refs/heads/master@{#296503}

TBR=huangs@chromium.org,blundell@chromium.org,mathp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387751

Review URL: https://codereview.chromium.org/600203002

Cr-Commit-Position: refs/heads/master@{#296553}

BUG=397741

Review URL: https://codereview.chromium.org/601573002

Cr-Commit-Position: refs/heads/master@{#296552}

This is to intended to match the HTTP/2 static table:
http://http2.github.io/http2-spec/compression.html#static.table.definition (entry 16).

BUG=389914

Review URL: https://codereview.chromium.org/437353004

Cr-Commit-Position: refs/heads/master@{#296551}

BUG=412955

Review URL: https://codereview.chromium.org/595353003

Cr-Commit-Position: refs/heads/master@{#296550}

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/598833002

Cr-Commit-Position: refs/heads/master@{#296549}

BUG=414936
TEST=WindowManagertest.BezelGestureToSwitchBetweenWindows

Review URL: https://codereview.chromium.org/574113004

Cr-Commit-Position: refs/heads/master@{#296548}

EnhancedBookmarkBridge is only used in android platform and should be
moved to chrome/browser folder, bacause most bookmark services going
through this bridge requires profile.

BUG=415774

Review URL: https://codereview.chromium.org/597253003

Cr-Commit-Position: refs/heads/master@{#296547}

Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)

Reason for revert:
Caused test failure:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944

Original issue's description:
> Fix doodle verification URL.
>
> When verifying that the cached doodle is still valid, we load the doodle
> URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> the ":" was being escape to "%3A", causing the server to respond with a
> 400 error. This mollifies the server by keeping the colon unescaped.
>
> BUG=413845
>
> Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> Cr-Commit-Position: refs/heads/master@{#296512}

TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845

Review URL: https://codereview.chromium.org/599243002

Cr-Commit-Position: refs/heads/master@{#296546}

This was caused by some very slow running trybots. If the test was running significantly slower
than a second, a MemoryPressureNotifier event was able to be sent, which caused the ResourceManager
to perform some asynchronous action which is not wanted for these unit tests.

BUG=412537, 417189
TEST=AppActivityTes.TestUnloadProxyLocation, AppActivityTest.TestMultipleActivityUnloadLock

Review URL: https://codereview.chromium.org/598033004

Cr-Commit-Position: refs/heads/master@{#296545}

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/592353003

Cr-Commit-Position: refs/heads/master@{#296544}

Have TestRunner::OverridePreference() recognize "WebKitWebSecurityEnabled"
as a boolean preference which controls the web_security_enabled web
preference.

R=mkwst,jochen
BUG=254993

Review URL: https://codereview.chromium.org/601513002

Cr-Commit-Position: refs/heads/master@{#296543}

BUG=none
TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/600153002

Cr-Commit-Position: refs/heads/master@{#296542}

Discussion thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo

NOTRY=true

Review URL: https://codereview.chromium.org/596723003

Cr-Commit-Position: refs/heads/master@{#296541}

Note: Currently this solution is implemented in the chrome module but once
ZoomController moves to extensions, zooming from embedder to guest should
move to GuestViewBase and a more general solution should be made available
for GuestView types that wish to receive this zoom plumbing.

BUG=416581

Review URL: https://codereview.chromium.org/598163003

Cr-Commit-Position: refs/heads/master@{#296540}