GitLab

This CL separates the part of LocalSharedObjectsContainer which is to be componentised into an interface, and keeps the LSOC itself an implementation detail of TabSpecificContentSettings (to be moved to the embedding client at a later point).

More design details here: https://docs.google.com/a/google.com/document/d/1rQ9PMCPL6wHh-QjaZWOBcaYXQgbCka7unSsciQ52qOs/edit#heading=h.hid3xtn12izy

BUG=384873

Review URL: https://codereview.chromium.org/588583002

Cr-Commit-Position: refs/heads/master@{#297802}

BUG=383418
TEST=Build target libjingle_peerconnection_javalib

Review URL: https://codereview.chromium.org/551793003

Cr-Commit-Position: refs/heads/master@{#297801}

Revert of No longer requiring pixel output for WebRTC tests. (patchset #4 id:60001 of https://codereview.chromium.org/611953004/)

Reason for revert:
Turns out this change makes video+canvas grabbing produce junk; this is not good since our tests depend on that working. Reverting.

Original issue's description:
> No longer requiring pixel output for WebRTC tests.
>
> We used to require pixel output for our canvas-scraping, but that
> appears to no longer be required. This speeds up the test 3x on my
> win machine, from 30 seconds to about 10.
>
> The content_browsertests on ChromeOS will still enable pixel
> output since it seems the requirements there are different - video
> tags will not work unless that is enabled, it seems. I think
> that's fine since our original problem was with the browser_tests
> anyway, and I think the content_browsertests are probably fast
> enough on ChromeOS anyway (whereas the browser_tests weren't).
>
> BUG=396505
>
> Committed: https://crrev.com/e6a342dcab57c3a2de1fd21301f37fdf3f8ad070
> Cr-Commit-Position: refs/heads/master@{#297654}

TBR=tommi@chromium.org,xians@google.com
NOTREECHECKS=true
NOTRY=true
BUG=396505

Review URL: https://codereview.chromium.org/619003003

Cr-Commit-Position: refs/heads/master@{#297800}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8126c1..e3dbcaf

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/625513003

Cr-Commit-Position: refs/heads/master@{#297799}

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/624573002

Cr-Commit-Position: refs/heads/master@{#297798}

The name conflicts with CSS's Rect.

BUG=419360
TEST=None

Review URL: https://codereview.chromium.org/624563002

Cr-Commit-Position: refs/heads/master@{#297797}

TEST=Not affected.
BUG=None

Review URL: https://codereview.chromium.org/622683004

Cr-Commit-Position: refs/heads/master@{#297796}

These null-checks were inadvertedly removed during this
refactoring:
https://codereview.chromium.org/481803004/

getWebContents() can return null after destruction
so we need to null-check before use.

BUG=415666

Review URL: https://codereview.chromium.org/615883003

Cr-Commit-Position: refs/heads/master@{#297795}

Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 id:1 of https://codereview.chromium.org/625543002/)

Reason for revert:
Oops, wasn't supposed to revert this after all.

Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
>                                   ^
>   symbol:   class TopControlsState
>   location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG=405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/617103007

Cr-Commit-Position: refs/heads/master@{#297794}

Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)

Reason for revert:
Fails to compile on several bots:

https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio

First error:
FAILED: cd ../../clank/native/framework; python <snip ...>
../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
import org.chromium.content.common.TopControlsState;
                                  ^
  symbol:   class TopControlsState
  location: package org.chromium.content.common

Original issue's description:
> Use the new java_cpp_enum rule in content.
>
> This moves most of the generated Java enums under content/ to use the
> java_cpp_enum rule removing the need for keeping the enums in
> separate list files and the need for the .template files.
>
> BUG=405532, 351558
>
> Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> Cr-Commit-Position: refs/heads/master@{#297789}

TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=405532, 351558

Review URL: https://codereview.chromium.org/625543002

Cr-Commit-Position: refs/heads/master@{#297793}

volumeId. When the notification saying "Open removable device" is clicked,
Files.app finding corresponding volumeId from the map, and navigate to the
volume.

Files.app: Remove navigationVolumeMap from the background page.

But if the background page once closed, the map is cleared and the app cannot
find the corresponding volume.

The CL adds devicePath field to VolumeInfo, and let the app find the
corresponding volume information directly without using the map.

BUG=419107
TEST=repro steps of the bug.

Review URL: https://codereview.chromium.org/612303005

Cr-Commit-Position: refs/heads/master@{#297792}

BUG=400674
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/604383003

Cr-Commit-Position: refs/heads/master@{#297791}

BUG=

Review URL: https://codereview.chromium.org/619873009

Cr-Commit-Position: refs/heads/master@{#297790}

This moves most of the generated Java enums under content/ to use the
java_cpp_enum rule removing the need for keeping the enums in
separate list files and the need for the .template files.

BUG=405532, 351558

Review URL: https://codereview.chromium.org/615893003

Cr-Commit-Position: refs/heads/master@{#297789}

The Related CL:
https://codereview.chromium.org/609793002/

BUG=226505
TBR=rockot

Review URL: https://codereview.chromium.org/607053002

Cr-Commit-Position: refs/heads/master@{#297788}

The cast icon has moved to the video control bar, so we should keep it visible even on error.

BUG=419651
TEST=manual

Review URL: https://codereview.chromium.org/620803002

Cr-Commit-Position: refs/heads/master@{#297787}

Cr-Commit-Position: refs/heads/master@{#297786}

It's flaking on try runs.

BUG=419644
TBR=dmichael@chromium.org

Review URL: https://codereview.chromium.org/619293002

Cr-Commit-Position: refs/heads/master@{#297785}

It fails on bots and also locally.

BUG=419644
TBR=dmichael@chromium.org

Review URL: https://codereview.chromium.org/614903008

Cr-Commit-Position: refs/heads/master@{#297784}

TBR=phajdan@chromium.org

Review URL: https://codereview.chromium.org/620973002

Cr-Commit-Position: refs/heads/master@{#297783}

TBR=phadjan@chromium.org

Review URL: https://codereview.chromium.org/623593004

Cr-Commit-Position: refs/heads/master@{#297782}

This is a smaller library that is always checked out and depsed in. It seems there is no particular reason for it to be in a separate repo other than it makes changes more difficult.

Review URL: https://codereview.chromium.org/608853002

Cr-Commit-Position: refs/heads/master@{#297781}

The method signature of
blink::WebApplicationCacheHost::didReceiveDataForMainResource() is going to be
changed. Not to break build, need to remove the implementation of the
interface in Chromium.

Blink side CL is here: https://codereview.chromium.org/618583002/

R=mkwst,jam
BUG=418885

Review URL: https://codereview.chromium.org/615823002

Cr-Commit-Position: refs/heads/master@{#297780}

BUG=405869
TBR=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/625453003

Cr-Commit-Position: refs/heads/master@{#297779}

Revert of Add --output-dir flag for page_runner.py. (patchset #2 id:40001 of https://codereview.chromium.org/616063004/)

Reason for revert:
Failing on all perf bots in generate_telemetry_profiles:

Traceback (most recent call last):
  <module> at tools/perf/generate_profile:13
    sys.exit(profile_generator.Main())
  Main at tools/telemetry/telemetry/page/profile_generator.py:145
    AddCommandLineArgs(parser)
  AddCommandLineArgs at tools/telemetry/telemetry/page/profile_generator.py:115
    help='Generated profile is placed in this directory.')
  add_option at /usr/lib/python2.7/optparse.py:1020
    self._check_conflict(option)
  _check_conflict at /usr/lib/python2.7/optparse.py:995
    option)
OptionConflictError: option --output-dir: conflicting option string(s): --output-dir

Locals:
  co            : ('--output-dir', <Option at 0x2b074d0: --output-dir>)
  conflict_opts : [('--output-dir', <Option at 0x2b074d0: --output-dir>)]
  handler       : 'error'
  opt           : '--output-dir'
  option        : <Option at 0x2b08290: --output-dir>

Original issue's description:
> Add --output-dir flag for page_runner.py to specify a custom directory for
> output profiling and results data.
>
> Motivation behind this flag: I've run into a bug where a run on a local device
> and a run on the try bots are showing different versions of the page. I wanted
> to use the android_screen_recorder_profiler.py to record the try bot version
> and see what it is actually showing. However, it currently tries to output the
> video to a temporary directory in /tmp (which I do not have permission to write
> to).
>
> BUG=
>
> Committed: https://crrev.com/2a859c8f48b40d7bc443812e6cf760f10e0d22ba
> Cr-Commit-Position: refs/heads/master@{#297740}

TBR=tonyg@chromium.org,nednguyen@google.com,ariblue@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/616953005

Cr-Commit-Position: refs/heads/master@{#297778}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f08ac8f..d8126c1

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/616953004

Cr-Commit-Position: refs/heads/master@{#297777}

QuicServerInfo.

BUG=417835
R=rch@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/618083003

Cr-Commit-Position: refs/heads/master@{#297776}

Without a message, you can't identify where the assertion was triggered,
except via the javascript console.

BUG=397019

Review URL: https://codereview.chromium.org/620913003

Cr-Commit-Position: refs/heads/master@{#297775}

This eliminates the need for callers to do explicit conversions, and also
ensures callers don't try to implement pickling of a size_t using a 32-bit type,
leading to truncation on 64-bit targets.  The pickle layer will ensure 64-bit
types are always used.

I'll be changing other callsites to use this in future patches.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/601563003

Cr-Commit-Position: refs/heads/master@{#297774}

in which we would consider the mapping to be missing even if
the probability was such that we would not honor the advertisement.

BUG=

Review URL: https://codereview.chromium.org/620753007

Cr-Commit-Position: refs/heads/master@{#297773}

NSS upstream patches:
https://hg.mozilla.org/projects/nss/rev/2cb5c73ac307
https://hg.mozilla.org/projects/nss/rev/544eb0f50d40

R=agl@chromium.org
BUG=416841

Review URL: https://codereview.chromium.org/595823003

Cr-Commit-Position: refs/heads/master@{#297772}

Currently GestureNav/horizontal overscroll is enabled on all Aura builds. However to engage GestureNav you either need a touch screen or a 2-finger gesture support for the touchpad. This means we are paying the cost of screenshotting for every navigation on some machines where you won't ever be able to experience GestureNav.

BUG=398516

Review URL: https://codereview.chromium.org/617543002

Cr-Commit-Position: refs/heads/master@{#297771}

MSVC is somewhat pickier about casting things to bool.

BUG=338884

Review URL: https://codereview.chromium.org/618123007

Cr-Commit-Position: refs/heads/master@{#297770}

BUG=419556
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/622713002

Cr-Commit-Position: refs/heads/master@{#297769}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/16c9ae4..f08ac8f

TBR=eustas@chromium.org,jsbell@chromium.org

Review URL: https://codereview.chromium.org/617263005

Cr-Commit-Position: refs/heads/master@{#297768}

BUG=414340

Remove

Review URL: https://codereview.chromium.org/621763003

Cr-Commit-Position: refs/heads/master@{#297767}

BUG=418656

Review URL: https://codereview.chromium.org/620673002

Cr-Commit-Position: refs/heads/master@{#297766}

For function call arguments:
- if all arguments plus ')' fit at current point, insert
- if all arguments fit at current, one per line
- otherwise at minimum of current and margin+4, one per line, recurse into children. Similar for binary expressions so that "a + b" can wrap.

Also, add basic output of AccessorNode + test.

(not as fancy as clang-format, but there's not that many long
function calls in .gn files.)

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/607243002

Cr-Commit-Position: refs/heads/master@{#297765}

It's no longer flaky since the underlying bug was fixed in crrev.com/615633003.

BUG=415792

Review URL: https://codereview.chromium.org/619683002

Cr-Commit-Position: refs/heads/master@{#297764}

BUG=402005,413370

Review URL: https://codereview.chromium.org/583883002

Cr-Commit-Position: refs/heads/master@{#297763}