- 07 Apr, 2020 40 commits
-
-
Mike Dougherty authored
This reverts commit 318566fd. Reason for revert:NavigationController_Background test failing on https://ci.chromium.org/p/chromium/builders/ci/ios13-sdk-simulator Original change's description: > [Sharing] Adding Empty Modal for QR Code Generator > > Includes empty: > - Coordinator > - Uses a UINavigationController to present VC. > - View Controller > > Hooked up to the sharing action through BrowserCoordinator, which is > hidden behind a flag. > > Tested on iPhone X 13.4 and iPad sim 12.4. > > Added unit tests for the view controller. > > Bug: 1064990 > Change-Id: Ia23b83208cd0672372e2f53bcbc3dc4d6c1cf1fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130819 > Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756659} TBR=marq@chromium.org,seblalancette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1064990 Change-Id: I4927cf9588efaf2959b99c9241db45107c870923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140293Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#757101}
-
Maria Villarreal authored
Per guidance, all the hardcoded colors in this file have new native color IDs. For now the color IDs have the same values, no changes made to the colors, and they are used for GetDarkSchemeColor and GetDefaultColor. Bug: 1056950 Change-Id: Iae1bfe721e45b594724a0cf7cb4b2127c23716bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111761 Commit-Queue: Maria Villarreal <mavill@microsoft.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#757100}
-
Orin Jaworski authored
This CL eliminates the duplicate business logic in result view that determines visibility of button row buttons. Instead, the view consults the popup model to determine visibility. IsSelectionAvailable is made public as originally intended. Bug: 1046523 Change-Id: I92333dfd9e1d9e733af286640f1c1c8c4ac1f475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138631 Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#757099}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id0052df6c64fa7bd06dd3253e77a16214c82b170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757098}
-
Xianzhu Wang authored
Bug: 1025907 Change-Id: I7849f4decfd800f1608a231c1ae038b4ec56e90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136882Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757097}
-
Peter Kasting authored
This already happens implicitly, but using a raw pointer doesn't make it clear, and one test used set_owned_by_client() here to avoid it. Switch to smart pointers and remove set_owned_by_client() use. Bug: none Change-Id: Icd87a9c48631697dc0e4638ba5af643828a840e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137815 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#757096}
-
Lukasz Anforowicz authored
This test seems slow - 20 iterations of the test took more than 80 seconds on Z840. Therefore the [ Timeout ] expectation for this test should probably be replaced with a [ Slow ] expectation. Fixed: 678482 Change-Id: I8e400a813901d390673907bf9c7b64057fee5057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137816 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#757095}
-
Ian Kilpatrick authored
The DCHECK in the bug was caused by an order-of-operations issue. Within the following calculation: max_inline_contribution = child_sizes.max_size + line_left_inset + line_right_inset; If: child_sizes.max_size == LayoutUnit::Max() line_left_inset == LayoutUnit(1) line_right_inset == LayoutUnit(-1) max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1); This resulted in max_size < min_size. Bug: 1004060 Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136885 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#757094}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e89877724aba..09fdff26a543 Created with: gclient setdep -r src-internal@09fdff26a543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1026667 Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com Change-Id: I55a8a2b09da7cd400f099305358bca88f8e6cb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140064Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757093}
-
Wenbin Zhang authored
Some Mac high end devices has been dead for more than a week. This has blocked the perf test for two days already. Due to the current COVID-19 situation, the lab may not be able to recover machines as quickly as normal. We will reduce the shard size for now to keep perf test running. Bug: chromium:1068120 Change-Id: Id0c60787bfa684a267f3f782a7ec2bfbc326b4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138000Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757092}
-
Peter Kasting authored
Much of this function was a long comment about the meaning of bit 30 of the LPARAM, which is irrelevant to anything we care about. Rip it all out. The rest of the comment was about bit 31. We can avoid testing bit 31 directly by using the KF_UP mask, which is (at least slightly) semantically more obviously related to "is the key up", and easier to search MSDN for (though it's not wonderfully documented). So rip this commentary out too. This also used a temp for no reason I can perceive. Simplify. Bug: none Change-Id: Iaef578c74b23762a6836da5aba63cd3884ab7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138957 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#757091}
-
Alex Ilin authored
The new consent flow didn't consider IsPrimaryAccountOnly() restriction: - All the browser cookies were exported to the extension consent - The flow didn't stop if the user chose a non-primary account on the consent page - IdentityGetAuthTokenFunction tried to use a non-primary Gaia ID cached before but failed due to IsPrimaryAccountOnly(); the only way to recover from this is to sign-out from that non-primary account This CL makes sure that the new consent flow works correctly when IsPrimaryAccountOnly() returns true. Bug: 1026237 Change-Id: Ibacfecaab5248fc5bf64a78fce4ff32f611831b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139695Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757090}
-
Sam Maier authored
I was able to build and run monochrome_bundle, and was able to draw on a screenshot with this change. Change-Id: I0e6e988f565d008a068fb2785c55cdc13ae66f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140060 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757089}
-
Randy Rossi authored
The following ninja command would fail unless earlier deps happened to create the required chrome/browser/resources/chromeos/accessibility/chromevox out directory for the generated deps file. The jsbundler should ensure the destination directory exists. Building chromevox was failing in downstream chromium sometimes unless other deps that were run in parallel happened to create this directory. ninja -C out/Release chrome/browser/resources/chromeos/accessibility/chromevox:chromevox_background_script Bug: None Test: Local build of the above rule Change-Id: I92e9de00761719cb909c7e3a3e26d9bb2177bfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136485Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757088}
-
Mugdha Lakhani authored
PageInfoClient and ChromePageInfoClient are introduced to provide an easy way to retrieve ChromePageInfoDelegate and ChromePageInfoUiDelegate from (native) ConnectionInfoPopup. VrHandler allows componentizing VR-specific code. Bug: 1052375 Change-Id: I822bbbbd5ac20029917bb4bcf6883db82efb352d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089770 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#757087}
-
Jeff Yoon authored
Deleting the unused JSON configurations for iOS bots that have migrated to the Chromium recipe. - WebRTC bots remain b/c they run their own recipe. - ios-simulator-noncq is still in use for the EG2 deprecation, and will not be migrated until that project is complete. Bug: 1055164,912681 Change-Id: Ic2db32d8300b3cf6efad333814f1fd4d052aea81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136234Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#757086}
-
Sven Zheng authored
It is the only failing test for sync e2e tests for now. Disable it first and investigate later. Bug: 1068415 Change-Id: Ib58ed1c9e39b90338ad56b546b621a995a93a1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138603 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#757085}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b4a27407e2be..1d1d0e1a13a6 git log b4a27407e2be..1d1d0e1a13a6 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 bclayton@google.com Update third_party/marl/BUILD.gn with new files 2020-04-07 bclayton@google.com Update Marl to 539094011 Created with: gclient setdep -r src/third_party/swiftshader@1d1d0e1a13a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I670a9eef05d741041c7a7d53b907e034a77f4fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140051Reviewed-by:
-
Devlin Cronin authored
It's no longer used. Also remove a couple of other no-longer-used private methods. Bug: 894447 Change-Id: Iec3f13664999611195ba3f0813d5a23fed7d1929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133235Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757083}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24627887555a..e19babf99696 git log 24627887555a..e19babf99696 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 robertphillips@google.com Remove GrAtlasManager.h from all other .h files 2020-04-07 westont@google.com Use Debian9 builds for ChromeOS until they are fixed. 2020-04-07 reed@google.com detect if the skip failed Created with: gclient setdep -r src/third_party/skia@e19babf99696 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068536 Tbr: csmartdalton@google.com Change-Id: I4a0485d5ca5a91fc71387a3839fcf8b3f4c1d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139949Reviewed-by:
-
John Delaney authored
This CL amends navigations originating from anchor elements (that declare impression attributes) with a struct containing data for a new impression. Per the explainer, an impression is only valid when its navigation results in a committed top frame navigation to the pre-specified destination url. This requires the data to be sent alongside the navigation rather than in a separate mojo. https://github.com/csharrison/conversion-measurement-api#impression-declaration These impression navigations can commit in different WebContents or different windows, but are always main frame navigations. The impression struct is stored and pulled off the NavigationRequest when the navigation finishes and forwarded to conversion storage by a WebContentsObserver(/conversion_host.h). Navigations caused by context menu clicks are not handled in this CL, and will be addressed in a followup, see https://crbug.com/1049674. Design doc(RVG): https://crbug.com/1039466 Explainer: https://github.com/csharrison/conversion-measurement-api Bug: 1044342 Change-Id: I0b8b0cfebdcecc8f9c016b0eb6405acaedac037e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012883 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#757081}
-
Jérôme Lebel authored
Sign-in promo is always presented in sheet style (user sign-in or sign-in promo). This patch doesn't change the first run, since it is not presented. Bug: 971989 Change-Id: I7923a728d6912013903b9fc71a24fef29f2b9b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139764 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757080}
-
Peter Kasting authored
This monitors the main widget all the time, and removes the bookmark bar and widget observers if it shuts down. This is safer than the existing code that blindly does RemoveAll() in TearDown(), in case these don't live until teardown (spoiler: I will shorten their lifetimes in a future patch). It's also convenient, since test 21 wants the main widget monitored anyway, so this simplifies that test. Bug: none Change-Id: I411519fe75e92b2339c52b88acaee7eff16aecb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138233Reviewed-by:
-
Xianzhu Wang authored
This can be used to evaluate the effectiveness of measures to increase LCD text. (TBR for trivial change under tools/perf/measurements) TBR=wenbinzhang@chromium.org Bug: 642885 Change-Id: I97dd8aca06a91f5cd1d7f922ac70345e0e3a986c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136698 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757078}
-
Ben Joyce authored
Should not affect api calls after this has landed. https://critique.corp.google.com/#review/304996839 Bug: 1067296 Change-Id: Ic95d4bc923784592d58d6eb4b0af4aca45d52a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136697Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#757077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8e129de0bc1a..fdbd42e2f874 git log 8e129de0bc1a..fdbd42e2f874 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 tvanderlippe@chromium.org Add eslint-import-plugin to node_modules Created with: gclient setdep -r src/third_party/devtools-frontend/src@fdbd42e2f874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068198 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0dc39acb79219b1debdaea836a16bbcaaf3e7688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140059Reviewed-by:
-
Andrew Grieve authored
Also tweak milestone_apk_sizes.py for easier copy/paste into spreadsheet Change-Id: I7e1ce6cd15644a5784636b97dcd3f6e394d16f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137825 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757075}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/177d32254ec8..3b13db544626 git log 177d32254ec8..3b13db544626 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 ilkos@google.com Add oom mark victim event 2020-04-07 lalitm@google.com Merge "tp: ensure that binder transaction ids are always positive in systrace" Created with: gclient setdep -r src/third_party/perfetto@3b13db544626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153097949 Tbr: perfetto-bugs@google.com Change-Id: Ic05719a2a3479fdf53f3eaba9266faef93999247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140052Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ae4715e..5deecef6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68ee092737200d142d7f8d294d3ced4cd68e94fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139893Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757073}
-
Ulan Degenbaev authored
Finch study shows that the flag has no statistically significant impact on memory and reduces GC time by 6%-10% on the 99-th percentile. Bug: 1049132 Change-Id: Ibcc99e8543cf356b107e4be1f3ec35e6fa22e03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139703Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757072}
-
Rohit Rao authored
The AppConfig spec does not support complex structured data, so we will encode "dict" policies as JSON strings. PolicyLoaderIOS has been updated to compare the type of the loaded policy data against the expected type for that policy and attempt a conversion if the types don't match. BUG=1065906 Change-Id: Ic3ef56baba05bc7b4753c872ab8817a41d5138cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135827Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757071}
-
Khushal Sagar authored
R=kbr@chromium.org Bug: 1066820 Change-Id: Ib414f167f8c1b61ef190cbaff2a74e26994cae91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138101 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757070}
-
Xianzhu Wang authored
It was reverted in crrev.com/c/2135834 because of crbug.com/1067845. This reland avoids the change of CompositorElementId for sticky elements. Original change's description: > [CompositeAfterPaint] Allow non-atomic effects in multicol > > This is not fully correct, but we have to accept it in our current > multicol painting based on FragmentClips. > > Actually we have already allowed non-atomic effects in multicol within > composited layers since SlimmingPaintV175. A fragmented element with > effect applies the effect on each fragment separately. We have to do > this because each fragment has its own fragment clip, and its own paint > properties because they may depend on the fragment clip. > > This CL enables non-atomic composited effects for CompositeAfterPaint. > This is not an issue in pre-CompositeAfterPaint which doesn't allow > fragmentation of composited layers (which is incorrect). > > The root issue will be fully fixed by LayoutNG block fragmentation > which doesn't need FragmentClips. > > Bug: 1064341 > Change-Id: Id6ae4c263381f24d037f3c2bc493d73cd050598e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124340 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754166} Bug: 1064341 Change-Id: I48682c9d84441acd9cf90d4429281916423ef4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137506 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Katie D authored
Adds tests for docked magnifier, dictation, switch access, and some more for select-to-speak. Adds coverage for lines which change checked state of the HoverHighlightViews, and also checks checked state as well as the bool for tests. Total line coverage increase from 64% to 96% in tray_accessibility.cc. Some clean-up to reduce common lines in helper functions within the test. Bug: 1067399 Relnotes: N/A Change-Id: I05ae85ac043c9fa71e0813a1f0948d990d82afbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135022 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#757068}
-
Michael van Ouwerkerk authored
Change-Id: I97ab5e565227dbce08081c262ba992572b9f446f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139759 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#757067}
-
Chris Sharp authored
The code after was assuming the arrays were the correct list which was resulting in crashes when the tests were failing. Change-Id: Ibf10202085fc6ec29012b28ce94a09825e68add2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139895 Auto-Submit: Chris Sharp <csharp@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#757066}
-
Chris Sharp authored
TBR=apotapchuk@chromium.org Bug: 1047176 Change-Id: Ic25a9fcde0a23cdc488ab86c1ab52837d9616b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139898Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d14735b25df3..eb298a024032 git log d14735b25df3..eb298a024032 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b5757b95005b..9c3204a1fde0 (1 commits) Created with: gclient setdep -r src/third_party/angle@eb298a024032 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ia6f63664e57092db0a07c6dfa9e0aa8068d7033d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139939Reviewed-by:
-
Tomasz Moniuszko authored
It's needed for ENABLE_SESSION_SERVICE flag. Change-Id: I799a9d3ae17fa4716273e5b77a3cc6614017fff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139715 Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#757063}
-
Fergal Daly authored
With CreateNewHostForSameSiteSubframe enabled, a new frame is created and so we expect the embedding token to change. Bug: 1064944 Change-Id: I8f9833cc5942c847b78a93ddfa021597771f5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138991Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#757062}
-
