GitLab

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon.

BUG=669323

Review-Url: https://codereview.chromium.org/2564433004
Cr-Commit-Position: refs/heads/master@{#437738}

This corrects how the ServiceManager clears out identity mappings
to singleton services, preventing it from indefinitely holding a
raw Instance* to any singleton it starts.

BUG=None

Review-Url: https://codereview.chromium.org/2566663003
Cr-Commit-Position: refs/heads/master@{#437737}

Review-Url: https://codereview.chromium.org/2560353002
Cr-Commit-Position: refs/heads/master@{#437736}

All new tests repro prior to their fix, and no longer repro on trunk.

Added 257c076e3e8866554529d495440b606e321d9e39 to internal repo.

R=dalecurtis@chromium.org
BUG=668346,640912,640889,639961,637428,635422

Review-Url: https://codereview.chromium.org/2569543002
Cr-Commit-Position: refs/heads/master@{#437735}

Merge internal change: 141451848

Review-Url: https://codereview.chromium.org/2561913003
Cr-Commit-Position: refs/heads/master@{#437734}

BUG=661612

Review-Url: https://codereview.chromium.org/2550063003
Cr-Commit-Position: refs/heads/master@{#437733}

The Breadcrumbs project dumps system state to a persistent file so that it can
be analyzed after a crash.  We want to include in that the complete set of field
trials.  That means saving them to the file when the browser starts and being
able to retrieve them from the file on a future run; they will be loaded into a
protobuf and uploaded.

BUG=663414

Review-Url: https://codereview.chromium.org/2560723004
Cr-Commit-Position: refs/heads/master@{#437732}

The behavior we want to launch is animate-nonsecure-only, so update the
waterfall to that animation behavior.

BUG=

Review-Url: https://codereview.chromium.org/2569433003
Cr-Commit-Position: refs/heads/master@{#437731}

When trying to understand why particular symbols are pulled in to a
binary it can be helpful to examine the verbose linker output.
However it quickly becomes unwieldy. This parses it and allows
querying of it to explain why a particular object file is pulled
in. This was used in the investigation of the linked bug, and others.

BUG=630755

Review-Url: https://codereview.chromium.org/2564543003
Cr-Commit-Position: refs/heads/master@{#437730}

BUG=671194
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
TEST=manual, install Trusteer Rapport, verify dialog appears.

Review-Url: https://codereview.chromium.org/2566733003
Cr-Commit-Position: refs/heads/master@{#437729}

BUG=

Review-Url: https://codereview.chromium.org/2515313003
Cr-Commit-Position: refs/heads/master@{#437728}

Force slow path for now, which is the same as what we are doing in
PaintInvalidationState.

BUG=672989
TEST=virtual/spinvalidation/fast/multicol/span/abspos-containing-block-outside-spanner.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2569483003
Cr-Commit-Position: refs/heads/master@{#437727}

Safe Browsing Extended Reporting reports show a number of certificate
errors from Windows users where the certificate error is
ERR_CERT_DATE_INVALID but the certificate chain appears to have
perfectly valid dates.

To get some diagnostic data from Canary, this CL calls
DumpWithoutCrashing() when we observe such a chain. This CL is intended
to be reverted after obtaining a few days of data from Canary.

BUG=672906

Review-Url: https://codereview.chromium.org/2567643003
Cr-Commit-Position: refs/heads/master@{#437726}

Cleans up a bunch of service manager details which exist to support
the currently untenable goal of dynamically loading service binaries
in a common host executable.

Changes services to instead build as standalone executables, and
teaches the service manager how to launch them.

BUG=642879

Review-Url: https://codereview.chromium.org/2557213002
Cr-Commit-Position: refs/heads/master@{#437725}

Since the anchor's text might have been changed via the textContent
assignment, the icon might not be attached.

This patch makes sure icon is attached to the dom before attempting to
remove it.

BUG=672746
R=dgozman

Review-Url: https://codereview.chromium.org/2552883014
Cr-Commit-Position: refs/heads/master@{#437724}

Previously, the various editors would return |null| to the caller
(PaymentRequestImpl) in the case of a cancel. We are now returning the
original item that was passed in for edit.

BUG=672996
TEST=PaymentRequest*Test*

Review-Url: https://codereview.chromium.org/2561373002
Cr-Commit-Position: refs/heads/master@{#437723}

Two types of sync metadata, once stored in the sync directory, are now being
migrated to the web database. These two types are the per-entry EntityMetadata
and the ModelTypeState, which is globalstate for the autofill model type. This
change adds a migration to add the tables and functions on AutofillTable to
read/write/delete it, with associated tests.

BUG=671832

R=shess@chromium.org,mathp@chromium.org,pavely@chromium.org

Review-Url: https://codereview.chromium.org/2550293002
Cr-Commit-Position: refs/heads/master@{#437722}

Another refactoring aimed at slimming down the TraceLog monster-class
and isolating dependencies of the tracing codebase.
This CL is a pure refactor with no intended behavioral changes.
It moves all the trace filters classes outside of the TraceLog.
This is required to make the next CLs which will change the lifetime
management of filters easier to review.

BUG=659689

Review-Url: https://codereview.chromium.org/2549103003
Cr-Commit-Position: refs/heads/master@{#437721}

and net/quic/core/congestion_control to sync with internal.

Review-Url: https://codereview.chromium.org/2566703002
Cr-Commit-Position: refs/heads/master@{#437720}

BUG=620813

Review-Url: https://codereview.chromium.org/2556813002
Cr-Commit-Position: refs/heads/master@{#437719}

Make use of the PpdCache from PrintPreview.  Setup downloading ppds from
the quirks server.

BUG=662755
TEST=Setup a printer.  Log out.  Rename ppd file.  Open printer from print
preview.

Review-Url: https://codereview.chromium.org/2542363002
Cr-Commit-Position: refs/heads/master@{#437718}

Typed arrays in blink (e.g. DOMFloat32Array) are typedef of DOMTypedArray<T, U>
so using forward declarations causes conflicts. Stop using forward
declarations for typed arrays in union containers. Instead, include
headers directly.

BUG=671755

Review-Url: https://codereview.chromium.org/2559323004
Cr-Commit-Position: refs/heads/master@{#437717}

This patch is a subtask of "Decoupling Gamepad from //content".

In this patch the GamepadService, GamepadServiceUnittest, GamepadMonitor and
GamepadSharedBuffer are moved out of content/browser/gamepad or render_host,
and into device/gamepad/.

The file //content/common/gamepad_hardware_buffer.h is removed, we move the
definition of GamepadHardwareBuffer into gamepad_shared_memory.h, and change
its definition by using generic SharedMemorySeqLockBuffer<blink::WebGamepads>.

In the unittest of GamepadProvider, we don't pass a MockSharedMemoryBuffer
(which has no seqlock controls) anymore. GamepadProvider will create a
SharedMemoryBuffer by default in its constructor, so we add the seqlock-read
accordingly in its unittest.

Based on a patch by bajones@chromium.org.

BUG = 612330

Review-Url: https://codereview.chromium.org/2563483006
Cr-Commit-Position: refs/heads/master@{#437716}

The end goal is to trigger purge from DataTypeManagerImpl at the very beginning
of configuration based on information available in DataTypeManager and
DataTypeControllers.

In this change I moved PurgeDisabledTypes call from
SyncManagerImpl::ConfigureSyncer and called it separately from
SyncBackendHost{Impl/Core}.

R=maxbogue@chromium.org
BUG=647505

Review-Url: https://codereview.chromium.org/2563883006
Cr-Commit-Position: refs/heads/master@{#437715}

This change removes the CopyToWebGLTexture fallback reason, which
was no longer capturing the right thing, and replaces it with
more granular fallback reasons for the different variants of texImage.
This CL also adds more specific fallback reasons to track cases where
a canvas is copied to the clipboard and createImageBItmap.

BUG=671637
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2557783002
Cr-Commit-Position: refs/heads/master@{#437714}

This is merely a sanity check. Technically you could show the host
without initializing it, but chances are you didn't meant to do that (or
you can easily change your code to Init before Show).

BUG=NONE

Committed: https://crrev.com/2212ddb7876c7a259a696cbdc4af483193cc98ac
Review-Url: https://codereview.chromium.org/2552003002
Cr-Original-Commit-Position: refs/heads/master@{#437285}
Cr-Commit-Position: refs/heads/master@{#437713}

Previously RateCounter was using base::Time instead of base::TimeTicks,
which may cause it to generate incorrect values in some cases. Fxed it
to use TimeTicks. Also updated it to use TickClock interface for tests.

Review-Url: https://codereview.chromium.org/2561173004
Cr-Commit-Position: refs/heads/master@{#437712}

PeerConnection creates new threads internally and shuts them down when
connection is closed. This is a blocking operation, so Debug builds were
DCHECK'ing every time connection is terminated. Added ScopedAllowIO to
work around this issue.

BUG=660081

Review-Url: https://codereview.chromium.org/2567533002
Cr-Commit-Position: refs/heads/master@{#437711}

BUG=668584

Review-Url: https://codereview.chromium.org/2560993003
Cr-Commit-Position: refs/heads/master@{#437710}

This re-adds POSIX shared memory support on Mac. This
is for use in the sharing of field trials using shared memory. You
can see the design doc for this project at:
https://docs.google.com/document/d/1mTjD99PchmCGYtLvpxaXFObVnid1zmXIsWBI7GjuJgo/
and the motivation for this change under "Port to other platforms".

NOTE: turning on NOPRESUBMIT because this re-adds some banned calls to AllowIO.

BUG=671228
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2555483002
Cr-Commit-Position: refs/heads/master@{#437709}

BUG=504347

Review-Url: https://codereview.chromium.org/2567723003
Cr-Commit-Position: refs/heads/master@{#437708}

From discussion at
https://crrev.com/2555033003/#msg21

BUG=

Review-Url: https://codereview.chromium.org/2565813002
Cr-Commit-Position: refs/heads/master@{#437707}

BUG=chromedriver:1506

Review-Url: https://codereview.chromium.org/2387353004
Cr-Commit-Position: refs/heads/master@{#437706}

CompositorFrameSink implements cc::mojom::MojoCompositorFrameSink.

CompositorFrameSink is no longer a friend class of exo::Surface.

Added exo::CompositorFrameSinkHolder class that implements cc::mojom::MojoCompositorFrameSinkClient.

BUG=659601
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2493223002
Cr-Commit-Position: refs/heads/master@{#437705}

The post task to delete the predictor on the IO thread comes from the
profile destruction. Thus, callers into the predictor on the UI thread
with *valid* profiles are guaranteed to have their IO thread tasks queued
before the predictor is torn down on the IO thread.

This means we can safely use base::Unretained in place of weak pointers
in these cases.

BUG=671970

Review-Url: https://codereview.chromium.org/2559323008
Cr-Commit-Position: refs/heads/master@{#437704}

BUG=

Review-Url: https://codereview.chromium.org/2563133002
Cr-Commit-Position: refs/heads/master@{#437703}

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2558933003
Cr-Commit-Position: refs/heads/master@{#437702}

Remove vertical separator between subpage header and first section on the
Custom Spelling subpage of chrome://md-settings/languages.

R=stevenjb@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2557193002
Cr-Commit-Position: refs/heads/master@{#437701}

This is to remove dependencies from ImageResourceInfo.h and
ImageResourceContent.h to Resource.h in
https://codereview.chromium.org/2469873002/.

BUG=667641

Review-Url: https://codereview.chromium.org/2537063002
Cr-Commit-Position: refs/heads/master@{#437700}

This change makes PresentationServiceDelegateImpl cancel requests to join
session if they have the "auto-join" presentation ID and the user pref is set to
tab mirroring for the origin. This way, when a page requests to auto-switch from
tab mirroring to Cast SDK on a site where the user has chosen to use tab
mirroring, the auto-switching gets cancelled.

This CL relies on a profile pref introduced by
https://codereview.chromium.org/2487673003/.

BUG=664671

Review-Url: https://codereview.chromium.org/2517833004
Cr-Commit-Position: refs/heads/master@{#437699}