- 22 Sep, 2020 40 commits
-
-
Chris Sharp authored
The policy description was changed to say this policy was deprecated but the deprecated flag wasn't added. See https://chromium-review.googlesource.com/c/chromium/src/+/2215811 BUG=1086429 Change-Id: Ib9068ec4d0ad12272b71b9bd554933477f702606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419431Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809275}
-
Andreea Costinas authored
The PolicyCertService tracks which Profile has used a policy provided trust anchor by the user's email address. This CL fixes an issue in which the stored data is queried by the username hash instead of the email. Bug: 1106441 Test: unit test Change-Id: I0e0402f39068fbbc1b218cde0684c4fe6c1a880e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413489Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#809274}
-
Side Yilmaz authored
DownloadController defaults profile key to regular profile key in case of the profile is not reachable over download item. This CL changes the logic as below to prevent using regular profile key in incognito mode: - If download item provides a profile, use its key. - If not, get key from ProfileKeyStartupAccessor, as this means the code block runs in reduced mode. - If there is no key from ProfileKeyStartupAccessor, this means the incognito tab is closed and download will be destroyed when incognito goes away. In this case, just return. Bug: 1041781, 1075562 Change-Id: Id53485735891d9089cbf1e7a1c8c6e43cabc84a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413947 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809273}
-
Manuel Rego Casasnovas authored
In LayoutNG the overflow of positioned elements is already computed in LayoutNGBlockFlowMixin<Base>::AddLayoutOverflowFromChildren(), so we don't need to compute it again in the legacy code. Specifically positioned elements are already considered in NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). BUG=1098231 Change-Id: I8e527617ae31ef564eeea57eb823ca93465cf62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391256 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#809272}
-
dpapad authored
Replaces all instances of |#| as the numeric placeholder in pluralization strings with the new |{...}| format, as outlined in go/icu-message-migration. Bug: None Change-Id: I4e3409242e0b6bf94cb58de7327a381bfe237363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423404Reviewed-by:Rainhard Findling <rainhard@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#809271}
-
Harry Cutts authored
Bug: 1114828 Test: Check the new flag appears in chrome://flags Change-Id: Iac50ad3843fccf6f94cba27c7ff322e99be0708e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421298Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#809270}
-
Alan Cutter authored
This CL moves the call to GetPreinstalledWebApps() from SynchronizeExternalInstallOptions() to ScanDir() in preparation for adding metrics for enabled/disabled preinstalled web apps: https://chromium-review.googlesource.com/c/chromium/src/+/2418756 This enables the metrics to record for both JSON config files and hard coded install options. As part of this change ScanDir() is not just reading JSON config files and has been renamed to LoadInstallOptionsBlocking(). Other methods have been renamed to remove the "ScanDir" naming from the vicinity. Bug: 1128801 Change-Id: Ic95089c7c56c78f653c8aaa7683683fe2bd8f79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422022 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#809269}
-
Roman Sorokin authored
TBR=beccahughes@chromium.org Bug: 1124983 Change-Id: I1f56f52732b5ad24cd6ab11fb47970eabf19407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423709Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809268}
-
Antonio Gomes authored
This CL is a follow up of https://crrev.com/c/2414551, where AudioRendererSinkCacheImpl was moved to Blink core. BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifdaa4a5b68c4be2585307522629edc3e25f9a046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418911 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809267}
-
Matthias Körber authored
This CL adds support to store all address tokens and their verification statuses in the profile address table. Change-Id: Iad73aeb2e6464b872a8689b7077457cf39b01e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421450Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#809266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82f83e6cda76..a8aa0a8f5d26 2020-09-22 jacktfranklin@chromium.org Reland "Fix ElementsBreadcrumbs mutation bugs." 2020-09-22 mathias@chromium.org Add final separator to Rendering tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5bf612ea4a9c66f4db7df6a8a7d0fc62a02eee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423531Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809265}
-
Roman Sorokin authored
on Mac First failure on Mac10.13 Tests (dbg) https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20097 First failure on Mac10.14 https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/8525 suspect CL:2418018 TBR= Bug: 1130533 Change-Id: I2f3d46934ecb28a477d888df4422838a706d1b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421744Reviewed-by:
-
Roberto Moura authored
In order to allow the tab thumbnails to be up to date when the thumb strip is visible, the grid's collection view needs to be updated even when other view controllers are obscuring it. When selecting a new item from the collection view (blue highlight around the thumbnail), the item that is currently selected needs to be deselected to prevent multiple simultaneous selection. Bug: 1127604 Change-Id: Ic1e4a2dd4d0f2c269031b9d27b47b38c56b07a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410494Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#809263}
-
Andrey Zaytsev authored
Bug: 1128924, 1070620 Change-Id: Ib316e2a8e43eb1796b970ae340f9907210f58ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421374 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#809262}
-
Roman Sorokin authored
on linux-chromeos-dbg TBR=anasalazar@chromium.org Bug: 1130958 Change-Id: I9febe5766d3b906852df7d9cfbab0d8f4f4c3689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421663Reviewed-by:
-
Nohemi Fernandez authored
This method was previously required in iOS in order to filter CHROME_CONNECTED cookies. Now that we use NSURLSession this is instead handled in the account consistency service. Bug: 1101748 Change-Id: Id40b810e841ad3b7189309998c15224214978461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421669 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809260}
-
Frédéric Wang authored
This feature was initially implemented in [1] [2]. After discussion with the CSSWG, the property and values have been renamed [3]. This CL performs the following changes: - Rename math-superscript-shift to math-shift - Rename value "display" and "inline" to "normal" and "compact" - Add a MathML test to verify the effect of CSS math-shift (rather than just testing indirectly via UA style sheet rules). - Sort math-style / math-shift alphabetically [1] https://chromium-review.googlesource.com/c/chromium/src/+/2144185 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2277814 [3] https://github.com/w3c/csswg-drafts/issues/5388 Bug: 6606 Change-Id: I1c7c7c12954261217cafffabffbe044c6659db9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421662Reviewed-by:
Rob Buis <rbuis@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#809259}
-
Roman Sorokin authored
on linux-chromeos-dbg TBR=anqing@chromium.org Bug: 10948093 Change-Id: I2012e7d25ed7a84a3d92be5620c7c8683cee149b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423706Reviewed-by:
-
Nikita Podguzov authored
Old version of UI: https://screenshot.googleplex.com/7ewxr4cinJGSMf9 New version of UI: https://screenshot.googleplex.com/8q4GUAcSyZVaQn5 Bug: 1100800 Change-Id: If43bea1dac27f0c915da389c8d45396b46e0f213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421737Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809257}
-
Ioana Pandele authored
For the favicon fallback, the name of the app should be used. If that doesn't exist, use "A" since the displayed string will be App(package name). Bug: 1124282 Change-Id: I9f14ccaa5a152780e48f59e785c0161ee90567ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421497Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#809256}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5ec560fb8c75..566821cb0e58 2020-09-22 jmadill@chromium.org Suppress 3 more Intel/GL/Compute shader fails. 2020-09-22 lehoangq@gmail.com Metal: Disable unused attribute slots. 2020-09-22 syoussefi@chromium.org Vulkan: Use subpass to unresolve render-to-texture attachments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I32959d8df0fc8c3bf906a799a0a1cab9b12ec72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423262Reviewed-by:
-
Mohamed Amir Yosef authored
This CL makes sure that icons in the autofill dropdown menu adapt to changes in the theme by introducing a subclass of ImageView that listens to theme changes. Screenshots: Before: https://screenshot.googleplex.com/5SNap3FrsrsMQQo.png After: https://screenshot.googleplex.com/8W7PmdUttXYgGwU.png Bug: 1115952 Change-Id: I0d7b952b325d8314963dabf596871815e4ecb3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421449 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809254}
-
Jinsuk Kim authored
Checks if the curren Tab is in destroyed state in order to prevent BrowserControlsManager from accessing TabBrowserControlsConstraintsHelper after the tab becomes invalid. Bug: 1110909 Change-Id: Ib6cccfdf61abcc18f1f0f5300bc80901c696cef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418274Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#809253}
-
Fredrik Söderqvist authored
This replaces the special display item and fairly complicated source graphic recording for 'filter' on a SVG element with using an effect node like for other 'filter' handling. This means that SVGFilterRecordingContext and related code can be removed and the code vastly simplified. It also lays a large piece of the foundation for handling the full 'filter' specification on SVG elements. PaintChunksToCcLayer's logic for handling 'empty' paint chunks is improved to be able to handle cases where a filter expands the bounds of an element. This changes the clipping behavior and how the source graphic is rendered which causes slight (non-discernible) changes to some tests. It also affects the visual rect since it now uses the visual rect of the painted content and not the paint rect that was computed from the filter. The visual rect of the painted content will have been conservatively extended to the filter region. It's expected that this will improve in future CLs when the filter region is not included in the visual rect. Bug: 109224, 441297, 1128962 Change-Id: Ie0ad3b65aecba0c2bde06de7e3c8c4066e63c928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187795Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#809252}
-
Johan Bay authored
This command takes a DOM node and a name and/or role to search for. It searches the accessibility subtree of the given node for the name and role. The command also includes ignored nodes in its result. The command is the underlying primitive for a new aria-based querying mechanism in Puppeteer. This CL is a follow-up to crrev.com/c/2366896. The feedback given there has been addressed in this CL. Doc: https://docs.google.com/document/d/1-BUEUgqAZlh26fv9oLfy1QRr0MF3ifnxGh7-NDucg9s/ Change-Id: Ibdcdb230b5d1287ab009f2dd9d25a53932072d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398547 Commit-Queue: Johan Bay <jobay@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#809251}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80297a032922..4d0f8b8c9cc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rsorokin@google.com Change-Id: Ia57a05337c199438b2a9e6e08c29cd7b310a6f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809250}
-
Alice Wang authored
This CL adds three more metrics for the web sign-in flow. Bug: 1120334 Change-Id: Ie28d1046289b7221f3075e2b7cecf0b57252539d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418380 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#809249}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ee96f113769..82f83e6cda76 2020-09-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd0d8648992763112a210f8e5db68dfa3f958876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423524Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600732621-efcb2b5a6f18794514e083516aa5205975064ad2.profdata to chrome-mac-master-1600754349-f2bf1ecbd6b189476a5e50362abd5d7f8ec183c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia9461fa9bf9c1462ad7962c7b2b314e97008881f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423526Reviewed-by:
-
Wei Lee authored
We should show a message to users to let them know we have changed the default camera folder from "MyFiles/Downloads" to "MyFiles/Camera". Bug: 1127587 Test: Launch CCA and the dialog show up Change-Id: I2dc78e839dfb4bc54a42da2627eb89d491689016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407734 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#809246}
-
Dana Fried authored
This changes long-standing problems with FlexLayout that were not problems with BoxLayout. Specifically: - Flex weights now dictate deviation from a view's preferred size (which may now be zero), so that when a view with a FlexLayout shrinks, its flex children shrink proportionately, just as they grow proportionately when the host view enlarges. - When a child view hits its minimum size or drops out, remaining space is correctly allocated across other child views, even at the same flex priority. This solves a number of weird corner cases and rounding issues at the result of a bit more complexity. However, the code is more heavily documented and broken into steps so the net effect is that it should be relatively maintainable. Bug: 1012134, 1012113 Change-Id: Idc3059d572b3d165866b44c077c38d483d862596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100026 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#809245}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d6daec3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: If505c3a247f5ac630c18da834a7a4e3732978d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422864Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809244}
-
Soumadeep Mazumdar authored
Issue: Pen/Touch selection handles persist even on refresh. On refresh, the active client is invalidated before handles are dismissed. Selection handles in PDF created in touch selection controller currently had no way of being destroyed on a tab refresh before the actual parent was destroyed. This is not the case in HTML where there is an explicit call made to HideAndDisalllowShowingAutomatically to remove the handles from aura observer depending on window focus lost. Fix: Added call to Hide and not show handles automatically on destruction. Following similarly from HTML, this call is made from PDFWebContentsHelper destructor which takes care of removing the selection handles before destroying the controller. Since this is tied to the client, it does not remove existing handles in other active clients. Bug: 1110815 Change-Id: I9818f06ac8fe7fac3223472a58088544f2bc462a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359652 Commit-Queue: Soumadeep Mazumdar <somazu@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809243}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I2e2ab47f24ea29929a38a1d4ca406d15f2845ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414279Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#809242}
-
Daniel Libby authored
This will give us more insight into how frequently this happens as well as give us more accurate sites via HTTP Archive. The current data just shows when zoom not equal to one is parsed. R=ikilpatrick@chromium.org Bug: 1067747 Change-Id: Idfcc600b802e35955dc85705b7248b29f89863fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422355Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
Olivier Yiptong authored
This cleans up the per-platform build configuration preprocessor directives. With this change, the platform build configurations are consolidated in one place. Bug: 1043306 Change-Id: Id9e2da3bf156e245b510ce7b32346df285fd6f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422811 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809240}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4a6338f2de7331e19b8dab18403bcb70e29eb22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423261Reviewed-by:
-
Dan Elphick authored
Move RAILMode from Info to Default so it's not disabled by default. Change-Id: Ib302aa70bb4f87e579d8c925eebfc43744f8bd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397719 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#809238}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600711078-15e6465f6b9c8d99add6c7e09aa1cb16b33babfa.profdata to chrome-linux-master-1600754349-bb0b36845adda8f601cf43d9095b0eb5c5334e61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I7cbff8884062ad5363f8d76b075956a050a2bc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423525Reviewed-by:
-
Julie Jeongeun Kim authored
This CL checks the case that |document_page_count| is bigger than |kMaxPageCount| at PrintJobWorker::GetSettingsWithUI() to fix the fuzzer issue from the ipc_fuzzer_replay and the ipcdump. On the normal flow, the renderer doesn't call GetPrintSettingsFromUser() if |expected_page_count| is bigger than |kMaxPageCount| at PrintRenderFrameHelper::Print(). Bug: 1130456 Change-Id: Ic1c91399eba2c794240744320b8d8a3ce5eaeb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421849 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
