- 10 Apr, 2020 40 commits
-
-
Maksim Sisov authored
We have cleaned up ui/gl from USE_X11. These includes are not needed anymore. TBR=backer@chromium.org Bug: 1036285 Change-Id: I6420b774a6a190527f76ab3fa5cb058b54d76a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144136Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#758167}
-
Yuki Shiino authored
Stringifier.IR and IndexedAndNamedProperties.IR are not updated during the compilation, so these IRs shouldn't be used at all. Bug: 839389 Change-Id: Id74cb0f310cd234794f22a675a281ee3b078be42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141500Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758166}
-
Brian Manthos authored
No functional changes. Change-Id: Ic7d93c1c13d174a7d04a251bedcc8b5bcfb458bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145132 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758165}
-
Shakti Sahu authored
This CL includes : 1 - Rounding the tiles using RoundedCornerImageView 2 - Gradient overlay above RCIV 3 - Tile width calculation logic depending on screen size Bug: 1068666 Change-Id: I014a01f17514e8df1da65cfd12e2baf9eb931e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137818 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#758164}
-
Gauthier Ambard authored
This CL makes sure that we don't display the NTP if the loaded page is an interstitial page. This is caused by the behaviour of interstitial when the committed interstitial feature isn't enabled. In that case the workflow is: 1. about:newtab is loaded 2. User loads bad.badssl.com 3. Navigation did start for bad.badssl.com 4. Navigation ends for bad.badssl.com 5. This is a bad ssl page so Chrome actually reverts to about:newtab 6. Load stops, but at this point the visible URL is about:newtab 7. The interstitial is displayed and the visible URL is updated to bad.badssl.com 8. The observers are notified through DidChangeVisibleSecurityState 9. No further callbacks So the main issue is that there is not callback notifying that the visible URL has changed. This CL fixes it by adding a callback on DidChangeVisibleSecurityState and also on LoadStop to avoid having the NTP flashing between 6 and 7. Fixed: 1067250 Change-Id: Ifc57addf5a6fa9e6295446da34e117028add73fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141971 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758163}
-
Nohemi Fernandez authored
Updates EarlGrey tests that are impacted by the new default signout UI. Bug: 1005509 Change-Id: I688c15b7b3a7b77be6da9e87d2047dd831818aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139708Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#758162}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b60df8ed2de8..1260c0bbd0ae git log b60df8ed2de8..1260c0bbd0ae --date=short --first-parent --format='%ad %ae %s' 2020-04-10 mathias@chromium.org Update console message expectation Created with: gclient setdep -r src/third_party/devtools-frontend/src@1260c0bbd0ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2e8e1509c0ed00d8a9cb7eb4cacb6adc4a4a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758161}
-
Colin Blundell authored
We are targeting InterceptNavigationDelegateImpl for componentization and sharing with WebLayer. The main blocker is its dependence on Tab. This CL starts decoupling InterceptNavigationDelegateImpl from Tab: - We add a //chrome-level InterceptNavigationDelegateTabHelper object to attach InterceptNavigationDelegateImpl to a Tab. - We add an InterceptNavigationDelegateClient interface that the embedder implements to give the context that InterceptNavigationDelegateImpl is currently obtaining from Tab, and populate it with an initial method. The implementation of the Client interface is currently separate from the TabHelper object due to a thorny circular dependency issue in InterceptNavigationDelegateTest.java. Once InterceptNavigationDelegateImpl is cleaned of all dependencies on Tab I suspect that this circular dependency will go away and we will be able to merge the Client implementation into the TabHelper object. Future CLs will complete the cleaning of //chrome-level dependencies from InterceptNavigationDelegateImpl. Bug: 1031465 Change-Id: I0f63b31d77efffe9d74ff68065c55e59ba163cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134290 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#758160}
-
Rushan Suleymanov authored
Currently, during the initial merge of bookmarks it may be possible that processing of local creation may cause crash if the previous neighbour wasn't processed yet (due to matching by GUID with some remote update). This patch fixes that behaviour by finding the last tracked entity. That entity will be used to calculate next UniquePosition. Bug: 1050776 Change-Id: I5275aee07d5bd5f4e4ac534734c209ec2ed78b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144160 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758159}
-
Takashi Toyoshima authored
This patch updates the policy_templates.json to update the announced removal plan. This will also update the official support page for these enterprise policies. Bug: 1053866 Change-Id: Ie31dbeb7d00b4ae9ce2b45757dc9ad4a8c62181f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134753 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#758158}
-
Alex Kalugin authored
Check for ShouldKeepErrorPageInCurrentProcess in case of failure produces incorrect log output (both new error codes). Change-Id: I405c1c901ce5abe516a37d30a408633b0c81eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144198Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#758157}
-
Mansi Awasthi authored
This CL adds an end to end browser test for validating that PDF text fields are getting added to the accessibility tree correctly. It also includes a test to validate the value of inline text boxes for PDF with text fields. Bug: 1030242 Change-Id: I4f337ad5459b36239549b40e35ef16a52c5f16d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134092Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758156}
-
Maksim Sisov authored
Actually, I couldn't find the real use of this code. It seems like all the windows we create are aura Windows and this condition never executes. Bug: 1069469 Change-Id: Ic3caebca38769e45b873cbc15f1ef618232be390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144054 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758155}
-
Yoichi Osato authored
Bug: 1066716 Change-Id: I7dfe445604ad6e8556e7f9de462ceed7f0305fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142883Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#758154}
-
arthursonzogni authored
This reland the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2062336 The diff: https://chromium-review.googlesource.com/c/chromium/src/+/2144100/1..5 The previous CL was reverted because if was not compiling reliably. The target: //third_party/blink/common:common was missing: //services/network/public/mojom:mojom_blink However, adding it would creates a dependency cycle: ERROR Dependency cycle: //third_party/blink/public/common:common -> //third_party/blink/common:common -> //services/network/public/mojom:mojom_blink -> //mojo/public/cpp/bindings:wtf_support -> //third_party/blink/public:blink_headers -> //third_party/blink/public/common:common It means we can never #include a generated .mojom-blink.h from //third_party/blink/common:common Fortunately, there are already many .mojom-shared.h there. So we can can include web_sandbox_flags.mojom-shared.h instead. The enum definition is entirely contained in this file anyway. The mojom-shared.h is already a dependency:: /third_party/blink/common:common -> /services/network/public/cpp:cpp -> /services/network/public/mojom:mojom [generated HERE] R=kinuko@chromium.org TBR=thakis@chromium.org,mfoltz@chromium.org,iclelland@chromium.org,mkwst@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org Bug: 1041376 Change-Id: I272d4971920d6d3c04a965f1aa9b90376353b446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144100Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758153}
-
Wei Lee authored
The mojom_bindings_generator.py is refactored again by https://crrev.com/c/2128966 And cause the deploy function of cca.py out of work. This CL fixes the usage accordingly. Bug: None Test: cca deploy works again Change-Id: I55003cf6317c400b1b82df8139d28d6111c0bef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142885Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758152}
-
Maksim Sisov authored
In order to be able to move X11DesktopWindowMoveClient out of ui/views to ui/base/x, we need to stop subclassing wm::WindowMoveClient. This CL does it. Basically, we implement WindowMoveClientPlatform that reroutes the requests for RunMoveLoop to DWTHPlatform::RunMoveLoop, which then is supposed to call PlatformWindow::RunMoveLoop. Current, for X11, these calls are routed to DWTHX11::RunMoveLoop. Test: verify Tab Drag works on chrome/x11. Bug: 1069469 Change-Id: I60cd60001c47ddfcefe8248cb7a0a087c85bb164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144053 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/48d345fd83fd..05e2350de5a9 git log 48d345fd83fd..05e2350de5a9 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9fa8abd9..6de7d4c5 (410 commits) 2020-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2caf7ffda74f..c68dfaf3a529 (9 commits) Created with: gclient setdep -r src/third_party/skia@05e2350de5a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ie8c5aaf09dd813ca35626a42b702f490648e8cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145317Reviewed-by:
-
Yuki Shiino authored
Updates the implementation of cross origin properties generated by the new bindings generator. No prod change. Bug: 839389 Change-Id: I9ac45e76341f075e15d89288d5a9776bb4321f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143110Reviewed-by:
-
Yuki Shiino authored
Adds v8_event_counts.{cc,h} and v8_is_input_pending_options.{cc,h}. Bug: 839389 Change-Id: I5c7696af4272afe209a54c79fd4adc39b41c5b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141490Reviewed-by: -
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3470cbf..0bb2b300 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib042318fa896c756b1f671f57bc2e663c0f95f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758147}
-
Roman Sorokin authored
Fixed: 1067461 Change-Id: I18d02649f37c33e8c14e3fe13e4f57f3f27b6113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141896 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#758146}
-
Jenny Zhang authored
TBR=holte@chromium.org Bug: 1046006 Change-Id: I65ea50b224f85821f2e343ce3e3907340175b69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145158Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758145}
-
Julie Jeongeun Kim authored
This CL is a follow-up CL of crrev.com/c/2134466. This TC has an issue number[1] that introduced it. But, since Chromium changed the behavior at [2], it should be updated with the latter. It also updates "assert" to deliver clear messages. [1]https://bugs.webkit.org/show_bug.cgi?id=81809 [2]crbug.com/531783 Bug: 1063749 Change-Id: If3b1c761cab29e351e337eda4f3797f12679140c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143094 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#758144}
-
John Z Wu authored
This is to support butter sync where passwords are account scoped. The profile password store can be left as is because all access to the stores are controlled via WebViewPasswordFeatureManager. Bug: 1056406 Change-Id: I916beffe9b95b4e9d8216363ed3db88b1c17875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141007 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#758143}
-
Alice Wang authored
This CL resets the AccountManagerFacade test instance to null in AccountManagerTestRule teardown. Bug: 1066800 Change-Id: I670cb1b4741ddfd6f5f126b21f17ae5b9c346887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135698Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758142}
-
Takashi Toyoshima authored
Bug: 898589 Change-Id: I814297c70cbfbe9052d6d6507e0ab01257e0b94d NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134183 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#758141}
-
Julie Jeongeun Kim authored
This CL iterates all descendants for GetSelectionCount and GetSelectedChild. When listbox has group children, it should iterates their children as well to check the select state. Bug: 1058961 Change-Id: Ib6459bf6f47023d4258ef4c2f2dc545739d7a61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115211 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#758140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df3cc205af96..c68dfaf3a529 git log df3cc205af96..c68dfaf3a529 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 xinghua.cao@intel.com Avoid GPU-GPU copy for StructuredBuffer Created with: gclient setdep -r src/third_party/angle@c68dfaf3a529 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Id6bfd75ed19ed19e569972dfb7fa64f635d8541e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145312Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/854ac61e90a4..48d345fd83fd git log 854ac61e90a4..48d345fd83fd --date=short --first-parent --format='%ad %ae %s' 2020-04-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3cfa8e28be80..e6f65d9265e7 (5 commits) Created with: gclient setdep -r src/third_party/skia@48d345fd83fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I7c4cee8525bca9197d7fc376cdd1c39b67209220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145313Reviewed-by:
-
Shengfa Lin authored
run_py_tests will collect tests that have failed from first run and run it again, exit status will reflect the result from first run if everything succeeded or second run if first run has failure. Modified util for writing to json file to support multiple runs result. Modified client_replay_unittests to use updated util write json. Bug: 919953 Change-Id: I256af55f30284c545263e2f20dd161d7448558a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143513 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758137}
-
Samuel Huang authored
This CL removes the warning message DeprecationWarning: the imp module is deprecated... from running print_python_deps.py on SuperSize (or other Python 3 projects). The key is to follow the recommendation to use importlib. Caveats: * The library only in Python 3, so we need to keep on using imp for Python 2. * This requires Python version detection and using import statements locally. * importlib.util is more fine-grained than expected, and requires: * Manually extracting module name from module path. * Explicitly adding loaded module to sys.modules. Meanwhile, once the module runs, the modules it transitively uses will be automatically added. Fixed: 1069660 Change-Id: I41b6be8975db1219da006e0c9e5d98b42acf15c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145094Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#758136}
-
Jimmy Gong authored
This is a reland of 75e29f77 - The fix is to ensure that the print-management dom element is created and ready by the time we're querying for its child elements. - This was done by flushing the dom when the whenCalled promise is resolved, ensuring that the elements are ready. Original change's description: > Fix flaky printmanagement browser test > > - The original cause of the flaky is because the page element was not > ready by the time we try to query for elements within it. > - The fix is to attach a promise to the instatiation of the page and > to only continue with the test once the promise is resolved. This > ensures that each step of the test is handled synchronously. > > Bug: 1068860 > Test: browser_tests > Change-Id: I0a30e2971107b44354603adbb0396ddfea3c218d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142951 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: jimmy gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757687} Bug: 1068860 Change-Id: I4b2e8b3836aa676c3d5aa43295432dd1afed6927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145253 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#758135}
-
edchin authored
This CL: 1) Ports chrome/browser/bookmarks/managed_bookmark_service_factory.h/cc to iOS 2) Updates bookmark_client_impl.h/cc with an instance of ManagedBookmarkService, gotten from the factory. 3) Instantiates the new service where all browser state keyed service factories are invoked. Bug: 1065187 Change-Id: I840a3b2496310f0a3f40be20a35e6d71144dcdc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142106 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
There are several QP value variables. Their meaning might be ambiguous. This clarifies them by modifying comments. Bug: 1067522, 1034382 Test: webrtc.* and video.EncodeAccel.* on eve Change-Id: I4c3812fd2126b6c3d4e6747262474bd5d095ac5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134181Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#758133}
-
Hiroki Nakagawa authored
This reverts commit 275bf019. Reason for revert: NewTabPageDoodleShareDialogTest.All constantly fails on Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3224 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33302 Original change's description: > [webui][ntp] Add doodle share dialog > > The share dialog opens when clicking the share button on simple and > animated doodles. The dialog lets the user share the doodle via > Facebook, Twitter, email, and copy the doodle URL. > > + Add doodle description tooltip. > > + Remove TODO about the share button focus ring working for dark > doodles. We decided it's an edge case and doesn't warrant fixing. > > Bug: 1039910 > Change-Id: Ib2b8d9ca9447a2d6363d3c76167b393f914f60e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138792 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758033} TBR=tiborg@chromium.org,aee@chromium.org,ajgo@chromium.org,owone@google.com Change-Id: I62f6bc2e7d5e442e4c57e23fe16412313268861b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142884Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#758132}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55d00afb3680..b60df8ed2de8 git log 55d00afb3680..b60df8ed2de8 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b60df8ed2de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If7b3887d43391c00d3b9a60503a620e29d7821de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145191Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile without argument is getting deprecated. Use cases of this call that only refer to incognito or guest mode can use GetPrimaryOTRProfile() instead. All calls to this function in ProfileHelperImpl are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I946e0e39817ab32ce07a93009dddf5c5aef3019b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143813Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#758130}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9173e675..f3470cbf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f9f78d663f200948ef0a3d39f39f65ed262af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144238Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0994171. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." a9c7f7ae "[css-filters] Move drop-shadow-clipped.html to WPT" 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 8b540121 "[css-masking] Migrate clip-path-css-tranform-mutated.html to WPT" 67f851b8 "[css-masking] Migrate clip-path-columns-shape.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I98c74819b74fe858a329bdb6cb880a0c21e525c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144515Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758128}
-
