- 10 Sep, 2019 40 commits
-
-
Eliot Courtney authored
This fixes the case where the occlusion is changed while we are updating all the pending properties. This caused some wrong occlusion updates. Bug: 140563748 Test: Spurious occlusion update no longer occurs when leaving PIP. Change-Id: Ic9bdbf62c655285eb8fbe1c80d221ff95bbbd096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794526 Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#695323}
-
Scott Violet authored
I had to change //component/version_info as generate_version_info is not externally visibile and should be a public_dep of version_info. BUG=none TEST=none Change-Id: I8e27071b70f5c888eb33456283b7794bb166e270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790745Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695322}
-
Sharon Yang authored
This is a reland of b02a397f Original change's description: > [fuchsia] Register Views with Fuchsia Accessibility APIs > > * Add the AccessibilityBridge class skeleton, which will eventually > handle the logic for conversion between Chromium and Fuchsia > accessibility data structures. > * Register a ViewRef to the Fuchsia SemanticsManager. > > Test: Added AccessibilityBridgeUnitTest.* > > Bug: 973095 > Change-Id: Ie8eb6a8cdd68e0082d3479b9b1288f8aaa68a600 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708043 > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693914} Bug: 973095 Change-Id: Ia13e5f80383abe6d22f3e3049a07b6204861b400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796627Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695321}
-
John Chen authored
Dsiabling the following failing perf tests on android-pixel2-perf: system_health.memory_mobile/browse:chrome:newtab system_health.common_mobile/browse:chrome:newtab v8.browsing_mobile/browse:chrome:newtab v8.browsing_mobile-future/browse:chrome:newtab system_health.memory_mobile/browse:chrome:omnibox system_health.common_mobile/browse:chrome:omnibox v8.browsing_mobile/browse:chrome:omnibox v8.browsing_mobile-future/browse:chrome:omnibox TBR=crouleau@chromium.org NOTRY=true Bug: 1002640, 1002665 Change-Id: Ie0d5edfb7f47b2e3d7d6266c6b727cf12b02bbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795892Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#695320}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/058a26f57015..a9e27d5c7f1b git log 058a26f57015..a9e27d5c7f1b --date=short --no-merges --format='%ad %ae %s' 2019-09-10 dpranke@chromium.org Add a COMPONENT (Platform>NaCl) entry to //OWNERS. Created with: gclient setdep -r src/native_client@a9e27d5c7f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=mseaborn@chromium.org Bug: None Change-Id: I4e55a36ffd97c3afef87df8a72f89629fdf04dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796747Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695319}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de5f63910e24..467073a0c18f git log de5f63910e24..467073a0c18f --date=short --no-merges --format='%ad %ae %s' 2019-09-10 qingsi@webrtc.org Revert "Adds peer scenario connection interface." 2019-09-10 qingsi@webrtc.org Revert "Reland "Refactor SCTP data channels to use DataChannelTransportInterface."" 2019-09-10 peah@webrtc.org First step for introducing multichannel support for the AEC3 capture 2019-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a87779d3..56140e7d (695071:695187) Created with: gclient setdep -r src/third_party/webrtc@467073a0c18f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I9b2e099671c1a60fcdc1e0a1d1ddf32a4cbd85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795305Reviewed-by:
-
Alexandre Frechette authored
Bug: 872096 Change-Id: I9401f3ea3b88c86a959eee3d59c8faedd3e764de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772320Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#695317}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the content.mojom.FrameSinkProvider interface, and adapt unit tests. Bug: 955171 Change-Id: I1b4d9769549648ee7f9dd30c310445093736b354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795329Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695316}
-
Alex Gough authored
During process creation, a job tracker (JobTracker as before) or a process tracker (ProcessTracker) is created in the process launching thread. These are then posted to the tracking thread (TargetEventsThread) (before the job is associated with the thread). New control keys are provided for the tracking thread to receive these objects and take ownership. For jobs, they are stored in a job tracking list (jobs) and job notifications are used to determine if a job has finished. Now, when finished, the tracking is removed from the job tracking list and destroyed, freeing the related target policy. For processes, these are now stored in a process tracking list (processes) and a wait registered on the default thread pool for a duplicated copy of the process’s handle to signal process exit. The wait’s callback simply posts a message to the tracking thread indicating that the process is done. When a process is done, the process tracker is removed from the process tracking list and freed. The related target policy is freed. As there may be more than MAXIMUM_WAIT_OBJECTS(=64) children we use RegisterWaitForSingleObject and a lightweight callback to post back to the tracking thread. No manipulation of these lists is done outside of the tracking thread. Policies used to be destroyed in the BrokerServices dtor so this may move some crashes around, especially if there are many processes and shutdown is stalled by a busy host. child_process_ids can now be manipulated entirely within the tracking thread so does not need locking. The working of WaitForAllTargets() could be improved but is not addressed in this effort. The lock is no longer required. This CL prepares for chrome://sandbox on Windows by moving access to stored policy objects to a single thread. I have manually tested by simulating a job-free chrome. Notes for this CL https://docs.google.com/document/d/1_9lde2MOX96VxE6k7IYtQFb5Zwpom5ZLFhCsfI7xXIc/edit#heading=h.3jv39q2gpdkw Change-Id: I35d7970fc285d80bd6ea2143cdab7d82b42d57cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743294 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#695315}
-
Michael Crouse authored
Bug: 932707 Change-Id: If73900c292289d4646af04a9ff6801d2d52d8049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795982Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.CacheStorageCache interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I863f4bc37756af961c545e693c4bdd760f637340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791151Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#695313}
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: I2a1e6297174eaf71643f0706dd6ce19f704002ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796346Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695312}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f57b7cb8f0bc..8e63cab2e8fb git log f57b7cb8f0bc..8e63cab2e8fb --date=short --no-merges --format='%ad %ae %s' 2019-09-10 bsalomon@google.com Revert "Separate texture creation from uploading in GrGpu subclasses." 2019-09-10 senorblanco@chromium.org Dawn: implement staging buffer manager. 2019-09-10 senorblanco@chromium.org Update Dawn backend to accommodate recent Skia API changes. 2019-09-10 bsalomon@google.com Update new blurrect_compare GM to skip when SkCanvas::makeSurface will fail 2019-09-10 bsalomon@google.com Remove unused GM deferred canvas feature 2019-09-10 bsalomon@google.com Separate texture creation from uploading in GrGpu subclasses. 2019-09-10 ethannicholas@google.com fixed an assertion error with unspecified sksl array sizes Created with: gclient setdep -r src/third_party/skia@8e63cab2e8fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I3ff625d428e0936c6ac2dd9fb962b831334b352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796782Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6d242c0..e1cf2cc2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e1f74807f1982011e88d63d75fd0facea90bf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795670Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695310}
-
Ben Mason authored
Bug: 1002642 Change-Id: Ibd238eae9c86de75279cddf281c931a9fb1ec3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795496Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#695309}
-
Jacob DeWitt authored
Now that both position and orientation are used, some expected view matrices had to be updated. Bug: 1001733 Change-Id: I3dacd02ff724c0f173fae2c3473014df9fc6d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795492 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#695308}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b07dda63ef03..548a26302ef5 git log b07dda63ef03..548a26302ef5 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 thestig@chromium.org Use pdfium::form_flags constants in CPDF_FormField. 2019-09-10 thestig@chromium.org Remove redundant assertions in more CFFL classes. 2019-09-10 thestig@chromium.org Add more test cases for AFSimple_Calculate(). 2019-09-10 thestig@chromium.org Roll build/ b8866fdd3..f0964b29a (143 commits) 2019-09-10 thestig@chromium.org Roll third_party/googletest/src/ a45c24ac1..3a4503986 (68 commits) 2019-09-10 thestig@chromium.org Roll third_party/catapult/ 2861f86d3..884c81e17 (125 commits) 2019-09-10 thestig@chromium.org Roll third_party/depot_tools/ 59bb8cce8..e5641be5f (97 commits; 27 trivial rolls) 2019-09-10 thestig@chromium.org Roll third_party/binutils/ 92bfa0a5d..01aa7745b (1 commit) 2019-09-10 thestig@chromium.org Roll buildtools/ aeda9c123..fce87d1a3 (2 commits) 2019-09-10 thestig@chromium.org Roll build/ e7232efeb..b8866fdd3 (12 commits) Created with: gclient setdep -r src/third_party/pdfium@548a26302ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:611744 Change-Id: I32dfaa60b8a4715a7718f0003c45f0fedb7866b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795304Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: I36d53904d2be2d95d410ef88e3c973884a7777c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796428Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695306}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/4baa46a5d104..5903ef1f95a0 git log 4baa46a5d104..5903ef1f95a0 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 stevenperron@google.com Have update_build_version.py new parameter (#805) Created with: gclient setdep -r src/third_party/shaderc/src@5903ef1f95a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I30f9dec6756add748eb7d7215f98189288a09f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796762Reviewed-by:
-
Chris Mumford authored
In the prior implementation the exception was uncaught which resulted in the lower level JNI layer failing a CHECK. This resulted in the Java exception being logged to adb, but then a second stack trace which was purely in native code. This caused many developers to think the problem was in WebView. This change eliminates the native crash by catching the exception, rethrowing it on the UI thread, and also failing the resource load. TEST=Manual Bug: 718929 Change-Id: I7dc4226e6f95023cc841a0fb23bcac33c330fd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742956 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#695304}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I47b47236a4baa9f508373bf74e66130a6236c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774920 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#695303}
-
wutao authored
Bug: b/140765499 Test: new unittests in AmbientContainerViewTest Change-Id: I3ca9427ca225187b513bceec64f854f0c3567357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794032 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695302}
-
Bailey Berro authored
Opens directly to native printer settings rather than the printing page Bug: 980230 Change-Id: I77900a57fc1491d5e20ea991ed34d4da48b12e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796313 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695301}
-
Eric Willigers authored
If any of the border-*-radius values have distinct horizontal and vertical radii, the serialized border-radius shorthand contains / Bug: 817471 Change-Id: I647ea57e6989def0677b16f79ba89cacf5ed809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695686 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#695300}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1f562b7ad68c..369f46e37423 git log 1f562b7ad68c..369f46e37423 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jbudorick@chromium.org devil: add support for stdin to cmd_helper.Popen. Created with: gclient setdep -r src/third_party/catapult@369f46e37423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:922145 Change-Id: I4d98b40fcb0680e909e0dff9296aa17fd04d34c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795303Reviewed-by:
-
Wez authored
* Implement the fuchsia.web.Frame/SetUrlRequestRewriteRules API. * Add a mojo interface to provide the renderers with new rules. * This interface is implemented in the browser in UrlRequestRewriteRulesManager, which also takes care of validating and converting the rules from FIDL to Mojo, and providing them to the WebEngineURLLoaderThrottles in the browser. * In the renderer, there is one rules receiver per RenderFrame, implemented in UrlRequestRulesReceiver. They cache the rules and provide them to the WebEngineURLLoaderThrottles in the renderer. * Add unit tests and browser tests for the new API. Bug: 976975 Change-Id: I446ea4838d50e65c568e7e2cbcd32c23d64af426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659677 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
-
Yue Li authored
Generalize the board type check rule to match different sub-types of the board. Bug: b/140766051 Test: Manual Test Change-Id: Iecd194dbccb2f8b6ceb299632d301e6b58f1797e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794202Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
Brian Ho authored
This CL registers a few functions in the Vulkan binding generator script to be used for importing dma-bufs as VkImages [1] with the end goal of supporting WebGPU on Chrome OS. In particular, we add: - vkGetPhysicalDeviceImageFormatProperties2: allows us to query if the physical device supports importing dma-bufs into Vulkan via the VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT flag [2]. - vkGetMemoryFdPropertiesKHR: allows us to list the types of memory that our buffer backed by a dma-buf can be imported as. - vkGetImageMemoryRequirements2: allows us to list the types of memory supported by a given VkImage which can be compared to the output of vkGetMemoryFdPropertiesKHR to determine a suitable memory type for import. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1796049 [2] https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkExternalMemoryHandleTypeFlagBits.html BUG=996470 TEST=ran the script and used the newly bound functions Change-Id: I0f61e531009596d7237153f203084639e649afd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794142Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#695296}
-
Nate Fischer authored
No change to logic. This cleans up C++ includes, guided by the `cppclean` tool: * Changes some #includes to forward declarations * Moves some #includes from the .h to the .cc file * Deletes #includes which are no longer necessary * Add some #includes for <string> (not detected by cppclean) Also deletes a redundant definition for a constructor. Test: autoninja -C out/Default system_webview_apk Change-Id: I53bd5329c1e7116ecc4c50997501556ca6b08869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794275 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695295}
-
Mohit Bansal authored
This CL adds additional test for validating alt text retrieval for various scenarios. This CL makes use of a new test file which has a mix of text, images and links. Bug: 981448 Change-Id: Iae48b5111227c1729486fdf3fe67dba8aa364835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792414 Commit-Queue: Mohit Bansal <mohitb@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Xiyuan Xia authored
Fix ash_ui_perftests compile after https://crrev.com/c/1775390 Bug: 973483 Change-Id: Iaebaa8ffe341080f01f28a5e399cd0a4ebf7e673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795488Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695293}
-
Alexandre Frechette authored
Change-Id: I2af8368c4c85990b0a72407ef8be7233f26ddfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754105 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
-
Dale Curtis authored
Log in it's current position was logging status after we'd replaced the sink with a fake device. We need to log the status before we do that. BUG=986021 R=sandersd Change-Id: I27c588e5b5c0445b29d5f5034df0053e98c27a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796625 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695291}
-
Chris Blume authored
Previously, the SkiaRenderer GL bot was added with the restriction that it must find matching devices in the GPU pool. But the GPU pool did not include any Nexus 5Xs which could satisfy the SkiaRenderer GL bot's other requirements. This CL removes the GPU pool requirement for the SkiaRenderer GL bot. Bug: 969855 Change-Id: I69787e0415890c6e5755df6cfb3be99b4de92c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796642Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#695290}
-
David Tseng authored
Bug: 1001562 Change-Id: I0e0eb5ab1b04f20605946c525ea4abdea831c11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791439Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695289}
-
Dirk Pranke authored
This helps people figure out how to file bugs for stuff in that directory. Change-Id: I88cde6f209fcbd710a011b57df390a558bfdfca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795495Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695288}
-
Toni Barzic authored
Removes code that was used to scaled the app list main view on small screens (when apps grid did not fit into the available space). CL:1759856 changed approach to update the item sizes inside the apps grid instead. The following is thus no longer necessary: * AppsContainerView::GetMinimumSize() override - was used to calculate whether and what scale to use (the usage has been removed; not used during container layout * ContentsView::GetAppListMainViewScale() - the scale transform on the main view does not get set any longer, so the scale should always be 1 Change-Id: I2bcafd63b7e34c2c40167d365cfbe83b192f71e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789467Reviewed-by:Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695287}
-
Danan S authored
Previously we were using a private API to force the user to do a full Google signin after gellerization. Instead, we now use UserManager::SaveForceOnlineSignin, which is the public API for this purpose. Also reverts changes to signin_metrics enum from http://crrev.com/c/1786857 Bug: 1000948 Change-Id: I287bc86b1d719f11d0da0c6bb6ef09fcfd355987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789827Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695286}
-
Brian White authored
Adds expires_after attribute for 146 histograms that do not show any access in the past 120 days. Change-Id: I1c7e0fbe985dfd2c813f93d677e2d4fe2f58f038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796263 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL adds debug markers methods (pushDebugGroup, popDebugGroup, and insertDebugMarker) to GPUCommandEncoder. Bug: 877147 Change-Id: I19d13e2f2c61ab58bb0cb9b266e9ef69b285bbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732078Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#695284}
-
