- 26 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bcda22bca456..b5a297f389e0 git log bcda22bca456..b5a297f389e0 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 vapier@chromium.org unittests: use 0.1.2.3 for device IPs 2019-11-26 vapier@chromium.org osutils: WriteFile: add automatic encoding support 2019-11-26 vapier@chromium.org cros_build_lib: align CommandResult with subprocess.CompletedProcess 2019-11-26 vapier@chromium.org cros_build_lib: align RunCommandError with subprocess.CalledProcessError 2019-11-26 vapier@chromium.org auto_updater_unittest: rework mocks 2019-11-26 vapier@chromium.org flash_unittest: rework mocks 2019-11-26 engeg@google.com chromium: Trivial cros lint fixes 2019-11-26 vapier@chromium.org cbuildbot_launch: get unittests passing under Python 3 2019-11-26 vapier@chromium.org release_stages: fix channel pickling 2019-11-26 vapier@chromium.org failure_message_lib: tweak dict usage for Python 3 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 jacobraz@google.com flash_ap: integrate ap flashing with cros commands. 2019-11-26 vapier@chromium.org flash: fix encoding handling of files/programs 2019-11-26 vapier@chromium.org config: delete all Chrome PFQ related builders 2019-11-25 vapier@chromium.org cros_sdk: fix download under Python 3 2019-11-25 vapier@chromium.org cros_sdk_unittest: rework skipping logic for python3 2019-11-25 vapier@chromium.org wrapper: inrease min python version to 3.5 2019-11-25 vapier@chromium.org vm_test_stages_unittest: fix mock return 2019-11-25 manojgupta@google.com config_lib: Fix Lab name mapping for ARM64 boards. 2019-11-25 vapier@chromium.org signer_payloads_client_unittest: fix mock typo Created with: gclient setdep -r src/third_party/chromite@b5a297f389e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If9bd826fb2add1208170133ec6c0f836ac03bd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719212}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I8656ee4a72e3da131e0e1a31c799fd6b697c7e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#719211}
-
Kevin Ellis authored
PlayStateInternal is being phased out as it relies on an extended play state that includes a non-spec-compliant pending state. This patch cleans up the implementation of UnlimitedCurrentTimeInternal. The DCHECK code was previously used as a sanity check to ensure that an update to the timing calculations did not change the value of current time. This check is no longer being performed. The unlimited time may deviate from the current time for a finished animations since the hold time is not being used in the calculation when a start time is set and not paused. Bug: 960944 Change-Id: Ie8bd77b8cf770dc79fa65a08ed66c88fd6327c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933123 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719210}
-
Daniel Rubery authored
This change isolates the core code for deep scanning into its own directory, and adds an OWNERS file for that directory. Change-Id: Ia7c1c04fba88628aed6303382f29297aa9139eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925451 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719209}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1da43bc4..5a069fea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icabb70bea6250a52f82f98465c72edb03d6e1fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936987Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719208}
-
David Roger authored
This is minor cleanup, to make the code clearer or remove small bits of dead code. Change-Id: Ibf5e2253988c8a5638e69a6ae7e99af0d00a1e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932548 Commit-Queue: Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719207}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fdaba6cf16f3..68c657298074 git log fdaba6cf16f3..68c657298074 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 ivoc@webrtc.org Add a CreateNetEq method that takes an AudioDecoderFactory Created with: gclient setdep -r src/third_party/webrtc@68c657298074 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I751a9185cd2c48f129521f5a6538d59a6853d794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936896Reviewed-by:
-
Eric Robinson authored
This CL adds a metric to determine the priorities of frames seen during the life of the RenderProcessHost. This can be either no frames seen, mixed priorities, only low, or only normal. This metric will be useful in determining which hosts remain low priority over their lifetime. While it's not an exact metric (it doesn't measure time spent with mixed/low/normal), it is expected that most processes in architectures with site isolation will have only low or only normal priorities attached to them in their lifetime. We also plan on going back and adding a more in-depth metric in the future. Bug: 1026606 Change-Id: I252505cfc5424fef151e6cfd90ba437000cd2683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924689 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719205}
-
Vasilii Sukhanov authored
Bug: 1028095 Change-Id: I4f954414aa51f67f38185eca3df4595e0a8b77d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936255Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719204}
-
Monica Basta authored
The profile info cache relies now on the AccountFetcherService to fetch the account info as well the account image. The AccountFetcherService downloads the image on signin or every 24 hours. The profile info cache used to rely on the profile_downloader to download 256 image while the AccountFetcherService used to download 64 image. The AccountFetcherService currently downloads 256 images but for existing profiles there is a delay of 24 hours until the image of size 256 is downloaded. To eliviate this case, the GaiaInfoUpdateService will do the following: (1) If the image's size is equal to |kAccountInfoImageSize|, it means it is a newly downloaded image either for a new signin event or a 24 hour refresh, so we should save it to the profile info cache. (2) Else, it means it is an old image and should not override the existing one. Bug: 1028328 Change-Id: I2c77b2bf803b60aa98b46a80649697707e223005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936313Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719203}
-
John Abd-El-Malek authored
It keeps flaking, e.g. see https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97387 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97381 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97370 In the last 100 runs it has flaked 7 times. TBR=falken@chromium.org Bug: 868667 Change-Id: Ib0a809f85eb919ec098f7c80b8b47e2944e6a72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937127Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719202}
-
Christopher Cameron authored
Restructure how shims connect to be as follows * (the shim process connects and creates an AppShimHostBootstrap) * OnShimProcessConnected is called with the bootstrap, and then split to two paths * OnShimProcessConnectedForLaunch if we should open a new window * (e.g, user clicked on the icon) * Use the AppShimRegistry to create a list of windows to open * Potentially-asynchronously load the profiles, and then * OnShimProcessConnectedForLaunch will go through those profiles and create new app windows for them * If the app shim is an "old" shim that specified a profile, then only open the specified profile * OnShimProcessConnectedForRegisterOnly if not * (e.g, Chrome created an app window on its own and we're starting the shim to display it in its own process) * Search for an existing AppShimHost to connect to * Create one if needed only because tests want this (that cleanup can come later) * OnShimProcessConnectedAndAllLaunchesDone is then called by both of the above branches. This function will * If the above-branch found or created an AppShimHost, then connect the bootstrap to it * Otherwise, tell the bootstrap that it should quit. The big difference in structure here is how we load profiles. Prior to this change, we - Had OnShimProcessConnected asynchronously load the list of profiles for which the app is installed - Then selected one profile, send it to LoadProfileAndApp, and only attached the shim to that one profile. By contrast, we now - Read profiles from the AppShimRegistry - Load all profiles we may want to launch via a chain of calls to LoadProfileAndApp TBR=dominickn Bug: 1001213 Change-Id: I4b4355cc79606fc33a6de926af00bce48c086100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928016Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#719201}
-
Brian Salomon authored
Change-Id: I07d87ac4c414203a47d1d41ffdf7faefb6130711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935255 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Brian Osman <brianosman@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#719200}
-
Sorin Jianu authored
That means handling the network errors by primarily looking at net_error. Bug: 1028369 Change-Id: I8181bced25f8b56144ea336a03883d0dceea5108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935428Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719199}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1882203 https://chromium-review.googlesource.com/c/chromium/src/+/1898106 fixed the underlying issue and it should now be safe to land this. Original change's description: > [PM] Freeze Origin Trial - Remove the unknown state > > Most frames won't set a freeze origin trial policy and so making > kDefault the default state when a frame gets created will reduce the > number of IPC calls. This could cause pages to be frozen before all > their frames have reported their policy, a following CL will unfreeze > frozen pages that receive an opt-out OT token. > > Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708808} Change-Id: I15440c8f7d8f23584553f924ffc66051fc7cf713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933451Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#719198}
-
Andreas Haas authored
StaticBitmapImage returned 0 to indicate an invalid image size (e.g. integer overflow). This case was not handled properly by the caller. With this CL we add handling for the 0-case and throw an exception. R=jbroman@chromium.org Bug: chromium:1027522 Change-Id: I755ea7b3e9c50a73d20487397d9862f3ca67dd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932441 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719197}
-
Robert Sesek authored
Bug: 981129 Change-Id: I83d914dca778400f64fff340ea2872e8fbfe0834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929858Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719196}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/win/chrome_elf_init_unittest.cc This CL was uploaded by git cl split. Bug: 1018667 Change-Id: I4743155712ef4dc72ae9bde108f182d47eb5b60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917512Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719195}
-
Koji Ishii authored
Following bot results are included. 401 402 403 404 405 407 408 409 410 411 412 414 415 416 110 lines were removed and 31 lines were deflaked by consecutive results since 403. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I81036269ca37ea1a7534868c3173069e69c55ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932151Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719194}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: Id0ae7b02ba2d2ecd135331da5649d415033088b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936294Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719193}
-
Ted Choc authored
BUG=966272 Change-Id: I627f2137adb00a7acd312012d53d57050861426f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935288Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719192}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ce424670. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I499ccd850b9e9d1fb647280d5c902dfedd625173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936848Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719191}
-
Josh Karlin authored
Bug: 1028233, 1028232, 1028231, 1028228, 1028227, 1028224, 1028220, 1028230, 1028229, 1028226, 1028225, 1028222, 1028221 Change-Id: Iea73e6179477276931e93d8f94fd849827bbf7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936967 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
Charlie Harrison authored
Bug: 988723 Change-Id: I17c031b98f14fb7c76606fa03583d4027b005092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936887 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719189}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40a7dfc268b6..704d5408dbf0 git log 40a7dfc268b6..704d5408dbf0 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 michaelludwig@google.com Allow Tessellator to operate on provided GrQuads 2019-11-26 brianosman@google.com Copy SkottieUtils' classes into skresources Created with: gclient setdep -r src/third_party/skia@704d5408dbf0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I5acc3def5b8fc72e9445e9bdd0fb53b0e9fab826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936949Reviewed-by:
-
Owen Min authored
Bug: 1028336 Tbr: sky@chromium.org Change-Id: I8392785669999816732aab67f4bed7e02ba37989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935834Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719187}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. The Closure here was explicitly a RepeatingClosure in one place, but it really should be a OnceClosure. The closure is used to exit the RunLoop, which can't occur more than once. It is currently not used at all. R=jam@chromium.org Bug: 953861 Change-Id: I8a6b2a36b10c8fe523d163cf26fccaa8b155a319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934785Reviewed-by:
-
Brian Osman authored
This has recently been split out for reuse by other modules. Change-Id: I564189258d43365bb49b47b286f21c394055cfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935832Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#719185}
-
Albert Chaulk authored
Bug: 144861135 Test: None Change-Id: I0536d253e12cd3a2295ef667d3c8016f498b4ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936891Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#719184}
-
Yifan Luo authored
Bug: 995475 Change-Id: I2eba159d9a462bf29e3f3c944a57b70d19914040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903362 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719183}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=sky@chromium.org, dpranke Bug: 953861 Change-Id: Ie70184db86a0fa19af7b3f2de67867d46e23a523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934775 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719182}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. R=avi@chromium.org TBR=dpranke Bug: 953861 Change-Id: I324303b817f72ac38fa253609785565aec0c241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932667Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719181}
-
Yun Liu authored
Will ssh to bot if still nothing printed. Bug: 1027818 Change-Id: I98147da43689d2b4ea9db0ee8643312eac6fc72b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935860 Auto-Submit: Yun Liu <yliuyliu@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#719180}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ff260580c07e..6807a2568cda git log ff260580c07e..6807a2568cda --date=short --first-parent --format='%ad %ae %s' 2019-11-26 rharrison@google.com Rolling 5 dependencies (#908) Created with: gclient setdep -r src/third_party/shaderc/src@6807a2568cda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I6b00cd5a0d92c8e32d1dd376bc6a5a742bae154f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936950Reviewed-by:
-
John Abd-El-Malek authored
This reverts commit a6b47782. Reason for revert: some of the reenabled tests are flaking, see https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel?limit=100 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9718 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9717 Original change's description: > Explicitly shut down LoginDisplayHost in OOBEConfigurationTests > > It should remove flakiness upon shutdown. > > Bug: 997685 > Change-Id: I7258be4a2be53e6e42e9fc0cebc23bd0d78d6fad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934342 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719139} TBR=antrim@chromium.org,rsorokin@chromium.org Change-Id: I047b469ed5df1b5d181349e9a34ec5306ddac8c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937128Reviewed-by:
-
danakj authored
R=bokan@chromium.org Bug: 954011, 1028284 Change-Id: I852b389c12b5bb96cbe2bdef52516b546fe6fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934651Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719177}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01adcafce0bf..b71b5729688e Created with: gclient setdep -r src-internal@b71b5729688e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1021528 Tbr: jbudorick@google.com Change-Id: I773b2380db8a20ab3d306c8cba6bf223d7e16071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936948Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719176}
-
Nektarios Paisios authored
TableView would fire a focus event every time the active row or column changed, e.g. every time an NVDA user would use the arrow keys to navigate around the view. However, Task Manager updates its displayed information very frequently and so by the time NVDA would process the focus changed event, the AXVirtualView object corresponding to the focused item would no longer be available. Task Manager marks every item as changed every time it refreshes its display, thereby causing the corresponding AXVirtualView object to be destroyed and re-created. To work around this issue, we delay firing the focus changed event after OnPaint. R=dmazzoni@chromium.org, sky@chromium.org Bug: 811277 Change-Id: I941cda49fefdc5becdbd7baf8f2cca26104d1aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930061Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719175}
-
Dominic Battre authored
Note that this is just reusing a string that already exists for Android and Desktop. This is not a new string. Bug: 1028095 Change-Id: Ie9e1fecfd17dfffc2626032e6667667033588b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936771 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719174}
-
David Roger authored
This feature has been enabled by default for some time and is no longer needed. Change-Id: I6b0ce810f3177114cf3575866713014411c06982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932901Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719173}
-
