- 17 Mar, 2020 40 commits
-
-
Kevin Marshall authored
Adds a class which accumulates a buffer of user events, which are timestamped strings recorded with the base::RecordAction() API. The buffer will periodically be drained and sent over FIDL IPC (not in scope for this CL). Bug: 1060768 Change-Id: Ieb235654e030eef81eefd963ae614ce68b72dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103393 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#751081}
-
Mike Wittman authored
Removes the dependency on support for native modules in ModuleCache to run V8UnwinderTest.CanUnwindFrom_OtherModule. Fuchsia and Android ARM64 do not have native module support yet. Bug: 1035855 Change-Id: Ib3e29aa72d183029babad57e790ddc8c0f419d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106489Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751080}
-
John Lee authored
https://i.imgur.com/iep45bz.png Fixed: 1035675 Change-Id: Ic73a425a68b5e7275df29f347592715880d39259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106348Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751079}
-
Robert Ogden authored
With the pending rollouts of some features that use the client config, we should enable everybody to fetch it by default, but leave a kill switch. Bug: 1048736 Change-Id: I6f88289173425551c10a0fa44dcc144570a2618b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107561Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#751078}
-
Sinan Sahin authored
NPE was caused by a line in ToolbarManager where mCanAnimateNativeBrowserControls was used before being set. The fix is to check if null. Also, it might make sense to update the if statement where the feature is checked to make sure we return early if ChromeFeatureList isn't initialized. Otherwise, we end up running feature specific code if CFL isn't initialized. Bug: 1062302 Change-Id: Ieac75c96d285f5768321c6d8425fda4511d0fa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107701 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751077}
-
Brian White authored
Bug: 1056622 Change-Id: Idd256e94b179137500bf732289c6992e150d6d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106561 Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#751076}
-
Ted Meyer authored
and media: :Status::IsOk() => media::Status::is_ok() media: :Status::Ok() => media::OkStatus() Change-Id: I94d09a860513e0c3efb54da392e56d3035dfddee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106740Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e73d36798847..80517cb9ee4c git log e73d36798847..80517cb9ee4c --date=short --first-parent --format='%ad %ae %s' 2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.resourceMapping 2020-03-17 tvanderlippe@chromium.org Fix command menu items for snippets Created with: gclient setdep -r src/third_party/devtools-frontend/src@80517cb9ee4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058320,chromium:1060565 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4daced7f414fed57dd0c7a81a215775c374d60bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751074}
-
Jarryd Goodman authored
Bumps expiry from M82 to M85, as the change is only being wrapped up now. Change-Id: Ic381576f33569d1ce5cd3eb8b33997afcb8942cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062884Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c3c88819af7..f297c2cef4e4 Created with: gclient setdep -r src-internal@f297c2cef4e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053735 Tbr: jbudorick@google.com Change-Id: Ia8c973bc63ced1bef4e5ebfe93f9e61451f3def1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107420Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751072}
-
Juanmi Huertas authored
Refactors the GetOrCreateResourceProvider of OffscreenCanvas simplifying the logic and removing AcceleratedResourceUsage. Also removes the usage parameter an metric capture, as in next CLs this usage will be completely removed. Part of a big refactor for CanvasResourceProvider. Bug: 1035589 Change-Id: Icd46f812d312f56454205c6f23f70c72e6e44d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103080 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751071}
-
Nate Fischer authored
These were fixed by SafeBrowsingCommittedInterstitials, which is on by default since M82. We no longer need to skip these tests. Fixed: 1006953 Test: N/A Change-Id: I0d7659c055fa9c51e93dc0a82bccff7a0b4fcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107683 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751070}
-
chrome://sync-confirmationDemetrios Papadopoulos authored
- Extract ui into a <sync-disabled-confirmation-app> element and migrate to Polymer 3 (similar to <sync-confirmation-app>). - Use SyncConfirmationBrowserProxy instead of making direct chrome.send() calls. - Delete remaining code from sync_disabled_confirmation.js, and use identical code in sync_confirmation.js Bug: 1012533 Change-Id: I142090cf297a288e807b4ddf9346ac4c9d3d742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101860 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751069}
-
Maks Orlovich authored
This is mostly to get clarity on what this should be doing before I change how parsing of client hints and communication from browser works, though it's not really dependent. Change-Id: I04e8b403a6aeae544d2616688a39c65c0e60b5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083449 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751068}
-
Chris Harrelson authored
This is a follow-on to [1]. In addition to the added unittest, this fixes a failure in a test [2] when trying to land [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2092698 [2] http/tests/lazyload/image-subpixel-position.html [3] https://chromium-review.googlesource.com/c/chromium/src/+/2103708 Bug: 992765 Change-Id: I32b28ff0ab4cd4f9f527c6601413a16d2a1d703c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106418Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751067}
-
Livvie Lin authored
UX proposal: https://docs.google.com/document/d/19iu3ISlOw9L_PCpOh8LB4TSKC8uBPzSBiEnkZm4IiQI/edit#heading=h.qyrxas7ncbc9 Design doc: go/context-menu-unelide-dd Bug: 1061576 Change-Id: I3627f0090112378f6df8bbaf274b40c35024a7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103291 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#751066}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..2aa80df14528 git log 440fc9959f06..2aa80df14528 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations. Created with: gclient setdep -r src/third_party/swiftshader@2aa80df14528 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I20a9dc345b0d0f5a5bad04ac21e53d3aa1c66ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107328Reviewed-by:
-
danakj authored
For LocalFrames that are in a Page owned by a WebView, each LocalFrame has a WebLocalFrameImpl which has a WebFrameWidget. This is always present except very early during initialization which most code can ignore. For LocalFrames in non-ordinary Pages, which live without a WebView (such as WebPagePopupImpl, devtools agent, unit tests) the LocalFrame has an EmptyLocalFrameClient instead of WebLocalFrameImpl and thus there are no WebFrameWidgets. Currently parts of core/ can not get to the WebFrameWidget because WebLocalFrameImpl is banned due to the layering mess being unresolved. It is also difficult to find the path there as going from LocalFrame requires: WebLocalFrameImpl::FromFrame(local_frame)->LocalRootFrameWidget() Since the conversion to WebLocalFrameImpl isn't a member of LocalFrame it's very hard to find and remember this path! We introduce here a well-lit road from LocalFrame to its WebFrameWidget and use it throughout ChromeClientImpl. While updating ChromeClientImpl we note that it was early-outting on WebViewImpl::does_composite() due to a null WebWidgetClient which it is no longer using, as it defers to the WebFrameWidget. Since ChromeClient means we have a WebView, we also know that WebFrameWidget does exist, and it is a better place to early out. So these are moved. This change will allow my display-mode CL for 1060336 to find the WebFrameWidget from code in core/css/ without changing blink layering more dramatically. And it is a long time coming to make this path clearer. R=dtapuska@chromium.org Bug: 1060336, 844547, 1058633 Change-Id: Iabb71ebf0c5ebaf7daea924425c9d3a3a2c23d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101847Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#751064}
-
Adam Langley authored
r745162 adds a v1 event in FidoCableDiscovery::OnStartDiscoverySession, but it's recorded unconditionally. With caBLE v2, there might not be v1 data in play. Change-Id: Ie0aa18f10137f028c4ef06f2ee8d00fc5a19490b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107424 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#751063}
-
Koji Ishii authored
This patch modifies the snap-to-pixel behavior implemented in r736251 <crrev.com/c/2024133>. The CL changed to snap the top of the padding box of the parent box to match legacy and |NGPaintFragment| behavior. It did so even for culled inline boxes too, but this part was not compatible. This patch changes the logic to ignore culled inline boxes for the snap-to-pixel behavior, matching legacy and |NGPaintFragment|. Bug: 982194 Change-Id: I667f35d4b55909505502633b2d7e70b058191c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106044 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751062}
-
Lily Chen authored
Bug: 1061664 Change-Id: I577aedb7e78d5ad2b8359254f8af1fc384410f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107439 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#751061}
-
Daniel Murphy authored
R=pwnall@chromium.org TBR: pwnall@chromium.org Change-Id: I3e66ad4dbfdc66e4f54192ee81c275bb54848a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107576Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#751060}
-
Anders Hartvoll Ruud authored
Blink currently disables the native appearance of a widget if the author specifies a border or background that's _different_ from the border/background as specified by the UA. This comparison between author and UA border/background is problematic, because it means we can toggle native appearance of widgets in the wild just by tweaking the UA style. Moreover, it leads to behavior that's hard to predict, as Blink may behave in different ways depending on the platform. Therefore, it was suggested to instead disable the native appearance if the author specifies _any_ border/background property, i.e. no comparison with the UA style. This matches Firefox' current behavior, but deviates from Safari (which is doing what Blink currently does). We currently have two code-paths for style resolution: CSSCascade (runtime feature enabled for 'stable'), and the old path. This CL affects the CSSCascade path only, since it's likely not worth it to implement this new behavior in old path (the plan is anyway to remove it). For the CSSCascade path, the comparison between author border/background and UA border/background was implemented by adding -internal-ua-* "companion" properties which held the values provided by the UA. (E.g. -internal-ua-background-color would hold the "as styled by UA"-value, and background-color would be the normal "as styled by author"). After the entire cascade was computed, the -internal-ua-* properties would be compared with the corresponding normal properties, and we would set the HasAuthorBackground/Border flags based on this. This CL now reverts all that, and instead simply checks if the cascaded values for background/border properties have kAuthor origin. I2S: https://mail.google.com/mail/u/2/#inbox/QgrcJHrtrSkDJhRHmWSHHJQSVjGTFHNHsSq Bug: 1061846 Change-Id: I2e543460fb28bcac81410c6a14891be90d6b1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970312Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#751059}
-
Samuel Huang authored
Previously print_python_deps.py only works for Python 2 target modules (specified with the --root switch). This CL makes the script detect the Python version of the target module (via shebang), and relaunch using the matching vpython version. Bug: 1054018 Change-Id: Iadf0df313fe098ee03c23b212dad928697be79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106967 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751058}
-
Ioana Pandele authored
This change adds a custom toggle to the accessory sheet to be displayed by the passwords accessory sheet when password saving is disabled for the current website. A custom toggle is needed because the view needs to display a title as well as a subtitle that indicates whether the toggle is on or off and the toggle needs to be vertically centered in the view. The SwitchView is set to be unclickable so that the parent view handles the click and the tap animates properly. The background is set to null so that there is no ripple effect on the thumb of toggle. This is consistent to the appearance of ChromeSwitchPreference. Bug: 1044930 Change-Id: I6ba5fdf8b70c117729fc0163f0ca62408a6e59d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095119Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#751057}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ib16193b5bab4aa6d5b807d067843f67670bf87e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087984 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751056}
-
Mansi Awasthi authored
This CL adds GetAccessibilityTextFieldInfo() for fetching text field information from PDFiumEngine using AccessibilityTextFieldInfo struct. GetAccessibilityTextFieldInfo() is called from within GetAccessibilityInfo() to populate PrivateAccessibilityTextFieldInfo. The CL also includes corresponding unit test. Bug: 1030242 Change-Id: Iafab8645f42c3720482f7e180d94587380f58de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084671 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751055}
-
Brian White authored
Bug: 1056622 Change-Id: I44509d2df9d16eb3b804cdb0f2c60a4e8a206921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107601 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Jesse Schettler authored
Update the description of the arc-print-spooler-experiment flag to reflect that it is no longer restricted to the Canary and Dev channels. Bug: b:151731767 Change-Id: Ia550b913422e6b84225c754948552e647558f5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107419Reviewed-by:
-
Kai Ninomiya authored
Reduces the typical ("median") number of flakes per webgpu_blink_web_tests run from about 5-10 to 0. Bug: 1058176, 953991 Change-Id: Ibf0c169be5a0bb2a123b04893369808542a2390d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099523Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#751052}
-
Colin Blundell authored
This CL takes a prepapatory step to WebLayer sharing Chrome's ExternalNavigationHandler for launching external intents by creating and populating the ExternalNavigationParams struct that gets passed to the former class. I adapted the building of ExternalNavigationParams in //chrome's InterceptNavigationDelegateImpl.java:buildExternalNavigationParams() to //weblayer, leaving notes in the code where we might need to refine the calculation of some arguments over time. This CL also changes //weblayer's ExternalNavigationHandler to take in the params just so that the constructed object is used. There is no behavioral change. Bug: 1031465 Change-Id: If7135fcbfc9d369f2683208fde12725925156736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100974Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#751051}
-
Tibor Goldschwendt authored
The fakebox is an NTP search input field that forwards focus and pastes to the omnibox. It's merely an affordance on the NTP to redirect the user to the omnibox, which implements the actual search and suggestions UX. This CL adds a fakebox to the WebUI NTP similar to the existing fakebox on the local NTP. See crbug/1061073 for how the WebUI NTP fakebox looks like. Bug: 1061073 Change-Id: Ic84bbe45867baeb2040b4981ca2d5be4ee1709d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101299 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#751050}
-
Avery Musbach authored
The present CL adds a user action for entering multi-display split view, and a histogram for time spent in multi-display split view. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.MultiDisplaySplitViewMetrics/0 Bug: 1059477 Change-Id: I6e6bdfc1a13038c854f811b9165eb514a888e645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101382 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751049}
-
Dan Harrington authored
Now surfaces can be added to FeedStream. These surfaces receive updates when the model changes. Also removed FeedStreamBackground, as we're not going to need it. This was originally primarily going to handle storage, but storage will provide an async API. Bug: 2090767 Change-Id: I043f3e7dc10a4fd3a1c983bd0fb47f2f0b04e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102590Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#751048}
-
Friedrich Horschig authored
With this CL, sync users will see a link to the account checkup unless they use a custom passphrase. Screenshots in the linked bug. Bug: 1062253 Change-Id: Ib31676dab5457192edcc131f23775462a115c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106090Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 110188fb. With Chromium commits locally applied on WPT: acbe6d96 "Add timeouts for EventWatchers on CSS animation tests" 6a942cea "[WPT/upgrade-insecure-requests] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1048 and retry the command." 1bb259bc "[WPT/referrer-policy] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 8469 and retry the command." 168319dc "[WPT/mixed-content] Merge multiple subtests into one file warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1397 and retry the command." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I963c1a5524908415565ef3887535bdcd2b863d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106319Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751046}
-
Jarryd Goodman authored
Update the copy on the warning about being signed out of sites. Bug: 1062281 Change-Id: I2af8362ab3f002451e6f3e14349ed1ec575af18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106460Reviewed-by:
-
Milica Selakovic authored
Tests were left out in https://chromium-review.googlesource.com/c/chromium/src/+/2080233 so they are added in this CL. Bug: 1053522 Change-Id: I9b166cfc4084a4627c7c65973ae4dd3dc6445da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106189 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#751044}
-
Caleb Rouleau authored
R=rmhasan@google.com NOTRY=true Bug: 1062104 Change-Id: Ibc2dd5b4d952d5ab13b8027e820047ebfff37cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106558Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#751043}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95e01a220bc7..469205e1adaf git log 95e01a220bc7..469205e1adaf --date=short --first-parent --format='%ad %ae %s' 2020-03-17 titovartem@webrtc.org Roll in third_party/turbine 2020-03-17 danilchap@webrtc.org Disable libaom decoder by default Created with: gclient setdep -r src/third_party/webrtc@469205e1adaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I632af5f56bf26f2845b47ebe38b2909cd670d17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107414Reviewed-by:
-
