GitLab

This is follow up cleanup after renaming NavigationHandle::IsSamePage to
NavigationHandle::IsSameDocument in this CL:
https://codereview.chromium.org/2716493004/

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742923002
Cr-Commit-Position: refs/heads/master@{#456231}

cros-disks's Unmount method now ignores the "force" option (CL:388592,
chromium:646224). This CL updates CrosDisksClient to stop passing the
"force" option when invoking the Unmount method.

BUG=700548
TEST=chromos_unittests

Review-Url: https://codereview.chromium.org/2743113003
Cr-Commit-Position: refs/heads/master@{#456230}

Added missing files.

BUG=none
R=jochen@chromium.org, thakis@chromium.org

Review-Url: https://codereview.chromium.org/2747483002
Cr-Commit-Position: refs/heads/master@{#456229}

This makes it easier/cleaner to implement CoreOobeView::Delegate on ScreenManager in a follow-up CL.

BUG=672142

Review-Url: https://codereview.chromium.org/2739073002
Cr-Commit-Position: refs/heads/master@{#456228}

This uses auto convert script to convert content instrumentation tests to JUnit4,
assisted with some manual clean up. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2708243004
Cr-Commit-Position: refs/heads/master@{#456227}

Building with VS 2017 using a packaged toolchain is not yet supported
but if you try to do it you get a surprising result - the VS 2013
toolchain gets downloaded. This adds a 2013 check to avoid this, and
also simplifies/corrects an existing 2017 check and comment.

This lets us fail-fast if a user tries the VS 2017 depot-tools
combination before it is supported.

BUG=683729

Review-Url: https://codereview.chromium.org/2741783006
Cr-Commit-Position: refs/heads/master@{#456226}

CUPS provides cupsGetJobs2 but it doesn't provide the necessary fields
to report status accurately.  Notably, it doesn't provide
job-impressions-completed or printer-state-reasons both of which are
necessary to differentiate errors.

BUG=684853

Review-Url: https://codereview.chromium.org/2691093006
Cr-Commit-Position: refs/heads/master@{#456225}

This CL fixes an issue where Chrome would display a banner saying that it
was not the default browser when it actually was.

The cause of this was 'xdg-settings check default-web-browser
google-chrome.desktop' returning 'no' when Chrome might have been the
default (see further explanation in the CL comments).

BUG=578888
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2737283002
Cr-Commit-Position: refs/heads/master@{#456224}

BUG=699287
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742103002
Cr-Commit-Position: refs/heads/master@{#456223}

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`

Review-Url: https://codereview.chromium.org/2538883003
Cr-Commit-Position: refs/heads/master@{#456222}

See bug for details of regression.

This reverts commit be0cfa14 which was:

Make Crashpad start asynchronous, and move back to chrome_elf

Crashpad initialization has been reworked to support an asynchronous
mode where StartHandler() only calls CreateThread() and does not
synchronize with that thread, making it safe to use in DllMain().

So, we can now move it back into chrome_elf to catch earlier crashes.

We block much later now in browser startup, before a renderer (i.e.
another client that would connect to the handler) will be started. This
should not be strictly necessary, but is slightly more conservative as a
first pass. This allows for error reporting, and prevents log spew from
each renderer that starts up and tries to connect to a nonexistent
handler. Also added is a UMA timer to see how long we're blocking
startup for by joining with the background thread.

TBR=mark@chromium.org, thestig@chromium.org, grt@chromium.org
BUG=700371

Review-Url: https://codereview.chromium.org/2743923003
Cr-Commit-Position: refs/heads/master@{#456221}

BUG=674667

Review-Url: https://codereview.chromium.org/2734963002
Cr-Commit-Position: refs/heads/master@{#456220}

This change emits a UKM PageLoad metric for the EffectiveConnectionType
observed at navigation start.

This change also corrects an issue where we logged some information in
OnStart. When OnStart is invoked, we don't yet know if we're observing
a page load, so we move all logging to later in the flow, when we know
we're observing a page load.

BUG=700537

Review-Url: https://codereview.chromium.org/2740403002
Cr-Commit-Position: refs/heads/master@{#456219}

BUG=675285

Review-Url: https://codereview.chromium.org/2745893002
Cr-Commit-Position: refs/heads/master@{#456218}

Update waterfall testing config for AutofillCreditCardDropdownVariations

BUG=

Review-Url: https://codereview.chromium.org/2741043002
Cr-Commit-Position: refs/heads/master@{#456217}

This change adds two bluetooth checks. 1 is to determine if the hardware has bluetooth capabilities. 2 is to determine if bluetooth is on for the device. Both conditions must be met for the PhysicalWebSharing feature to be enabled.

BUG=685856

Review-Url: https://codereview.chromium.org/2737393003
Cr-Commit-Position: refs/heads/master@{#456216}

https://pdfium.googlesource.com/pdfium.git/+log/6791295a4e8c..e472622d33bd

$ git log 6791295a4..e472622d3 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 npm Bound cbox from tricky faces

Created with:
  roll-dep src/third_party/pdfium
BUG=699961

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2741783005
Cr-Commit-Position: refs/heads/master@{#456215}

BUG=632580

Review-Url: https://codereview.chromium.org/2744593005
Cr-Commit-Position: refs/heads/master@{#456214}

This CL removes a mutable reference to ResourceRequest in the argument
of ResourceFetcher::determineRequestContext(),
to reduce mutableResourceRequest() call.

BUG=632580

Review-Url: https://codereview.chromium.org/2742933002
Cr-Commit-Position: refs/heads/master@{#456213}

The argument for OnCheckExtensionsResult should only contain the bad
extensions, but PVer4 code was including all CRXs (blacklisted or not).

BUG=700145

Review-Url: https://codereview.chromium.org/2742913002
Cr-Commit-Position: refs/heads/master@{#456212}

This CL tries to update the last access time for a download item correctly.
The download items have several clients and the access does not go through
a common code path. One option is to look at the file system's last access
time (atime in Unix) and update it from a non-UI thread task. However, it
was found that the last access time is not updated or at best lazily updated
by most of the POSIX systems in case of a file read. So the other approach
is to update the last access time manually whenever the file is opened
through chrome. NTP, download infobar, duplicate download infobar,
download home and download notification are the entry points where
we fire an intent to open the downloaded file. To find the download
item, we need a GUID and the correct profile which was passed correctly
to the appropriate call sites.

BUG=689981

Review-Url: https://codereview.chromium.org/2737723002
Cr-Commit-Position: refs/heads/master@{#456211}

TBR=pdr@chromium.org
BUG=700530

Review-Url: https://codereview.chromium.org/2740843005
Cr-Commit-Position: refs/heads/master@{#456210}

BUG=700057

Review-Url: https://codereview.chromium.org/2743633005
Cr-Commit-Position: refs/heads/master@{#456209}

It is common that FooResource::fetch()-like functions sets
the request context via mutableResourceRequest().
This CL centralizes such mutableResourceRequest() calls into newly
introduced FetchRequest::setRequestContext(), to limit the ways to
modify a ResourceRequest after it is put in a FetchRequest.

BUG=632580

Review-Url: https://codereview.chromium.org/2741753003
Cr-Commit-Position: refs/heads/master@{#456208}

BUG=700499

Review-Url: https://codereview.chromium.org/2742643004
Cr-Commit-Position: refs/heads/master@{#456207}

https://skia.googlesource.com/skia.git/+log/8da9e9407211..e393a629491e

$ git log 8da9e9407..e393a6294 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 reed disable assert until I can understand why it fails in cc_unittests
2017-03-10 jvanverth Add new test cases for Android shadow sample.
2017-03-10 brianosman Revert "Treat cross context images as Ganesh-created resources"
2017-03-10 bungeman Fix SkFILEStream.
2017-03-10 reed Check for bad bounds in picture cullbounds
2017-03-10 brianosman Treat cross context images as Ganesh-created resources
2017-03-10 benjaminwagner Rename GalaxyS7 to include model number.
2017-03-10 fmalita Revert "Revert "Hold sk_sp<GrAtlasTextBlob> refs in GrTextBlobCache instead of raw ptrs""
2017-03-10 fmalita Fix SkTHashTable dangling values
2017-03-10 reed re-guard against negative dimensions on no-draw canvas

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: Ic80781b6bb184afa2f6862488cd5574314f6f0e0
Reviewed-on: https://chromium-review.googlesource.com/452673Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#456206}

Review-Url: https://codereview.chromium.org/2744783002
Cr-Commit-Position: refs/heads/master@{#456205}

In the AudioDestination construction process, WebAudioDevice can start
the thread even before m_fifo is ready. This may result a crash when
render() method is called by AudioDeviceThread.

This CL implements a speculative fix of the incorrect order of
initialization.

BUG=692423
TEST=(none)

Review-Url: https://codereview.chromium.org/2740103005
Cr-Commit-Position: refs/heads/master@{#456204}

This has specialized logic that the current OWNERs should have
to look at when new changes land (for now).

BUG=None

Review-Url: https://codereview.chromium.org/2736403007
Cr-Commit-Position: refs/heads/master@{#456203}

Allows cc::ResourcePool to re-use larger resources to fulfill a smaller
request. This avoids expensive allocations, and is especially useful in
cases where layer sizes are changing due to animation.

Also extends the timeout for resource expiration from 1s to 5s, which
will also cut down on resource allocations.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2726263003
Cr-Commit-Position: refs/heads/master@{#456202}

Dynamic inflation of the progress bar caused it's color to be
incorrect on incognito tabs. This change modifies the ToolbarTablet
to set the appropriate color whenever the tab's model changes.

BUG=698715

Review-Url: https://codereview.chromium.org/2742573006
Cr-Commit-Position: refs/heads/master@{#456201}

BUG=

Review-Url: https://codereview.chromium.org/2743773003
Cr-Commit-Position: refs/heads/master@{#456200}

When we run integration tests, we need accounts with a clean slate.
This CL clears out the data on sync servers for the given test account,
and restarts sync. This operation doesn't require read/writing any data
to the account, and thus passphrase decryption is by-passed (Some tests
have the side-effect of setting a decryption passphrase that requires
clear server data to be run without decryption).

R=pavely@chromium.org,skym@chromium.org

TEST=run this command
ninja -C out/Debug sync_integration_tests -j 200 && \
xvfb-run --server-args="-screen 0 1920x1080x24" \
out/Debug/sync_integration_tests \
--gtest_also_run_disabled_tests \
--gtest_filter=*E2ETest* \
--sync-url=https://clients4.google.com/chrome-sync/dev \
--sync-user-for-test=testuser@gmail.com\
--sync-password-for-test=testpassword
--vmodule=*sync*=1

BUG=

Review-Url: https://codereview.chromium.org/2716413003
Cr-Commit-Position: refs/heads/master@{#456199}

No new code, just shuffling things around so WebKit/Source/modules
and content/browser have a more related structure, also in terms
of bug components and OWNERS.

BUG=none  (no new code)

Review-Url: https://codereview.chromium.org/2745583005
Cr-Commit-Position: refs/heads/master@{#456198}

BUG=700060
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2741853005
Cr-Commit-Position: refs/heads/master@{#456197}

chfremer@ has been very active on this area. Adding more active chrome devs
would be beneficial while tommi@ stays as webrtc owner.

https://paste.googleplex.com/4940035765829632

Review-Url: https://codereview.chromium.org/2739303004
Cr-Commit-Position: refs/heads/master@{#456196}

The ASan runtime recently changed to print slice information in
stacks (https://reviews.llvm.org/D27390). The last clang roll included
that change.

The upstream asan_symbolize script was changed to be able to understand
slice information in https://reviews.llvm.org/rL291280. We need to
merge in that change to make symbolizing asan stacks work again on Mac.

This roll brings in the following changes:
https://reviews.llvm.org/rL294450
https://reviews.llvm.org/rL294303
https://reviews.llvm.org/rL291280
https://reviews.llvm.org/rL256578
https://reviews.llvm.org/rL251356
https://reviews.llvm.org/rL248962
https://reviews.llvm.org/rL247642
https://reviews.llvm.org/rL231492

BUG=686113,699062

Review-Url: https://codereview.chromium.org/2739213005
Cr-Commit-Position: refs/heads/master@{#456195}

BUG=700117
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2748443003
Cr-Commit-Position: refs/heads/master@{#456194}

- Drag now works again.
- Ensure the nested run loop gets torn down on errors.
- Adds logs of dvlogs for debugging when needed.
- Moves registration of aura components to //ui/aura/.

BUG=699235,665077

Review-Url: https://codereview.chromium.org/2739213003
Cr-Commit-Position: refs/heads/master@{#456193}

MojoTestConnection is responsible for creating the inter-process mojo pipes.
These must be set on the command line for the child processes running individual
test cases.

It is also responsible for bringing up services. This however was being done at
test enqueuing time. When the remote service was brought down at the end of the
first test case, all registered services were having their pipes close. Thus
preventing subsequent tests from connecting.

This change moves the service registration until the child process is being
connected. This actually occurs after the previous test has completed.

mash.browser_tests.filter has also been updated to include more tests which are
passing locally. This way we get expanded coverage on the bots.

TEST=BrowserTests
BUG=678687

Review-Url: https://codereview.chromium.org/2737353003
Cr-Commit-Position: refs/heads/master@{#456192}