GitLab

This is a reland of r275819 https://codereview.chromium.org/317253003 but without compiling it on Android.

TBR=scottmg

Review URL: https://codereview.chromium.org/338493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276816 0039d316-1c4b-4281-b951-d872f2087c98

False start should not disable the session cache, but if we never process the
server Finished message, the session cannot be resumed.

BUG=none

Review URL: https://codereview.chromium.org/301283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276815 0039d316-1c4b-4281-b951-d872f2087c98

The BookmarkEntity class always represents a Bookmark, so there's no
reason to have a ModelType param as part of its constructor.

BUG=NONE

Review URL: https://codereview.chromium.org/319823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276814 0039d316-1c4b-4281-b951-d872f2087c98

Add hide/show functions for the callout widgets on the panel manager, and use
them from WindowSelectorPanels to control them.

BUG=377775
TEST=WindowSelectorTest.WindowOverviewHidesCalloutWidgets

Review URL: https://codereview.chromium.org/327873005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276813 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276810 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176012:176039&mode=html
TBR=yhirano@chromium.org,dpranke@chromium.org
BUG=

Review URL: https://codereview.chromium.org/328403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276809 0039d316-1c4b-4281-b951-d872f2087c98

Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX.

In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win).  The current change achieves this and should provide a way to gauge the effect of timer coalescing.

An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing.

Local performance tests didn't uncover any regressions from this change.

BUG=356804

Review URL: https://codereview.chromium.org/331513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276808 0039d316-1c4b-4281-b951-d872f2087c98

Add shadows to the windows in overview mode. The shadows are destroyed when
going out of overview mode.

BUG=376353
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/335673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276807 0039d316-1c4b-4281-b951-d872f2087c98

(This makes mojo_shell_tests not hang.)

R=sky@chromium.org

Review URL: https://codereview.chromium.org/336483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276806 0039d316-1c4b-4281-b951-d872f2087c98

mathp since he's a chromium veteran and wrote/knows the code

BUG=

Review URL: https://codereview.chromium.org/336493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276805 0039d316-1c4b-4281-b951-d872f2087c98

When synchronizing page scale values between trees, setting the page scale
factor and deltas seperately means that the observer functions called when
the page scale factor was changed get called with a transient, incorrect
total page scale factor. This CL combines the seperate methods for updating
the page scale factor and page scale delta into one and updated tree
synchronizations to use this new one-shot function. The old methods remain
but call into the newly added method.

BUG=366249

Review URL: https://codereview.chromium.org/315003009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276804 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this patch the server would not notify the client of a new
root if the client already knew about the root. Now it always
notifies.

Here's an example of this case: two nodes, A and B with B a child of
A and A the root for the client. If B is added as a root then
previously I would not send B in OnRootsAdded. Now I do.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/323413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276803 0039d316-1c4b-4281-b951-d872f2087c98

I'd like to simplify the OpenResource implementation for the Non-SFI case. I
think that this can all stop using the trusted plugin now; this change makes
the ManifestResolveKey method easier to use from within
ppb_nacl_private_impl.cc.

BUG=239656

Review URL: https://codereview.chromium.org/329593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276802 0039d316-1c4b-4281-b951-d872f2087c98

This flag will be used to make the builds determinist, e.g. in place like this one: https://code.google.com/p/chromium/codesearch#chromium/src/base/build_time.h&l=15

BUG=314403

Review URL: https://codereview.chromium.org/324403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276801 0039d316-1c4b-4281-b951-d872f2087c98

The ConnectionFactory::ConnectionListener gets informed of connection events,
including the actual ip endpoint with which a connection was established. This
will eventually be hooked up to app handlers to allow services to act on
connection changes. For now it just allows the debug page to more accurately
reflect the connection state.

BUG=377882

Review URL: https://codereview.chromium.org/317723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276800 0039d316-1c4b-4281-b951-d872f2087c98

This function made unnecessary use of the render
target and didn't walk its clipping ancestor
chain correctly. This CL refactors the function
and fixes that walk (and adds test to show that
the walk is correct).


R=danakj@chromium.org

Review URL: https://codereview.chromium.org/328753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276799 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383089
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/335673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276797 0039d316-1c4b-4281-b951-d872f2087c98

The AutocompleteActionPredictor cancels prerenders in its destructor, so the
cancel and app terminating signals are likely racing. Disable the final status
check as it's not relevant to this test.

BUG=368721

Review URL: https://codereview.chromium.org/334553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276796 0039d316-1c4b-4281-b951-d872f2087c98

Known caveat:
- Since GCM on Android only supports a single registration per native
  app, only a single web app can register at once, and even then only
  if they pass --disable-sync-gcm-in-order-to-try-push-api on the command
  line which disables Chrome Sync etc from receiving GCM messages.

Depends on https://codereview.chromium.org/316963003/

BUG=350384

Review URL: https://codereview.chromium.org/314293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276795 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/333773002/)

Reason for revert:
Sorry for the inconvenience, but this patch broke compile of http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/5358

Original issue's description:
> Revert of Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/328383003/)
> 
> Reason for revert:
> browser_tests failures were caused by another CL:
> http://src.chromium.org/viewvc/chrome?revision=276656&view=revision
> 
> This build which included revert of 276656 is green.
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30917
> 
> Reverting revert.
> 
> Original issue's description:
> > Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/)
> > 
> > Reason for revert:
> > Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916
> > 
> > Original issue's description:
> > > Introduce SessionManager that will contain code to start user session on Chrome OS
> > > 
> > > Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init
> > > related code from LoginUtils to SessionManager. LoginUtils will temporarily implement
> > > SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface.
> > > SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n).
> > > 
> > > LoginUtils::OnPrepareProfile() is split into
> > > StartSession()
> > > --PreStartSession() - things like switching logging dest
> > > --CreateUserSession() - will eventually create UserSession instance
> > > --StartCrosSession() - notify cros::SessionManager
> > > --NotifyUserLoggedIn() - UserManager::UserLoggedIn()
> > > --PrepareProfile()
> > > 
> > > PrepareProfile() - calls PM::CreateProfileAsync()
> > > --OnProfileCreated()
> > > ----InitProfilePreferences() - early initialization
> > > ----UserProfileInitialized()
> > > ------transfer signin profile auth date (cookies/proxy auth/certs)
> > > ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession()
> > > ----FinalizePrepareProfile(()
> > > ------Own TPM (if it didn't happen for some reason)
> > > ------Notify SAML offline signin limiter
> > > ------Notify ProfileImpl
> > > ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> > > ------InitRLZ (for primary user)
> > >   
> > > 
> > > Minor cleanup
> > > * Unify DemoApp profile initialization flow with regular one
> > > * Don't pass display_email to LoginUtils::PrepareProfile
> > > * Move powerwash related prefs registration to ResetScreenHandler
> > > * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences()
> > > 
> > > BUG=370175,276163
> > > 
> > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626
> > 
> > TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=370175,276163
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276760
> 
> TBR=antrim@chromium.org,bauerb@chromium.org,rouslan@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=370175,276163
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276783

TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370175,276163

Review URL: https://codereview.chromium.org/336693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276794 0039d316-1c4b-4281-b951-d872f2087c98

That call is only available since API level 17.

BUG=380210
NOTRY=True

Review URL: https://codereview.chromium.org/334773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276793 0039d316-1c4b-4281-b951-d872f2087c98

Add plumbing for registration from push service-agnostic content layer
to GCMDriver in chrome layer.

To achieve this, GCMProfileService owns an implementation of a new
PushMessagingService class, which can be used from the content layer.

Based on mvanouwerkerk's prototype in https://codereview.chromium.org/186023002, but significantly refactored.

BUG=350384
TBR=benm@chromium.org

Review URL: https://codereview.chromium.org/317823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276792 0039d316-1c4b-4281-b951-d872f2087c98

This reduces redundant state calculations.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/333713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276791 0039d316-1c4b-4281-b951-d872f2087c98

This is simply the result of running 'make' in the doc
directory.

R=binji@chromium.org, binji

Review URL: https://codereview.chromium.org/332903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276789 0039d316-1c4b-4281-b951-d872f2087c98

At runtime, the classloader will look for classes in both apk's dex
files. In the standard Android build system, an instrumentation test
apk's dex file does not include the classes included in the tested apk's
dex file.

To do this, when dexing, write a file listing the inputs to the dex
file. When dexing for an instrumentation apk, exclude those files listed
as inputs of the tested apk's dex file.

For proguarded apks, this exclusion will need to happen for proguard
inputs instead of dex inputs, so this change does not cover that case.

BUG=272790
NOTRY=true

Review URL: https://codereview.chromium.org/313273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276788 0039d316-1c4b-4281-b951-d872f2087c98

This silences a line of log spew that's generated on every launch of a local
debug build.

BUG=none
TEST=less log spew
R=rsesek@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/333493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276787 0039d316-1c4b-4281-b951-d872f2087c98

converted to use the new ActionRunner API.

BUG=361809

Review URL: https://codereview.chromium.org/321253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276786 0039d316-1c4b-4281-b951-d872f2087c98

We used to always recorded with LCD ON and if needed disabled it with an
SkFilter during rasterization. This is wasteful on platforms where LCD
text is always disabled. This patch records SkPicture with correct
setting. One downside to this approach is that we would need to
invalidate and record anytime the LCD text setting changes. But since
this can only happen once for a layer (all future changes are ignored),
this is not going to be a big performance issue.

On the positive side, this patch will simplify a lot of things on the
rasterization front - no SkDrawFilter, or LCD text tile versions, or
a special rasterization mode for disable LCD.

BUG=368513

Review URL: https://codereview.chromium.org/315393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276785 0039d316-1c4b-4281-b951-d872f2087c98

Appears to have broken
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/5246

  src/tools/android/adb_profile_chrome/main.py: Has executable bit but
  not shebang or ELF header.

Please add the shebang and reland. Sorry for the inconvenience.

> Move adb_profile_chrome under tools/android/
>
> Move adb_profile_chrome from build/android/ to tools/android/ to make
> its purpose clearer.
>
> BUG=375754
> TEST=tools/android/adb_profile_chrome/run_tests
>
> Review URL: https://codereview.chromium.org/310413003

TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/330713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276784 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/328383003/)

Reason for revert:
browser_tests failures were caused by another CL:
http://src.chromium.org/viewvc/chrome?revision=276656&view=revision

This build which included revert of 276656 is green.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30917

Reverting revert.

Original issue's description:
> Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/)
> 
> Reason for revert:
> Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916
> 
> Original issue's description:
> > Introduce SessionManager that will contain code to start user session on Chrome OS
> > 
> > Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init
> > related code from LoginUtils to SessionManager. LoginUtils will temporarily implement
> > SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface.
> > SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n).
> > 
> > LoginUtils::OnPrepareProfile() is split into
> > StartSession()
> > --PreStartSession() - things like switching logging dest
> > --CreateUserSession() - will eventually create UserSession instance
> > --StartCrosSession() - notify cros::SessionManager
> > --NotifyUserLoggedIn() - UserManager::UserLoggedIn()
> > --PrepareProfile()
> > 
> > PrepareProfile() - calls PM::CreateProfileAsync()
> > --OnProfileCreated()
> > ----InitProfilePreferences() - early initialization
> > ----UserProfileInitialized()
> > ------transfer signin profile auth date (cookies/proxy auth/certs)
> > ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession()
> > ----FinalizePrepareProfile(()
> > ------Own TPM (if it didn't happen for some reason)
> > ------Notify SAML offline signin limiter
> > ------Notify ProfileImpl
> > ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> > ------InitRLZ (for primary user)
> >   
> > 
> > Minor cleanup
> > * Unify DemoApp profile initialization flow with regular one
> > * Don't pass display_email to LoginUtils::PrepareProfile
> > * Move powerwash related prefs registration to ResetScreenHandler
> > * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences()
> > 
> > BUG=370175,276163
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626
> 
> TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=370175,276163
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276760

TBR=antrim@chromium.org,bauerb@chromium.org,rouslan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370175,276163

Review URL: https://codereview.chromium.org/333773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276783 0039d316-1c4b-4281-b951-d872f2087c98

The original change contained a use-after-free bug. This was caused by window crossfade animation during maximizing, combined with input event processing. The crossfade would take the current layer and delete it. However the next input event to the window tree would attempt to access the now deleted layer.

Original Code Review: https://codereview.chromium.org/271913002/
Revert Review: https://codereview.chromium.org/309973002/

Revert "Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/)"
This reverts commit 8863218a.

TBR=jamescook@chromium.org
TEST=FrameCaptionButtonContainerViewTest.AnimationUpdatesLayerTree
BUG=363717

Review URL: https://codereview.chromium.org/316693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276782 0039d316-1c4b-4281-b951-d872f2087c98

When a touch-move event is 'held', i.e. it is not dispatched, the event does
produce any gesture events. However, once this 'held' event is dispatched
(either because a touch-release event was encountered, or because
ReleasePointerMoves() was called on the dispatcher), it should be used to
generate the appropriate gesture events.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/332703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/337543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276780 0039d316-1c4b-4281-b951-d872f2087c98

    
Move adb_profile_chrome from build/android/ to tools/android/ to make
its purpose clearer.
    
BUG=375754
TEST=tools/android/adb_profile_chrome/run_tests

Review URL: https://codereview.chromium.org/310413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45650
TEST=none
NOTRY=true

Review URL: https://codereview.chromium.org/336613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383272

Review URL: https://codereview.chromium.org/329073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true
R=msw

Review URL: https://codereview.chromium.org/324983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328382

Review URL: https://codereview.chromium.org/319703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276775 0039d316-1c4b-4281-b951-d872f2087c98

Still not hooked up and not quite everything compiles but this should be the bulk of the functionality.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/328313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276774 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/336633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276773 0039d316-1c4b-4281-b951-d872f2087c98