Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Apr, 2020 33 commits
  3. 19 Apr, 2020 7 commits
    • Daniel Libby's avatar
      Revert "Reland "Add support for drawImageRect-based directly composited images"" · 9c1d371f
      Daniel Libby authored 
      This reverts commit 0de4d371.

Reason for revert: Need to sort through memory regressions on the
perfbots - see crbug.com/1071564

Original change's description:
> Reland "Add support for drawImageRect-based directly composited images"
>
> Reland now that M83 has forked. Also adjust DCHECK in
> picture_layer_impl.cc. crbug.com/1063358 points out that even if the
> aspect ratio matches, we can still end up with a scaled tile that does not
> exactly match the layer's bounds because of the raster scale adjustments
> that kick in inside RecalculateRasterScales when the desired scale is
> adjusted based on the ideal scale.
>
> > Original change's description:
> > > Add support for drawImageRect-based directly composited images
> > >
> > > Directly composited images is a feature that rasterizes images at their
> > > intrinsic size, when an image is the only thing drawn into a layer.
> > > However, this determination is today made prior to painting the image
> > > in blink, which can't be done with CompositeAfterPaint enabled.
> > >
> > > This CL adds support for detecting PictureLayers that qualify as directly
> > > composited images, by analyzing the paint ops of the display item list.
> > > If a single drawImageRect paint op is detected (with some facilities for
> > > detecting images for which orientation is respected), then we'll
> > > propagate the image's intrinsic size over to PictureLayerImpl on commit.
> > > PictureLayerImpl then uses that information to calculate a raster scale
> > > that results in the image being rasterized at its intrinsic size.
> > >
> > > There are a few additional changes needed outside that core calculation.
> > > If the aspect ratio of the layer bounds does not match the image's
> > > aspect ratio, we won't raster the image at the intrinsic size, but
> > > instead will choose the scale from one dimension. In these cases, we will
> > > choose to re-raster when the layer is resized until the layer bounds
> > > aspect ratio matches that of the image.
> > > If we do adjust the raster scale and add tilings to the active tree
> > > (as is seen in the default configuration for web_tests), we should drop
> > > the previous tilings (which are now non-ideal) since the max raster scale
> > > tile will be chosen when the SharedQuadState is created during
> > > AppendQuads.
> > > We also need to tell the LayerImpl if nearest neighbor should be used
> > > when the TileDrawQuad is scaled in the display compositor to preserve
> > > the same output of the original drawImageRect.
> > >
> > > Bug: 875110
> > >
> > > Change-Id: I2cda143f483c2aa30a6ae1fb850e1c7ef1227882
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036542
> > > Reviewed-by: vmpstr <vmpstr@chromium.org>
> > > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > > Commit-Queue: Daniel Libby <dlibby@microsoft.com>
> > > Cr-Commit-Position: refs/heads/master@{#751891}
>
> TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 875110
> Change-Id: I485e939ba08575a3e2af5a821558e54ce6132cc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144398
> Reviewed-by: Daniel Libby <dlibby@microsoft.com>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Daniel Libby <dlibby@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#758935}

TBR=vmpstr@chromium.org,pdr@chromium.org,dlibby@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 875110, 1071564
Change-Id: Id418d813962bd56145361f26b4e42552815fb033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156071Reviewed-by: default avatarDaniel Libby <dlibby@microsoft.com>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#760367}
      9c1d371f
    • John Chen's avatar
      [ChromeDriver] Fix release notes handling · 00d94fb5
      John Chen authored 
      The release script was recently modified to change to a temp dir
as its working directory, and that caused it to look for notes.txt
in the wrong location. This CL fixes it.

Change-Id: Ib0d0abe2689a5bc80c4e6079e5cde2588f5b7a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155202Reviewed-by: default avatarWenbin Zhang <wenbinzhang@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760366}
      00d94fb5
    • Chromium WPT Sync's avatar
      Import wpt@2f0a0b106cd4e5476df43530b16161005f66845b · dde6f4e4
      Chromium WPT Sync authored 
      Using wpt-import in Chromium 879e9aa2.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
86131ac4 "Add a test for ReplaceTrack that verifies video track content."
6c8523d2 "[scroll-timeline] Implement element-based scroll offset"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Icdc5be30cb668bba3daeba13d3d3e0e5618fa03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156012Reviewed-by: default avatarWPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#760365}
      dde6f4e4
    • Wez's avatar
      [fuchsia] Enable toolkit_views in Fuchsia builds. · e13bf58c
      Wez authored 
      Enabling |toolkit_views| in all Fuchsia builds ensures that Views can be
built under Fuchsia, which will be required when we start wanting to add
UX e.g. to mitigate use of web permissions.

Enabling Views to be compiled in advance of that requirement is a trade-
off between overhead maintaining the Views/Fuchsia configuration while
it is unused, and cost of making it work on Fuchsia in future. Since the
vast majority of Views is cross-platform, the maintenance overhead
should be relatively small.

Also remove unused //build/args/fuchsia.gn.

Change-Id: I24b534e2bf8f005db76a0a612fa4fa57ac1b1e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056951Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarMichael Spang <spang@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760364}
      e13bf58c
    • David Tseng's avatar
      Ensure AccessibilityManager::ChromeVoxDeferredLoader's warmup utterance targets Googletts · 4fe3a6a4
      David Tseng authored 
      This fixes an issue where on user accounts with other tts extensions installed, we always get back a reply by waiting for Googletts voices, and targeting Googletts with our warmup utterance.
Without this change, it's possible chromeVoxDeferredLoader waits forever if the engine never sends an event.

TBR=dmazzoni@chromium.org

Test: all flows including login, guest, regular sessions. In each case, with ChromeVox previously loaded, and without ChromeVox previously loaded (i.e. automatically started on session start).
Change-Id: I7abe9556bbd00a432a969f38343e0e8c1f24e94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156065Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760363}
      4fe3a6a4
    • Yuzu Saijo's avatar
      [bfcache] Add browsertest for printing and bfcache integration · e8ab8653
      Yuzu Saijo authored 
      This CL adds a browsertest to make sure that when printing feature is
used on a page, the page is not cached in BackForwardCache.

This is because we currently do not close the popup caused by printing
properly for bfcache. Blocklisting the feature is the first step, and
supporting it is the next step.

Bug: 106849
Change-Id: Ie8195ae88f94d967aed915422099c6e208b67c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148706
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760362}
      e8ab8653
    • Javier Ernesto Flores Robles's avatar
      [iOS][MF] Add @try to -executeFormAssistAction: · c3ddb228
      Javier Ernesto Flores Robles authored 
      Sometimes an exception is thrown by the system when trying to execute one
of the input form accessory actions. This catches the exception to avoid
the crash and continue.

Bug: 942445
Change-Id: Ia3a127cf3ce6e41eba63c62034d574aa296ea952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144159Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760361}
      c3ddb228