GitLab

- Remove |options| set.
- Remove InitializeFrom* methods.
- Remove unused SetChannelFlags method.

BUG=577816

Review-Url: https://codereview.chromium.org/2621923002
Cr-Commit-Position: refs/heads/master@{#442870}

A method that checks if files of deleted profiles still exist was added in http://crrev.com/2546523003. We decided that it is ok to call NukeProfileFromDisk without checking if the files still exist because it fails silently. But we also show a log message that says that there are still files. This cl adds a condition to check if profile files still exist to avoid showing the wrong log message.

BUG=236244

Review-Url: https://codereview.chromium.org/2622853002
Cr-Commit-Position: refs/heads/master@{#442869}

BUG=577816

Review-Url: https://codereview.chromium.org/2622883002
Cr-Commit-Position: refs/heads/master@{#442868}

R=yhirano@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2625573003
Cr-Commit-Position: refs/heads/master@{#442867}

Introduce a mechanism for an incoming QuicAllowed cloud policy
to control QUIC protocol usage for new streams even after
IOThread initialization.
NetPrefObserver has been re-introduced to observe the change
(after it was removed in crrev.com/2140733002 and
crrev.com/2172543003).

BUG=658454
TEST=browser_tests --gtest_filter=*QuicAllowed*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2546533003
Cr-Commit-Position: refs/heads/master@{#442866}

This flag can be removed because all policy test servers provide
verification signatures.

BUG=275291

Review-Url: https://codereview.chromium.org/2606423002
Cr-Commit-Position: refs/heads/master@{#442865}

Otherwise, the painting will not take into consideration the new
value.

BUG=677903

Review-Url: https://codereview.chromium.org/2616343004
Cr-Commit-Position: refs/heads/master@{#442864}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627453003
Cr-Commit-Position: refs/heads/master@{#442863}

BUG=554298

Review-Url: https://codereview.chromium.org/2625903003
Cr-Commit-Position: refs/heads/master@{#442862}

https://chromium.googlesource.com/chromium/src/+/c5291a0115a65

BUG=588060
TBR=joone.hur@intel.com

Review-Url: https://codereview.chromium.org/2628823002 .
Cr-Commit-Position: refs/heads/master@{#442861}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyOffsetPosition from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIOffsetPosition.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIOffsetPosition.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIOffsetPosition.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613863002
Cr-Commit-Position: refs/heads/master@{#442860}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2627633002
Cr-Commit-Position: refs/heads/master@{#442859}

BUG=671585
TEST=download tgz file, and confirm that double-clicking the tgz file shows suggestions about extensions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2553003003
Cr-Commit-Position: refs/heads/master@{#442858}

BUG=678688, 680007, 680008

Review-Url: https://codereview.chromium.org/2623853002
Cr-Commit-Position: refs/heads/master@{#442857}

Stop loading destroys the pending entry which leads to a crash in release.
Remove the call to stop.

BUG=679721

Review-Url: https://codereview.chromium.org/2623583005
Cr-Commit-Position: refs/heads/master@{#442856}

In HTMLAnchorElement::attributeChanged,

    params.name != hrefAttr && isLink()

should have been

    params.name != hrefAttr || isLink()

This CL fixes it, and improves code readability.

BUG=679669

Review-Url: https://codereview.chromium.org/2623163002
Cr-Commit-Position: refs/heads/master@{#442855}

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2628753002
Cr-Commit-Position: refs/heads/master@{#442854}

BUG=670455

Review-Url: https://codereview.chromium.org/2624763002
Cr-Commit-Position: refs/heads/master@{#442853}

Override location of machine-local policy directory for both unit tests
and browser tests. This makes sure that any policy data the machine has
does not affect the test results.

BUG=630614

Review-Url: https://codereview.chromium.org/2612733003
Cr-Commit-Position: refs/heads/master@{#442852}

1) Make title row is 1dp bigger and text shifted down 2dp.
2) Make bottom row (tiles of icons) 1dp bigger.

BUG=663199
TEST=Verfied on local build.

Review-Url: https://codereview.chromium.org/2592583002
Cr-Commit-Position: refs/heads/master@{#442851}

This CL creates the Suggestions UI with a Collection View.

BUG=679369

Review-Url: https://codereview.chromium.org/2619353004
Cr-Commit-Position: refs/heads/master@{#442850}

Before this, the method existed on NewTabPageManager, but was never
actually called.

BUG=yeah

Review-Url: https://codereview.chromium.org/2613863007
Cr-Commit-Position: refs/heads/master@{#442849}

BUG=673904
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2619233005
Cr-Commit-Position: refs/heads/master@{#442848}

BUG=679349

Review-Url: https://codereview.chromium.org/2627663002
Cr-Commit-Position: refs/heads/master@{#442847}

Supports V8<Type>Partial::preparePrototypeAndInterfaceObject.

BUG=

Review-Url: https://codereview.chromium.org/2620013002
Cr-Commit-Position: refs/heads/master@{#442846}

FetchRequest is a parameter object for calling
ResourceFetcher::requestResource(). Its usage should be limited to
requestResource(), it's callers and ResourceFetcher's methods directly
called by requestResource() (this is already enforced by annotating
FetchRequest with STACK_ALLOCATED).

Logic in FrameFetchContext should be limited to what we cannot put in
ResourceFetcher for dependency reason. It's better passing what's only
needed.

BUG=671533
R=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2555713002
Cr-Commit-Position: refs/heads/master@{#442845}

AutocompleteActionPredictor::StartPrerendering actively destroys the existing
prerender when a new one is created, even if the new one is a duplicate.

Thus, when there is a duplicate prerender, PrerenderManager::AddPrerender
must return a handle to it, and not null. That way it increases the
reference count on the prerender and prevents it from being destroyed.

This can be done by simply changing the ordering of the existing code.

BUG=679714

Review-Url: https://codereview.chromium.org/2622893002
Cr-Commit-Position: refs/heads/master@{#442844}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/026b76327c0c..94bbb858ca38

$ git log 026b76327..94bbb858c --date=short --no-merges --format='%ad %ae %s'
2017-01-10 dschuff Set bot names back to precise for trybots

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2623173002
Cr-Commit-Position: refs/heads/master@{#442843}

We rAF until the property has changed, instead of using setTimeout.

BUG=248938

Review-Url: https://codereview.chromium.org/2621853002
Cr-Commit-Position: refs/heads/master@{#442842}

This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file.

NOEXPORT=true
BUG=676491

Review-Url: https://codereview.chromium.org/2619163005
Cr-Commit-Position: refs/heads/master@{#442841}

This is the second try to fix a performance regression of menulist rendering.
The first try [1] didn't have major improvement. This CL reverts it, and cache
another value.

[1] crrev.com/438496

BUG=673754

Review-Url: https://codereview.chromium.org/2600873002
Cr-Commit-Position: refs/heads/master@{#442840}

We now wait for the end event instead of using setTimeout.

BUG=248938

Review-Url: https://codereview.chromium.org/2618293002
Cr-Commit-Position: refs/heads/master@{#442839}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyFontVariationSettings from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIFontVariationSettings.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIFontVariationSettings.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIFontVariationSettings.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2613723003
Cr-Commit-Position: refs/heads/master@{#442838}

This patch converts following tests to utilize
w3c test harness with |assert_selection()| to ease of maintenance for improving
code health('=>' means move/renaming):
LayoutTests/editing/selection/4947387.html =>
  LayoutTests/editing/selection/modify_move/move-by-paragraph.html

LayoutTests/editing/selection/after-line-wrap.html =>
  LayoutTests/editing/selection/modify_move/move-forward-after-line-break.html

LayoutTests/editing/selection/click-left-of-rtl-wrapping-text.html =>
 LayoutTests/editing/selection/mouse/click-left-of-rtl-wrapping-text.html

This is preparation to remove default styles on contenteditable containers.
See crbug.com/427135.

BUG=427135,679977

Review-Url: https://codereview.chromium.org/2525273002
Cr-Commit-Position: refs/heads/master@{#442837}

This CL copies from |VisibleSelection::showTreeForThis()| and renames
 following "base" and "extend".

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2533693002
Cr-Commit-Position: refs/heads/master@{#442836}

In VideoDecodeAcceleratorParamTest.TestSimpleDecode there are many ASSERT_xx
while testing, which aborts test and doesn't delete GLRenderingVDAClient in
GetRenderingTaskRunner.

1. For thumbnail test, in fact it doesn't need ASSERT for MD5 missing, wrong
format, or comparison failure since it won't break any other things. Change to
EXPECT_xx and LOG(ERROR).

2. Delete GLRenderingVDAClient in VideoDecodeAcceleratorParamTest::TearDown().
When ASSERT happens it aborts test immediately and call TearDown(), so we can
make sure GLRenderingVDAClient is deleted.

BUG=654677
TEST=test debug version of video_decode_accelerator_unittest on Elm
1. For thumbnail test, try to not push md5 file and the test will fail and end
gracefully. Add an invalid entry in md5 and the test will pass with error
messages.
2. Try to make assertion in any place inside TEST_P. Test will fail and end
gracefully.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2596193005
Cr-Commit-Position: refs/heads/master@{#442835}

BUG=680050
TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2625083002 .
Cr-Commit-Position: refs/heads/master@{#442834}

BUG=680043
TBR=mikhail.pozdnyakov@intel.com

Review-Url: https://codereview.chromium.org/2622183003 .
Cr-Commit-Position: refs/heads/master@{#442833}

Something in this range broke the Mac builder:
https://chromium.googlesource.com/chromium/src/+log/c6e4c6f1f9865b5a77d2cc4eb8c7104b632624f1%5E..1a7740c44a6c4d03423c4b5ff7d746e1a1b7363e?pretty=fuller

r442828 is the most obvious candidate which may have affected builds.

BUG=679607
TBR=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2626993002 .
Cr-Commit-Position: refs/heads/master@{#442832}

https://skia.googlesource.com/skia.git/+log/fb00390b46b3..db52cf3b040d

$ git log fb00390b4..db52cf3b0 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 reed move SkDraw.h to core

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2620283003
Cr-Commit-Position: refs/heads/master@{#442831}