- 29 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d95366028fd0..48a6bcf4f11e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:996088 Tbr: olka@google.com Change-Id: I80a37bd094435985ce9871079d84af023c8e9c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222302Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773103}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14aed087..a869b729 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ac1a40260e7cccdd9b39fb04277f35997d2a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218394Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773102}
-
Sergey Ulanov authored
Now webgl-antialiasing-mode and webgl-msaa-sample-count can be specified in WebEngine config. This will allow to control MSAA support when using WebGL. Bug: 766360 Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773101}
-
Matthias Körber authored
Change-Id: I3147cce49be27f644aec762e48f1c1793d73f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220008Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#773100}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93a9381c76d8..399b81d2743f 2020-05-29 rharrison@chromium.org Add standalone tint gclient config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ife9ea05c6ff94eace191fc9fa5ece35cbf47fabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222303Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773099}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c24dc8f24368..fcef4e406f7d 2020-05-29 bmeurer@chromium.org [sources] Make editor location mapping more robust. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1056632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34eb7e59ff0c855995a8c6d2f910052a0fb6b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222305Reviewed-by:
-
Christopher Cameron authored
Add methods to create a SharedImageRepresentationOverlay for IOSurfaces. This is based on the GLImage, so common-ize the GLImage lifetime across all (now 3) callers. Bug: 894929 Change-Id: Iac2e629a9e2d05089ee72889e42255b75a6fe51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222220Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773097}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I59742d38cf9e8f1bed6745b5195e20451d23c29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222304Reviewed-by:
-
Victor Hugo Vianna Silva authored
With the addition of new fields to the PasswordUiEntry type over time, this helper function (used to create mock data for tests) was modified to set default values to these fields, since they were not relevant for most tests. Once deduplication happens in passwords_section though, only duplicates will be allowed to share the value of frontendId, which is problematic. In order to avoid having several optional parameters in an fixed order, this CL changes the signature to receive them in a key/value manner. When no frontendId is passed, it assumes the value of the id. This allows tests that do not care about duplicate entries to simply set the id value. Besides that, the CL also touches existing tests that did not set id values (which was inconsistent with the production code anyway). This will allow adding the deduplication functionality in crrev.com/c/2219503 without touching these tests, but rather focusing on adding tests for the new behavior. Bug: 1049141 Change-Id: If773b2684eda844dc025fea6255288215cd66bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218055 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#773095}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/295a4177aebc..e4f8e19e72e9 2020-05-29 cwallez@chromium.org Remove the defaulting for bytesPerRow = 0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ieadc653a6d85b527692dfa7337fdc4c90779245a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222301Reviewed-by:
-
Fredrik Söderqvist authored
Since SVGTransformListTearOff::consolidate() is the business logic of this method, we can implement the specific logic there rather than in SVGTransformList. With that also drop the IsEmpty() check from it return the resulting AffineTransform instead of using an out- variable. SVGTransformList: :Concatenate() - leaving that to the callers - and have Change-Id: I25c80f7ae222f48fafecccd876a2cd79d57004e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218021Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#773093}
-
Richard Knoll authored
This hooks up the NearbyProcessManager to the NearbySharingServiceImpl that will manage which profile is enabled for Nearby via some user action and UI. Bug: 1084576 Change-Id: I1290044115e247a03cc95a6cbcb3587e2bc69f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218114Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#773092}
-
Yoshifumi Inoue authored
Utilize selection_test() in editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html This patch changes "modify-by-lineboundary-in-inline-editable-contexts.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Iec04294c7960073945badcbfff1afa43beffdac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220412 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773091}
-
Henrique Ferreiro authored
Replace the validity of a blink::WebDragData object with the usage of base::Optional. This CL removes WebDragData::valid_, and Initialize(), IsNull() and Reset() methods. Bug: 1039255 Change-Id: Ieca195ab87bbf28f574959e0f5418941a8b80d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216074Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#773090}
-
chrome://safe-browsingJun Kokatsu authored
This change removes innerHTML usage in chrome://safe-browsing so that it'll be compatible with Trusted Types. Bug: 41905 Change-Id: I06ba1bf4d1bfd7cdf2b0769678fdb5daf02390c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212627 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#773089}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dd9feece3750..52014ab2d7f2 2020-05-29 dberris@chromium.org experiment: Explore E-Divisive with Jupyter 2020-05-29 dberris@chromium.org auto-triage: Tidy up issue filing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1086639 Tbr: rmhasan@google.com Change-Id: Ic21f593854553ecfdc548060a6f567ce2a0bfe5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222135Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eb9831d2211c..c24dc8f24368 2020-05-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a6d3f50ce77f25fc7bb535f1091dbccba827205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222132Reviewed-by:
-
Dominic Mazzoni authored
The goal is to make it easier to read, and also easier to see which attributes are being computed based on each accessibility mode. Bug: none Change-Id: Ic62a7db94d1e6383dabc1e5e0b7fa4ef78ce6e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220713 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773086}
-
Olga Sharonova authored
This reverts commit 3984e14d. Reason for revert: CrostiniManagerRestartTest.RestartMultipleThenUninstall crashing on https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg first failure https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18909 crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878996586056266096/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniManagerRestartTest.RestartMultipleThenUninstall__status_CRASH_/0 Original change's description: > Refactor crostini use CrostiniId rather than vm_name, container_name > > Refactor only change. > > Change places where vm_name and container_name are being used in a > function to use ContainerId, and particularly ContainerId::GetDefault. > > TBR=haraken@chromium.org > > Bug: 846190 > Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Julian Watson <juwa@google.com> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773035} TBR=haraken@chromium.org,joelhockey@chromium.org,juwa@google.com Change-Id: I8bc3d9e68df869fc19c04381d4d013fe6ef4f7b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218313Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#773085}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Id65b80afd9334e1e6f60dbed6701eae8f75436f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222133 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#773084}
-
Fredrik Söderqvist authored
This abstraction has no uses, so fold its single function into its single user. Rename the argument to make it clear that it is a tear-off type. Also call Target() only once on the tear-off item (since it has side- effects). Change-Id: Ife6a14cbfe85f2ebe17dab9d6d29b0ffba933ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218172Reviewed-by:
-
Makoto Shimazu authored
This reverts commit c9b650e1. Reason for revert: https://crbug.com/1087751 Original change's description: > Reland "Roll ICU to 67.1" > > This reverts commit d90baa9e. > > Reason for revert: reland ICU67.1 after #if 0 the problematic new code > > Fix in 630b884f84d > > Original change's description: > > Revert "Roll ICU to 67.1 f2223961" > > > > This reverts commit db2cb995. > > > > Reason for revert: caused 30ms startup performance regression on Windows > > > > Original change's description: > > > Roll ICU to 67.1 f2223961 > > > > > > ICU 67.1 release notes: http://site.icu-project.org/download/67 > > > ICU 66.1 release notes: http://site.icu-project.org/download/66 > > > CLDR 37: release notes: http://blog.unicode.org/2020/04/unicode-locale-data-v37-released_23.html > > > > > > 1. Update to 67-1 > > > Diary https://docs.google.com/document/d/1ZDtSPa3ZkzBIJmqrDVmGmyrTihjx8Me4fKQoQcBj02E/edit# > > > > > > Size changes: > > > 65-1 . 67-1 > > > 7786368 7778704 android/icudtl.dat > > > 6412768 6400752 android_small/icudtl.dat > > > 1418320 1430976 android_small/icudtl_extra.dat > > > 5060880 5048912 cast/icudtl.dat > > > 10481632 10470736 chromeos/icudtl.dat > > > 10506736 10498032 common/icudtb.dat > > > 10506736 10498032 common/icudtl.dat > > > 900576 . 898416 flutter/icudtl.dat > > > 6375984 6363968 ios/icudtl.dat > > > > > > > > > Bug: 1064326, 827538 > > > Change-Id: I169e1f99514b36cafd54a6bc8a9914ccf222d008 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > > Commit-Queue: Frank Tang <ftang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#764138} > > > > TBR=machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1064326, 827538, 1080367 > > Change-Id: I98ebe6e01631b10ecc1955ac9d3bc53be11e23c6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209232 > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#771137} > > TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1064326, 827538, 1080367 > Change-Id: I6d255bac08a68d6716ac51d84765acc010c6a10d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220363 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773036} TBR=wittman@chromium.org,machenbach@chromium.org,kojii@chromium.org,jshin@chromium.org,ftang@chromium.org Change-Id: I62514ad0a6c270f8099e4a473e31f93d3ee7619a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064326, 827538, 1080367, 1087751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217839Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773082}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09841a6eaf28..d95366028fd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: Iccd1e2374cc9a64ca2d1e465f20d1fd7426213e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220902Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5729680.html" to utilize |selection_test()| and renames to "delete_range_before_space.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ifb10e35390c66f6d82c207a35d90d0324fa8d3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220109 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL adds |-internal-space-around| keyword to |text-align| CSS property. It is used for the default value of ruby annotation boxes and ruby base boxes. We assumed |start|, the initial value of text-align, in ComputedStyle had a special effect for ruby annotation and ruby base, and we made a variant of kJustify internally. The code was complicated, and introducing |-internal-space-around| simplifies the code. This CL has a small behavior change: - If text-align:start is specified to <rt>, we ignored it before this CL and applied the 'space-around' behavior. After this CL, we apply text-align:start behavior in that case. * LayoutRubyRun.cc ComputedStyle for LayoutRubyBase was sometimes overwritten by LayoutObject::PropagateStyleToAnonymousChildren(), and the TextAlign value was reset to kStart. Uses UpdateAnonymousChildStyle() to keep the expected TextAlign value. * insert-paragraph-into-table-expected.txt |style="text-align: -internal-space-around;"|, which is unable to parse, appears. This will be fixed when we implement ruby-align CSS property. Bug: 1069817 Change-Id: Iecc1e999d11b58dd4d950f3579310546f5db7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217673 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#773079}
-
Thomas Lukaszewicz authored
Bug: 459423 Change-Id: I33d21c8e23f1544f8ad68a9f58db57a5a3ce1874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216634 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773078}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d311f594622..93a9381c76d8 2020-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic9a59ccca2dc48c57d1ca540da8c1707028fee92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222131Reviewed-by:
-
Yunke Zhou authored
Make ALT+V a toggle (instead of only switch on) for the system info on the login screen Bug: 1081689 Change-Id: I7edb4bcfa39f60585937f2a1a4507f7f3abbb15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210461Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#773076}
-
Yuzu Saijo authored
This CL removes PutPageIntoBackForwardCache and RestoreFromBackForward Cache IPCs and use mojo instead. Now the page state is managed by PageLifecycleStateManager, which is responsible for sending updates to renderer via mojo messages. Bug:1057506 Change-Id: I2e1fafe79c758f8d6d56eabd9ee13f288f370bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192540 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773075}
-
Xing Liu authored
The download home UI uses offline item collection code stack. This CL introduces a new struct in both native and Java. The DownloadSchedule struct will be converted to this when plumbing to the UI. Bug: 1078454 Change-Id: Ib636f5df4a81c4fd12c6cca7df5e064b895e45a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218483 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773074}
-
Hiroki Nakagawa authored
This UMA is still usuful for monitoring the health condition of worker threads. Bug: 1084061 Change-Id: I3ac54843dfbe67fe965b3e15a4da5ab126cb19f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217725 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773073}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590710362-c13fe441c8f420f4cd2f4cff6b98279f2ecbf633.profdata to chrome-win64-master-1590724612-5db2101d2a61d33e1335d92c89441aeea9c7ea20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7e8163649d33b1bd40d224cbf7f3be4d8d5d59fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222128Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/468f8fff..14aed087 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53c98a50d732ec99460cd186ff27e87f0d690698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218392Reviewed-by:
-
Hiroki Nakagawa authored
We have no plans to work on this TODO. Bug: 616721 Change-Id: Ifb7a5803f9494936c50c164d655e754db87a6dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222063 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#773070}
-
Marc Treib authored
This reverts commit 54b1dc4f. This is a *temporary* revert to investigate some unexplained metrics changes, see linked bug. Bug: 1075587 Change-Id: I4c4a3c0b1ac5e0f6a39dc15f5fd8aafc87ffec35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218171Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#773069}
-
Alan Cutter authored
This CL refactors WebAppInstallFinalizer database write code to not plumb through bool is_new_install. Instead the database write callsites encode what they want to happen afterwards as part of the CommitCallback. This is a refactor only CL in preparation for: https://chromium-review.googlesource.com/c/chromium/src/+/2216143 Bug: 1084405 Change-Id: Ib71740878d9e339fd8cc6ee73b6bd6fa1b782272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217835 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#773068}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590710362-35a7ecd8a402bd31319e2be75ae7373248116b8a.profdata to chrome-mac-master-1590724612-c1421d9824c914ff15feb610fd2b028bed82b9e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idc6406933af55e570acd4d0c9e9246ddc6aaa060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222124Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c272f416f07..dd9feece3750 2020-05-29 dberris@chromium.org operations: Fixup style config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Ibd749a0eee5958ef247cbffbcdb6db0d08f752da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222127Reviewed-by:
-
Omid Tourzan authored
Bug: 953308 Change-Id: I13b337fe205e897e0350a007d690a24ce582787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220409Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#773065}
-
Clemens Arbesser authored
Closing the keyboard before attempting to click the button should finally fix those flaky tests. Bug: 1087042 Bug: 1084324 Change-Id: Iae013984e3b844eb665aac7f363f2111f139e378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218834 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#773064}
-
