Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Aug, 2018 30 commits
  3. 19 Aug, 2018 10 commits
    • Nico Weber's avatar
      Run browser_tests (and viz_browser_tests) on win/asan bot. · f4d9a36a
      Nico Weber authored 
      - PlatformAppBrowserTest.PictureInPicture consistently fails with a
  (apparently windows-only) use-after-free on win/asan. That code is new,
  so just revert it (see below), https://crbug.com/873234

- PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
  disable the test in that config, https://crbug.com/856169

- SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
  fails fairly consistenly on win/asan (and elsewhere) in
  network_service_browser_tests, so don't enable that suite on the win/asan
  bot just yet (https://crbug.com/840063).

Bug: 869973

Revert "Enable Picture-in-Picture for chrome apps."

This reverts commit e031e566.

Reason for revert: Test has a use-after-free, https://crbug.com/873234

Original change's description:
> Enable Picture-in-Picture for chrome apps.
>
> This CL enables Picture-in-Picture in chrome apps by implementing
> EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
>
> Bug: 863309
> Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
> Reviewed-on: https://chromium-review.googlesource.com/1156513
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580497}

TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863309
Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
Reviewed-on: https://chromium-review.googlesource.com/1180763
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584347}
      f4d9a36a
    • Mohamed Heikal's avatar
      [Tools] Add suggest_owners script to repo · 66d74229
      Mohamed Heikal authored 
      suggest_owners.py looks at commit history and suggests chromium
developers to be added as owners to subdirectories in the repo.

Change-Id: Ia7f2df2dbf7d96dc9322532b4c5cdab1443c95b8
Reviewed-on: https://chromium-review.googlesource.com/1174701Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584346}
      66d74229
    • Xing Liu's avatar
      Background download: Network/battery status listener implementation on Mac. · 3ea8bbe5
      Xing Liu authored 
      net::NetworkChangeNotifier and base::PowerObserver are not hooked to
correct platform code on Mac, thus make background download service not
working correctly.

This CL provides default implementation for device status monitoring on
Mac that always treat the device connected to internet and power source.

This is mostly a temporary solution before platform code is implemented
correctly.

Also pull out BatteryStatusListener and NetworkStatusListener to a
separate file.

Bug: 825878
Change-Id: If34d8eb0cbe5d0575920c4251eda5e5161695adf
Reviewed-on: https://chromium-review.googlesource.com/1178689Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584345}
      3ea8bbe5
    • Christopher Cameron's avatar
      RemoteMacViews: Re-separate test code · 79550cc4
      Christopher Cameron authored 
      This removes parts of crrev.com/583350, preserving the following
- explicitly require that NSWindows be NativeWidgetMacNSWindow

This removes the ability to create an NSWindow in the AppShim process
for now. That will be re-added later.

This is a re-land of crrev.com/584323 (reverted in crrev.com/584323),
with the changes in lifetime management (use of autorelease) removed,
because it appears that tests make assumptions about lifetime. Added
a comment about this.

TBR=tapted

Bug: 859152
Change-Id: Ia0e2811c903316a0c1ed07be6cd7275bb8cf421d
Reviewed-on: https://chromium-review.googlesource.com/1180707Reviewed-by: default avatarccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584344}
      79550cc4
    • Thomas Tangl's avatar
      [unified-consent] Add Google-G icon in settings · 0cd492d7
      Thomas Tangl authored 
      This CL adds a Google G icon next to
"Sync and Google services" on the chrome://settings
page.

Bug: 872486
Change-Id: I8ef68cd0969dc7e926c40d91b05784e72106153d
Reviewed-on: https://chromium-review.googlesource.com/1179753Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584343}
      0cd492d7
    • Ned Nguyen's avatar
      Revert "Reland "metrics: Initialize persistent metric allocator early."" · a3819689
      Ned Nguyen authored 
      This reverts commit 63fab7f6.

Reason for revert: breaking android-go-perf on chrome perf waterfall
BUG:875640

Original change's description:
> Reland "metrics: Initialize persistent metric allocator early."
> 
> This is a reland of 0cdc1458
> 
> Original change's description:
> > metrics: Initialize persistent metric allocator early.
> >
> > The PersistentMemoryAllocator in the gpu (and other) process is created
> > asynchronously. If any uma-histogram is reported before that time, then
> > those Histograms are not stored in the shared memory. This has some
> > implications:
> >  . If the process crashes (which is common for the gpu process on
> >    android), then these metrics are lost.
> >  . If the process stays alive, then the metrics are reported
> >    periodically, but because it is buffered, it doesn't match up
> >    correctly with the other metrics that are reported in the shared
> >    memory.
> >
> > The allocator is created in response to a message from the browser,
> > which includes the handle for the shared memory to use for the allocator.
> > The browser waits until the process has been launched and connected.
> > So this happens much later, compared to other messages which are sent
> > from browser over mojo without waiting for the connection to have
> > been established first. Therefore, change this so that the browser
> > immediately shares the shared-memory segment with the gpu process. mojo
> > takes care of waiting for the process-launch etc.
> >
> > BUG=865179, 778749
> >
> > Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e
> > Reviewed-on: https://chromium-review.googlesource.com/1174709
> > Reviewed-by: Brian White <bcwhite@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583673}
> TBR=avi,sadrul
> 
> Bug: 865179, 778749
> Change-Id: I205221ed82b073464e1c4d52593ba727ebc211a5
> Reviewed-on: https://chromium-review.googlesource.com/1179346
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Commit-Queue: Matthew Jones <mdjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584203}

TBR=avi@chromium.org,sadrul@chromium.org,bcwhite@chromium.org,mdjones@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 865179, 778749
Change-Id: I7fd057c81494dff8072a2e847510821ec6ff8530
Reviewed-on: https://chromium-review.googlesource.com/1180741Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584342}
      a3819689
    • Thomas Tangl's avatar
      [unified-consent] Refactor migration code and add settings updates · 28ac1ad7
      Thomas Tangl authored 
      The migration code in the UnifiedConsentService is refactored:
 - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is
 extracted to it's own pref kShouldShowUnifiedConsentBump.
 - The migration state kInProgressWaitForSyncInit is introduced
 to be able to update the settings for migration when sync is
 initialized.

Additional changes:
 - ShouldShowConsentBump only returns true if the consent bump
 feature is enabled.
 - The rollback enables sync-everything now also when the user is
 not syncing USER_EVENTS (which is disabled during the migration).

Users that previously had the unified consent feature enabled and
for which ShouldShowConsentBump=true, will not be shown the consent
bump anymore after this CL is landed. This will only affect a few
users on Canary and Dev.

Bug: 863932
Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c
Reviewed-on: https://chromium-review.googlesource.com/1172690Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584341}
      28ac1ad7
    • Nico Weber's avatar
      Revert "RemoteMacViews: Re-separate test code" · e33fda00
      Nico Weber authored 
      This reverts commit 740a6c4c.

Reason for revert: views_unittests WidgetTest.FullscreenStatePropagated ,
WidgetTest.FullscreenStatePropagated_DesktopWidget consistently started failing on 10.10 (other versions seem happy):

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34348

Original change's description:
> RemoteMacViews: Re-separate test code
> 
> This removes parts of crrev.com/583350, preserving the following
> - explicitly require that NSWindows be NativeWidgetMacNSWindow
> - return a scoped_nsobject from CreateNSWindow, and remove requirement
>   of autoreleasing the result, to clarify lifetimes
> 
> This removes the ability to create an NSWindow in the AppShim process
> for now. That will be re-added later.
> 
> Bug: 859152
> Change-Id: Ife70a91ac9557f2ec7a488a8714f907eaecea0e3
> Reviewed-on: https://chromium-review.googlesource.com/1177276
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584323}

TBR=tapted@chromium.org,ccameron@chromium.org

Change-Id: I9c16deb13126c51171bdd180200025cbcf808a03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859152
Reviewed-on: https://chromium-review.googlesource.com/1180762Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584340}
      e33fda00
    • Nico Weber's avatar
      Revert "RemoteMacViews: Remove browser dependencies of SetBounds" · 6789bf06
      Nico Weber authored 
      This reverts commit 5f99a2c0.

Reason for revert: WebDialogBrowserTest.SizeWindow fails on max 10.11, 10.12 (10.10 and 10.13 seem happy):

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28636
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14984

Original change's description:
> RemoteMacViews: Remove browser dependencies of SetBounds
> 
> The function BridgedNativeWidget::SetBounds calls back into the
> NativeWidgetMac to determine
> - the minimum content size
> - if the widget's position should be relative to the parent or the
>   screen (and the offset to do that computation)
> - if the widget is a modal sheet
> This call will eventually be running in the app shim process, where
> these values will not be available (without adding a synchronous IPC).
> 
> Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl::
> SetBounds, and have that function pre-compute the required parameters,
> - minimum content size
> - offset necessary to be applied to compensate for position being
>   relative to the parent or the screen
> - (but not if the widget is a modal sheet, that's coming later)
> and pass these as parameters to BridgedNativeWidget::SetBounds.
> 
> Split out the SetBounds calls made during initialization from
> being within BridgedNativeWidget::Init to being made by its caller,
> BridgedNativeWidgetHostImpl::InitWindow, to allow the additional
> parameters to be passed in.
> 
> Bug: 859152
> Change-Id: I2f33ab08f60d2ed1bc3b6af5ecf3402e3715ffd4
> Reviewed-on: https://chromium-review.googlesource.com/1178813
> Commit-Queue: ccameron <ccameron@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584327}

TBR=ellyjones@chromium.org,ccameron@chromium.org

Change-Id: I1300db812416881fb539b586e7d7fab2597d60c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859152
Reviewed-on: https://chromium-review.googlesource.com/1180761Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584339}
      6789bf06
    • Nico Weber's avatar
      Run sync_integration_tests on win/asan bots. · 3eeee6d2
      Nico Weber authored 
      One recently re-enabled test fails, so to be able run the whole suite, also:
Revert "Reland "[Sync:USS] Enable more two client bookmarks integration tests""

This reverts commit f846b651.

Reason for revert: One of the tests fails on win/asan, https://crbug.com/875239

Original change's description:
> Reland "[Sync:USS] Enable more two client bookmarks integration tests"
>
> This is a reland of 94d8037b
>
> Original change's description:
> > [Sync:USS] Enable more two client bookmarks integration tests
> >
> > This CL enables more integration tests for bookmarks to run
> > against USS archiecture.
> >
> >
> > Bug: 516866
> > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f
> > Reviewed-on: https://chromium-review.googlesource.com/1158691
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580434}
>
> Bug: 516866
> Change-Id: Ia922ab75b92c013cc2e06cb3ec5a549875390316
> Reviewed-on: https://chromium-review.googlesource.com/1161882
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580499}

TBR=mastiz@chromium.org,mamir@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 516866, 875239
Change-Id: I85e49dbfd4e6c2aba675854efb42c4a87d3243b8
Reviewed-on: https://chromium-review.googlesource.com/1180661
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584338}
      3eeee6d2