Commits · d69ae10aa0ea4a475f7e3d8118a8f39895f64352 · eriksson monteiro / tangled

20 Jan, 2021 27 commits

Files app: Add the optimize_webui() rule for foreground page · d69ae10a

Luciano Pacheco authored Jan 20, 2021

This is a preparation to run the foreground page as JS modules.

Bug: 1133186
Change-Id: Iad424b0d91985015bc1cf746866c996c3334fe88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637167
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844998}

d69ae10a

Prerender: Update README.md and WATCHLISTS · bc1a8d3d

Hiroki Nakagawa authored Jan 20, 2021

This CL...

- adds "Trigger" in the terminology section in README.md.
- adds how to watch relevant code changes in README.md.
- removes the no_state_prefetch directories from the WATCHLISTS entry
  for prerendering. The new prerendering implementation deviates from
  the NoStatePrefetch implementation. Probably watchers are no longer
  interested in changes for them.

Bug: 1126305
Change-Id: Ia07a60f1ae0c6f26de54c4cfa75dadf64386b25c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636979
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844997}

bc1a8d3d

WebSQL: Simplify API for DatabaseTracker::DeleteDataForOrigin. · e3b82499

Victor Costan authored Jan 20, 2021

The method currently follows an unfortunate maybe-async pattern
established in //net whereby operations may either report an outcome
synchronously by returning a net::Error other than net::ERR_IO_PENDING,
or report the outcome asynchronously by invoking a callback.

This CL changes the method to unconditionally run the callback with the
operation outcome. This is intended to simplify the mental model and
control flow around the method.

Change-Id: I4337cb5e93820596510b02c0b6bde75a6f3111f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632853Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844996}

e3b82499

Convert callbacks in //chrome/browser/chromeos/tether · 9b60b5b5

Reilly Grant authored Jan 20, 2021

This change converts callbacks from base::Bind and base::Callback to
Once/Repeating in //chrome/browser/chromeos/tether.

Bug: 1148570
Change-Id: Ic3b780c5714af71aae25691f77aad3fb69f5986d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638571
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844995}

9b60b5b5

Updating trunk VERSION from 4394.0 to 4395.0 · 03514c1d

chrome-release-bot authored Jan 20, 2021

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I1023b188d5cd372654f9f843e23f8000792885b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639394Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844994}

03514c1d

[webid] Allow idp_endpoint to be a relative URL · 8b6172ae

Sam Goto authored Jan 20, 2021

The idp_endpoint property today of the .well-known/webid response is now
taken as an absolute URL, which makes it inconvenient for deployment.

In this CL we resolve the idp_endpoint URL as a relative URL to the file
that it is contained in, allowing both absolute URLs and relative URLs
to co-exist.

Bug: 1141125
Change-Id: I224274634e5eaf7f7d66d044931fe5823f346829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631295
Auto-Submit: Sam Goto <goto@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844993}

8b6172ae

[Sync confirmation] Move dark mode css till the end to get precedence · acf3123a

Jan Krcal authored Jan 20, 2021

This CL fixes a regression that (for both the old and the new design),
light mode illustrations are used when in dark mode. This happened
by moving the dark mode css into one selector in the beginning. This
CL moves that till the end of the css to get precedence over the
light mode css specified before.

Bug: 1167092
Change-Id: I04783bb5aa34794c107cc846017accb140dea692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632680
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844992}

acf3123a

Don't allow WebCodecs fuzzers to fuzz if creation aborts. · 285cd875

Dale Curtis authored Jan 20, 2021

A review of similar Blink classes shows we should be returning nullptr
during the ::Create() method if there are exceptions. I've updated the
fuzzers to handle a null return value here now.

Fixed: 1167511, 1167532, 1167534
Change-Id: Idbbfaeac2e93eb1f4b8f02ad880724ac5454eac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638397
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844991}

285cd875

Roll DevTools Frontend from 13d0f7c03fe3 to 5dbc16c0c6bd (1 revision) · d3f376a9

chromium-autoroll authored Jan 20, 2021

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13d0f7c03fe3..5dbc16c0c6bd

2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate settings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1158760
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Idcd06707f3234b07843d7fcec30591c0cb6b4733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638558Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844990}

d3f376a9

Add [[clang::nomerge]] attribute to ~CheckError(). · 88602533

Zequan Wu authored Jan 20, 2021

To disable merging multiple ~CheckError() destructor for accurate crash logs.

Bug: 1153188
Change-Id: If6d153661667a63f13b645f6d284eb3d5ea3a300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611331
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Zequan Wu <zequanwu@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844989}

88602533

bindings: Replace View() with Get() (MaybeShared) · 2de58a02

Canon Mukai authored Jan 20, 2021

Get() does the same thing as View() and it is recommended to use Get()
instead of View(). So replaced View() with Get() and deleted View().

Change-Id: I4f9b407b6ea6b27f79c4d52049a647db4e9a874a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636097Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Canon Mukai <canonmukai@google.com>
Cr-Commit-Position: refs/heads/master@{#844988}

2de58a02

Revert "trigger_scripts: support go client in chromeos_device_trigger" · 78d95924

Takuto Ikuta authored Jan 20, 2021

This reverts commit 3fd9ba25.

Reason for revert:
https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071

Original change's description:
> trigger_scripts: support go client in chromeos_device_trigger
>
> This scripts needs json conversion similar to
> https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62
> when using go client.
>
> This is fix for breakage like
> https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159
>
> Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> Bug: 1127205
> Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#844979}

TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com

Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127205
Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844987}

78d95924

Revert "Reland "Force Python 3 to be used in build."" · 17801e45

Yutaka Hirano authored Jan 20, 2021

This reverts commit 6ea5c38d.

Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview

Original change's description:
> Reland "Force Python 3 to be used in build."
>
> This reverts commit b6172196.
>
> Reason for revert: We rolled GN to a new version with a fix for
> the win dev issues, so hopefully is good to go now.
>
> Original change's description:
> > Revert "Force Python 3 to be used in build."
> >
> > This reverts commit bb97ab9b.
> >
> > Reason for revert: Various breakages.
> >
> > Original change's description:
> > > Force Python 3 to be used in build.
> > >
> > > This CL makes Python 3 be the default script executable used by Ninja
> > > to run action() and action_foreach()'s during the build.
> > >
> > > This does *not* mean that everything works with Python3; many targets
> > > may still use Python 2 via the python2_action() and
> > > python2_action_foreach() targets or via custom logic.
> > >
> > > However, it does mean that it should prevent regressions from
> > > creeping in.
> > >
> > > This CL should not be taken to imply that we can start to write
> > > Python3-specific code that can run during the build; we should
> > > still be trying to ensure that everything is compatible with Python2.
> > >
> > > Also, this CL does not enable the use of vpython in actions; we should
> > > still avoid that because vpython is slower than direct Python
> > > invocations.
> > >
> > > Bug: 1112471
> > > Change-Id: I472b032b500715156d955b0758640a7ed0384305
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787
> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > > Cr-Commit-Position: refs/heads/master@{#836234}
> >
> > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
> >
> > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1112471
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#836284}
>
> TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1112471
> Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#844885}

TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1112471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844986}

17801e45

Delete some unused document mode code · dab8d7cd

Michael Thiessen authored Jan 20, 2021

Change-Id: I5451d561fb455956bb876683e5784a296419c199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637085
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844985}

dab8d7cd

[LibassistantV2] Move |SendVoicelessInteraction| to Mojom service. · 2469b23e

Meilin Wang authored Jan 20, 2021

This CL is the part 1 of moving |SendVoicelessInteraction| calls to
Libassistant Mojom service. It defines and implements four more APIs
(listed below) under |ConversationController| Mojom service, and hooks
them up in the browser process by replacing |SendVoicelessInteraction|
calls in |AssistantManagerServiceImpl| with the corresponding Mojom
method.

* StartEditReminderInteraction
* RetrieveNotification
* DismissNotification
* SendAssistantFeedback

Note that in the CL, |ConversationControllerProxy| will forward all
calls through Mojom to the service implementation, where the actual
proto message gets encoded. In this way, we can remove Libassistant
dependencies from the Assistant service side (classes under
/chromeos/services/assistant).

Bug: b/171748795
Change-Id: I350cf49b898fffa798b73bb7720ae1583ce84ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625327Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844984}

2469b23e

Read later: Ignore talkback for more icon when selects a bookmark row. · 0b4263bc

Xing Liu authored Jan 20, 2021

When the more icon in BookmarkRow is disabled in selection mode, let
talkback ignores this view.

Bug: 1166730
Change-Id: I657892b0c7c297b5bf5254440ab41ff0d20453a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637082Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844983}

0b4263bc

Use DistilledURL when loading distilled data · c0015aa9

Olivier Robin authored Jan 20, 2021

When using loadData, the html has access to the cookies of the URL.
It is necessary to pass the URL of the distilled page to avoid cross
domain leak.

This CL breaks the workflow of user following a new redirection on
reloading the page.

Bug: 1167901
Change-Id: I6cb01a6580ed511de19f55b35acf91f7f3c7493d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637584
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844982}

c0015aa9

Reland "Move installer.cc file to updater/win directory." · f2570ac7

Sorin Jianu authored Jan 20, 2021

This is a reland of e1f49aca

Original change's description:
> Move installer.cc file to updater/win directory.
>
> The installer API code is Windows-specific and it would be desirable
> to isolate //chrome/updater from its implementation details.
>
> This change uses public_deps and visibility to make
> updater:lib and updater/win:lib act as a unit, to resolve the issue
> of the circular includes as suggested by the GN documentation.
>
> Bug: 1014630
>
> Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#842765}

Bug: 1014630
Change-Id: I84d717aad974254f5daf24547888c8bf880cf9be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635202Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844981}

f2570ac7

Roll Chrome Win32 PGO Profile · 492b0dcc

chromium-autoroll authored Jan 20, 2021

Roll Chrome Win32 PGO profile from chrome-win32-master-1611068186-6acea0a5e8e4dcb5129946657add72ff4aa0a2a2.profdata to chrome-win32-master-1611078768-a6f5b9bbbe47c14760aa754313a33dbc3d6dd128.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6da16ae022c812e736c4f9039c67f38ea8c094ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637078Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844980}

492b0dcc

trigger_scripts: support go client in chromeos_device_trigger · 3fd9ba25

Takuto Ikuta authored Jan 20, 2021

This scripts needs json conversion similar to
https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62
when using go client.

This is fix for breakage like
https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
Bug: 1127205
Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844979}

3fd9ba25

Remove MyChromeEverywhere entry from testing config. · a31e3d6f

Caitlin Fischer authored Jan 20, 2021

The server-side config shows that this study ended.

Bug: 1126640
Change-Id: Ib731ca75db831a4a54b9ba3bcd7b63391723f056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631934Reviewed-by: Siyu An <siyua@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#844978}

a31e3d6f

Roll Skia from f3087d8297fe to b7e836cee99b (4 revisions) · 5b716039

chromium-autoroll authored Jan 20, 2021

https://skia.googlesource.com/skia.git/+log/f3087d8297fe..b7e836cee99b

2021-01-19 mtklein@google.com Revert "Support indexing by loop variables in SkVMGenerator"
2021-01-19 bsalomon@google.com Reland "Test all YUVA image factories with different encoded origins."
2021-01-19 brianosman@google.com Support indexing by loop variables in SkVMGenerator
2021-01-19 csmartdalton@google.com Extract some GrPathTessellatoOp logic into virtual helper classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: scroggo@google.com
Change-Id: I9d52bbdffdc4c0547f4d4c8fc6163b8e2d1fdc3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638555Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844977}

5b716039

Roll src-internal from 7bcb61f96b8c to b6bed55becc6 (3 revisions) · 541dc66b

chromium-internal-autoroll authored Jan 20, 2021

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bcb61f96b8c..b6bed55becc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC dbertoni@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: dbertoni@google.com
Change-Id: Ia95cf7379a7c7217e8a0ef114d5f03a56696bd3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638116Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844976}

541dc66b

Move media controls UA style into a separate ruleset · 66efe30f

Rune Lillesveen authored Jan 20, 2021

The current rules for media controls should only apply to elements in
the UA shadow dom for media elements, but were added to the ruleset for
all html UA style. Since the media controls styling adds a bunch of
rules in the universal tag bucket, once we add a media element to our
renderer, we were stuck with having to reject a bunch of these rules for
every html element.

Instead, create a different set of styles for media controls and only
try applying rules from that set for elements inside the UA shadow tree
for media elements.

Bug: 1166198, 1032957
Change-Id: I5b2fa635558a28a29bf69538f94763d158c7d2ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631490
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844975}

66efe30f

Fix icon sizes in holding space context menus. · 45e98de8

David Black authored Jan 20, 2021

Previously relied on intrinsic icon size which was sometimes correct,
sometimes wrong.

Bug: 1167365
Change-Id: Iaf2b3454bde9eb340913fc552f936d59d204f0be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638519Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#844974}

45e98de8

Read later: Add BookmarkBridgeTest.addToReadingList. · 4ef269d9

Xing Liu authored Jan 20, 2021

BookmarkBridge.addToReadingList is not covered.

This is also part of a reland for:
https://chromium-review.googlesource.com/c/chromium/src/+/2625276

Bug: 1166251
Change-Id: Ib6ad34b4daa935151c4895d43fc0eee292727787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627771
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844973}

4ef269d9

[Live Caption] Update Live Caption subtitle string based on UX feedback. · 9a823ced

Abigail Klein authored Jan 20, 2021

Bug: 1055150, 1167349
Change-Id: I4c321cdfa6e00c3a8002cbea02e89fc2689e3ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633375Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#844972}

9a823ced

19 Jan, 2021 13 commits

Fix python3 issues with gen_fuzzer_owners.py. · f009f158

Dale Curtis authored Jan 19, 2021

cli_output.splitlines() needs a decode('utf-8') now.

Bug: 941669
Change-Id: I8c5241483dac9d77655501aa6e560e679df16dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638534
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#844971}

f009f158

[iOS] Make CWTChromeDriver's launch script work with ASan builds · 7e31b67b

Ali Juma authored Jan 19, 2021

When launching an ASan build of CWTChromeDriver,
libclang_rt.asan_iossim_dynamic.dylib needs to be included
in DYLD_INSERT_LIBRARIES.

This CL updates launch scripts to include this value when
using ASan.

This is needed as part of adapting CWTChromeDriver for fuzzing.

Bug: 1158540
Change-Id: I924f865027ac8c50deeec2eaa401647efff62452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633681Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844970}

7e31b67b

Roll ANGLE from e670fc72a5ae to 2e0490eedcc8 (8 revisions) · b7eb5067

chromium-autoroll authored Jan 19, 2021

https://chromium.googlesource.com/angle/angle.git/+log/e670fc72a5ae..2e0490eedcc8

2021-01-19 jmadill@chromium.org Capture/Replay: Serialize float states properly.
2021-01-19 syoussefi@chromium.org Suppress failing tests on mac ARM
2021-01-19 jmadill@chromium.org Vulkan: Support GL_EXT_tessellation_shader.
2021-01-19 m.maiya@samsung.com Vulkan: Add integer type incomplete texture tests
2021-01-19 cnorthrop@google.com Tests: Add Asphalt 8 trace
2021-01-19 syoussefi@chromium.org Fix image bindings with an image after an image array of array
2021-01-19 jmadill@chromium.org Test Runner: Prevent race by not resetting timeout.
2021-01-19 cnorthrop@google.com Capture/Replay: Use glUniform1iv on samplers, ignore images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1167763
Tbr: cnorthrop@google.com
Test: Test: Fortnite MECTest: Test: angle_perftests --gtest_filter="*asphalt_8*"Test: Test: dEQP-GLES31.functional.tessellation.*
Change-Id: I33597fd39018c548229ab7528e54df74b52ec09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638109Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844969}

b7eb5067

Reduce iterations of testTabSwitcherStability from 200 to 50. · 021bb222

Yaron Friedman authored Jan 19, 2021

According to flakiness dashboard this is our slowest test and generally taking at least 45seconds and sometimes up to 4 minutes.

Change-Id: Ie4d0f17eced89adebe1ffe1dff17db74395776a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635075Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844968}

021bb222

Introduce Session Log Manager · 04f000d5

Bailey Berro authored Jan 19, 2021

This change introduces the SessionLogManager class. The
SessionLogManager owns the various logging classes and will be
responsible for constructing the session log when requested by the user.

Bug: 1128204
Change-Id: I4c41effce7d1faf99f2c68c773642e44aec18dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632870
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844967}

04f000d5

Adds fuchsia-builder-perf-fyi config · 1a592fb9

Rohan Pavone authored Jan 19, 2021

Builder is not currently active, but exists in another repo.

Bug: 1128105
Change-Id: Ic4de73c066751c7973e270bbda5358e31fb73408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628343Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844966}

1a592fb9

System Media Controls: Use SMC directly in MediaKeysListenerManager · f27ff35f

Tommy Steimel authored Jan 19, 2021

This CL refactors the MediaKeysListenerManager to use the
SystemMediaControls directly instead of through a MediaKeysListener.
This will allow us to fix a few different bugs that were stuck on this
refactor, such as providing a content-specific name to the
SystemMediaControls and properly destroying it when there are no active
sessions.

This CL also renames the HardwareKeyMediaController to make more sense.

Bug: 974035
Change-Id: I1818fdc8849e679c5a7791a0516ba051ee8eefbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606785Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844965}

f27ff35f

Add OAuth2 flow for Box: WholeFileUpload (for files <= 50MB only) · 02c0633e

Alice Gong authored Jan 19, 2021

BUG=1157672

Change-Id: Iffd50344615d56c2b2a4a843e8a22eab9f4306f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621923Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Alice Gong <alicego@google.com>
Cr-Commit-Position: refs/heads/master@{#844964}

02c0633e

Roll SwiftShader from 8da0f82baf35 to 89fd1480b47e (1 revision) · f4d3a840

chromium-autoroll authored Jan 19, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/8da0f82baf35..89fd1480b47e

2021-01-19 digit@google.com vulkan: Support VK_KHR_external_memory_fd on OS X.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I1366a05d78896c54fa35070fbd171b2093fd5ff2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638240Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844963}

f4d3a840

Convert callbacks in //chromeos/components/tether · a4a08356

Reilly Grant authored Jan 19, 2021

This change converts callbacks from base::Bind and base::Callback to
Once/Repeating in //chromeos/components/tether.

Bug: 1007654
Change-Id: I8aa947682d8ba5f2864d6dc9a1ed153d5ba90416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637929
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844962}

a4a08356

Roll Chrome Win64 PGO Profile · 24640130

chromium-autoroll authored Jan 19, 2021

Roll Chrome Win64 PGO profile from chrome-win64-master-1611068186-b36b631e8b34e83450d9bdf5237d6c35b34952b4.profdata to chrome-win64-master-1611078768-7ecf7fe9cdf533d2ba0fd4fcea641cfa29b8dba9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I0def19a6624fa0dc61837b4b524be596d6d2f8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638245Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#844961}

24640130

Add missing BUILD dependency · fdcdb732

Jeroen Dhollander authored Jan 19, 2021

This caused linking issues on a debug build (I do not know why it
doesn't cause issues on a non-debug build).

[0/1/1] SOLINK ./lib_libassistant_service.so
FAILED: lib_libassistant_service.so lib_libassistant_service.so.TOC
python "../../build/toolchain/gcc_solink_wrapper.py" <snip>
ld.lld: error: undefined symbol: NewLibassistantEntrypoint
>>> referenced by libassistant_entrypoint_client.cc:40 <snip>

Bug: b/171748795
Test: compiled
Change-Id: Id302592f9bd1623656403da530c05899a22cfc7d
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636682
Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844960}

fdcdb732

Remove concatOp that uses a 3x3 matrix · 6817ed4a

Aaron Krajeski authored Jan 19, 2021

Part of the greater effort to migrate cc and the paint_op_buffer away
from SkMatrix, which is 3x3 and relatively slow, compared to SkM44.

Two functions were added to paint op buffer in previous Cls,
Concat44 https://chromium-review.googlesource.com/c/chromium/src/+/2577704
SetMatrix44 https://chromium-review.googlesource.com/c/chromium/src/+/2562783
Each of these take an SkM44 as an argument instead of an SkMatrix.

This CL changes the implementation of RecordPaintCanvas::concat so that
it always ends up sending an SkM44 to the paint op buffer and removes
the older implementation of ConcatOP (that used an SkMatrix). Now there
is only one concat operation in the paint op buffer.

The next and hopefully final step of this project will be to do the same
thing for SetMatrixOp.

Bug: 1155544, 1167153
Change-Id: I7a3b3a168e91ec37151e5f95897abadc5bc05542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626051
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844959}

6817ed4a