- 17 Apr, 2018 40 commits
-
-
Mohamed Amir Yosef authored
This CL adds a simple integration test for downloading a bookmark. It's a simpler version of the existing DownloadDeletedBookmark test. Bug: 516866 Change-Id: I29f54aa2647b6b89e821b7e84faf84292d6f8707 Reviewed-on: https://chromium-review.googlesource.com/1014045 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551392}
-
Nate Chapin authored
Bug: 829119 Change-Id: Ie393ac9e18bdfcded983d98a16c00254b0954547 Reviewed-on: https://chromium-review.googlesource.com/1000519 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551391}
-
Joone Hur authored
This CL moves all files in ui/display/manager/chromeos to ui/display/manager and adds build_display_configuration GN arg so that the display configurator could be used in Linux desktop. BUG=733450 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idd790cfe6f9e5daf6ccad23353573028ebe5d7ee Reviewed-on: https://chromium-review.googlesource.com/969416Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551390}
-
Nate Chapin authored
This is necessary to support nested workers. Bug: 829119 Change-Id: Ib48d10fc724477f720e77a15237ab106d8ed86f9 Reviewed-on: https://chromium-review.googlesource.com/1012794Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#551389}
-
kristipark authored
The URL is incorrect due to the welcome page migration (it currently redirects to chrome.com). Also, users have already been through the first run UX, so the welcome page is not really needed. Bug: 824038 Change-Id: I739e920e2fd4f4498226a04e162b29f2ed1011c7 Reviewed-on: https://chromium-review.googlesource.com/1006186 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551388}
-
Stephen Lanham authored
crrev.com/c/1005506 changed the name of PartitionAllocReturnNullTest. BUG= internal b/78119983 Test: manual Change-Id: I85e8457eeddf563e56a10c02d808ddd336e5a010 Reviewed-on: https://chromium-review.googlesource.com/1015405Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551387}
-
Justin Cohen authored
Bug: 819460, 832593 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6ba2bfc9e22758203b5dc44698e40db5295c79ce Reviewed-on: https://chromium-review.googlesource.com/1005912Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551386}
-
Shimi Zhang authored
Run testUseWideViewportLayoutWidthNoQuirks() on N 600 times and on O 100 times, then run both tests for another 500 times, didn't see any failure, enable to see how will the flakiness dashboard say. Bug: 797009 Change-Id: If970a068fe6bccc5a9b1d7960fa69ff678260112 Reviewed-on: https://chromium-review.googlesource.com/1014475Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#551385}
-
Nico Weber authored
This reverts commit be8138a4. Reason for revert: broke checkbins on 32-bit, https://crbug.com/833951 Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > Reviewed-on: https://chromium-review.googlesource.com/983632 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551367} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ia6060fe909656ce5903cf6906beb8b5e4ef538c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792131 Reviewed-on: https://chromium-review.googlesource.com/1015141Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551384}
-
Jeffrey Kardatzke authored
This adds a small D-Bus service framework to ash and then adds an initial service that has one call "OpenUrl" which will then open a new tab in Chrome with that URL. This is intended to be used by Chrome OS clients that want to open a URL with Chrome; initial usage will be from VMs. Relanding crrev.com/c/998081, fixed missing D-Bus .conf file TBR=stevenjb@chromium.org,dominickn@chromium.org,hashimoto@chromium.org,mkwst@chromium.org Bug: 822496 Bug: 831333 Test: Verified with dbus-send that links open properly Change-Id: I5e6d9c716ef6da88b184e8e05582825d9547946e Reviewed-on: https://chromium-review.googlesource.com/1014424 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551383}
-
Alexey Kozyatinskiy authored
This roll includes: - [inspector_protocol] first class citizien .pdl support + migrated cros_protocol.json to .pdl TBR=dgozman@chromium.org,dpranke@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true Bug:none Change-Id: I0fff1582bd41115e2aa348008c7a5d48f5c59a7e Reviewed-on: https://chromium-review.googlesource.com/1014468 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551382}
-
Malay Keshav authored
std::string is not used correctly with ioctl() and hence fails to get the field info. Replace it with C string. Bug: 827452 Change-Id: Iace6ce24a6405c40a68eeff71c090883b847a46f Component: Event Device Info, phys Reviewed-on: https://chromium-review.googlesource.com/1014409Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#551381}
-
Tetsui Ohkubo authored
According to UX spec, if a feature pod button is togglable and has a detailed view, the icon click should toggle the feature and the label click should show the detailed view. This CL changes the behavior of Bluetooth feature pod button to follow this rule. UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=821671 Change-Id: Ia4158975c6a0d7c409c1bacd58786223eea4567e Reviewed-on: https://chromium-review.googlesource.com/1013130Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#551380}
-
Yuichiro Hanada authored
This CL adds the new mojo API and a method of KeyboardController to request hiding the virtual keyboard if it's shown. The difference between HideKeyboard() and RequestHideKeyboard() is that the request made by RequestHideKeyboard() can be canceled by focusing another text input field. Bug: b:72456023 Change-Id: Ief7e48da3a249825fdddd48bdcb3aa20d379eec6 Reviewed-on: https://chromium-review.googlesource.com/1004881 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#551379}
-
Becca Hughes authored
Roll preloaded data to 1.0.3.0 BUG=833861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I32aff80f3637e7ff2608f155d0e3ebf3182489b9 Reviewed-on: https://chromium-review.googlesource.com/1014719Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#551378}
-
wutao authored
Currently for fullscreen window, Ash lets the browser or apps to process the accelerator first. However, focus_manager handles "alt-tab" as a "Tab" traversal key event. This cl fixes this bug. Bug: 832739 Test: New test FocusManagerTest.IsTabTraversalKeyEvent Change-Id: I6252a5614390223c581d032d39dbad1c84de6b48 Reviewed-on: https://chromium-review.googlesource.com/1014651 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551377}
-
Lei Zhang authored
Valgrind bots are gone. BUG=605605 Change-Id: Ie722b831d0a6fca8b48620e5a9d993896346cbef Reviewed-on: https://chromium-review.googlesource.com/1014956Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551376}
-
Yash Malik authored
Injecting HOVER_EXIT is done by the platform if the coordinates for the HOVER_MOVE are out of bounds, so we don't need to inject it ourself. Bug: 819348 Change-Id: I4486f9970fac031373215bdcb7021de6a422da02 Reviewed-on: https://chromium-review.googlesource.com/1014715Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551375}
-
bsheedy authored
Adds an option to the VR bisect script to run in manual mode. This removes the automatic "gclient sync" and waits for user input before building and running the test. This is meant to be used in the rare case that some change in the bisect range breaks gclient sync and requires some DEPS change to fix. This allows the user to manually add in the fix and sync while still allowing the script to handle the building, running, and result retrieval. Change-Id: I7bfd5b7b059dec84b3feefbbc6ada3e01659d30d Reviewed-on: https://chromium-review.googlesource.com/1014460Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551374}
-
Greg Daniel authored
getTextureHandle on SkSurface is deprecated so moving chrome over to the new API. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_vr Change-Id: I55ec116814dbd62237b573da44938bc0a8fe877e Reviewed-on: https://chromium-review.googlesource.com/1010534Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551373}
-
Cody Peterson authored
The primary display rotation transforms for 90, 180, and 270 degree rotations have been updated so that located events are properly transformed to the new correct location after being subjected to the inverse root transform. The inverse root transform is used to take the (x, y) reported for a given located event and transform it to a new (x', y') to align properly with the transformation applied to the display graphics. Take the case of a display with the following characteristics: Height = 720 Width = 1280 Under the current case, the inverse root transforms are as follows: 90deg = [0, 1, 0, 0; -1, 0, 0, 720; 0, 0, 1, 0; 0, 0, 0, 1] 180deg = [-1, 0, 0, 720; 0, -1, 0, 1280; 0, 0, 1, 0; 0, 0, 0, 1] 270deg = [0, -1, 0, 1280; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] With the applied change, the inverse root transforms become: 90deg = [0, 1, 0, 0; -1, 0, 0, 719; 0, 0, 1, 0; 0, 0, 0, 1] 180deg = [-1, 0, 0, 719; 0, -1, 0, 1279; 0, 0, 1, 0; 0, 0, 0, 1] 270deg = [0, -1, 0, 1279; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] To see that these new transformations are correct, take the 270 degree rotation case and consider the corner points of the display. The corner point transformations under the old and updated transforms are: Old (0,0)-->(1280,0) (719,0)-->(1280,719) (0,1279)-->(1,0) (719,1279)-->(1,719) New (0,0)-->(1279,0) (719,0)-->(1279,719) (0,1279)-->(0,0) (719,1279)-->(0,719) The old transformations take the corner points and incorrectly update them, even outside of bounds for events at (0,0) and (719,0). The new transformations properly map all corner points. The same behavior can be observed for 90 and 180 degree rotations as well. BUG=None TEST=Check on devices with 90, 180, and 270 degree rotations Change-Id: I2d56cf1a4e871d3a08a886bc218fff7262157b73 Reviewed-on: https://chromium-review.googlesource.com/982373Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Cody Peterson <crpeterson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551372}
-
Emily Hanley authored
Bug: 779631 Change-Id: Id4848d02863e3e1533171495f56041eb8c5ec347 Reviewed-on: https://chromium-review.googlesource.com/1014954Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#551371}
-
Adrienne Walker authored
Chromium-side changes for: https://skia-review.googlesource.com/c/skia/+/120608 Bug: 829614 Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f Reviewed-on: https://chromium-review.googlesource.com/1008924Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551370}
-
mrefaat authored
Bug: 833872 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6c06c7e031dd2fcf8569c377e1d4696b45e007ca Reviewed-on: https://chromium-review.googlesource.com/1014714Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551369}
-
Jonathan Backer authored
This CL does several things: - Adds TransferCache methods to RasterDecoderImpl. This is copy-and-paste from GLES2DecoderImpl (including OOP-R setup). - Switches InProcCommandBuffer to use either RasterDecoder or GLES2Decoder based on ContextCreationAttribs. Logic for decision copied from GpuChannel. - Adds RasterInProcessContext for use by tests (copy-and-paste from GLInProcessContext but simpler). - Parameterizes TransferCacheTest to test both RasterDecoder and GLES2Decoder Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2629f0a9469abfaaf10b10ae28076d3e0881eb66 Reviewed-on: https://chromium-review.googlesource.com/1011104Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#551368}
-
Hans Wennborg authored
lld is LLVM's linker. It produces PE/COFF and PDB files just like link.exe, but it's significantly faster and it can also handle LLVM's internal representation, which will enable us to do link-time optimization and control-flow integraty checks with Clang. While lld is much faster at linking, it doesn't support incremental links, meaning builds that only touch a few files and re-link a large executable may become slower. This is the first attempt at switching everything over, with the purpose of gathering data and finding unknown unknowns. It's likely temporary until something breaks. is_win_fastlink is implicitly ignored when using lld, as lld without fastlink is faster than link.exe with it. Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's link.exe to make sure that configuration keeps working. Bug: 792131 Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d Reviewed-on: https://chromium-review.googlesource.com/983632 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551367}
-
Vaclav Brozek authored
This data member is not used. Bug: 833838 Change-Id: I0b1483ffb9195284de70f2b0649f431c0278345e Reviewed-on: https://chromium-review.googlesource.com/1013980 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551366}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02ba7243. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15711 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Iba62be41f86519a7e862eef4eaa1a27514dd666e Reviewed-on: https://chromium-review.googlesource.com/1015060 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551365}
-
Robert Ogden authored
Removes the histograms and related code, as well as what little helper functions were added when these histograms were added. Bug: 657541 Change-Id: I4bebf6d2b70fad9c0eb6b40edea9507f61e9bae3 Reviewed-on: https://chromium-review.googlesource.com/1014344Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#551364}
-
Sky Malice authored
Change-Id: I702a1a074b24961ba22ffed45fb856bd950f8dbc Reviewed-on: https://chromium-review.googlesource.com/1014372 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551363}
-
Artur Khachatryan authored
Test CorrectEventFiringTest.testSubmittingFormFromFormElementShouldFireOnSubmitForThatForm has become flaky on Android Chromium build bot. Disabling test. Bug: chromedriver:2286 Change-Id: I6f2fca1b9f74669a3796f1b9868f6314e541b882 Reviewed-on: https://chromium-review.googlesource.com/1014713Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551362}
-
bsheedy authored
Adds early returns to XRWebGLDrawingBuffer if the drawing buffer client is null. This fixes a segfault that was causing a renderer crash when exiting (or entering?) WebXR presentation. Bug: 833620 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaf03bff95f542da63e871b1abf8a96e1b0b29d7f Reviewed-on: https://chromium-review.googlesource.com/1014480Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551361}
-
Conley Owens authored
Just one more step in Removing the Physical Web from Chrome. BUG=826540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b99e83a64a0c655c37569cb7d9f0924bbfb6948 Reviewed-on: https://chromium-review.googlesource.com/988954Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#551360}
-
Alexei Svitkine authored
This reverts commit c3884364. Reason for revert: This has unintended consequences for Android Webview. Reverting so that the logic can be updated to not log the field for webview when the CL is relanded. Original change's description: > Update system_profile.proto. Populate app_package_name > > Bug: 833214 > Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217 > Reviewed-on: https://chromium-review.googlesource.com/1010055 > Commit-Queue: Shuo Weng <shuow@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551296} TBR=asvitkine@chromium.org,wychen@chromium.org,shuow@google.com Change-Id: I3c14d6f4b1a565d651c69be5d11a28959149f0c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833214 Reviewed-on: https://chromium-review.googlesource.com/1014205Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551359}
-
Victor Costan authored
Bug: 829893 Change-Id: I892ab0504e87ea2c6f65bdf932b030e6a7589f2b Reviewed-on: https://chromium-review.googlesource.com/998982Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#551358}
-
https://pdfium.googlesource.com/pdfium.git/+log/6b26e1ae6932..3900ddb64f30 $ git log 6b26e1ae6..3900ddb64 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 thestig Add a virtual CPWL_Wnd::GetText() method. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd6d94a554ab292fea802bd28549f1e82b4a3d69 Reviewed-on: https://chromium-review.googlesource.com/1014953 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551357}
-
Artem Titov authored
Don't depend on //base for webrtc standalone build, because it breaks webrtc compilation Bug=none Change-Id: I68bb4400e858a008ba6dfb7debfe6f6a6237b9ca Reviewed-on: https://chromium-review.googlesource.com/1013574Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Artem Titov <titovartem@chromium.org> Cr-Commit-Position: refs/heads/master@{#551356}
-
Katie D authored
NOTRY=true TBR=dmazzoni@chromium.org Change-Id: I52c8cb2287f31554f5c6faab740ebd701b135eed Reviewed-on: https://chromium-review.googlesource.com/1013693 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#551355}
-
Christopher Grant authored
The method that now draws all our textures was missing a dedicated trace event. Add it for easier developer profiling. BUG= R=tiborg Change-Id: I05e318b49dac4f36e768cba5010228904d06053a Reviewed-on: https://chromium-review.googlesource.com/1014332Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551354}
-
Mounir Lamouri authored
This is allowing the user to use Tab and up/down keys to navigation throughout the menu. It can also be closed using the Escape key. This change also trap the focus inside the menu while it's visible and make it so that hovenig an item will move the focus to it, like most menus will do. This is mostly for accessibility so users can interact with the controls using only a keyboard. The change applies to both the overflow menu and the text track list. Bug: 821131 Change-Id: I22db341d0d55a8e3297b3c7a18c92331e296cd9e Reviewed-on: https://chromium-review.googlesource.com/1013478Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#551353}
-