GitLab

This reverts commit 2b4b4ee8.

Reason for revert: CrOS OOBE/login-screen failures

See crbug.com/968554
eg: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/9026

Original change's description:
> ThreadPool: Do not run BEST_EFFORT tasks during startup.
>
> With this CL, a task posted with:
>
> base::PostTaskWithTraits(
>     FROM_HERE,
>     {base::TaskPriority::BEST_EFFORT, ...},
>     base::BindOnce(...));
>
> Will not be allowed to run before startup is complete.
>
> The signal used to know that "startup is complete" is the same as
> AfterStartupTaskUtils. It is not perfect. It will be improved in a
> separate CL.
>
> This CL aims to be the smallest change possible to allow seamless
> migration of BrowserThread::PostAfterStartupTask() to
> base::PostTaskWithTraits().
>
> Bug: 887407
> Change-Id: I83ef387b82496ece3ed10c0c2466f42a6a5b19b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631668
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Carlos Caballero <carlscab@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664488}

TBR=avi@chromium.org,gab@chromium.org,fdoray@chromium.org,carlscab@google.com

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887407, 968554

Change-Id: I205b250267fd629b5da5db646d3b93c522642949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637005Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664826}

Fixes a weakSelf lifetime issue in the target device sheet that
prevented the sending of the tab after the user selected a device.

Bug: 949226
Change-Id: Icda0279baea3bc524d36fbcc4d363a455d29d933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635412
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Auto-Submit: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664825}

This makes it a little easier to read / removes an ifdef.

Change-Id: If1d6505bf4820508e4bdd212be54bb3cb110a786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593733
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664824}

This CL fixes 2 bugs with Clank Start Phase 2.

1. When focusing URL bar, the current tab's URL was displaying.

2. Primary color was returning default color during tab switcher exit
transition. Fixed by observing if a tab switcher exit is in progress.

R=yusufo@chromium.org

Bug: 968210
Change-Id: Id2a934be168e38aa5ffd50f6bddbe393e8500c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635415Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Matt Simmons <mattsimmons@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664823}

This is a reland of 514383cf
Relanding without any changes. This got reverted at crrev.com/c/1636667 but the
CL is unrelated to the failures, as we can tell from the fact that the bots
didn't stop failing after the revert.

Original change's description:
> Make ChromeDriver/DevTools APIs return sink structs
>
> Make the get_sinks API return sink structs instead of sink name strings.
>
> Bug: 963963
> Change-Id: Idb6b555544f29aaa308b8d289335073348c653f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615982
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664485}

TBR=caseq,johnchen

Bug: 963963
Change-Id: I5c5484e804388a237e9db652bf4704a0cce0fd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637408Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664822}

This test is really fuzzy when it doesn't need to be, allowing for
fairly large error when all of the test cases match it exactly. Remove
the fuzziness.

Bug: 948128
Change-Id: I1101377700def57816f7479e139c4804ffe8aa0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637397Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664821}

VaapiVDA reuses and decodes into buffers after they come back from
clients.
This patch sets a flag |read_lock_fences_enabled| on the Picture passed
to VAAPI clients to make sure buffers won't be sent back until they're
completely used by clients.
This should prevent possible races where buffers are reused for decoding
before their contents are fully displayed.

Bug: 961411
Test: Instructions in the bug
Change-Id: I5584969f0c09b5b35584bf6f955b1a599b6ac0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636453Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664820}

* Enabled network service by default on Clank.
* Network service is in-process by default on Android and
  out-of-process by default on all other platforms.

Note: Network service in Android WebView is still disabled by default
      until further testing supports enabling the network service
      for WebView.

Bug: 953463, 962735

Change-Id: Ia775c01c29e51de082b8d60225c2b48bc7d5d59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588996
Commit-Queue: Chris Mumford <cmumford@google.com>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664819}

Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.


Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ

Bug: 907141
Change-Id: I18b4af39d13289a26abee1f36564538d9f8a14c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630970Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664818}

There currently exist two "factories for creating NSViews". They are:
- remote_cocoa::BridgeFactoryImpl
  - this is used for views::Widgets
- content::NSViewBridgeFactoryImpl
  - this is used by content::RenderWidgetHostView/WebContentsView
  - this functionality exists in content only because of dependencies
    that should be removed (but that will not happen soon)

Merge the content::NSViewBridgeFactoryImpl into
remote_cocoa::BridgeFactoryImpl. To deal with the layering issues
- add a SetContentNSViewCreateCallbacks function that may be used to
  set functions from content to call
- use a stub interface in remote_cocoa for the mojo interfaces that
  exist in content (this is already what is done for
  RenderWidgetHostNSViewBridge, for similar reasons).

remote_cocoa::BridgeFactoryImpl will in future patches be renamed
to remote_cocoa::Application (it roughly corresponds to an
NSApplication in another process). Start using the word "application"
in variables referring to this structure.

Change ui::ViewsHostableView, content::WebContentsViewMac, and
content::RenderWidgetHostViewMac to no longer use the "host id" to
refer to views::BridgeFactoryHost and content::NSViewBridgeFactorHost,
but rather access the remote_cocoa::mojom::BridgeFactory (to be
renamed to remote_cocoa::mojom::Application) directly. Delete the
concept of "host id".

Move the WebContentsBridge mojo interface from content/public to
content (this interface is ultimately targeted to go to
components/remote_cocoa, so it should be kept out of public paths).

R=ellyjones (cleanup)
R=dominickn (mojo)
TBR=avi (content/, chrome/)

Bug: 958255, 888290
Change-Id: I2bb001b5f53bd67b5bbd65b59e7cfaab100fbd34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633111
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664817}

BEST_EFFORT tasks will not run until after startup and only if there is no
critical work pending.

This patch should not change the current behaviour. Please double check
whether the task being posted via BrowserThread::PostAfterStartupTask
really cares about being run after startup or just wants to run after
any critical work was completed. If you are fine with it just running
after critical work has completed LGTM and keep on with your life. If
that is not the case let me know and please explain your reasoning in a
comment.

More details:
https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI

This CL was uploaded by git cl split.

R=calamity@chromium.org

Bug: 887407
Change-Id: Ibf4ce78002aa2da9980ed7229d79e8c0fea1711d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632163
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#664816}

Using wpt-import in Chromium 525933f1.
With Chromium commits locally applied on WPT:
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
abf2ac5e "webrtc wpt: avoid race conditions"
d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property."
0882bebe "Change ICE connection state on transceiver changes"
1bbbd106 "Add feature policy for client hints, used for third-party subresources."
2229f484 "Revert "Change ICE connection state on transceiver changes""
ab94a58b "Add the remaining Client Hints to Feature Policy."
e1be827e "Reland "Use promise in wpt pointer event tests to finish the tests""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I319ec8d2166b1fdd030a73876fe35f72db9a1fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637428Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664815}

This avoids potential controller position glitches which would
make a controller appear to temporarily teleport to the origin
on a 6DoF headset.

Bug: 968193
Change-Id: Ia284e9bdf809231784dfafdaccb90d1dc33f8134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636563Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664814}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=qinmin@chromium.org

Bug: 616447
Change-Id: I690e54134472c8583fddd396e0513b25012d399c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636061
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664813}

To verify if |blockSelectionClient| in SelectionPopupControllerImpl was
set to false when these tests were failing

Bug: 967811
Change-Id: Id11ac9df208c2f0c2d371cbd90e55fe4789b7e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637435Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664812}

Bug: 892299, 967472
Change-Id: Ib2dd89a38e656193c7d78468227c6b54f08cf791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636849Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#664811}

In the sensors tool, when orientation is disabled, hovering over the
orientation stage shows a message prompting the user to enable
orientation in order to rotate. Before, the tooltip said that the
user could drag to rotate, even when orientation is disabled.
Before and after images: https://imgur.com/a/7RGhZGZ

Change-Id: I40114f3322a85c50744cdb5d2f69a61aa572a8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629208
Commit-Queue: Olivia Flynn <t-olflyn@microsoft.com>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664810}

The Text Aggregation implementation introduced a regression
in paint time. The regression was caused by
ScopedPaintTimingDetectorBlockPaintHook where we save frame_view
as a persistent object every time we paint a block element.

This CL will correct this issue by making frame_view a Member
instead of Persistent so as to introduce less overhead.

Other things this CL do:
1. Capture text and aggregator only when
paint_info.phase == PaintPhase::kForeground.
2. Move the aggregator hook from block_painter to
line_box_list_painter. For LayoutNG, we've also moved its
hook from PaintBlockFlowContents() to PaintLineBoxChildren().
3. Call aggregator hook only when a block has children inline.

The above two changes will reduce the unnecessary block hooks.

Reference:
https://chromium-review.googlesource.com/c/chromium/src/+/1591949
https://docs.google.com/spreadsheets/d/1QWU7qh2GbkfW6Qxz0pqy8KInLqjoHuLJcN1g2I2XZZY/edit#gid=0

Bug:965011

Change-Id: Ie89dc5e873a408c75f3a414d33ec46bc80307cc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634613
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664809}

The consent dialog strings - title, body, button texts - are all shared
between Android and Windows.

Bug: 963637, 962755
Change-Id: I4d3f090db1ee2487f305b6993b2851c112df594c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620695Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664808}

The Google Search App seems to put the clock icon on these suggestions.
We should too, as we try to be congruent.

This has no effect unless one of the two clock icon flags are on, and
they are both off by default.

Bug: 929477
Change-Id: I69b62e47fcbdc70b738738340e4a134f4a2c4a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636559Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664807}

This CL replaces ScopedNestableTaskAllower with kNestableTasksAllowed passed
as argument to the RunLoop involved if any.
Only native nested loops should use ScopedNestableTaskAllower (soon to be deprecated).
For more details, see:
https://cs.chromium.org/chromium/src/base/message_loop/message_loop_current.h?sq=package:chromium&dr=CSs&g=0&l=159

A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1635819

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 766678
Change-Id: I6624b7e20ad6d7852fa91151ddd149932cebe516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636056
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664806}

Per the spec, a selectend event should always be sent if a selectstart
event has been fired, evenif the gesture is cancelled.  Currently if an
input source was removed but it had sent a selectstart event a selectend
event would never be sent.  This fixes that for both the cases where an
input source is lost, and if the session ends while a controller is
pressed.

Per the HTML interaction spec, since these removals cannot be
guaranteed to have fired as a result of user interaction, the frame
is not notified of UserActivation in this case (and as such the
OnSelectEnd method is not re-used).

Bug: 968291
Change-Id: Ibea99e59ee7a528b7a34db610bfca76c27d495b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636851Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664805}

We regain some microtime by only checking the math in `Release` in DCHECK
builds. In production, don't check.

Bug: 965157
Change-Id: I8a4b84bd2e51bbe26c182d355116ebee2fac9cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636593Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664804}

Hidden items:
 1. Ime menu tray
 2. Overview button tray
 3. Palette tray
 4. Logout buton tray
 5. Virtual keyboard tray

Bug: 948955
Change-Id: I8ade734877dfeb6ef45e6516c86384328a1d052f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622366
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664803}

1. Implement vulkan representation of the SharedImageVideo.

2. Skia promise image requires sampler conversion information ycbcr
in the vulkan mode. This information is needed during the promise
image creation time which happens before BeginReadAccess. This is
done by passing this info to promise image via
VideoFrame->StreamVideoDrawQuad->ResourceMetadata.

3. Add ycbcr info to the video frame. Update required mojom and struct
traits.

4. Add ycbcr info to the StreamVideoDrawQuad and update required mojom
and struct traits.

Bug: 900963
Change-Id: Ie4537604efe446492377d3615ed7c3cfde8c2130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582774
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664802}

Use the InjectGestureScrollEvent API to additionally generate gesture
events to scroll when dragging the thumb, tapping scrollbar parts or
handling gestures forwarded from the browser process.
Instead of invoking ScrollableArea::UserScroll or
SetScrollOffsetSingleAxis, we'll instead generate the appropriate
sequence of scroll gesture events to further unify how scrollbar scrolls
are performed and allow us to gather latency metrics on them. This is
done under the ScrollbarInjectsScrollGestures feature flag (currently
off by default).

For thumb moves, we don't know which direction the scroll will be when
we get MouseDown on the thumb part, which can cause the correct node to
not get added to the scroll chain. Because of this, we use the existing
pattern of generating the GestureScrollBegin 'on demand' when we inject
the first GestureScrollUpdate. This removes the need to inject GSB on
MouseDown, since it works the same way for mouse-down on other parts
as well.

Additionally, if we inject scroll gestures targeted at a
ScrollableArea, in ScrollManager we don't route those gestures to the
scrollbar_handling_scroll_gesture_ but instead bypass and just use
the event_target/scroll_gesture_handling_node_ which was set when the
ScrollableArea was targeted. This allows for GSB/GSU sent from the
browser process to continue to be handled by the scrollbar code (needed
in order to reverse the scroll direction and make the scroll
proportional to the scroller/scrollbar size) while the injected scroll
updates (interleaved with those from the browser process) target the
scrollable area and perform the actual scroll.

One other note: currently, gestures targeting a scrollbar do not
snap when the gesture is completed. Because the scrollbar is handling
the updates (returns true from Scrollbar::GestureEvent) the logic to
handle snapping is never executed. This change fixes this completely for
scroll gestures on scrollbars, but has the side effect of scrollbar taps
on track/buttons to not have a visual effect in the face of snapping.
The code currently just immediately injects a GSE - this is processed
before there is any visual indication of the scroll happening and thus
to the user, it doesn't look like a scroll happened.
This will be addressed in a follow up change to post a delayed task that
will inject a gesture scroll end and clear the pressed part, etc.

Bug: 954007
Change-Id: Ic8a641a3183d5613088a3392bb6bde8fe44e45e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633112Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#664801}

These scripts help with gathering and processing historical data to be used for clustering.

Bug: chromium:959971
Change-Id: I1b42612324be0e9ce2e74babe6cdfb52c92f5c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594779
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664800}

For a tab that is requesting its mobile version site, and is not
originated from ARC context, return to its normal version site when
exiting tablet mode.

Bug: 953577
Change-Id: Ifa1f3b694ae5b237b80ea912f7e1b981b7d0debb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637181
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664799}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6dc629b226f..e18325d988a5


Created with:
  gclient setdep -r src-internal@e18325d988a5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com

Change-Id: Iddef9575cd97586b7c9f5b3d7512de28517dec35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637390Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664798}

This allows for testing of mediators that set up AlertViewControllers.

Bug: 941745
Change-Id: I103f40000d3a9714ba782c41fbf2976263122728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636397
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664797}

Change-Id: I2a049b3c8ad7ed50b478d6ba2f8aded22544a307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628989Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664796}

This CL exposes a way to close bindings on an interface so that the
client can explicitly disconnect and stop receiving messages.

Change-Id: I322f4e41d5522fe8aa7ba9b4a1eb702607281dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636850Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664795}

Fixes a crash.

Bug: 968014
Change-Id: I70b4aaea1d42c766920bebfcfb64e946b3499512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634748
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664794}

[MessageLoop]: Replace MessageLoopCurrent::task_runner() in /content/public/test/test_download_http_response.cc.

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=dtrainor@chromium.org

Bug: 616447
Change-Id: Ib6d3b417344ca2ece7c09d98b52a8f6e79b480f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636358
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664793}

Change-Id: I5f729822140f544717432aa0b45c56dfdf30b9ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636787
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664792}

Updates a unit test to match the logic change introduced in
a548a739 (Don't run tcmalloc
dependent unit tests with sanitizers).

BUG=b:70905156

Change-Id: I7ab3810321fc607c0cdb5c4cd737bbd44223bce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636343Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Auto-Submit: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664791}

Changed icon to a 20x20 question mark

Screenshot: https://imgur.com/a/I3bjAsb

Bug: 953800
Change-Id: Ia07d6ab627725a9c37724b175aead33e4865d3f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621689
Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664790}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=thakis@chromium.org

Bug: 616447
Change-Id: I28a3d9671e8546ce33c1012771d464380df5bb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637457
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664789}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=sammiequon@chromium.org

Change-Id: I82d400ba9fa58b1532047c0781ea27f0da89ab44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636351Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#664788}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I2240a1dd90a86cbae9c0be476e94aef873a5134c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637438Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664787}