- 14 Dec, 2020 40 commits
-
-
Cheick Cisse authored
Create Open javascript action and set up histograms for contextMenu actions Bug: 1140387 Change-Id: I836eff307c6de1a8b233c3018a9856799bd43513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584646 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#836802}
-
Pavol Marko authored
Remove all references of ACCOUNT_TYPE_SESSIONLESS_USER from SessionManagerClient, in preparation of removing this account type from session_manager. The only user of this account type was PreSigninPolicyFetcher which was removed in CL:2513205 Bug: 832127 Change-Id: I3b8e8a9fdfb38c5cc925a1c77dafc3a96297b054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513584 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#836801}
-
Shengfa Lin authored
ChromeDriver python tests sometimes encounter timeout while launching browsers. Currently, ChromeDriver would try to re-launch browser again with max retry of 3 for all tests. However, the original browser might still be launching after the retry/retries. This change is to terminate/kill the original browser before the retry. There are two benefits: 1. If the original browser is terminated/killed before retry, then we will not see the log from it later in ChromeDriver log. This can avoid confusion. 2. It reduces resource consumption with less concurrent browsers running. This is in hope to reduce test flakiness. Change-Id: Ie31c155398e1c4ca19d3697e6f25f853323191ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586972 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836800}
-
Theo Johnson-kanu authored
- Before this CL maximum delay before rotating background advertisement was 15 minutes. This CL lowers that time to 14:30 minutes or 870 seconds. Bug: 1157171 Change-Id: I1866f843ace4076ac2af2a6998f9fbeb492afe64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588300 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836799}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I179c720aa3b384c243cf61c3186fae17f8acfc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585691Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836798}
-
Stephen McGruer authored
Bug: 1158023, 1048761 Change-Id: Iddb98f4e8f346e6bf2b2249a14a5b1c6f1eb2f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590424 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#836797}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib01124680727235df66644f8a6dcbab7d4b51f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590391Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836796}
-
Phillis Tang authored
On WebAppInstallFinalizer::FinalizeInstall, if there is an existing app but the install is user initiated, overwrite user controllable fields like user_display_mode. Bug: 1124300 Change-Id: I011fb0f9306b89d6de76256d3d6c7b197c310171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583202 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#836795}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2eec62f. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I173630eff103d7f1d2508694fea1abd75d07741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590017Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836794}
-
Peter Kasting authored
The existing code bases the decision on whether the toolbar button icons have a custom color, which causes accessibility problems. Bug: 1153079 Change-Id: I0f9996891a7327ffed3d45b77944fa33481b8b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587578 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836793}
-
Side Yilmaz authored
This CL make ToolbarButtonInProductHelpController use the correct profile instead of using always regular profile. Bug: 1048632 Change-Id: Icde76cb9e023c8159b44611f943084080435a884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567227Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836792}
-
Sven Zheng authored
This is a reland of efe87dc0 Original issue was fixed in crrev.com/c/2584633 Locally tested Lacros can build with these gn args. Original change's description: > [Lacros] Use cfi and thin_lto for Lacros official build > > CFI and ThinLTO were disabled on the simple chrome workflow > because they increase build time quite a bit. > But for official build, then should be enabled. > > Bug: 1157567 > Change-Id: I33a9eac37221f31da9a6725b19992d5daded72dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586085 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835956} Bug: 1157567 Change-Id: Ib8d009f1e0e8efe8b8c3033086c9df4b6d596175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590075Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836791}
-
Trevor Perrier authored
This CL updates the language on two error messages in translate_prefs.cc Bug: 1028966 Change-Id: Id15a6886e257007988763b4e557ee5da02b1db68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587608Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#836790}
-
Andrey Kosyakov authored
Bug: 1128206 Change-Id: I7bc10beb585f07b6f49e61faae9cd8ab35eaa5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587606Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#836789}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4747e2779d79..b9e29f68c268 2020-12-14 brgoddar@microsoft.com TextPrompt: Limit Autocomplete Retry to suggestion builder filters If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157017 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I732c9f2b5db722c990f1f04cb0d7211d4d719fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836788}
-
Gordon Seto authored
Update contact visibility description strings. Screenshots: https://screenshot.googleplex.com/hYrwMyzZVk5NkTu.png https://screenshot.googleplex.com/BAQr9hf5jbQdm4s.png Fixed: 1158484 Change-Id: I32676f87c1a25c536319c44debb8ddf7c1a462b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590704Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#836787}
-
Daniel Cheng authored
Neither the category nor the name are supposed to include double quotes, but the macro doesn't enforce this. While it's possible to add a check that both arguments are free of double quotes, this CL implements an alternate idea suggested by danakj@ to simply make both the category and the name string literals. One tricky part is that the original macro defined two variables, and used the name to (try to) generate unique identifiers. However, if name is a string literal, this is no longer possible, as it's not possible for the C preprocessor to unquote strings. While it should be possible to rig together enough macros to generate a (hopefully) unique identifier using __COUNTER__ and then pass it as a macro argument so the identifier may be used in multiple places, this CL takes an alternate approach. It allocates the static pointer to the crash key inside a lambda expression to avoid having to name it at all. Change-Id: Ie264223a7da18a552670782af9b02aa17cad0290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585678 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836786}
-
Saurabh Nijhara authored
DeviceAutoUpdateTimeRestrictions policy has been updated in the update engine code. It now supports cancelling an ongoing update when a restricted time interval specified in the policy starts. The scope of the policy is no longer limited to just kiosk mode. The policy is not applicable in case of update from version lower than minimum Chrome OS version, quick fix build update, enterprise rollback and interactive update. Reference Chrome OS CLs - https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2572916 Bug: 1117450 Change-Id: I3df1a81ae4f35d356ecdcd7529a4827b614de92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584865 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836785}
-
Mason Freed authored
The slotchange event is fired on slots the first time they receive assignedNodes. This is the case on all browsers. The previous test just checked that *any* slotchange event was fired, which always passed. The conditions being checked could be removed from the tests and they would mostly all pass. With this CL, the assignedNodes() are compared to the expectations, to ensure a pass. The tests that check multiple slots are a bit of a hack, since the slotchange events come asynchronously. But this still seems better than the prior test. Another note: despite documentation [1] saying that the assignedNodes() accessor should return fallback content, it does not. This is also the case for WebKit and Gecko. Further, the prior test strongly implied that 'slotchange' should be fired for changes to the fallback content, but due to the above fact, no such event is fired, since the assignedNodes() value does not change. [1] https://developer.mozilla.org/en-US/docs/Web/API/HTMLSlotElement/assignedNodes Bug: 1158001 Change-Id: I2ce15d53239f2c9204d1f1633f333897139e337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587711 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836784}
-
Fabrice de Gans-Riberi authored
This adds a standalone cast streaming receiver implementation intended to be used for tests involving cast streaming. Bug: 1110490 Change-Id: Ide0e33587d2e269e8808102342cc30aa7513cb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583103 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836783}
-
Christoph Schwering authored
This CL refactors FormStructure::SectionenedFieldIndexes in some ways: - it moves the class from the private part of the header to the body; - it eliminates the std::vector copies in CurrentSection() and CurrentIndex(); - it eliminates the use of pointer arithmetic in FormStructure::RationalizeRepeatedFields(); - it eliminates casts of -1 to size_t, which is undefined behaviour; - it names the member variables in a style-conformant way. Bug: 1007974 Change-Id: Id6580c7962abd9d69bdb5c1f5a7b1bed3f9759c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587061 Auto-Submit: Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#836782}
-
Hongbo Song authored
Bug: 1152552 Change-Id: I8d8de0c6ffc4bcaad61e914736ecfe1428a6a472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588642 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#836781}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I198128b18209814d1c4e5ac2a3bf5a554d866e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590285Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#836780}
-
Brian Sheedy authored
Fixes a typo in update_wpr_unittest.py that causes a test to fail with newer versions of the mock library due to assert_not_called actually working properly in newer versions. Bug: 1156832 Change-Id: Ic980f181ca18c3b0e2148fcdbd35fde39bd5c1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587756 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836779}
-
chrome://flagsdpapad authored
Bug: 1148478 Change-Id: I40eb960f78bb165320483f17cae361ee299a5961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589453 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836778}
-
Raymond Toy authored
Add metrics to record the value of latencyHint which can be one of four values in the following order: "interactive" "balanced" "playback" exact The first three are the values of the AudioContextLatencyCatergory enum. The last is for case when an explicit floating-point value is given. When the hint is a floating-point value, we record the value in milliseconds. Each of these metrics are recorded each time an AudioContext is created. Bug: 1156304 Change-Id: I264f6f9a38983bd0e40f42e720cfcf685e7a1cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586047Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836777}
-
Fredrik Söderqvist authored
In some fairly generic code-paths we can have a 'filter' property while not actually applying it - and thus don't have a SVGResourceClient. (For example for 'filter' on <feImage>.) Bug: 1158392, 1028063 Change-Id: I12bf8b6120a17f750582f037d59951a565731210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589837 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836776}
-
Fredrik Söderqvist authored
We can get null SVGResource objects if the property references an external resource while external resources are not allowed (which is the case for most properties ATM). Bug: 1158420, 1028063 Change-Id: I9fbd92166250cb2ba954cb754e3b3b0d1c476a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589877 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836775}
-
Clark DuVall authored
This is a reland of f63587ac Reason for reland: This broke on L because loadNativeLibrary returns void and it was being cast to int. We don't actually use the return value for anything, so just return success on L/M. Original change's description: > [WebLayer] Fix relro sharing in GPU and load native lib in the background > > WebLayer relro sharing in the browser process has likely always been > broken in WebView compatibility mode because the ClassLoader created > does not have a class loader namespace, see here: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/native/webview/loader/loader.cpp;l=129-132;drc=master > Unfortunately, this is difficult to fix since sharing relro in WebLayer > when it is loaded in the same process as WebView causes crashes. This > will be investigated more in a follow up. > > Relro sharing was never implemented for the WebLayer GPU process, and > this change adds support to do that. > > In addition, library loading is kicked off on a separate thread much > earlier in startup, which allows it to finish before it is needed on the > UI thread. > > Pinpoint runs: > startup.mobile: https://pinpoint-dot-chromeperf.appspot.com/job/169ab7ef520000 > -18.4% messageloop_start_time > -3.4% navigation_commit_time > -1.8% first_contentful_paint_time > > weblayer_startup: https://pinpoint-dot-chromeperf.appspot.com/job/17959d48d20000 > -6.4% weblayer_startup_wall_time > > system_health.memory_mobile: https://pinpoint-dot-chromeperf.appspot.com/job/16d61b37520000 > -10.0% (3.9MiB) all_processes private_dirty_size > -29.8% (3.7Mib) gpu_process private_dirty_size > > Bug: 1146438 > Change-Id: I52292f0472f18397b0a900307649e6f1b54bd5c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581007 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835580} Bug: 1146438 Change-Id: I189a6a3605174a60a5269839c6cb3ce89c18efbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586518 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#836774}
-
Alex Turner authored
Rarely, a subframe navigation to about:blank can have an ongoing activation throttle, which is unexpected and triggers a DCHECK. Such a navigation should not have a throttle created. We add a DCHECK to ensure a navigation with such a URL does not. We also temporarily add some DCHECKs that will provide some detail about the redirect chain when an unexpected filter is found. Finally, we add a DCHECK that covers uncommitted initial loads. These will only trigger when the original DCHECK already would have; which DCHECK triggers will tell us details about the navigation. Bug: 1155870 Change-Id: Id6ba3f47f75ef871456c2bd311995b4f7ff2ddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576433 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#836773}
-
Aaron Leventhal authored
When replacing an AXObject with a different type of object, and keeping the same id, we don't want to remove it from the relation cache, is its relations are still the same. In addition, make sure that AXIDs that are removed are removed from all relevant maps, so that the condition cannot occur where an AXID is removed from an owner children map, but is still tracked by the owner, thus its owned children do not think they are owned. The best failing test for this is in CL:2585685 which turns on accessibility for all browser tests, via browser_tests --gtest_filter="HistoryListTest.*". Bug: 1153576,1156936 Change-Id: I0bb4d38f78b343bd34d2e42e1cf695fcfd99460e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584610 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#836772}
-
Shengfa Lin authored
Add a sentence to describe New session command in New Request section Change-Id: I4ac4d6273e9d10afa2ac0b73b0e47d760df0f117 no-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585108Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#836771}
-
Solomon Kinard authored
Change-Id: Id537c69afff7c933498f072ec4b0fd1741e8d1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559801 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#836770}
-
Joon Ahn authored
Similar to using base::TimeTicks over base::Time, performance.now() only ticks forward and allows us to not worry about system time changes. It also allows for easier mock in tests. Bug: 1156229 Test: browser_tests --gtest_filter=*NearbySh* Change-Id: Id1cf98d77b5f3557aaa95daf8a3114714ef97008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587613 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836769}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607925234-ef20c18621d9ca5f7c0d39fedb05c76a05c36900.profdata to chrome-mac-master-1607968714-c306ec7882cc59048926f4cb1ac6492a09bdd2f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5ecabd006d5301fcbd61c9dcdf1ab0669f8c83dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/928ad2740611..4b99456364d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158020,chromium:783819 Tbr: atotic@google.com,ftirelo@google.com Change-Id: I4b016e987a6e2d38f57df92f6073f3ac880d64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iffa6165398de3f1e011ca39b097b42ac7e0db108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836766}
-
Michael Lippautz authored
Inheriting from Heap* containers is dangerous because of missing virtual destructors and trace methods. This only leaves HeapHashSet as container that can be inherited from, which has one actual use in production code. Bug: 1056170 Change-Id: I66a301754adb4d970ccc631f1113edcb915c3abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589855Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836765}
-
Peter McNeeley authored
Bug: 1113306 Change-Id: I631f1d722acf8c39c296643e16c12ce6f3d0e95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585629Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#836764}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/39f69dcae076..1f0dc9cd1b82 2020-12-14 johnstiles@google.com Update SkSL type priorities to differentiate signed/unsigned types. 2020-12-14 johnstiles@google.com Fix various SkSL errors that don't report a line number. 2020-12-14 brianosman@google.com Centralize storage/initialization of SkSL::Compiler in GrGpu 2020-12-14 brianosman@google.com SkSLSlide: Guard against asserts in the compiler 2020-12-14 johnstiles@google.com Replace SkSL::Type constructors with named factory functions. 2020-12-14 kjlubick@google.com [canvaskit] Update to emsdk 2.0.10 2020-12-14 kjlubick@google.com [canvaskit] Update Chrome version and use npm ci for tests 2020-12-14 kjlubick@google.com [canvaskit] Update npm dev dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I2e4bdabf3855e98b9b5d8589b06d81380a7894e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836763}
-