- 18 Feb, 2020 40 commits
-
-
Maksim Moskvitin authored
DeprecatedInvalidatorRegistrar is a part of the legacy implementation of invalidations. This CL removes it and replaces remaining usages with InvalidatorRegistrarWithMemory. Bug: 1029481 Change-Id: Ic0e8733c096ee327c82a5aeaeea7cbf8be3bcb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056727Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#742109}
-
Vasilii Sukhanov authored
This reverts commit 0de7bdfe. Reason for revert: UMA may want to use HTTP Original change's description: > Enforce https for all googleapis.com endpoints. > > That question came up during security review. We should enforce HSTS at least > for the password leak check API. However, it's benificial to enforce it for all > possible APIs. > > Bug: 1049177 > Change-Id: Ieacb6675c195c89606cc3a8d956bdfa855b8b64f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057125 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Nick Harper <nharper@chromium.org> > Reviewed-by: Nick Harper <nharper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741576} TBR=vasilii@chromium.org,nharper@chromium.org,cthomp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049177 Change-Id: I34828caed420ef7705b733d5a608ca0deb94f3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060955Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742108}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2988bc84. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 145f7594 "[NativeFS] Enable storing handles in IndexedDB." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I80281408befed99192211cfabacdc092bb1e692d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742107}
-
Simon Zünd authored
Asynchronous source mapping requires asynchronous live location. Links to CSS files use live locations. Therefore, dumping styles that contain links need to properly await pending UI updates. This CL prepares all web tests in http/tests/devtools/elements/* for this upcoming asyncification by awaiting * ElementsTestRunner.dumpSelectedElementStyles * ElementsTestRunner.dumpComputedStyles Note that we can not use {then} syntax as these methods do not yet return actual promises. This CL is a straight up mechanical change that adds adding async/await to all call-sites. Bug: chromium:1032016 Change-Id: I1285bae6125e1c3b3f3857eb32368ef96653c212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061748 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#742106}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d353ca088149..e51f8dd09af0 git log d353ca088149..e51f8dd09af0 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cwallez@chromium.org Fix compilation with stdlibc++ (instead of libc++) Created with: gclient setdep -r src/third_party/dawn@e51f8dd09af0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifd6219f1b6c06ab2126876f80b71d27a5db581a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742105}
-
Nazerke authored
Tab Page Coordinator. This CL modernizes the ContentSuggestionsCoordinator and NewTabPageCoordinator - use the superclass -initWithBaseViewController:browser: initializer, instead of -initWithBaseViewController:. - remove the public property for dispatcher, browserstate. - use self.browser to get dispatcher, browserstate values. Bug: 1029346, 1048398, 1048421 Change-Id: I63833d751d9ed6031a9b7d502a7fbfe2fdc203b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035991Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#742104}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f78c3a6a..961ac1ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ide4ace361118d243bc94957e11df0155ab3b1b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061868Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742103}
-
Alice Wang authored
This CL fixes the bug that ConfirmManagedSyncDataDialog throws NPE when it is recreated. Bug: 1033911 Change-Id: Iecc87fdb04026e0e86c7c964ef16132a870c885c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057066Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742102}
-
Friedrich Horschig authored
Extend click metrics which remain relevant for saving and updating. Bug: 1053094 Change-Id: I082d70ed7e6170cb5bfc36ee1dab38674f9f1abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061249 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742101}
-
Bret Sepulveda authored
Test is timing out. TBR=estade@chromium.org Bug: 1052802 Change-Id: Ie2d035437475d98cbeda7b15ee4bf88b32ee39b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060957Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742100}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib5913775863401c68d680c68da30a5be723a514f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061799Reviewed-by:
-
Maksim Ivanov authored
This removes the flags that were incorrectly specified for the force-installed login-screen extensions/apps (installed via the DeviceLoginScreenExtensions policy) : * The FROM_WEBSTORE flag wasn't necessarily true, since the policy can specify any update URL - so it can also point to a self-hosted CRX file. (In particular, this is used in a few browser tests.) * The WAS_INSTALLED_BY_DEFAULT flag seemed to be not suitable as well, since the policy-installed extensions aren't "default" (unlike, for example, the "offline Docs" extension). This CL is expected to have no functional effect for the existing scenarios for the login-screen policy apps/extensions (e.g., smart card login or Imprivata login). However, the CL makes the flags more precise, and prevents problems with future code if it tries to make some decisions based on the presence of these flags. Bug: 888172, 1051513 Change-Id: Ibdb70ff664b462edf660a21db0451f22d4632803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049855Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#742098}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4bdd08e3ef7e..4af17e434cdc git log 4bdd08e3ef7e..4af17e434cdc --date=short --first-parent --format='%ad %ae %s' 2020-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 481daed34f15..0bbf7ba9f909 (5 commits) Created with: gclient setdep -r src/third_party/skia@4af17e434cdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I66f82a200c81cd8483a064de05c73d10e23df1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061790Reviewed-by:
-
Yutaka Hirano authored
Remove services/network/loader_util.{cc, h}. Also rename kFrameAcceptHeader to kFrameAcceptHeaderValue and kDefaultAcceptHeader to kDefaultAcceptHeaderValue because sharing the same suffix for the header name and header value is confusing. Bug: 1049483 Change-Id: I3a3eeee420f3c5c57f1021f50ed2ea344ead07ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040857 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742096}
-
Bret Sepulveda authored
After landing crrev.com/c/2054095 these tests should no longer be flaky, so they are re-enabled. If one of these tests begins flaking independent of the others, please disable it individually. Bug: 1050712, 1049036, 1049063, 1048980, 1048956, 932402, 947668 Change-Id: I2a18bdad8ae07155a0ff9333e7547e0338d07834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059413Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742095}
-
Harald Alvestrand authored
The test for getStats() on an RTP receiver was testing with the wrong track (sent track not received track). The change gives a reasonable error message (not all stats are present). Bug: none Change-Id: I7f35dc90a2e4f6ee4ed67e8d6ae2ecdf9246c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060952Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#742094}
-
Alex Danilo authored
Uses the CSS properties 'has-cursor' and 'hide-pending' to apply a background color to the search box wrapper when it's open. Bug: 992823 Change-Id: I3fc27b9cac65d2cfeb5985344ad4140c8992c912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060215 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742093}
-
Alice Wang authored
This CL changes add account icon in account picker dialog to mobile identity consistency project style. Screenshots: https://crbug.com/1044614#c1 Bug: 1044614 Change-Id: I4684c23a1cedee2459b223c7ec10e14be2411324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995165 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742092}
-
Fabian Sommer authored
Change some paddings and font sizes in the PIN UI. Bug: 1051862 Change-Id: Ic70694c75e65dfa8aaf9aaac1bde25f74a870320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058818Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#742091}
-
Alice Wang authored
This CL cleans up some unused methods and method return values in SigninTestUtil and IdentityManagerIntegrationTest. Bug: 1004418 Change-Id: I09c3126d2b954304defffa4a7eefc64bb2423cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054093 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f8af01a92a0..a8bd7a17cf77 Created with: gclient setdep -r src-internal@a8bd7a17cf77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1051776 Tbr: jbudorick@google.com Change-Id: Ica7bcaca1ae7ea59dee66ae33715b9eb2087b0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061788Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742089}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e0661d7dd4e..7efa03ac94b5 git log 2e0661d7dd4e..7efa03ac94b5 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 481daed34f15..0bbf7ba9f909 (5 commits) 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src ae59435606fc..113d07a6ebda (1 commits) Created with: gclient setdep -r src/third_party/angle@7efa03ac94b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I6d0c6fbdfe69187596fdc111b592a1cde6887d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061789Reviewed-by:
-
Simon Zünd authored
Devtools web tests that dump stack traces use source maps to translate source locations. The upcoming asyncification of the source mapping machinery requires that test helpers properly await the result of source mapping. This CL prepares some web tests in http/tests/devtools/sources/* for this upcoming asyncification by properly awaiting {SourcesTestRunner.captureStackTrace} and friends. This CL is a straight up mechanical change by adding async/await keywords in the necessary places. Drive-by: Also await {ConsoleTestRunner.dumpConsoleMessages} in the http/tests/devtools/sources/* web tests. R=mathias@chromium.org Bug: chromium:1032016 Change-Id: If5962a091f872a3aef32f1af005b9e4aa37671bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061150Reviewed-by: -
Hitoshi Yoshida authored
Generates setXxxToNull() to set null value on a nullable dictionary member, whose C++ type uses base::Optional<T>. This API is a migration adapter, and there are some use cases in hand-written code. We also can set a null value for other types using setXxx() APIs. Bug: 839389 Change-Id: I6989a58ed3542d4f76f7b9e519f3c49947732904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060406 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#742086}
-
Ian Struiksma authored
In http://crrev.com/c/2041592 class variable 'element_' was sent in FindFormAndFieldForFormControlElement method call when previously it had been function variable 'element'. This sends it as it had before. Bug: 957444 Change-Id: I5a985ae59b678ac47bc9c038c9fd8d33814fc3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057539 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742085}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8f1ba5bf1dbb..e22500101fbd git log 8f1ba5bf1dbb..e22500101fbd --date=short --first-parent --format='%ad %ae %s' 2020-02-18 khamu@microsoft.com High contrast update for Network panels Created with: gclient setdep -r src/third_party/devtools-frontend/src@e22500101fbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie73f8c73d673522a45c3eba57e657717177554d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061381Reviewed-by:
-
Fredrik Söderquist authored
This replaces the LayoutObject* in SVGFilterGraphNodeMap's mapping from "filter primitive" -> "filter effect" with a weak reference to the SVGFilterPrimitiveStandardAttributes. This avoids the step through the (basically unused) LayoutObject as well as keeping a raw pointer reference in the node map. Bug: 109224 Change-Id: Ic2874013d3986d9a0a108e4e790590a65988ba15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060075Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#742083}
-
Jason Lin authored
... instead of the cancel button. Bug: 1016195 Change-Id: I018874940dbfb72e6c99e6fedc7c8222866db4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059619 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#742082}
-
Marijn Kruisselbrink authored
This is the last in a series of CLs to enable storing native file system handles in IndexedDB. This adds the plumbing from blink to the browser process, as well as logic in IndexedDBBackingStore to actually serialize handles to disk. Bug: 955193 Change-Id: Ib43e0395d0355cd2ab24eef33168f4e09879f0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931647Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742081}
-
Hiroki Nakagawa authored
This reverts commit 1431d28a. Reason for revert: The tests still consistently time out on WebKit Linux Leak. Original change's description: > Reland "Worker: Add data URL tests for nested dedicated workers" > > The original patch was reverted because the tests with worker variant > (nested dedicated workers) consistently timed out on WebKit Linux Leak. > In general, nested dedicated workers are slow, and also WebKit Linux > Leak is slow. Probably this is the reason why the tests consistently > timed out. > > To mitigate it, this patch adds timeout=long in the WPT's META line in > addition to the original patch. > > For sheriff: If the tests still time out on WebKit Linux Leak, feel free > to revert this patch again. In that case, I'll attempt to separate the > tests into multiple files. > > Original change's description: > > Revert "Worker: Add data URL tests for nested dedicated workers" > > > > This reverts commit 1d73a2eb. > > > > Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) > > > > Original change's description: > > > Worker: Add data URL tests for nested dedicated workers > > > > > > This CL renames data-url.html to data-url.any.js in order to run the > > > tests on a dedicated worker. Previously these tests only ran on window. > > > > > > Bug: n/a > > > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#741367} > > > > TBR=nhiroki@chromium.org,shimazu@chromium.org > > > > Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: n/a > > Bug: 1052322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741417} > > Bug: 1052322 > Change-Id: I348ba1743f58a6f0fedf2b739a1cb6a574af6f2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060356 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742050} TBR=nhiroki@chromium.org,shimazu@chromium.org Change-Id: I09412305ad6d2093ffb6c489774552eb0bd58f3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061577Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742080}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba88b74030e4..83f5cce214ee git log ba88b74030e4..83f5cce214ee --date=short --first-parent --format='%ad %ae %s' 2020-02-18 dberris@chromium.org Dashboard: Add test with custom anomaly config Created with: gclient setdep -r src/third_party/catapult@83f5cce214ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044760 Tbr: wenbinzhang@google.com Change-Id: I379407cc74b4ad168978530363153b19e1f853f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061122Reviewed-by:
-
Frank Li authored
This CL contains MediaFoundationSourceWrapper and related files. Explainer: https://docs.microsoft.com/en-us/windows/win32/medfound/protected-media-path Design Doc: https://docs.google.com/document/d/1kXMdmfsSKU3tcwTxG-wFU-MaEA6sN3by45PCGBV8zJU Bug: 999747 Change-Id: Ie75371525808c86e2cf6fbd35771c1f4cd6bfca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004066 Commit-Queue: Frank Li <frankli@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742078}
-
Noel Gordon authored
Orientations of 5 or more flip the image width/height on render, while our returned EXIF IFD data does not: https://crbug.com/1039141#c9 Fix that: flip the EXIF IFD metadata width/height if needed. Tbr: lucmult Bug: 1039141 Change-Id: Icfaece4bedc49b2ab6870a763cea21939b384c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060442Reviewed-by:
-
Alexey Baskakov authored
The new WebAppMigrationManager is responsible for any migration-related code. WebAppMigrationManager::StartDatabaseMigration performs the offline migration of all bookmark apps to new web apps registry. We do the offline migration only once, before the initial sync. Any additional apps arriving after the initial sync should be installed via WebAppSyncBridge::CommitUpdate() "as if" a user installs them. This will be explained in go/chrome-bmo-migration doc and implemented as a follow up CL. WebAppMigrationManagerBrowserTest demonstrates some new techniques on how to write integration tests: - PRE test and content::IsPreTest(). - URLLoaderInterceptor instead of EmbeddedTestServer. More tests and test/data/ will follow: - DatabaseMigration_FullManifest and manifest_full_data.json. - A set of apps to test the queue. Bug: 1020037 Change-Id: I0038d321932a72deeb00fd21cd3171f1b8ee0fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014340 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Noel Gordon authored
Add 32px files-ng-only <cr-button> centered in the splitter bar. The design did not say where to place it, so make it centered. Add style being careful that the splitter bar and the splitter button both behave like buttons and can both activate dragging. For example, --hover-bg-color, :hover, :active etc need quite fine control so that button color matches regardless of which element started the drag. Bug: 1002790, 992819 Change-Id: I99edc231f49bed97b1b29e012f50af5ca7d0080a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060225Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dbb98007b7b..4bdd08e3ef7e git log 9dbb98007b7b..4bdd08e3ef7e --date=short --first-parent --format='%ad %ae %s' 2020-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2dd40d7fa75c..c8676d4ba37d (10 commits) Created with: gclient setdep -r src/third_party/skia@4bdd08e3ef7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I0e747b89a0132eb7ae4279883ea88e84566385da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061121Reviewed-by:
-
Toni Barzic authored
Bug:1050544 TBR=tommycli@chromium.org (LGTM given on the cl, but missed +1) Change-Id: I53c0eae00f0cf080e9123e0b7849da67f6f9fde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049083 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#742073}
-
Kent Tamura authored
Make |Event| arguments of the following functions |const|: - Node::DispatchSimulatedClick() - HTMLFormElement::SubmitImplicitly() - HTMLFormElement::PrepareForSubmission() - HTMLFormElement::ScheduleFormSubmission() - SelectType::DefaultEventHandler() This CL has no behavior changes. Change-Id: I91c233a6dead779f771ddeea357bad3f91a145f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060214Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742072}
-
Wei-Han Chen authored
hardware_verifier is a new service on Chromebook. This CL declares the metrics we want to track for this service. BUG=b:147654337 TEST=None Cq-Depend: chromium:2049010, chromium:2000275, chromium:2000534 Change-Id: Iaadacc4425ff1257d3e6961e2108a181f8f95d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011582 Commit-Queue: Wei-Han Chen <stimim@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742071}
-
Keishi Hattori authored
There is no more users for LifecycleObserver and LifecycleNotifier so this CL removes them. Bug: 1052319 Change-Id: I1cd9a45867d66247add3ba53b69cd964cd3a630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060428 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742070}
-
